Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/300#discussion_r140575606
--- Diff: query_optimizer/rules/FuseHashSelect.hpp ---
@@ -0,0 +1,67 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/300#discussion_r140575077
--- Diff: query_optimizer/rules/FuseHashSelect.cpp ---
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/300#discussion_r140569985
--- Diff: query_optimizer/ExecutionGenerator.cpp ---
@@ -939,6 +939,15 @@ void ExecutionGenerator::convertHashJoin(const
P::HashJoinPtr _plan) {
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/300#discussion_r140575177
--- Diff: query_optimizer/rules/FuseHashSelect.hpp ---
@@ -0,0 +1,67 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/300#discussion_r140570548
--- Diff: query_optimizer/PhysicalGenerator.cpp ---
@@ -175,6 +176,8 @@ P::PhysicalPtr PhysicalGenerator::optimizePlan() {
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/300#discussion_r140575916
--- Diff: query_optimizer/strategy/Join.cpp ---
@@ -371,6 +373,7 @@ void Join::addHashJoin(const logical::ProjectPtr
_project,
Github user dylanpbacon commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/300#discussion_r140610972
--- Diff: query_optimizer/strategy/Join.cpp ---
@@ -371,6 +373,7 @@ void Join::addHashJoin(const logical::ProjectPtr
_project,
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/300
We need to fix the performance bugs before merging.
| **TPC-H** | **master** | **this PR** |
| -- | --: | --: |
| 01 | 5,421 | 5,039 |
| 02 | 402 | 3,968
Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/281#discussion_r140540422
--- Diff: query_execution/QueryManagerBase.hpp ---
@@ -338,6 +285,19 @@ class QueryManagerBase {
**/
virtual bool
Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/281#discussion_r140544269
--- Diff: query_execution/WorkOrdersContainer.hpp ---
@@ -343,6 +346,18 @@ class WorkOrdersContainer {
Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/281#discussion_r140544741
--- Diff: query_execution/tests/QueryManagerSingleNode_unittest.cpp ---
@@ -753,99 +752,51 @@ TEST_F(QueryManagerTest,
Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/281
I have finished one pass. Will take another look once the comments are
addressed.
---
12 matches
Mail list logo
