Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/5
There is the only one gcc test killed by the Travis.
https://travis-ci.org/apache/incubator-quickstep/jobs/133990216#L5810
If we could somehow run it with 2 concurrent jobs
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/19#discussion_r66455959
--- Diff: relational_operators/TextScanOperator.cpp ---
@@ -155,116 +63,50 @@ bool TextScanOperator::getAllWorkOrders(
InsertDestination
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/7
@hbdeshmukh @pateljm I've dropped the second commit using the command line.
So no worry about that, and use `git rebase -i` for merging new commits.
---
If your project is set up
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/27#discussion_r66725743
--- Diff: parser/CMakeLists.txt ---
@@ -374,12 +374,15 @@ set_property(SOURCE
${CMAKE_CURRENT_BINARY_DIR}/SqlParser_gen.cpp APPEND PROPERT
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/27#discussion_r66725906
--- Diff: storage/BasicColumnStoreTupleStorageSubBlock.cpp ---
@@ -473,10 +483,10 @@ void
BasicColumnStoreTupleStorageSubBlock
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/27#discussion_r66725967
--- Diff: storage/BasicColumnStoreTupleStorageSubBlock.cpp ---
@@ -671,6 +688,8 @@ void
BasicColumnStoreTupleStorageSubBlock::shiftNullBitmaps
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/27#discussion_r66725964
--- Diff: storage/BasicColumnStoreTupleStorageSubBlock.cpp ---
@@ -575,6 +585,13 @@ predicate_cost_t
BasicColumnStoreTupleStorageSubBlock
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/27#discussion_r66725825
--- Diff: storage/BasicColumnStoreTupleStorageSubBlock.cpp ---
@@ -183,26 +189,27 @@ bool
BasicColumnStoreTupleStorageSubBlock::DescriptionIsValid
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/28#discussion_r66733141
--- Diff: cli/QuickstepCli.cpp ---
@@ -335,6 +347,9 @@ int main(int argc, char* argv[]) {
std::unique_ptr parser_wrapper(new SqlParserWrapper
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/27
@craig-chasseur Please remove all the copyright updates, per discussion in
the dev mail list below. Thanks!
> All of your copyright headers need to look exactly l
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/28#discussion_r66737198
--- Diff: cli/QuickstepCli.cpp ---
@@ -430,6 +445,13 @@ int main(int argc, char* argv[]) {
reset_parser = true;
break
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/22
Let me know once you want to merge it. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/22#discussion_r66728135
--- Diff: build/profile_build.sh ---
@@ -0,0 +1,111 @@
+#!/bin/bash
+# This script may be useful for developers to profile the build process
Github user zuyu closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/26
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/28#discussion_r66727823
--- Diff: cli/QuickstepCli.cpp ---
@@ -430,6 +445,13 @@ int main(int argc, char* argv[]) {
reset_parser = true;
break
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/22#discussion_r66728153
--- Diff: build/profile_build.sh ---
@@ -0,0 +1,111 @@
+#!/bin/bash
+# This script may be useful for developers to profile the build process
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/28#discussion_r66727801
--- Diff: cli/QuickstepCli.cpp ---
@@ -440,6 +462,13 @@ int main(int argc, char* argv[]) {
}
}
+#ifdef
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/28#discussion_r66730358
--- Diff: cli/QuickstepCli.cpp ---
@@ -430,6 +445,13 @@ int main(int argc, char* argv[]) {
reset_parser = true;
break
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/28#discussion_r66733198
--- Diff: cli/QuickstepCli.cpp ---
@@ -430,6 +445,13 @@ int main(int argc, char* argv[]) {
reset_parser = true;
break
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/14#discussion_r66646360
--- Diff: cli/QuickstepCli.cpp ---
@@ -323,13 +326,20 @@ int main(int argc, char* argv[]) {
worker_client_ids
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/14#discussion_r66646566
--- Diff: storage/InsertDestination.cpp ---
@@ -60,25 +60,28 @@ InsertDestination::InsertDestination(const
CatalogRelationSchema
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/24#discussion_r66648781
--- Diff: CMakeLists.txt ---
@@ -500,9 +500,13 @@ if(USE_TCMALLOC)
# as some generators, e.g. Ninja, may need it to build properly
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/14
FYI, In `optimizer/ExecutionGenerator`, we set `query_id` in `QueryContext`
proto, not `QueryContext` itself.
So, I think in this PR, we don't need to add `query_id
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/14#discussion_r0503
--- Diff: query_optimizer/ExecutionGenerator.cpp ---
@@ -1635,5 +1635,11 @@ void ExecutionGenerator::convertTableGenerator
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/14
@hbdeshmukh I see the changes in `ExecutionGenerator` and
`InsertDestination`, but to me, it is a overkill.
We could do it much simpler using the only `query_id` in `QueryContext
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/20
@pateljm How about trying with all the four options to see the time to
take, and then go with there?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/22#discussion_r66701380
--- Diff: build/profile_build.sh ---
@@ -0,0 +1,65 @@
+#!/bin/bash
+# This script may be useful for developers to profile the build process
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/22#discussion_r66701493
--- Diff: build/profile_build.sh ---
@@ -0,0 +1,65 @@
+#!/bin/bash
+# This script may be useful for developers to profile the build process
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/22#discussion_r66701489
--- Diff: build/profile_build.sh ---
@@ -0,0 +1,65 @@
+#!/bin/bash
+# This script may be useful for developers to profile the build process
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/22
I just rebase it with the master, and I'll merge it after running it on a
`Linux` box. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/22
@navsan This file has a lot of trailing whitespaces that need to remove.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/14#discussion_r66686943
--- Diff: query_execution/CMakeLists.txt ---
@@ -235,36 +241,6 @@ if (ENABLE_DISTRIBUTED)
add_test(BlockLocator_unittest BlockLocator_unittest
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/14#discussion_r66691003
--- Diff: query_execution/QueryExecutionTypedefs.hpp ---
@@ -67,7 +68,8 @@ enum QueryExecutionMessageType : message_type_id
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/14#discussion_r66691680
--- Diff: relational_operators/AggregationOperator.hpp ---
@@ -123,6 +123,8 @@ class AggregationWorkOrder : public WorkOrder
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/14
@hbdeshmukh I did one pass, and I would highlight two things:
* Please remove some duplicated doxygen in operator header files, as a
part of incorrect auto-rebasing.
* Emphasis
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/14#discussion_r66686682
--- Diff: query_execution/AdmitRequestMessage.hpp ---
@@ -0,0 +1,73 @@
+/**
+ * Copyright 2016, Quickstep Research Group, Computer Sciences
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/14#discussion_r66687418
--- Diff: query_execution/AdmitRequestMessage.hpp ---
@@ -0,0 +1,73 @@
+/**
+ * Copyright 2016, Quickstep Research Group, Computer Sciences
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/14#discussion_r66688816
--- Diff: query_execution/Foreman.hpp ---
@@ -71,233 +65,31 @@ class Foreman final : public ForemanLite {
* @note If cpu_id is not specified
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/14#discussion_r66690232
--- Diff: query_execution/PolicyEnforcer.hpp ---
@@ -0,0 +1,168 @@
+/**
+ * Copyright 2016, Quickstep Research Group, Computer Sciences
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/14
@hbdeshmukh Have you try to use `std::vector` instead
of `std::vector<QueryHandle*>`?
I believe we don't need to change anything in `QueryHandle` after query
optimization.
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/14#discussion_r66690499
--- Diff: query_execution/QueryContext.proto ---
@@ -54,4 +54,6 @@ message QueryContext {
// NOTE(zuyu): For UpdateWorkOrder only
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/14#discussion_r66691741
--- Diff: relational_operators/DestroyHashOperator.hpp ---
@@ -83,6 +85,8 @@ class DestroyHashWorkOrder : public WorkOrder
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/14#discussion_r66691464
--- Diff: query_optimizer/ExecutionGenerator.hpp ---
@@ -374,6 +375,14 @@ class ExecutionGenerator {
*/
void dropAllTemporaryRelations
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/25
Fix all in this PR. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/25
`AlwaysCreateBlockInsertDestination::getBlockForInsertion` and
`PartitionAwareInsertDestination::getBlockForInsertionInPartition`.
---
If your project is set up for it, you can reply
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/25
@navsan I thought you had confirmed that we don't need the critical section
when creating a block. OK, let me check it.
---
If your project is set up for it, you can reply to this email
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/25#discussion_r66700345
--- Diff: storage/InsertDestination.cpp ---
@@ -339,21 +339,20 @@ void
BlockPoolInsertDestination::getPartiallyFilledBlocks(std
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/14#discussion_r66492947
--- Diff: cli/CommandExecutor.cpp ---
@@ -194,11 +198,14 @@ void executeDescribeTable(
/**
* @brief A helper function that executes a SQL
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/14
@hbdeshmukh We have to rebase again, as we had "git merge" again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/20
@pateljm Before merging this PR, we need to rebase w/ master to get rid of
previous merged commits.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/14#discussion_r66543912
--- Diff: storage/InsertDestination.cpp ---
@@ -60,25 +60,28 @@ InsertDestination::InsertDestination(const
CatalogRelationSchema
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/5
@navsan Do you have any insights regarding the clang linking issues? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/17
@pateljm This PR is ready to merge, and has sync-ed with the master. Please
take another look. Thanks!
As for adding a document regarding how to add a new operator, we should do
so
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/20
@pateljm You might want to try add back the else case of `MAKE_JOBS=2` for
`clang`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/14#discussion_r66495816
--- Diff: cli/QuickstepCli.cpp ---
@@ -323,13 +326,20 @@ int main(int argc, char* argv[]) {
worker_client_ids
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/14#discussion_r66709222
--- Diff: query_execution/Foreman.cpp ---
@@ -22,355 +22,189 @@
#include
#include
-#include "catalog/CatalogDatabas
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/14#discussion_r66716091
--- Diff: query_execution/Foreman.hpp ---
@@ -22,46 +22,40 @@
#include
#include
-#include "catalog/CatalogTypedef
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/22#discussion_r66828192
--- Diff: build/profile_build.sh ---
@@ -0,0 +1,111 @@
+#!/bin/bash
+# This script may be useful for developers to profile the build process
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/27#discussion_r67010440
--- Diff: storage/BasicColumnStoreTupleStorageSubBlock.hpp ---
@@ -211,11 +213,12 @@ class BasicColumnStoreTupleStorageSubBlock : public
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/32
@pateljm Separating into two proto messages is overkill to me. In fact, the
most part in this PR is to duplicate the logics to process two identical proto
messages, except for `normal
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/33#discussion_r67095580
--- Diff: query_execution/PolicyEnforcer.hpp ---
@@ -60,12 +61,14 @@ class PolicyEnforcer {
const std::size_t num_numa_nodes
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/32
Even for the info you mentioned, `RebuildWorkOrder` could also have these
stored in `proto`.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/33
@hbdeshmukh is right about `WorkerDirectory`, and enforcing `NUMA-aware`
scheduling is the main reason to introduce this class.
In the distributed version, `Foreman` needs to query
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/5
@navsan I think it is related to how `tmb` explicitly specifies the library
`gflags_nothreads-static`. And disabling the shared build works using `gcc`,
although there are two cases
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/22#discussion_r66869747
--- Diff: build/profile_build.sh ---
@@ -0,0 +1,111 @@
+#!/bin/bash
+# This script may be useful for developers to profile the build process
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/28#discussion_r66870133
--- Diff: cli/QuickstepCli.cpp ---
@@ -430,6 +445,13 @@ int main(int argc, char* argv[]) {
reset_parser = true;
break
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/22
@navsan FYI, please edit the squashed commit messages when doing squashing.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/28
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/8
@pateljm FYI, the style guide does not specify the order of any input
arguments, including `query_id`.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user zuyu closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/15
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/16
DO NOT MERGE: Use the pre-built libgflags in Travis.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-quickstep
Github user zuyu closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/16
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/17
Serialized WorkOrders as proto.
This large PR serializes `WorkOrders` as a proto, as a part of achieving
distributed version.
Note that this would affect the on-going work
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/32
@pateljm I agree that if we would go with the split option, we do w/
extensions as following.
```
message WorkOrderCompletionMessage {
...
}
message
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/32#discussion_r67067611
--- Diff: query_execution/QueryExecutionMessages.proto ---
@@ -20,11 +20,16 @@ package quickstep.serialization;
message EmptyMessage
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/32#discussion_r67067803
--- Diff: query_execution/Worker.cpp ---
@@ -47,13 +49,32 @@ void Worker::run() {
}
ClientIDMap *thread_id_map = ClientIDMap::Instance
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/5
@navsan We need to fix the `cmake` error regarding `gflags-shared` (#13)
when `ENABLE_DISTRIBUTED=ON`:
https://travis-ci.org/apache/incubator-quickstep/jobs/137651757#L3727
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/32
@hbdeshmukh Since the time field in `WorkOrderCompletion` proto is
optional, we still do not need to split into two.
---
If your project is set up for it, you can reply to this email
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/35#discussion_r67446034
--- Diff: parser/ParseWindow.hpp ---
@@ -0,0 +1,204 @@
+/**
+ * Copyright 2016, Quickstep Research Group, Computer Sciences
Department
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/35#discussion_r67459445
--- Diff: parser/ParseBasicExpressions.hpp ---
@@ -429,6 +430,46 @@ class ParseFunctionCall : public ParseExpression {
return star_.get
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/35#discussion_r67459437
--- Diff: parser/ParseBasicExpressions.hpp ---
@@ -429,6 +430,46 @@ class ParseFunctionCall : public ParseExpression {
return star_.get
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/35#discussion_r67459543
--- Diff: parser/ParseWindow.hpp ---
@@ -0,0 +1,204 @@
+/**
+ * Copyright 2016, Quickstep Research Group, Computer Sciences
Department
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/37#discussion_r67539660
--- Diff: types/DecimalLit.hpp ---
@@ -0,0 +1,131 @@
+/**
+ * Copyright 2016, Quickstep Research Group, Computer Sciences
Department
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/39#discussion_r68326675
--- Diff: query_optimizer/expressions/WindowAggregateFunction.hpp ---
@@ -0,0 +1,246 @@
+/**
+ * Copyright 2011-2015 Quickstep Technologies
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/39#discussion_r68326516
--- Diff: query_optimizer/expressions/WindowAggregateFunction.hpp ---
@@ -0,0 +1,246 @@
+/**
+ * Copyright 2011-2015 Quickstep Technologies
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/39#discussion_r68326059
--- Diff: query_optimizer/expressions/WindowAggregateFunction.hpp ---
@@ -0,0 +1,246 @@
+/**
+ * Copyright 2011-2015 Quickstep Technologies
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/39#discussion_r68328569
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -973,8 +1011,36 @@ L::LogicalPtr Resolver::resolveSelect(
logical_plan
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/39#discussion_r68329454
--- Diff: query_optimizer/logical/WindowAggregate.hpp ---
@@ -0,0 +1,123 @@
+/**
+ * Copyright 2011-2015 Quickstep Technologies LLC
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/39#discussion_r68329405
--- Diff: query_optimizer/logical/WindowAggregate.hpp ---
@@ -0,0 +1,123 @@
+/**
+ * Copyright 2011-2015 Quickstep Technologies LLC
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/39#discussion_r68330778
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -992,6 +1059,29 @@ L::LogicalPtr Resolver::resolveSelect(
SelectListInfo
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/39#discussion_r68331984
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -1684,13 +1857,45 @@ L::LogicalPtr Resolver::resolveJoinedTableReference
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/39#discussion_r68332407
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -2362,17 +2568,19 @@ E::ScalarPtr Resolver::resolveSimpleCaseExpression(
// TODO
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/39#discussion_r68463508
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -1684,13 +1857,45 @@ L::LogicalPtr Resolver::resolveJoinedTableReference
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/40
The title is misleading, please change to `Use move semantics when
constructing optimizer::logical::Sort`, since we are not adding a move
constructor, but adding a new constructor w/ some
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/65
The main question is that why our unit test does not catch this bug, and
how to prevent similar bugs in the future (i.e, by adding a new unit test)?
---
If your project is set up
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/64#discussion_r72338203
--- Diff: query_execution/Shiftboss.cpp ---
@@ -0,0 +1,357 @@
+/**
+ * Licensed under the Apache License, Version 2.0 (the "Li
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/64#discussion_r72341258
--- Diff: query_execution/Shiftboss.cpp ---
@@ -0,0 +1,357 @@
+/**
+ * Licensed under the Apache License, Version 2.0 (the "Li
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/64#discussion_r72341816
--- Diff: query_execution/Shiftboss.hpp ---
@@ -0,0 +1,241 @@
+/**
+ * Licensed under the Apache License, Version 2.0 (the "Li
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/64#discussion_r72338431
--- Diff: query_execution/Shiftboss.cpp ---
@@ -0,0 +1,357 @@
+/**
+ * Licensed under the Apache License, Version 2.0 (the "Li
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/64#discussion_r72338585
--- Diff: query_execution/Shiftboss.cpp ---
@@ -0,0 +1,357 @@
+/**
+ * Licensed under the Apache License, Version 2.0 (the "Li
1 - 100 of 741 matches
Mail list logo