[GitHub] incubator-quickstep issue #101: Optimize PackedRowStoreValueAccessor & Basic...

[saketj]

Github user saketj commented on the issue:

https://github.com/apache/incubator-quickstep/pull/101
  
@zuyu Thanks, sure will do that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #101: Optimize PackedRowStoreValueAccessor & Basic...

[zuyu]

Github user zuyu commented on the issue:

https://github.com/apache/incubator-quickstep/pull/101
  
@saketj Next time, please squash all the commits into one before merging. 
Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #101: Optimize PackedRowStoreValueAccessor & Basic...

[pateljm]

Github user pateljm commented on the issue:

https://github.com/apache/incubator-quickstep/pull/101
  
LGTM. Merging. Thanks @saketj.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #101: Optimize PackedRowStoreValueAccessor & Basic...

[navsan]

Github user navsan commented on the issue:

https://github.com/apache/incubator-quickstep/pull/101
  
The compiler is probably running out of memory. Can you try turning down
the level of parallelism?

On Mon, Oct 3, 2016, 08:48 Saket Saurabh  wrote:

> It is strange that only one of the Travis build tasks for [clang++
> compiler, build=release and vector_copy_ellision_level=selection] is
> repeatedly failing due to a compiler error. (Reproduced below) .
>
> The same code compiles perfectly for clang++ release
> (vector_copy_ellision_level=joinwithbinaryexpression) and for all
> configurations of g++.
>
> I don't think it is related to changes of current PR. I tried running it
> multiple times, but still the same error. Does anyone else has also faced
> the same issue before, or might know what is causing it?
>
> Building CXX object
> 
types/operations/comparisons/CMakeFiles/quickstep_types_operations_comparisons_GreaterComparison.dir/GreaterComparison.cpp.o
> error: unable to execute command: Killed
> clang: error: clang frontend command failed due to signal (use -v to see
> invocation)
> Ubuntu clang version 3.7.1-svn253571-1~exp1 (branches/release_37) (based
> on LLVM 3.7.1)
> Target: x86_64-pc-linux-gnu
> Thread model: posix
> clang: note: diagnostic msg: PLEASE submit a bug report to
> http://bugs.debian.org/ and include the crash backtrace, preprocessed
> source, and associated run script.
> clang: note: diagnostic msg:
> PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:
> Preprocessed source(s) and associated run script(s) are located at:
> clang: note: diagnostic msg: /tmp/EqualComparison-835ea0.cpp
> clang: note: diagnostic msg: /tmp/EqualComparison-835ea0.sh
> clang: note: diagnostic msg:
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> 
,
> or mute the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #101: Optimize PackedRowStoreValueAccessor & Basic...

[saketj]

Github user saketj commented on the issue:

https://github.com/apache/incubator-quickstep/pull/101
  
It is strange that only one of the Travis build tasks for [clang++ 
compiler, build=release and vector_copy_ellision_level=selection] is repeatedly 
failing due to a compiler error.  (Reproduced below) . 

The same code compiles perfectly for clang++ release 
(vector_copy_ellision_level=joinwithbinaryexpression) and for all 
configurations of g++. 

I don't think it is related to changes of current PR. I tried running it 
multiple times, but still the same error. Does anyone else has also faced the 
same issue before, or might know what is causing it?

> Building CXX object 
types/operations/comparisons/CMakeFiles/quickstep_types_operations_comparisons_GreaterComparison.dir/GreaterComparison.cpp.o
error: unable to execute command: Killed
clang: error: clang frontend command failed due to signal (use -v to see 
invocation)
Ubuntu clang version 3.7.1-svn253571-1~exp1 (branches/release_37) (based on 
LLVM 3.7.1)
Target: x86_64-pc-linux-gnu
Thread model: posix
clang: note: diagnostic msg: PLEASE submit a bug report to 
http://bugs.debian.org/ and include the crash backtrace, preprocessed source, 
and associated run script.
clang: note: diagnostic msg: 
PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:
Preprocessed source(s) and associated run script(s) are located at:
clang: note: diagnostic msg: /tmp/EqualComparison-835ea0.cpp
clang: note: diagnostic msg: /tmp/EqualComparison-835ea0.sh
clang: note: diagnostic msg: 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #101: Optimize PackedRowStoreValueAccessor & Basic...

[saketj]

Github user saketj commented on the issue:

https://github.com/apache/incubator-quickstep/pull/101
  
@pateljm Thanks Jignesh. Have updated the patch and also added the 
performance numbers in the PR description.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #101: Optimize PackedRowStoreValueAccessor & Basic...

[pateljm]

Github user pateljm commented on the issue:

https://github.com/apache/incubator-quickstep/pull/101
  
@saketj Can you restart Travis to make sure the tests come back green. 
@navsan If this looks good to you, can we close this? 
Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #101: Optimize PackedRowStoreValueAccessor & Basic...

[saketj]

Github user saketj commented on the issue:

https://github.com/apache/incubator-quickstep/pull/101
  
@navsan Could you please review? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---