Github user navsan commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/109#discussion_r83202582
--- Diff: utility/BitVector.hpp ---
@@ -183,6 +183,19 @@ class BitVector {
}
/**
+ * @brief Assign this BitVector's contents to the pointed-to memory.
+ *
+ * @warning caller is responsible for ensuring the Bitvector has the
correct
+ * ownership and size.
+ *
+ * @param ptr Pointer to data representing a BitVector with the same
parameters
+ *as this BitVector.
+ **/
+ inline void setMemory(void *ptr) {
+this->data_array_ = static_cast(ptr);
--- End diff --
Doesn't this potentially lead to a memory leak?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
