[GitHub] incubator-quickstep pull request #295: Printed out the partition info in Que...

[zuyu]

Github user zuyu commented on a diff in the pull request:

https://github.com/apache/incubator-quickstep/pull/295#discussion_r138971636
  
--- Diff: query_optimizer/tests/logical_generator/Create.test ---
@@ -63,6 +67,15 @@ PARTITION BY HASH(attr1, attr2, attr3, attr4, attr5, 
attr6) PARTITIONS 4;
 --
 TopLevelPlan
 +-plan=CreateTable[relation=foo]
+| +-partition_scheme_header=ProtoDescription
+| | +-Property=ProtoProperty[Property=partition_type,Value=hash]
+| | +-Property=ProtoProperty[Property=num_partitions,Value=4]
+| | +-Property=ProtoProperty[Property=partition_attr_id,Value=0]
+| | +-Property=ProtoProperty[Property=partition_attr_id,Value=1]
+| | +-Property=ProtoProperty[Property=partition_attr_id,Value=2]
+| | +-Property=ProtoProperty[Property=partition_attr_id,Value=3]
+| | +-Property=ProtoProperty[Property=partition_attr_id,Value=4]
+| | +-Property=ProtoProperty[Property=partition_attr_id,Value=5]
--- End diff --

Here we just print out the internal states.


---

[GitHub] incubator-quickstep pull request #295: Printed out the partition info in Que...

[hbdeshmukh]

Github user hbdeshmukh commented on a diff in the pull request:

https://github.com/apache/incubator-quickstep/pull/295#discussion_r138950122
  
--- Diff: query_optimizer/tests/logical_generator/Create.test ---
@@ -63,6 +67,15 @@ PARTITION BY HASH(attr1, attr2, attr3, attr4, attr5, 
attr6) PARTITIONS 4;
 --
 TopLevelPlan
 +-plan=CreateTable[relation=foo]
+| +-partition_scheme_header=ProtoDescription
+| | +-Property=ProtoProperty[Property=partition_type,Value=hash]
+| | +-Property=ProtoProperty[Property=num_partitions,Value=4]
+| | +-Property=ProtoProperty[Property=partition_attr_id,Value=0]
+| | +-Property=ProtoProperty[Property=partition_attr_id,Value=1]
+| | +-Property=ProtoProperty[Property=partition_attr_id,Value=2]
+| | +-Property=ProtoProperty[Property=partition_attr_id,Value=3]
+| | +-Property=ProtoProperty[Property=partition_attr_id,Value=4]
+| | +-Property=ProtoProperty[Property=partition_attr_id,Value=5]
--- End diff --

Is it feasible to get the attribute names instead of their value? That 
might be easier to understand and read. 


---

[GitHub] incubator-quickstep pull request #295: Printed out the partition info in Que...

[zuyu]

GitHub user zuyu opened a pull request:

https://github.com/apache/incubator-quickstep/pull/295

Printed out the partition info in QueryPlan.

This PR displayed the partition info in the query plan.

Assigned to @hbdeshmukh.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zuyu/incubator-quickstep query-plan-part-info

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-quickstep/pull/295.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #295


commit 35a4d26c527ee49aa5d0993e647012fa82ff8695
Author: Zuyu Zhang 
Date:   2017-09-11T16:57:10Z

Printed out the partition info in QueryPlan.




---