Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/300
---
Github user dylanpbacon commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/300#discussion_r140610972
--- Diff: query_optimizer/strategy/Join.cpp ---
@@ -371,6 +373,7 @@ void Join::addHashJoin(const logical::ProjectPtr
_project,
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/300#discussion_r140575177
--- Diff: query_optimizer/rules/FuseHashSelect.hpp ---
@@ -0,0 +1,67 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/300#discussion_r140569985
--- Diff: query_optimizer/ExecutionGenerator.cpp ---
@@ -939,6 +939,15 @@ void ExecutionGenerator::convertHashJoin(const
P::HashJoinPtr _plan) {
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/300#discussion_r140575077
--- Diff: query_optimizer/rules/FuseHashSelect.cpp ---
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/300#discussion_r140570548
--- Diff: query_optimizer/PhysicalGenerator.cpp ---
@@ -175,6 +176,8 @@ P::PhysicalPtr PhysicalGenerator::optimizePlan() {
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/300#discussion_r140575916
--- Diff: query_optimizer/strategy/Join.cpp ---
@@ -371,6 +373,7 @@ void Join::addHashJoin(const logical::ProjectPtr
_project,
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/300#discussion_r140575606
--- Diff: query_optimizer/rules/FuseHashSelect.hpp ---
@@ -0,0 +1,67 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
