Re: Review Request 56192: RANGER-1338:Ranger Plugin failed to download policy when JaasConfig alone is used to set the UGI instead of Principal/Keytab

2017-02-01 Thread Abhay Kulkarni
//reviews.apache.org/r/56192/#comment235426> Consider printing jaasConfigAppName, principal here. - Abhay Kulkarni On Feb. 1, 2017, 10:35 p.m., Ramesh Mani wrote: > > --- > This is an automatically generated e-mail

Re: Review Request 56192: RANGER-1338:Ranger Plugin failed to download policy when JaasConfig alone is used to set the UGI instead of Principal/Keytab

2017-02-01 Thread Abhay Kulkarni
value of MiscUtil.getUGILoginUser() - Abhay Kulkarni On Feb. 2, 2017, 1:27 a.m., Ramesh Mani wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Review Request 56414: tag objects are not removed when attempting a full sync with Atlas tags

2017-02-07 Thread Abhay Kulkarni
/56414/diff/ Testing --- Associated a trait with an Atlas entity; stopped tagsync process; ran full synchronization using command line with atlasrest as source of tags and ensured that the entity-tag association as well as entity is removed from the ranger database. Thanks, Abhay

Review Request 56461: Modify Ranger Hbase Plugin ColumnIterator to use Cell instead of KeyValue (to avoid ClassCastException in certain cases)

2017-02-08 Thread Abhay Kulkarni
/56461/diff/ Testing --- Passed all unit tests including modified test for ColumnIterator. Thanks, Abhay Kulkarni

Review Request 56473: Plugin-status page shows incorrect last-update time

2017-02-08 Thread Abhay Kulkarni
, Abhay Kulkarni

Review Request 55860: Print details of any exception thrown when instantiating a custom Ranger condition evaluator

2017-01-23 Thread Abhay Kulkarni
/RangerDefaultPolicyItemEvaluator.java d2f6006 Diff: https://reviews.apache.org/r/55860/diff/ Testing --- Thanks, Abhay Kulkarni

Review Request 55915: Update Ranger plugin handling of service-not-found error

2017-01-25 Thread Abhay Kulkarni
by a configuration variable 'ranger.disable.policycache.when.service.not.found'. 2. Disabled service in Ranger Admin, and ensured that the policycache is not modified/moved, and policy-engine continues to use existing policies. Thanks, Abhay Kulkarni

Re: [VOTE] Release Apache Ranger 0.6.3 - release candidate 1 (dev group vote)

2017-01-27 Thread Abhay Kulkarni
+1 Thanks, -Abhay On 1/27/17, 10:28 AM, "Sailaja Polavarapu" wrote: >+1 >- Successfully extracted tar file >- Able to clean and build successfully. > >Thanks, >Sailaja > > > > > >On 1/27/17, 9:56 AM, "Ramesh Mani" wrote: > >>+1 (binding) >>

Review Request 56089: Fix issue uncovered by static code analysis

2017-01-30 Thread Abhay Kulkarni
--- Built clean and ran unit tests successfully. Thanks, Abhay Kulkarni

Re: Review Request 55959: RANGER-1307:Enable Deny and Exclusions conditions in Ranger Policies for WASB service-def

2017-01-25 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55959/#review163029 --- Ship it! Ship It! - Abhay Kulkarni On Jan. 25, 2017, 9:50

Re: Review Request 56640: Support for using resource-matcher for filtering policies within a service if service-resource is provided in the filter

2017-02-23 Thread Abhay Kulkarni
/apache/ranger/common/RangerSearchUtil.java 4fb52a4 Diff: https://reviews.apache.org/r/56640/diff/ Testing --- Tested with local VM with and without specifying "resourceMatchScope" option in the filter-spec. Thanks, Abhay Kulkarni

Re: Review Request 56640: Support for using resource-matcher for filtering policies within a service if service-resource is provided in the filter

2017-02-22 Thread Abhay Kulkarni
/apache/ranger/common/RangerSearchUtil.java 4fb52a4 Diff: https://reviews.apache.org/r/56640/diff/ Testing --- Tested with local VM with and without specifying "resourceMatchScope" option in the filter-spec. Thanks, Abhay Kulkarni

Re: Review Request 56640: Support for using resource-matcher for filtering policies within a service if service-resource is provided in the filter

2017-02-21 Thread Abhay Kulkarni
rceForFilter(filterResources, serviceDef) Method: "RangerServiceDefHelper.getFilterResourcesForPolicyFiltering(serviceDef, filterResources)" - Abhay --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache

Re: Review Request 56640: Support for using resource-matcher for filtering policies within a service if service-resource is provided in the filter

2017-02-21 Thread Abhay Kulkarni
in/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 15f205a security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 4fb52a4 Diff: https://reviews.apache.org/r/56640/diff/ Testing --- Tested with local VM with and without specifying "resourceMatchScope" option in the filter-spec. Thanks, Abhay Kulkarni

Re: [VOTE] Apache Ranger Release 0.7.0 - rc1

2017-02-21 Thread Abhay Kulkarni
+1 - Successfully built ranger from apache-ranger-0.7.0.tar.gz with rat plugin - Verified MD5/SHA hash Thanks, -Abhay On 2/21/17, 11:32 AM, "Ramesh Mani" wrote: >+1 (binding) > >- Did successful build of apache-ranger-0.7.0.tar.gz with rat plugin. >- Verified PGP

Review Request 56640: Support for using resource-matcher for filtering policies within a service if service-resource is provided in the filter

2017-02-13 Thread Abhay Kulkarni
in/java/org/apache/ranger/common/RangerSearchUtil.java 4fb52a4 Diff: https://reviews.apache.org/r/56640/diff/ Testing --- Tested with local VM with and without specifying "resourceMatchScope" option in the filter-spec. Thanks, Abhay Kulkarni

Re: Review Request 56640: Support for using resource-matcher for filtering policies within a service if service-resource is provided in the filter

2017-02-15 Thread Abhay Kulkarni
ugin/util/SearchFilter.java 8f6426c security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 15f205a security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 4fb52a4 Diff: https://reviews.apache.org/r/56640/diff/ Testing --- Tested with local VM with and without specifying "resourceMatchScope" option in the filter-spec. Thanks, Abhay Kulkarni

Re: Review Request 55703: RANGER-1197 : non admin user is able to get plugin status info

2017-01-19 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55703/#review162311 --- Ship it! Ship It! - Abhay Kulkarni On Jan. 19, 2017, 8:24

Re: Review Request 57114: Ranger Hive Authorizer API for row-filtering and column-masking need only return those tables that need masking/filtering

2017-02-27 Thread Abhay Kulkarni
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57114/#review166975 --- On Feb. 27, 2017, 11:22 p.m., Abhay Kulkarni wrote: > > ---

Re: Review Request 57114: Ranger Hive Authorizer API for row-filtering and column-masking need only return those tables that need masking/filtering

2017-02-27 Thread Abhay Kulkarni
/r/57114/diff/ Testing --- Ran all unit tests. Thanks, Abhay Kulkarni

Re: Review Request 57123: RANGER-1407 : Service update transaction log is not generated in some cases

2017-02-28 Thread Abhay Kulkarni
, the setting of tagServiceName in new RangerService object, if required, is performed by line 1502: service.setTagService(newTagServiceName); and transaction-log contains correct values in the case of old client. - Abhay Kulkarni On Feb. 28, 2017, 6:53

Re: Review Request 57123: RANGER-1407 : Service update transaction log is not generated in some cases

2017-03-01 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57123/#review167288 --- Ship it! Ship It! - Abhay Kulkarni On March 1, 2017, 8:52

Review Request 57099: Good coding practice in Ranger recommended by static code analysis

2017-02-27 Thread Abhay Kulkarni
f4d76ad Diff: https://reviews.apache.org/r/57099/diff/ Testing --- Ran unit tests successfully. Thanks, Abhay Kulkarni

Review Request 57114: Ranger Hive Authorizer API for row-filtering and column-masking need only return those tables that need masking/filtering

2017-02-27 Thread Abhay Kulkarni
-filter/column-mask apply per Ranger policies. Diffs - hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java cb94f19 Diff: https://reviews.apache.org/r/57114/diff/ Testing --- Ran all unit tests. Thanks, Abhay Kulkarni

Re: Question about group policies

2017-03-24 Thread Abhay Kulkarni
Hi Alex, This is exactly right. Users, groups and their associations in Ranger (specifically Ranger Admin) are props for being able to define policies. They are not the Œsource of truth¹. It is expected that the correct user <‹-> group associations will be available in the component (service)

Review Request 57849: tag downloads fail with error "XXServiceResourceElement.findTaggedResourcesInServiceId"

2017-03-22 Thread Abhay Kulkarni
optimizations turned off. Tag downloads succeeded without errors. Thanks, Abhay Kulkarni

Review Request 58034: 'Ranger KMS' repo is not getting created in manual installation

2017-03-29 Thread Abhay Kulkarni
of ranger.kms.service.user.hdfs and ranger.kms.service.user.hive configuration variables, and successfully created a KMS repo. The users configured as ranger.kms.service.user.hdfs and ranger.kms.service.user.hive were created in Ranger. Thanks, Abhay Kulkarni

Review Request 57977: 'show databases' fails with access-denied when user doesn't have access to some of the databases

2017-03-27 Thread Abhay Kulkarni
sting --- Tested scenario in the Apache JIRA. Also, fixed a unit test case, and added more unit tests for this scenario. Thanks, Abhay Kulkarni

Re: Review Request 58034: 'Ranger KMS' repo is not getting created in manual installation

2017-03-31 Thread Abhay Kulkarni
and ranger.kms.service.user.hive configuration variables, and successfully created a KMS repo. The users configured as ranger.kms.service.user.hdfs and ranger.kms.service.user.hive were created in Ranger. Thanks, Abhay Kulkarni

Re: Review Request 57697: Good coding practice recommended by static code analysis

2017-03-16 Thread Abhay Kulkarni
ated e-mail. To reply, visit: https://reviews.apache.org/r/57697/#review169178 --- On March 16, 2017, 5:22 p.m., Abhay Kulkarni wrote: > > --- > This is an automaticall

Review Request 57697: Good coding practice recommended by static code analysis

2017-03-16 Thread Abhay Kulkarni
/apache/ranger/biz/ServiceDBStore.java 26080b5 Diff: https://reviews.apache.org/r/57697/diff/1/ Testing --- Created Ranger service in a local VM and ensured that the default policies are created as expected. Thanks, Abhay Kulkarni

Review Request 58154: Policy engine updates to support tag-based masking policies

2017-04-03 Thread Abhay Kulkarni
--- Updated Tag-Service-Definition with dataMaskDef section for hive component, created a tag policy for data-masking; tagged a hive column with a tag and used beeline to test data-masking for that column. Thanks, Abhay Kulkarni

Re: Review Request 58034: 'Ranger KMS' repo is not getting created in manual installation

2017-04-03 Thread Abhay Kulkarni
and ranger.kms.service.user.hive configuration variables, and successfully created a KMS repo. The users configured as ranger.kms.service.user.hdfs and ranger.kms.service.user.hive were created in Ranger. Thanks, Abhay Kulkarni

Review Request 58219: Support administration of Tag-based masking policies

2017-04-05 Thread Abhay Kulkarni
reflected in the tag service-def. Thanks, Abhay Kulkarni

Re: Review Request 32873: A set of REST-based APIs to access, create and manipulate service definitions, services and policies for Ranger.

2017-04-14 Thread Abhay Kulkarni
available REST API. Thanks, Abhay Kulkarni

Re: Review Request 32485: RANGER-338 fix

2017-04-13 Thread Abhay Kulkarni
/org/apache/ranger/services/storm/client/StormClient.java 88303e7 Diff: https://reviews.apache.org/r/32485/diff/1/ Testing --- Built clean and ran unit tests. Thanks, Abhay Kulkarni

Re: Review Request 32548: Fixes for RANGER-339

2017-04-13 Thread Abhay Kulkarni
/unix/jaas/ConsolePromptCallbackHandler.java 62a3d5a Diff: https://reviews.apache.org/r/32548/diff/1/ Testing --- Built clean, ran unit tests, and ranger admin GUI. Thanks, Abhay Kulkarni

Re: Review Request 38235: RANGER-621 - Fixed impliedGrants specification in the Solr service definition

2017-04-13 Thread Abhay Kulkarni
-solr.json bc27352 Diff: https://reviews.apache.org/r/38235/diff/1/ Testing --- Ran unit tests. Thanks, Abhay Kulkarni

Re: Review Request 40240: RANGER-726: Fixed handling of hive_table entity notifications changes introduced in 0.6 Atlas

2017-04-13 Thread Abhay Kulkarni
/40240/diff/1/ Testing --- Ran unit tests. Tested against an Atlas installation in test cluster. Thanks, Abhay Kulkarni

Re: Review Request 58219: Support administration of Tag-based masking policies

2017-04-21 Thread Abhay Kulkarni
in the tag service-def. Thanks, Abhay Kulkarni

Review Request 58632: Add tag attributes to audit log record

2017-04-21 Thread Abhay Kulkarni
in generated audit record in GUI to verify that EXPIRES_ON tag is correctly shown alongwith its 'expiry_date' attribute-value. Thanks, Abhay Kulkarni

Re: Review Request 57301: RANGER-1422:Ranger Knox Plugin audit doesn't have the access type populated

2017-03-03 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57301/#review167881 --- Ship it! Ship It! - Abhay Kulkarni On March 3, 2017, 7:34

Re: Review Request 57438: Disable optimization for selective download of tags to components by default

2017-03-08 Thread Abhay Kulkarni
all unit tests. Thanks, Abhay Kulkarni

Review Request 57441: Turn Ranger deny policy & except condition blocks ON by default

2017-03-08 Thread Abhay Kulkarni
/main/java/org/apache/ranger/plugin/util/ServiceDefUtil.java dbdc935 security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefService.java 53b12d8 Diff: https://reviews.apache.org/r/57441/diff/1/ Testing --- Tested with local VM. Thanks, Abhay Kulkarni

Re: Review Request 57303: Refactoring to move default policy creation to RangerService classes

2017-03-11 Thread Abhay Kulkarni
://reviews.apache.org/r/57303/diff/3-4/ Testing --- Very basic testing done only in a simple cluster. Thanks, Abhay Kulkarni

Review Request 57438: Disable optimization for selective download of tags to components by default

2017-03-08 Thread Abhay Kulkarni
/RangerTagDBRetriever.java bdac0e8 security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 053df24 Diff: https://reviews.apache.org/r/57438/diff/1/ Testing --- Clean compiled, and ran all unit tests. Thanks, Abhay Kulkarni

Re: Review Request 56571: RANGER-1321:Provide a mechanism to create service-specific default policies

2017-03-01 Thread Abhay Kulkarni
e for which default policies are being created in this class. Ideally, this class should concern itself only with managing datastore for Ranger objects. - Abhay Kulkarni On Feb. 24, 2017, 8:19 a.m., Ramesh Mani wrote: > > --- > Thi

Re: Review Request 61078: RANGER-1708: Remove tag services from service type and service name filters under Access Audit.

2017-08-02 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61078/#review182021 --- Ship it! Ship It! - Abhay Kulkarni On Aug. 1, 2017, 6:42

Re: Review Request 61419: RANGER-1501:Audit Flush to HDFS does not actually cause the audit logs to be flushed to HDFS- improvement patch

2017-08-03 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61419/#review182173 --- Ship it! Ship It! - Abhay Kulkarni On Aug. 3, 2017, 10:01

Re: Review Request 61678: Call HDFS Native authorizer with correct parameters in case of fall-back

2017-08-16 Thread Abhay Kulkarni
/ Changes: https://reviews.apache.org/r/61678/diff/1-2/ Testing --- Tested with local VM Thanks, Abhay Kulkarni

Re: Review Request 60781: RANGER-1689:Add support for defining recursive policies for WASB service def

2017-07-11 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60781/#review180242 --- Ship it! Ship It! - Abhay Kulkarni On July 11, 2017, 7:20

Review Request 60949: Optimize Ranger code for authorization of HDFS 'getContentSummary' and 'delete' commands

2017-07-18 Thread Abhay Kulkarni
/policyengine/RangerPolicyenginePerfTester.java 056c548 storm-agent/src/main/java/org/apache/ranger/authorization/storm/authorizer/RangerStormAuthorizer.java 23c2b5f Diff: https://reviews.apache.org/r/60949/diff/1/ Testing (updated) --- Tested with local VM Thanks, Abhay Kulkarni

Review Request 61013: Request to get all policies for hive or hbase service-type does not include policies that apply to specific child resource(such as table in hive/column family in hbase)

2017-07-20 Thread Abhay Kulkarni
/resourcematcher/test_resourcematcher_wildcards_as_delimiters.json f896745 Diff: https://reviews.apache.org/r/61013/diff/1/ Testing --- Tested REST API as specified in the JIRA description, and verified that all necessary policies were returned. Thanks, Abhay Kulkarni

Re: Review Request 60949: Optimize Ranger code for authorization of HDFS 'getContentSummary' and 'delete' commands

2017-07-25 Thread Abhay Kulkarni
storm-agent/src/main/java/org/apache/ranger/authorization/storm/authorizer/RangerStormAuthorizer.java 23c2b5f Diff: https://reviews.apache.org/r/60949/diff/2/ Changes: https://reviews.apache.org/r/60949/diff/1-2/ Testing --- Tested with local VM Thanks, Abhay Kulkarni

Review Request 61199: Disable dynamic sorting of policies when trie pre-filter is enabled

2017-07-27 Thread Abhay Kulkarni
/diff/1/ Testing --- Tested in a local VM Thanks, Abhay Kulkarni

Re: Review Request 58154: Policy engine updates to support tag-based masking policies

2017-04-26 Thread Abhay Kulkarni
with dataMaskDef section for hive component, created a tag policy for data-masking; tagged a hive column with a tag and used beeline to test data-masking for that column. Thanks, Abhay Kulkarni

Re: Review Request 58154: Policy engine updates to support tag-based masking policies

2017-04-27 Thread Abhay Kulkarni
://reviews.apache.org/r/58154/diff/2-3/ Testing --- Updated Tag-Service-Definition with dataMaskDef section for hive component, created a tag policy for data-masking; tagged a hive column with a tag and used beeline to test data-masking for that column. Thanks, Abhay Kulkarni

Re: Review Request 61199: Disable dynamic sorting of policies when trie pre-filter is enabled

2017-07-28 Thread Abhay Kulkarni
/util/RangerResourceTrie.java c22ecde Diff: https://reviews.apache.org/r/61199/diff/3/ Changes: https://reviews.apache.org/r/61199/diff/2-3/ Testing --- Tested in a local VM Thanks, Abhay Kulkarni

Re: Review Request 61199: Disable dynamic sorting of policies when trie pre-filter is enabled

2017-07-28 Thread Abhay Kulkarni
/main/java/org/apache/ranger/plugin/util/RangerResourceTrie.java c22ecde Diff: https://reviews.apache.org/r/61199/diff/2/ Changes: https://reviews.apache.org/r/61199/diff/1-2/ Testing --- Tested in a local VM Thanks, Abhay Kulkarni

Re: Review Request 61412: RANGER-1649:Ranger Solr Plugin fails to refresh policy due to failure in ticket renewal mechanism

2017-08-09 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61412/#review182524 --- Ship it! Ship It! - Abhay Kulkarni On Aug. 9, 2017, 5:37

Re: Review Request 59247: Ranger plugins should use default service-def when it fails to obtain from Ranger Admin or cache

2017-05-12 Thread Abhay Kulkarni
commands through beeline command-line tool and verified that a. access to hive resource was denied, and b. audit log records were created, and viewable through ranger-admin GUI. Thanks, Abhay Kulkarni

Review Request 59247: Ranger plugins should use default service-def when it fails to obtain from Ranger Admin or cache

2017-05-12 Thread Abhay Kulkarni
through ranger-admin GUI. Thanks, Abhay Kulkarni

Re: Review Request 59296: Ranger plugins need to support additional date formats for tag attribute values

2017-05-17 Thread Abhay Kulkarni
testing specification and use of "ranger.plugin.tag.attr.additional.date.formats" configuration variable. Thanks, Abhay Kulkarni

Re: Review Request 59296: Ranger plugins need to support additional date formats for tag attribute values

2017-05-17 Thread Abhay Kulkarni
s://reviews.apache.org/r/59296/diff/3-4/ Testing --- Developed a unit test for testing specification and use of "ranger.plugin.tag.attr.additional.date.formats" configuration variable. Thanks, Abhay Kulkarni

Review Request 59296: Ranger plugins need to support additional date formats for tag attribute values

2017-05-15 Thread Abhay Kulkarni
e.json 1c7662d Diff: https://reviews.apache.org/r/59296/diff/1/ Testing --- Developed a unit test for testing specification and use of "ranger.plugin.tag.attr.additional.date.formats" configuration variable. Thanks, Abhay Kulkarni

Review Request 60286: Policy engine updates to support tag-based masking policies - update datamask/rowfilter resources

2017-06-21 Thread Abhay Kulkarni
://reviews.apache.org/r/60286/diff/1/ Testing --- Tested with a local VM Thanks, Abhay Kulkarni

Re: Review Request 60372: Disable propagation of row-filter-def from component servicedef to tag-servicedef

2017-06-22 Thread Abhay Kulkarni
GUI. Diffs - agents-common/src/main/java/org/apache/ranger/plugin/store/AbstractServiceStore.java 0b3ac60 Diff: https://reviews.apache.org/r/60372/diff/2/ Testing --- Tested with local VM. Thanks, Abhay Kulkarni

Review Request 60402: provide a way to get list of policies associated with given resource

2017-06-23 Thread Abhay Kulkarni
Diff: https://reviews.apache.org/r/60402/diff/1/ Testing --- Tested with local VM Thanks, Abhay Kulkarni

Re: Review Request 60140: RANGER-1647: Allow Ranger policy conditions to use tag attributes and values in Ranger

2017-06-21 Thread Abhay Kulkarni
t: > https://reviews.apache.org/r/60140/ > --- > > (Updated June 20, 2017, 11:36 p.m.) > > > Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Velmurugan > Periasamy. > > > Bugs: RANGER-1647 > https://issues.apache.org/jira/browse/RANGER-1647 > >

Re: Review Request 59296: Ranger plugins need to support additional date formats for tag attribute values

2017-05-18 Thread Abhay Kulkarni
testing specification and use of "ranger.plugin.tag.attr.additional.date.formats" configuration variable. Thanks, Abhay Kulkarni

Review Request 59729: Good coding practice suggested by static code analysis

2017-06-01 Thread Abhay Kulkarni
853c525 agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceTrie.java 7897f46 Diff: https://reviews.apache.org/r/59729/diff/1/ Testing --- Compiled clean and ran all unit tests successfully Thanks, Abhay Kulkarni

Review Request 59807: Good coding practice suggested by static code analysis

2017-06-05 Thread Abhay Kulkarni
/RangerPolicyResourceEvaluator.java 900b2e7 agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/ResourceMatcher.java aad353d Diff: https://reviews.apache.org/r/59807/diff/1/ Testing --- Compiled clean and passed all unit tests. Thanks, Abhay Kulkarni

Review Request 58912: Audit log record for 'show databases' hive command contains all tags

2017-05-01 Thread Abhay Kulkarni
--- Tested with local VM Thanks, Abhay Kulkarni

Re: Review Request 59809: RANGER-1631 : create temp function failing with permission issues

2017-06-05 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59809/#review176941 --- Ship it! Ship It! - Abhay Kulkarni On June 5, 2017, 5:41

Review Request 62483: Service should not be renamed if tagged service resources exist for it

2017-09-21 Thread Abhay Kulkarni
/jpa_named_queries.xml 68548a5 security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java 976fd0c Diff: https://reviews.apache.org/r/62483/diff/1/ Testing --- Ran all unit tests successfully. Tested with local VM. Thanks, Abhay Kulkarni

FW: New Defects reported by Coverity Scan for Apache Ranger

2017-09-21 Thread Abhay Kulkarni
Contributors/Committers, Please review and fix as appropriate. Thanks! On 9/21/17, 12:35 AM, "scan-ad...@coverity.com" wrote: > >Hi, > >Please find the latest report on new defect(s) introduced to Apache >Ranger found with Coverity Scan. > >9 new defect(s) introduced

Re: Review Request 62313: RANGER-1647: Allow Ranger policy conditions to use tag attributes and values in Ranger -- ranger0.7 branch

2017-09-14 Thread Abhay Kulkarni
ne 154) causes the value of the option to be overwritten. - Abhay Kulkarni On Sept. 13, 2017, 11:33 p.m., Sailaja Polavarapu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 62483: Service should not be renamed if tagged service resources exist for it

2017-09-22 Thread Abhay Kulkarni
omatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62483/#review185944 --- On Sept. 21, 2017, 11:11 p.m., Abhay Kulkarni wrote: > > --

FW: New Defects reported by Coverity Scan for Apache Ranger

2017-10-05 Thread Abhay Kulkarni
Ranger contributors/committers, Please review and fix as appropriate. Thanks! -Abhay On 10/5/17, 12:44 AM, "scan-ad...@coverity.com" wrote: > >Hi, > >Please find the latest report on new defect(s) introduced to Apache >Ranger found with Coverity Scan. > >1 new

Re: Review Request 62483: Service should not be renamed if tagged service resources exist for it

2017-10-16 Thread Abhay Kulkarni
/src/test/java/org/apache/ranger/rest/TestServiceREST.java 7c48d54 Diff: https://reviews.apache.org/r/62483/diff/2/ Changes: https://reviews.apache.org/r/62483/diff/1-2/ Testing --- Ran all unit tests successfully. Tested with local VM. Thanks, Abhay Kulkarni

Review Request 62947: Update Ranger to use 0.8.1 Atlas version

2017-10-12 Thread Abhay Kulkarni
/diff/1/ Testing --- Ensured that tagsync starts up without any errors. Thanks, Abhay Kulkarni

Re: Review Request 62918: RangerPolicy should use equals() to check equal for object of resources/policyItems/denyPolicyItems/allowExceptions/denyExceptions/dataMaskPolicyItems/rowFilterPolicyItems

2017-10-12 Thread Abhay Kulkarni
object. There is no need here for deep, object level equality check. This comment applies to all such changes in this patch. Thanks! - Abhay Kulkarni On Oct. 12, 2017, 2:25 a.m., Qiang Zhang wrote: > > --- > This is a

Review Request 63055: Audit log records for 'use dbName' and 'show databases' hive commands contain large number of tags

2017-10-16 Thread Abhay Kulkarni
with local VM Thanks, Abhay Kulkarni

Review Request 62208: Improve performance of merging lists of policyEvaluators returned by Trie

2017-09-10 Thread Abhay Kulkarni
of resource levels. Thanks, Abhay Kulkarni

FW: New Defects reported by Coverity Scan for Apache Ranger

2017-09-28 Thread Abhay Kulkarni
Contributors/Committers, Please review and fix as appropriate. Thanks! -Abhay On 9/28/17, 12:43 AM, "scan-ad...@coverity.com" wrote: > >Hi, > >Please find the latest report on new defect(s) introduced to Apache >Ranger found with Coverity Scan. > >1 new defect(s)

Review Request 63085: Tag enricher performance improvement in identifying tags for resource being accessed

2017-10-17 Thread Abhay Kulkarni
- agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java 5f0a422 Diff: https://reviews.apache.org/r/63085/diff/1/ Testing --- Passes all unit tests. Tested with perf-tool locally. Thanks, Abhay Kulkarni

Re: Review Request 63085: Tag enricher performance improvement in identifying tags for resource being accessed

2017-10-17 Thread Abhay Kulkarni
210eb3d5 Diff: https://reviews.apache.org/r/63085/diff/3/ Changes: https://reviews.apache.org/r/63085/diff/2-3/ Testing --- Passes all unit tests. Tested with perf-tool locally. Thanks, Abhay Kulkarni

Re: Review Request 63085: Tag enricher performance improvement in identifying tags for resource being accessed

2017-10-17 Thread Abhay Kulkarni
/RangerServiceDefHelper.java 210eb3d Diff: https://reviews.apache.org/r/63085/diff/2/ Changes: https://reviews.apache.org/r/63085/diff/1-2/ Testing --- Passes all unit tests. Tested with perf-tool locally. Thanks, Abhay Kulkarni

Re: Review Request 63085: Tag enricher performance improvement in identifying tags for resource being accessed

2017-10-18 Thread Abhay Kulkarni
/RangerServiceDefHelper.java 210eb3d Diff: https://reviews.apache.org/r/63085/diff/4/ Changes: https://reviews.apache.org/r/63085/diff/3-4/ Testing --- Passes all unit tests. Tested with perf-tool locally. Thanks, Abhay Kulkarni

Re: Review Request 63085: Tag enricher performance improvement in identifying tags for resource being accessed

2017-10-18 Thread Abhay Kulkarni
/RangerServiceDefHelper.java 210eb3d Diff: https://reviews.apache.org/r/63085/diff/5/ Changes: https://reviews.apache.org/r/63085/diff/4-5/ Testing --- Passes all unit tests. Tested with perf-tool locally. Thanks, Abhay Kulkarni

Re: Review Request 63225: Additional back-end work with more ServiceDef validations for Policy create/edit form should display only relevant accesses based on the user-selected resource

2017-10-23 Thread Abhay Kulkarni
/ Testing --- Developed unit tests for additional validations. Ran all unit tests successfully. Thanks, Abhay Kulkarni

Review Request 63225: Additional back-end work with more ServiceDef validations for Policy create/edit form should display only relevant accesses based on the user-selected resource

2017-10-23 Thread Abhay Kulkarni
/resourcematcher/test_defaultpolicyresourcematcher_for_resource_specific_policy.json 6b774f8 Diff: https://reviews.apache.org/r/63225/diff/1/ Testing --- Developed unit tests for additional validations. Ran all unit tests successfully. Thanks, Abhay Kulkarni

Re: Review Request 64042: RANGER-1897: tagsync update to replace Atlas V1 API usage with Atlas V2 API for tag-download using REST

2017-11-25 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64042/#review191850 --- Ship it! Ship It! - Abhay Kulkarni On Nov. 25, 2017, 8:43

Re: Review Request 64042: RANGER-1897: tagsync update to replace Atlas V1 API usage with Atlas V2 API for tag-download using REST

2017-11-22 Thread Abhay Kulkarni
> On Nov. 23, 2017, 1:41 a.m., Abhay Kulkarni wrote: > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java > > Line 298 (original), 466 (patched) > > <https://reviews.apache.org/r/64042/diff/1/?file=1900355#file1900355line471

Re: Review Request 64042: RANGER-1897: tagsync update to replace Atlas V1 API usage with Atlas V2 API for tag-download using REST

2017-11-22 Thread Abhay Kulkarni
elease registry if locked even in case of tty.addTypes() failure. - Abhay Kulkarni On Nov. 23, 2017, 12:52 a.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 61062: RANGER-1707 : fix hdfs traverse check

2017-11-22 Thread Abhay Kulkarni
> On Nov. 22, 2017, 2:35 p.m., Colm O hEigeartaigh wrote: > > Ship It! All, Can we please hold on pushing this patch? I am waiting for input from HDFS committers to ensure that this new HDFS authorization (Traverse checking) call sequence is what is intendeded. Thanks! - Abhay

Re: Review Request 63995: Ranger-1488 Adding GaianDB plugin serviceDef

2017-11-22 Thread Abhay Kulkarni
r": "org.apache.ranger.plugin.resourcematcher.RangerDefaultResourceMatcher", "matcherOptions": { "wildCard":false, "ignoreCase":true }, "validationRegEx":"",

Review Request 64189: TagSync should replace use of V1 Atlas APIs with V2 APIs for efficient tag-download from Atlas

2017-11-29 Thread Abhay Kulkarni
/tagsync/process/TestKafkaResourceMapper.java 3beb82f Diff: https://reviews.apache.org/r/64189/diff/1/ Testing --- Tested in local VM. Thanks, Abhay Kulkarni

Review Request 64228: Traverse check in RangerHdfsAuthorizer works incorrectly

2017-11-30 Thread Abhay Kulkarni
/src/test/java/org/apache/ranger/services/hdfs/RangerHdfsAuthorizerTest.java PRE-CREATION hdfs-agent/src/test/resources/hdfs-policies.json 056231f Diff: https://reviews.apache.org/r/64228/diff/1/ Testing --- Unit tested with HDFS versions 2.7.1 and 3.0.0. Thanks, Abhay Kulkarni

Re: Review Request 61062: RANGER-1707 : fix hdfs traverse check

2017-11-30 Thread Abhay Kulkarni
> On Nov. 22, 2017, 2:35 p.m., Colm O hEigeartaigh wrote: > > Ship It! > > Abhay Kulkarni wrote: > All, > > Can we please hold on pushing this patch? I am waiting for input from > HDFS committers to ensure that this new HDFS authorization (Traverse

  1   2   3   4   5   6   7   8   >