Review Request 56192: RANGER-1338:Ranger Plugin failed to download policy when JaasConfig alone is used to set the UGI instead of Principal/Keytab

2017-02-01 Thread Ramesh Mani
://reviews.apache.org/r/56192/diff/ Testing --- Thanks, Ramesh Mani

Re: Review Request 56192: RANGER-1338:Ranger Plugin failed to download policy when JaasConfig alone is used to set the UGI instead of Principal/Keytab

2017-02-01 Thread Ramesh Mani
/storm/authorizer/RangerStormAuthorizer.java c66b665 Diff: https://reviews.apache.org/r/56192/diff/ Testing (updated) --- Testing done in Local VM Thanks, Ramesh Mani

Re: Review Request 56192: RANGER-1338:Ranger Plugin failed to download policy when JaasConfig alone is used to set the UGI instead of Principal/Keytab

2017-02-03 Thread Ramesh Mani
in Local VM Thanks, Ramesh Mani

Re: Review Request 56146: RANGER-1342: Hive test connection is not working when using local/ldap user credentials in repo config

2017-01-31 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56146/#review163769 --- Ship it! Ship It! - Ramesh Mani On Feb. 1, 2017, 1:24 a.m

Review Request 56406: RANGER-1355:Ranger HiveAuthorizer should check for ALTER permission for MSCK command while authorizing

2017-02-07 Thread Ramesh Mani
: https://reviews.apache.org/r/56406/diff/ Testing --- Tested in local vm Thanks, Ramesh Mani

Review Request 56335: Ranger Audit framework enhancement to provide an option to allow audit records to be spooled to local disk first before sending it to destinations

2017-02-06 Thread Ramesh Mani
ugin, when Hiveserver2 is restarted audit into HDFS appears as this will close the existing opened hdfsfile) - Mentioned issue should not be present - - 3) Same has to be done for each for the plugins ( HBASE, STORM, KAFKA, KMS) Thank

Re: [VOTE] Release Apache Ranger 0.6.3 - release candidate 1 (dev group vote)

2017-01-27 Thread Ramesh Mani
+1 (binding) Did full maven build of source from https://dist.apache.org/repos/dist/dev/ranger/0.6.3-rc1/apache-ranger-0.6.3 .tar.gz without issue. Verified some of the src files. Thanks, Ramesh On 1/26/17, 12:50 PM, "Velmurugan Periasamy" wrote: >Rangers: > >Apache

Review Request 57002: RANGER-1406: Audit spoolfile not getting created when ranger service user didn't have permission to log into Solr

2017-02-23 Thread Ramesh Mani
/apache/ranger/audit/destination/SolrAuditDestination.java 405cfee Diff: https://reviews.apache.org/r/57002/diff/ Testing --- Testing done in local Thanks, Ramesh Mani

Re: Review Request 57002: RANGER-1406: Audit spoolfile not getting created when ranger service user didn't have permission to log into Solr

2017-02-23 Thread Ramesh Mani
permission to log into Solr Diffs (updated) - agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java 405cfee Diff: https://reviews.apache.org/r/57002/diff/ Testing (updated) --- Testing done in local vm Thanks, Ramesh Mani

Re: Review Request 56571: RANGER-1321:Provide a mechanism to create service-specific default policies

2017-02-24 Thread Ramesh Mani
security-admin/pom.xml 0fcfc5a security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java cb67b6a security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java 2b773da Diff: https://reviews.apache.org/r/56571/diff/ Testing --- Test in Local VM Thanks, Ramesh

Re: [VOTE] Apache Ranger Release 0.7.0 - rc1

2017-02-21 Thread Ramesh Mani
+1 (binding) - Did successful build of apache-ranger-0.7.0.tar.gz with rat plugin. - Verified PGP signature, MD5/SHA hash. Thanks, Ramesh On 2/20/17, 10:21 AM, "Selvamohan Neethiraj" wrote: >Rangers: > > > >Thank you for your contribution to this Apache community to be

Review Request 56614: RANGER-1381:Add hadoop-common.jar as dependency to ranger-hive-utils package to avoid build failure

2017-02-13 Thread Ramesh Mani
://reviews.apache.org/r/56614/diff/ Testing --- Testing done in Local build Thanks, Ramesh Mani

Review Request 56612: RANGER-1382:Good coding practice in Ranger recommended by static code analysis

2017-02-13 Thread Ramesh Mani
/AuditFileCacheProviderSpool.java 94db401 Diff: https://reviews.apache.org/r/56612/diff/ Testing --- Tested in Local Vm Thanks, Ramesh Mani

Re: Last date for submitting abstracts - DW summit

2017-02-10 Thread Ramesh Mani
Balaji, I have submitted now a Abstract on how to "Extending Ranger Authorization Model to other ApplicationsĀ² Thanks, Ramesh On 2/10/17, 10:03 AM, "Balaji Ganesan" wrote: >Rangers, > >Today is the deadline for submitting abstracts to Data Works/Hadoop Summit

Re: Review Request 56335: RANGER-1310: Ranger Audit framework enhancement to provide an option to allow audit records to be spooled to local disk first before sending it to destinations

2017-02-10 Thread Ramesh Mani
- 3) Same has to be done for each for the plugins ( HBASE, STORM, KAFKA, KMS) Thanks, Ramesh Mani

Review Request 56571: RANGER-1321:Provide a mechanism to create service-specific default policies

2017-02-10 Thread Ramesh Mani
in Local VM Thanks, Ramesh Mani

Re: Review Request 56461: Modify Ranger Hbase Plugin ColumnIterator to use Cell instead of KeyValue (to avoid ClassCastException in certain cases)

2017-02-09 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56461/#review164953 --- Ship it! Ship It! - Ramesh Mani On Feb. 8, 2017, 8:23 p.m

Re: Review Request 57099: Good coding practice in Ranger recommended by static code analysis

2017-02-27 Thread Ramesh Mani
/test/java/org/apache/ranger/plugin/resourcematcher/TestDefaultPolicyResourceMatcherForPolicy.java (line 137) <https://reviews.apache.org/r/57099/#comment239009> class level object need not be initialized - Ramesh Mani On Feb. 27, 2017, 7:03 p.m., Abhay Kulkarni

Re: Review Request 57099: Good coding practice in Ranger recommended by static code analysis

2017-02-27 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57099/#review166924 --- Ship it! Ship It! - Ramesh Mani On Feb. 27, 2017, 7:43 p.m

Re: Review Request 57123: RANGER-1407 : Service update transaction log is not generated in some cases

2017-02-28 Thread Ramesh Mani
(patched) <https://reviews.apache.org/r/57123/#comment239378> !"null".equalsIgnoreCase(oldValue) is the check done because oldValue will have a string "null". if this check is only for null value please remove it. - Ramesh Mani On March

Re: Question about group policies

2017-03-24 Thread Ramesh Mani
Adding to Abhay comment, In most of the Ranger Plugin from the components side we use org.apache.hadoop.security.UserGroupInformation API https://hadoop.apache.org/docs/r1.0.4/api/org/apache/hadoop/security/UserGr oupInformation.html which will wrap around JAAS and provides the mechanism to

Re: Question about group policies

2017-03-30 Thread Ramesh Mani
. By "work" I mean >when a user is a member of the group and only a group policy is defined, >then passing only the username results in policy evaluating correctly and >granting access to the resource. I have not yet tested this LDAP scenario >myself. Ramesh Mani: Groups

Re: Review Request 57988: RANGER-1479 : Fix bug in ranger-*-(security/audit).xml loading, which prevented loading from JAR's

2017-03-29 Thread Ramesh Mani
Rule:UnusedImports Priority:4 Avoid unused imports such as 'java.net.MalformedURLException'. - Ramesh Mani On March 29, 2017, 3:34 p.m., Zsombor Gegesy wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 58067: Ranger hive service definition to use hive metastore directly

2017-03-31 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58067/#review170738 --- Ship it! Ship It! - Ramesh Mani On March 31, 2017, 9:15 a.m

Re: Review Request 58067: Ranger hive service definition to use hive metastore directly

2017-03-31 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58067/#review170742 --- Ship it! Ship It! - Ramesh Mani On March 31, 2017, 9:15 a.m

Re: Review Request 57988: RANGER-1479 : Fix bug in ranger-*-(security/audit).xml loading, which prevented loading from JAR's

2017-03-31 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57988/#review170739 --- Ship it! Ship It! - Ramesh Mani On March 31, 2017, 12:32

Re: Review Request 57641: RANGER-1458 - Starting Yarn failed after installing Ranger Yarn Plugin

2017-03-15 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57641/#review169031 --- Ship it! Ship It! - Ramesh Mani On March 15, 2017, 12:39

Review Request 58165: RANGER-1495: Good coding practices recommendation by static code analysis

2017-04-03 Thread Ramesh Mani
6cc62a7 Diff: https://reviews.apache.org/r/58165/diff/1/ Testing --- Testing done in VM Thanks, Ramesh Mani

Re: Review Request 58115: Ranger-1489: Solr plugin fails to get client address

2017-04-01 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58115/#review170818 --- Ship it! Ship It! - Ramesh Mani On March 31, 2017, 6:20 p.m

Re: Review Request 58184: [RANGER-1497]Improvement of unit test coverage for ranger

2017-04-05 Thread Ramesh Mani
or all the grant access and if there is a failure there that means grant failed. Please check all the other occurances like this for handling the exception cases. - Ramesh Mani On April 5, 2017, 9:08 a.m., deepak sharma

Re: Review Request 58229: RANGER-1481 : Capture cluster name in ranger audit info

2017-04-20 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58229/#review172563 --- Ship it! Ship It! - Ramesh Mani On April 6, 2017, 7:16 a.m

Re: ranger for cassandra

2017-04-19 Thread Ramesh Mani
Earlier I have reviewed briefly the Cassandra authorizer and it is RBAC based authorization model which is not a straight forward fit into Ranger's Attribute Based Access Control model. Including dev list also. Pinging Bosco / Madhan to give their thoughts. Thanks, Ramesh From: anurag

Review Request 58658: RANGER-1513:Add Support for S3 authorization in Ranger Hive Plugin

2017-04-24 Thread Ramesh Mani
/HIVERangerAuthorizerTest.java 57b4eef hive-agent/src/test/resources/hive-policies.json 2b568dc Diff: https://reviews.apache.org/r/58658/diff/1/ Testing --- Test in local VM Thanks, Ramesh Mani

Review Request 57301: RANGER-1422:Ranger Knox Plugin audit doesn't have the access type populated

2017-03-03 Thread Ramesh Mani
, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. Bugs: RANGER-1422 https://issues.apache.org/jira/browse/RANGER-1422 Repository: ranger Description --- RANGER-1422:Ranger Knox Plugin audit doesn't have the access type

Re: Review Request 57239: RANGER-1416 - SunX509 is the hardcoded Algorithm for SSL

2017-03-03 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57239/#review167904 --- Ship it! verified the patch. - Ramesh Mani On March 2, 2017

Re: Review Request 57303: Refactoring to move default policy creation to RangerService classes

2017-03-13 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57303/#review168806 --- Ship it! Ship It! - Ramesh Mani On March 11, 2017, 8:44 a.m

Re: Auditing using Solr

2017-03-06 Thread Ramesh Mani
Nigel, There is one option which introduced by https://issues.apache.org/jira/browse/RANGER-1310. This will enable you to always spool to local disk first before the audit is pushed to the destinations. This guarantees that the audit data is not lost if the memory queue is destroyed by the

Re: Review Request 57123: RANGER-1407 : Service update transaction log is not generated in some cases

2017-03-01 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57123/#review167343 --- Ship it! Ship It! - Ramesh Mani On March 1, 2017, 8:52 a.m

Re: Review Request 58272: Ranger-1502: Solr shutdown does not cause the audit log file to be flushed and closed

2017-08-03 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58272/#review182129 --- Ship it! Ship It! - Ramesh Mani On April 7, 2017, 9:48 p.m

Re: Review Request 58268: Ranger-1501: Audit Flush to HDFS does not actually cause the audit logs to be flushed to HDFS

2017-08-03 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58268/#review182130 --- Ship it! Ship It! - Ramesh Mani On April 25, 2017, 2:54 p.m

Re: Review Request 61652: RANGER-1734 - Close the connection in the HIVERangerAuthorizerTest

2017-08-15 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61652/#review182952 --- Ship it! Ship It! - Ramesh Mani On Aug. 15, 2017, 9:06 a.m

Re: Review Request 61594: RANGER-1731: Exclude multiple guava versions

2017-08-11 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61594/#review182729 --- Ship it! Ship It! - Ramesh Mani On Aug. 11, 2017, 1:10 p.m

Re: Review Request 61412: RANGER-1649:Ranger Solr Plugin fails to refresh policy due to failure in ticket renewal mechanism

2017-08-09 Thread Ramesh Mani
/ Changes: https://reviews.apache.org/r/61412/diff/2-3/ Testing --- fixed PMD issue with earlier patch. Testing done in local VM. Thanks, Ramesh Mani

Re: Review Request 61412: RANGER-1649:Ranger Solr Plugin fails to refresh policy due to failure in ticket renewal mechanism

2017-08-09 Thread Ramesh Mani
nused function - Ramesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61412/#review182403 --- On Aug. 9, 2017, 5:3

Re: Review Request 60596: Ranger UI should consider "recursiveSupported" attribute value at each resource level to Store the Policy.

2017-07-07 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60596/#review179904 --- Ship it! Ship It! - Ramesh Mani On July 4, 2017, 5:44 a.m

Review Request 60781: RANGER-1689:Add support for defining recursive policies for WASB service def

2017-07-11 Thread Ramesh Mani
--- Test in local VM Thanks, Ramesh Mani

Re: Review Request 61021: RANGER-1672:Ranger supports plugin to enable, monitor and manage apache kylin

2017-07-24 Thread Ramesh Mani
> On July 24, 2017, 11:17 p.m., Ramesh Mani wrote: > > This seems to be interesting contribution! Thanks. - Ramesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61021/#rev

Re: Review Request 61021: RANGER-1672:Ranger supports plugin to enable, monitor and manage apache kylin

2017-07-24 Thread Ramesh Mani
) <https://reviews.apache.org/r/61021/#comment256818> Repeated class kylinUserResponse. Make it part of Util class - Ramesh Mani On July 21, 2017, 7:40 a.m., Qiang Zhang wrote: > > --- > This is an aut

Re: Review Request 58658: RANGER-1513:Add Support for S3 authorization in Ranger Hive Plugin

2017-04-30 Thread Ramesh Mani
://reviews.apache.org/r/58658/diff/2/ Changes: https://reviews.apache.org/r/58658/diff/1-2/ Testing --- Test in local VM Thanks, Ramesh Mani

Re: Review Request 61412: RANGER-1649:Ranger Solr Plugin fails to refresh policy due to failure in ticket renewal mechanism

2017-08-07 Thread Ramesh Mani
/ Changes: https://reviews.apache.org/r/61412/diff/1-2/ Testing (updated) --- fixed PMD issue with earlier patch. Testing done in local VM. Thanks, Ramesh Mani

Re: New Defects reported by Coverity Scan for Apache Ranger

2017-08-06 Thread Ramesh Mani
Bosco, I am working on these defects, Thanks, Ramesh On 8/6/17, 1:10 PM, "Don Bosco Durai" wrote: >Please review and fix. > >Thanks > >Bosco > > >On 8/6/17, 12:44 AM, "scan-ad...@coverity.com" >wrote: > > >Hi, > >Please find the

Re: Review Request 61783: created unit test for RANGER-1631

2017-08-22 Thread Ramesh Mani
t.java code which shows up in RED bars in the review. - Ramesh Mani On Aug. 21, 2017, 3:04 p.m., Endre Zoltan Kovacs wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 60361: RANGER-1663 - Make Kafka GSS test more robust

2017-06-23 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60361/#review178802 --- Ship it! Ship It! - Ramesh Mani On June 23, 2017, 9:02 a.m

Re: Review Request 60454: RANGER-1669:We need to support the original functionality of hive.show grant user username

2017-06-27 Thread Ramesh Mani
is has to be discussed with Hive comitter also. - Ramesh Mani On June 27, 2017, 10:57 a.m., pengjianhua wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 60454: RANGER-1669:We need to support the original functionality of hive.show grant user username

2017-06-27 Thread Ramesh Mani
ly, visit: > https://reviews.apache.org/r/60454/ > --- > > (Updated June 27, 2017, 10:57 a.m.) > > > Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, Ramesh Mani, > Velmurugan Periasamy, and Qiang Zh

Re: [VOTE] Release Apache Ranger 0.7.1 - release candidate 1 (dev group vote)

2017-06-02 Thread Ramesh Mani
+1 - Did successful build of apache-ranger-0.7.1.tar.gz with rat plugin. - Verified some source files. - Verified PGP signature, MD5/SHA hash. Thanks, Ramesh On 6/1/17, 8:08 AM, "Velmurugan Periasamy" wrote: >Hello Rangers: > >Apache Ranger 0.7.1 release candidate #1 is

Re: Review Request 59753: RANGER-1630 - StormClient doesn't decrypt password

2017-06-02 Thread Ramesh Mani
/client/StormClient.java Lines 399 (patched) <https://reviews.apache.org/r/59753/#comment250301> Minor error "Storm" connection not knox connection. - Ramesh Mani On June 2, 2017, 4:46 p.m., Colm O hE

Review Request 59809: RANGER-1631 : create temp function failing with permission issues

2017-06-05 Thread Ramesh Mani
/ Testing --- Testing done in local VM with command create temporary function row_sequence as 'org.apache.hadoop.hive.contrib.udf.UDFRowSequence' using jar '/usr/hdp/2.6.1.0-122/hive/lib/hive-contrib-1.2.1000.2.6.1.0-122.jar'; Thanks, Ramesh Mani

Re: Review Request 59753: RANGER-1630 - StormClient doesn't decrypt password

2017-06-05 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59753/#review176898 --- Ship it! fix the minor error and ship it - Ramesh Mani

Review Request 59041: RANGER-1561:Good coding practice in Ranger recommended by static code analysis

2017-05-07 Thread Ramesh Mani
/HIVERangerAuthorizerTest.java c4c2a2a security-admin/src/main/java/org/apache/ranger/patch/PatchForHiveServiceDefUpdate_J10007.java a886945 Diff: https://reviews.apache.org/r/59041/diff/1/ Testing --- Tested locally Thanks, Ramesh Mani

Re: Review Request 58658: RANGER-1513:Add Support for S3 authorization in Ranger Hive Plugin

2017-05-04 Thread Ramesh Mani
://reviews.apache.org/r/58658/diff/3/ Changes: https://reviews.apache.org/r/58658/diff/2-3/ Testing --- Test in local VM Thanks, Ramesh Mani

Re: Review Request 58658: RANGER-1513:Add Support for S3 authorization in Ranger Hive Plugin

2017-05-04 Thread Ramesh Mani
------- On May 4, 2017, 5:10 p.m., Ramesh Mani wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58658/ > --

Re: Review Request 61553: RANGER-1730 : Utility script that will list the users with a given role

2017-09-19 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61553/#review185650 --- Ship it! Ship It! - Ramesh Mani On Sept. 15, 2017, 10:17

Re: Review Request 62437: RANGER-1779 : last resource gets duplicated during update policy if policy is created through public api rest call

2017-09-20 Thread Ramesh Mani
/ServiceDBStore.java Line 2929 (original), 2930 (patched) <https://reviews.apache.org/r/62437/#comment262157> Please conside doing Set uniqueValues = new LinkedHashSet<>(values); and remove the code for finding the uniqueValues. You can trim the output later when you sent it if needed. -

Re: Review Request 61553: RANGER-1730 : Utility script that will list the users with a given role

2017-09-14 Thread Ramesh Mani
es 247 (patched) <https://reviews.apache.org/r/61553/#comment261683> Authorized? - Ramesh Mani On Sept. 14, 2017, 4:33 a.m., Fatima Khan wrote: > > --- > This is an automatically gene

Re: Review Request 62709: RANGER-1817 : Audit to Solr fails to log when the number of columns are in large number

2017-10-03 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62709/#review187051 --- Ship it! Ship It! - Ramesh Mani On Sept. 30, 2017, 6:26 a.m

Re: Review Request 63055: Audit log records for 'use dbName' and 'show databases' hive commands contain large number of tags

2017-10-16 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63055/#review188238 --- Ship it! Ship It! - Ramesh Mani On Oct. 16, 2017, 11:20 p.m

Re: Review Request 62024: RANGER-1756: Handle role related restrictions for users having User role.

2017-09-27 Thread Ramesh Mani
iginal), 370 (patched) <https://reviews.apache.org/r/62024/#comment263010> will CollectionUtils.size be more 1?, if so change this check CollectionUtils.size(userRolesList) == 1 to CollectionUtils.size(userRolesList) > 0 - Ramesh Mani On Sept. 27, 2017, 11:27 a.m., Nit

Re: Review Request 62709: RANGER-1817 : Audit to Solr fails to log when the number of columns are in large number

2017-09-30 Thread Ramesh Mani
Lines 32 (patched) <https://reviews.apache.org/r/62709/#comment263620> We need to have a default value for this config in ranger, which can be overridden. Default can be a much less value say 100, which can be rendered on UI without any performance issue. - Ramesh Mani O

Re: Review Request 62710: RANGER-1810:Ranger supports plugin to enable, monitor and manage apache Sqoop2

2017-10-02 Thread Ramesh Mani
/authorizer/RangerSqoopAuthorizer.java Lines 99 (patched) <https://reviews.apache.org/r/62710/#comment263728> can privilege be null? Is it test for this case? Please add some unit test also for various scenarios. - Ramesh Mani On Sept. 30, 2017, 8:34 a.m., Qiang Zhang

Re: Review Request 61783: created unit test for RANGER-1631

2017-08-31 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61783/#review184322 --- Ship it! Ship It! - Ramesh Mani On Aug. 23, 2017, 10:57 a.m

Re: Review Request 63919: RANGER-1895 - Simplify Storm dependencies

2017-11-27 Thread Ramesh Mani
tps://reviews.apache.org/r/63919/#comment269849> Colm, did you verify that audit to solr is working as expected? We may need this solr jar for Ranger audit dependency - Ramesh Mani On Nov. 27, 2017, 3:27 p.m., Colm O hEigeartaigh

Re: Review Request 63919: RANGER-1895 - Simplify Storm dependencies

2017-11-27 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63919/#review191925 --- Ship it! Ship It! - Ramesh Mani On Nov. 27, 2017, 3:27 p.m

Re: Moving master to Java 1.8?

2017-12-18 Thread Ramesh Mani
Colm, I having being thinking on this, when we move to Hbase 2.0 version we need Java 1.8 for the Ranger hbase plugin to compile. +1 for this. Thanks, Ramesh On 12/16/17, 10:18 AM, "Colm O hEigeartaigh" wrote: >Hi all, > >Before I fix the currently failing Hive tests

Re: Review Request 63552: RANGER-1837:Enhance Ranger Audit to HDFS to support ORC file format

2017-11-17 Thread Ramesh Mani
; > > Should we log and ignore this Exception This is done for purpose, so that the calling source can do the deffered count and log it. - Ramesh --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 63552: RANGER-1837:Enhance Ranger Audit to HDFS to support ORC file format

2017-11-17 Thread Ramesh Mani
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63552/#review190782 ------- On Nov. 17, 2017, 7:38 p.m., Ramesh Mani wrote: > > -

Re: Review Request 63552: RANGER-1837:Enhance Ranger Audit to HDFS to support ORC file format

2017-11-17 Thread Ramesh Mani
://reviews.apache.org/r/63552/diff/3-4/ Testing --- Testing done in local Thanks, Ramesh Mani

Re: Review Request 63552: RANGER-1837:Enhance Ranger Audit to HDFS to support ORC file format

2017-11-17 Thread Ramesh Mani
ches created. Yes, this is possible. We have three buffer params which I shall discuss in detail in JIRA and how to handle this. - Ramesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.

Re: Review Request 63785: RANGER-1884 : Default Policy is not created for Ranger KMS and Tag service

2017-11-14 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63785/#review190978 --- Ship it! Ship It! - Ramesh Mani On Nov. 14, 2017, 4:59 a.m

Re: Review Request 63552: RANGER-1837:Enhance Ranger Audit to HDFS to support ORC file format

2017-11-17 Thread Ramesh Mani
generated e-mail. To reply, visit: https://reviews.apache.org/r/63552/#review190104 ------- On Nov. 17, 2017, 7:38 p.m., Ramesh Mani wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.

Re: Plugin Shim question

2017-11-09 Thread Ramesh Mani
Colm, Yes look like we need to have multiple shims. To support multiple version of Hadoop, we may need a super shim which will find which version of Hadoop ( based on method signature) is used and then instantiate the corresponding sub shim RangerYarnAuthorizer. This may be the case for HDFS

Re: Review Request 63552: RANGER-1837:Enhance Ranger Audit to HDFS to support ORC file format

2017-11-03 Thread Ramesh Mani
://reviews.apache.org/r/63552/diff/3/ Changes: https://reviews.apache.org/r/63552/diff/2-3/ Testing --- Testing done in local Thanks, Ramesh Mani

Re: Review Request 63552: RANGER-1837:Enhance Ranger Audit to HDFS to support ORC file format

2017-11-03 Thread Ramesh Mani
/ Changes: https://reviews.apache.org/r/63552/diff/1-2/ Testing --- Testing done in local Thanks, Ramesh Mani

Review Request 63552: RANGER-1837:Enhance Ranger Audit to HDFS to support ORC file format

2017-11-03 Thread Ramesh Mani
/Writer.java PRE-CREATION pom.xml 589cd6a src/main/assembly/hdfs-agent.xml 5279a9a Diff: https://reviews.apache.org/r/63552/diff/1/ Testing --- Testing done in local Thanks, Ramesh Mani

Re: Review Request 64375: RANGER-1917 - Remove solr dependency from Kafka + Sqoop modules

2017-12-06 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64375/#review193084 --- Ship it! Ship It! - Ramesh Mani On Dec. 6, 2017, 12:37 p.m

Re: Review Request 64051: RANGER-1906 - Simplify Atlas plugin dependency management

2017-12-06 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64051/#review193085 --- Ship it! Ship It! - Ramesh Mani On Nov. 28, 2017, 11:44 a.m

Re: Review Request 64365: RANGER-1916:Remove duplicate code and optimize code in AtlasClient.class

2017-12-06 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64365/#review193086 --- Ship it! Ship It! - Ramesh Mani On Dec. 6, 2017, 7:53 a.m

Re: Review Request 67192: RANGER-2105:Ranger HiveAuthorization for INSERT OVERWRITE DIRECTORY

2018-05-18 Thread Ramesh Mani
) - hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java 780afac Diff: https://reviews.apache.org/r/67192/diff/2/ Changes: https://reviews.apache.org/r/67192/diff/1-2/ Testing --- Testing done in Local VM Thanks, Ramesh Mani

Review Request 67192: RANGER-2105:Ranger HiveAuthorization for INSERT OVERWRITE DIRECTORY

2018-05-17 Thread Ramesh Mani
/RangerHiveAuthorizer.java 780afac Diff: https://reviews.apache.org/r/67192/diff/1/ Testing --- Testing done in Local VM Thanks, Ramesh Mani

Review Request 67618: RANGER-2134:Ranger Storm Plugin fails to download policies with Storm autocreds in classpath

2018-06-15 Thread Ramesh Mani
://reviews.apache.org/r/67618/diff/1/ Testing --- Verified in local vm Thanks, Ramesh Mani

Re: Review Request 67347: RANGER-2115: Atlas service-def creation failing during Ranger installation

2018-05-29 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67347/#review203960 --- Ship it! Ship It! - Ramesh Mani On May 29, 2018, 5:43 a.m

Review Request 67426: RANGER-2120:Include protobuf-java.jar to Ranger Kafka plugin dependencies

2018-06-03 Thread Ramesh Mani
/67426/diff/1/ Testing --- Verified in Local VM Thanks, Ramesh Mani

Re: Review Request 67409: RANGER-2117:RangerKafkaAuthorizer to support new resources and operations which are in Apache Kafka 1.0.0

2018-06-04 Thread Ramesh Mani
ory, lookupSupported and recursiveSupported values in the service def - Ramesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67409/#review204190 ------- On June 4, 2018, 9:51 p.m., Ramesh Mani wrote: > >

Re: Review Request 67409: RANGER-2117:RangerKafkaAuthorizer to support new resources and operations which are in Apache Kafka 1.0.0

2018-06-04 Thread Ramesh Mani
: https://reviews.apache.org/r/67409/diff/1-2/ Testing --- Tested in Local VM Thanks, Ramesh Mani

Re: Review Request 67409: RANGER-2117:RangerKafkaAuthorizer to support new resources and operations which are in Apache Kafka 1.0.0

2018-05-31 Thread Ramesh Mani
23b9299 plugin-kafka/src/test/resources/kafka-policies.json d0e469a security-admin/src/main/java/org/apache/ranger/patch/PatchForKafkaServiceDefUpdate_J10015.java PRE-CREATION Diff: https://reviews.apache.org/r/67409/diff/1/ Testing --- Tested in Local VM Thanks, Ramesh Mani

Review Request 67409: RANGER-2117:RangerKafkaAuthorizer to support new resources and operations which are in Apache Kafka 1.0.0

2018-05-31 Thread Ramesh Mani
/resources/kafka-policies.json d0e469a security-admin/src/main/java/org/apache/ranger/patch/PatchForKafkaServiceDefUpdate_J10015.java PRE-CREATION Diff: https://reviews.apache.org/r/67409/diff/1/ Testing --- Tested in Local VM Thanks, Ramesh Mani

Re: Jersey version for plugin ...

2018-06-30 Thread Ramesh Mani
Hi Bosco, Yes Knox uses RangerAdminJersey2RESTClient as there is difference in the jersey bundle it uses for client. Did you try replacing the jersey 1.9 in knox plugin impl folder with jersey 2.22.2? Regards, Ramesh On 6/30/18, 7:20 PM, "Don Bosco Durai" wrote: >Seems Knox is using

Re: Ranger 1.1 release

2018-06-22 Thread Ramesh Mani
+1 for Ranger 1.1 release. On 6/22/18, 9:25 AM, "Velmurugan Periasamy" wrote: >Rangers: > >Now that support for Atlas 1.0 is added >(https://issues.apache.org/jira/browse/RANGER-2136 >), I propose to >release Ranger 1.1 (tentative first week

Re: Review Request 67700: RANGER-2141 : Add PatchForKafkaServiceDefUpdate_J10015.java in consolidated DB schema

2018-06-22 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67700/#review205241 --- Ship it! Ship It! - Ramesh Mani On June 22, 2018, 11:04 a.m

Re: Review Request 66877: RANGER-2089: Update scala library version for tagsync to be the same as in Atlas

2018-04-30 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66877/#review202159 --- Ship it! Ship It! - Ramesh Mani On April 30, 2018, 10:47

  1   2   3   4   5   6   7   8   9   >