Review Request 57837: Remember filters on all tabs of Ranger Audits page

2017-03-22 Thread bhavik patel
--- 1. Tested multiple search is working correctly in "Audit" tab. 2. Tested search remains the same when we navigate from one tab to other. 3. Tested search is working correctly for different user role. Thanks, bhavik patel

Re: Review Request 57837: Remember filters on all tabs of Ranger Audits page

2017-04-03 Thread bhavik patel
different user role. Thanks, bhavik patel

Review Request 58229: RANGER-1481 : Capture cluster name in ranger audit info

2017-04-06 Thread bhavik patel
lugins tab. Thanks, bhavik patel

Review Request 58608: RANGER-1481 : Capture cluster name in ranger audit info

2017-04-21 Thread bhavik patel
lugins tab. Thanks, bhavik patel

Re: Review Request 58229: RANGER-1481 : Capture cluster name in ranger audit info

2017-04-21 Thread bhavik patel
based install and if plugin passes the Ambari cluster name. It starts showing in Access log as well as in plugins tab. Thanks, bhavik patel

Re: Review Request 58229: RANGER-1481 : Capture cluster name in ranger audit info

2017-04-21 Thread bhavik patel
based install and if plugin passes the Ambari cluster name. It starts showing in Access log as well as in plugins tab. Thanks, bhavik patel

Request to make me contributor in Apache Ranger

2017-03-08 Thread Bhavik Patel
Rangers: As I have been involved in the Apache Ranger project for a while now, Can you please add me as a contributor to the project ? Thanks, Bhavik Patel +91-7208744109

Re: Review Request 57837: Remember filters on all tabs of Ranger Audits page

2017-04-19 Thread bhavik patel
different user role. Thanks, bhavik patel

Review Request 61685: RANGER-1717 : User with "KEYADMIN" role is not able to see "Audit => Admin" logs

2017-08-16 Thread bhavik patel
vice.java def9699 Diff: https://reviews.apache.org/r/61685/diff/1/ Testing --- 1. Verified "Audit => Admin" logs when user is logged in with "KEYADMIN" role. Thanks, bhavik patel

Review Request 61591: RANGER-1717 : User with "KEYADMIN" role is not able to see "Audit => Admin" logs

2017-08-11 Thread bhavik patel
vice.java 7618981 Diff: https://reviews.apache.org/r/61591/diff/1/ Testing --- 1. Verified "Audit => Admin" logs when user is logged in with "KEYADMIN" role. Thanks, bhavik patel

Re: Review Request 60732: RANGER-1491 : Automatically map group of external users to Administrator Role

2017-08-10 Thread bhavik patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60732/#review182659 --- Ship it! Ship It! - bhavik patel On Aug. 8, 2017, 8:31 a.m

Re: Review Request 60732: RANGER-1491 : Automatically map group of external users to Administrator Role

2017-07-11 Thread bhavik patel
Testing --- 1. Verified when ranger-admin connect to LDAP server than users are synchronised form there they got same role which is specified in usersync-side. 2. Verified unix authentication and usersync. Thanks, bhavik patel

Re: Review Request 60421: RANGER-1491 : Automatically map group of external users to Administrator Role

2017-07-11 Thread bhavik patel
ally generated e-mail. To reply, visit: https://reviews.apache.org/r/60421/#review180010 ------- On July 11, 2017, 5:52 a.m., bhavik patel wrote: > > --- > This is an automatically generated e

Re: Review Request 60421: RANGER-1491 : Automatically map group of external users to Administrator Role

2017-07-10 Thread bhavik patel
Testing --- 1. Verified when ranger-admin connect to LDAP server than users are synchronised form there they got same role which is specified in usersync-side. 2. Verified unix authentication and usersync. Thanks, bhavik patel

Re: Review Request 60680: Unable to login to Hadoop environment after opened Kerberos.

2017-07-07 Thread bhavik patel
. After testing with the attached patch the test-connection for the plugins is failing, can you please revisit and check if this patch is required? - bhavik patel On July 6, 2017, 8:26 a.m., pengjianhua wrote: > > --- >

Re: Review Request 60421: RANGER-1491 : Automatically map group of external users to Administrator Role

2017-07-18 Thread bhavik patel
ache.org/r/60421/diff/3/ Changes: https://reviews.apache.org/r/60421/diff/2-3/ Testing --- 1. Verified when ranger-admin connect to LDAP server than users are synchronised form there they got same role which is specified in usersync-side. 2. Verified unix authentication and usersync. Thanks, bhavik patel

Review Request 61071: RANGER-1674 : IMPORT START audit is not appearing on audit page

2017-07-23 Thread bhavik patel
g on audit page. Diffs - security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java ac5b4ff Diff: https://reviews.apache.org/r/61071/diff/1/ Testing --- 1. Verified "IMPORT START" audit is appearing on Audit==>Admin tab. Thanks, bhavik patel

Re: Review Request 57837: Remember filters on all tabs of Ranger Audits page

2017-04-25 Thread bhavik patel
different user role. Thanks, bhavik patel

Review Request 58730: RANGER-1499 : Upgrade Tomcat version

2017-04-26 Thread bhavik patel
SSL enabled environment for Ranger KMS (from UI as well as from curl). Thanks, bhavik patel

Review Request 58733: RANGER-1471 : Remember filters on all tabs of Ranger Audits page

2017-04-26 Thread bhavik patel
--- Tested multiple search is working correctly in "Audit" tab. Tested search remains the same when we navigate from one tab to other. Tested search is working correctly for different user role. Thanks, bhavik patel

Review Request 58734: RANGER-1546 : Code Improvement To Follow Best Practices

2017-04-26 Thread bhavik patel
/ranger/biz/RangerBizUtil.java efc308a Diff: https://reviews.apache.org/r/58734/diff/1/ Testing --- 1.Verified Ranger Admin & Ranger KMS on kerberized & SSL enabled environment. Thanks, bhavik patel

Review Request 58781: RANGER-1546 : Code Improvement To Follow Best Practice

2017-04-27 Thread bhavik patel
/ranger/biz/RangerBizUtil.java 5521ae8 Diff: https://reviews.apache.org/r/58781/diff/1/ Testing --- 1.Verified Ranger Admin & Ranger KMS on kerberized & SSL enabled environment. Thanks, bhavik patel

Re: Review Request 58734: RANGER-1546 : Code Improvement To Follow Best Practices

2017-04-26 Thread bhavik patel
nger KMS on kerberized & SSL enabled environment. Thanks, bhavik patel

Re: Review Request 58229: RANGER-1481 : Capture cluster name in ranger audit info

2017-04-25 Thread bhavik patel
pgrade scenario from older version to latest version. As soon as we upgrade to latest version, If it is a Ambari based install and if plugin passes the Ambari cluster name. It starts showing in Access log as well as in plugins tab. Thanks, bhavik patel

Re: Review Request 58608: RANGER-1481 : Capture cluster name in ranger audit info

2017-04-25 Thread bhavik patel
pgrade scenario from older version to latest version. As soon as we upgrade to latest version, If it is a Ambari based install and if plugin passes the Ambari cluster name. It starts showing in Access log as well as in plugins tab. Thanks, bhavik patel

Re: Review Request 58229: RANGER-1481 : Capture cluster name in ranger audit info

2017-04-25 Thread bhavik patel
parate clusters setup by Ambari. 3.Verified upgrade scenario from older version to latest version. As soon as we upgrade to latest version, If it is a Ambari based install and if plugin passes the Ambari cluster name. It starts showing in Access log as well as in plugins tab. Thanks, bhavik patel

Re: Review Request 60732: RANGER-1491 : Automatically map group of external users to Administrator Role

2017-08-08 Thread bhavik patel
g/r/60732/diff/2-3/ Testing --- 1. Verified when ranger-admin connect to LDAP server than users are synchronised form there they got same role which is specified in usersync-side. 2. Verified unix authentication and usersync. Thanks, bhavik patel

Re: Review Request 60421: RANGER-1491 : Automatically map group of external users to Administrator Role

2017-08-07 Thread bhavik patel
g/r/60421/diff/3-4/ Testing --- 1. Verified when ranger-admin connect to LDAP server than users are synchronised form there they got same role which is specified in usersync-side. 2. Verified unix authentication and usersync. Thanks, bhavik patel

Review Request 61845: RANGER-1748 : User is unable to update existing policy while importing policy from file

2017-08-23 Thread bhavik patel
/ Testing --- 1. Verified policies are getting updated while importing from file. Thanks, bhavik patel

Review Request 61848: RANGER-1748 : User is unable to update existing policy while importing policy from file

2017-08-23 Thread bhavik patel
/ Testing --- 1. Verified policies are getting updated while importing from file. Thanks, bhavik patel

Re: Review Request 59172: RANGER-1571 : Code Improvement To Follow Best Practices

2017-05-11 Thread bhavik patel
tion for plugins on simple as well as on kerberized environment. Thanks, bhavik patel

Re: Review Request 59143: RANGER-1571 : Code Improvement To Follow Best Practices

2017-05-11 Thread bhavik patel
--- 1. Tested Ranger Admin & Ranger KMS rest calls. 2. Verified Test-Connection for plugins on kerberized environment. Thanks, bhavik patel

Review Request 59172: RANGER-1571 : Code Improvement To Follow Best Practices

2017-05-11 Thread bhavik patel
/resources/conf.dist/ranger-admin-default-site.xml 0feecfe Diff: https://reviews.apache.org/r/59172/diff/1/ Testing --- 1. Tested Ranger Admin & Ranger KMS rest calls. 2. Verified Test-Connection for plugins on simple as well as on kerberized environment. Thanks, bhavik patel

Re: Review Request 59143: RANGER-1571 : Code Improvement To Follow Best Practices

2017-05-11 Thread bhavik patel
nd refer to them in the admin > > module? I have updated the patch as per your comments. - bhavik --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59143/#review174471 --

Re: Review Request 59143: RANGER-1571 : Code Improvement To Follow Best Practices

2017-05-10 Thread bhavik patel
. Tested Ranger Admin & Ranger KMS rest calls. 2. Verified Test-Connection for plugins on kerberized environment. Thanks, bhavik patel

Re: Review Request 59335: RANGER-1583 : Test connections are failing for plugins after upgrade

2017-05-17 Thread bhavik patel
> On May 17, 2017, 11:12 a.m., Colm O hEigeartaigh wrote: > > Why is the iteration count now "17"? > > bhavik patel wrote: > For previous version this iteration count was 17 so to support backwards > compatibility we have kept this count as 17, once the up

Review Request 59335: RANGER-1583 : Test connections are failing for plugins after upgrade

2017-05-17 Thread bhavik patel
& resource-lookup. Thanks, bhavik patel

Re: Review Request 59335: RANGER-1583 : Test connections are failing for plugins after upgrade

2017-05-17 Thread bhavik patel
59335/#review175228 --- On May 17, 2017, 11:05 a.m., bhavik patel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > htt

Review Request 59398: RANGER-1583 : Test connections are failing for plugins after upgrade

2017-05-19 Thread bhavik patel
--- 1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins test-connections & resource-lookup. 2. Verified on simple as well as on kerberized environment. Thanks, bhavik patel

Review Request 58915: RANGER-1500 : Add support to exclude/disable SSL protocols

2017-05-02 Thread bhavik patel
/conf.dist/ranger-admin-default-site.xml fb6d844 security-admin/src/main/resources/conf.dist/ranger-admin-site.xml a4c36e0 Diff: https://reviews.apache.org/r/58915/diff/1/ Testing --- Thanks, bhavik patel

Re: Review Request 58915: RANGER-1500 : Add support to exclude/disable SSL protocols

2017-05-02 Thread bhavik patel
rent protocols. Thanks, bhavik patel

Re: Review Request 58915: RANGER-1500 : Add support to exclude/disable SSL protocols

2017-05-05 Thread bhavik patel
/ Changes: https://reviews.apache.org/r/58915/diff/3-4/ Testing --- 1. Verifeid Ranger Admin & Ranger KMS on SSL enabled environment with excluding different protocols. Thanks, bhavik patel

Re: Review Request 58915: RANGER-1500 : Add support to exclude/disable SSL protocols

2017-05-02 Thread bhavik patel
-site.xml a4c36e0 Diff: https://reviews.apache.org/r/58915/diff/1/ Testing (updated) --- 1. Verifeid Ranger Admin & Ranger KMS on SSL enabled environment with excluding different protocols. Thanks, bhavik patel

Re: Review Request 58915: RANGER-1500 : Add support to exclude/disable SSL protocols

2017-05-03 Thread bhavik patel
/ranger-admin-site.xml a4c36e0 Diff: https://reviews.apache.org/r/58915/diff/3/ Changes: https://reviews.apache.org/r/58915/diff/2-3/ Testing --- 1. Verifeid Ranger Admin & Ranger KMS on SSL enabled environment with excluding different protocols. Thanks, bhavik patel

Re: Review Request 59335: RANGER-1583 : Test connections are failing for plugins after upgrade

2017-05-19 Thread bhavik patel
://reviews.apache.org/r/59335/diff/2/ Changes: https://reviews.apache.org/r/59335/diff/1-2/ Testing --- 1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins test-connections & resource-lookup. Thanks, bhavik patel

Re: Review Request 62495: RANGER-1797:Tomcat Security Vulnerability Alert. The version of the tomcat for ranger should upgrade to 7.0.81.

2017-09-22 Thread bhavik patel
plugin communication needs to be verified. Can you please confirm: all these cases are tested before commiting this patch. This is based on earlier experience of updating tomcat version. - bhavik patel On Sept. 22, 2017, 8:35 a.m., pengjianhua

Review Request 62074: RANGER-1765 : Add unique key constraint in x_group and x_group_users table

2017-09-05 Thread bhavik patel
database flavour. Thanks, bhavik patel

Re: Review Request 62074: RANGER-1765 : Add unique key constraint in x_group and x_group_users table

2017-09-07 Thread bhavik patel
Admin, Usersync, Ranger KMS with all database flavour. Thanks, bhavik patel

Review Request 62181: RANGER-1765 : Add unique key constraint in x_group and x_group_users table

2017-09-07 Thread bhavik patel
database flavour. Thanks, bhavik patel

Review Request 62611: RANGER-1748 : User is unable to update existing policy while importing policy from file

2017-09-26 Thread bhavik patel
file for specific resource. Thanks, bhavik patel

Re: Review Request 62495: RANGER-1797:Tomcat Security Vulnerability Alert. The version of the tomcat for ranger should upgrade to 7.0.81.

2017-09-27 Thread bhavik patel
> On Sept. 22, 2017, 9:11 a.m., bhavik patel wrote: > > pom.xml > > Line 212 (original), 212 (patched) > > <https://reviews.apache.org/r/62495/diff/1/?file=1832777#file1832777line212> > > > > @pengjianhua : This change needs thorough testing of

Re: Review Request 61591: RANGER-1717 : User with "KEYADMIN" role is not able to see "Audit => Admin" logs

2017-08-21 Thread bhavik patel
AssetMgr.java 7d1573d security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 302076e Diff: https://reviews.apache.org/r/61591/diff/2/ Changes: https://reviews.apache.org/r/61591/diff/1-2/ Testing --- 1. Verified "Audit => Admin" logs when user is log

Re: Review Request 62023: RANGER-1735: Support representing nested group memberships in Ranger Admin

2017-09-01 Thread bhavik patel
o explicitly catch RuntimeException as well. - bhavik patel On Sept. 1, 2017, 1:56 a.m., Sailaja Polavarapu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 62495: RANGER-1797:Tomcat Security Vulnerability Alert. The version of the tomcat for ranger should upgrade to 7.0.81.

2017-10-09 Thread bhavik patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62495/#review187494 --- @pengjianhua : Any updates on this? - bhavik patel On Sept. 22

Re: Review Request 62751: RANGER-1824 - Upgrade Spring Framework to 3.2.18

2017-10-03 Thread bhavik patel
, SSL, KnoxSSO, KnoxProxy enabled environments is working as expected? - bhavik patel On Oct. 3, 2017, 2:09 p.m., Colm O hEigeartaigh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://review

Re: Review Request 62534: RANGER-1748 : User is unable to update existing policy while importing policy from file

2017-09-26 Thread bhavik patel
policies are getting updated while importing from file for specific resource. Thanks, bhavik patel

Re: Review Request 63209: RANGER-1644 changed crypto algorithm to a strong one

2017-10-22 Thread bhavik patel
in PasswordUtils.java - bhavik patel On Oct. 22, 2017, 3:46 p.m., Endre Zoltan Kovacs wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 63657: The ranger policies json file should be formatted when exported at ranger service manager.

2017-11-14 Thread bhavik patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63657/#review191030 --- Ship it! Ship It! - bhavik patel On Nov. 8, 2017, 6:31 a.m

Re: Review Request 63657: The ranger policies json file should be formatted when exported at ranger service manager.

2017-11-14 Thread bhavik patel
> On Nov. 8, 2017, 7:06 a.m., bhavik patel wrote: > > could you please mention what testing you had done? > > wang yuan wrote: > I do some functional testing ,such as: > > old :Gson gson = new Gson() > > {"metaDataInfo":{"Host

Re: Review Request 63919: RANGER-1895 - Simplify Storm dependencies

2017-11-23 Thread bhavik patel
hdfs logs are writing properly? - bhavik patel On Nov. 23, 2017, 12:02 p.m., Colm O hEigeartaigh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.ap

Re: Review Request 63919: RANGER-1895 - Simplify Storm dependencies

2017-11-27 Thread bhavik patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63919/#review191995 --- Ship it! Ship It! - bhavik patel On Nov. 27, 2017, 3:27 p.m

Re: Review Request 63949: RANGER-1898 - Simplify Knox plugin dependency management

2017-11-27 Thread bhavik patel
as expected? because you are also removing the ranger-plugins-audit dependency. - bhavik patel On Nov. 27, 2017, 3:52 p.m., Colm O hEigeartaigh wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 62495: RANGER-1797:Tomcat Security Vulnerability Alert. The version of the tomcat for ranger should upgrade to 7.0.82.

2017-12-05 Thread bhavik patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62495/#review192836 --- Ship it! Ship It! - bhavik patel On Dec. 5, 2017, 2:59 a.m

Review Request 63785: RANGER-1884 : Default Policy is not created for Ranger KMS and Tag service

2017-11-13 Thread bhavik patel
. Verified default policy is getting created for Ranger Kms & for Tag service. Thanks, bhavik patel

Re: Review Request 63657: The ranger policies json file should be formatted when exported at ranger service manager.

2017-11-08 Thread bhavik patel
> On Nov. 8, 2017, 7:06 a.m., bhavik patel wrote: > > could you please mention what testing you had done? > > wang yuan wrote: > I do some functional testing ,such as: > > old :Gson gson = new Gson() > > {"metaDataInfo":{"Host

Re: Review Request 62495: RANGER-1797:Tomcat Security Vulnerability Alert. The version of the tomcat for ranger should upgrade to 7.0.82.

2017-12-01 Thread bhavik patel
> On Nov. 30, 2017, 9:38 a.m., Vishal Suvagia wrote: > > pom.xml > > Line 212 (original), 212 (patched) > > > > > > @PengJianhua, > > I used attached patch and did a build on my local machine > >

Review Request 66951: RANGER-2095 : Add unit tests for new read only admin-auditor/kms-auditor roles functionality

2018-05-04 Thread bhavik patel
://reviews.apache.org/r/66951/diff/1/ Testing --- Tested with below two type 1.eclipse->Run as->Junit Test 2.mvn test Thanks, bhavik patel

Review Request 67544: RANGER-2132 : Add unit tests for org.apache.ranger.common package

2018-06-12 Thread bhavik patel
PRE-CREATION Diff: https://reviews.apache.org/r/67544/diff/1/ Testing --- Tested with below two type 1.eclipse->Run as->Junit Test 2.mvn test Thanks, bhavik patel

Re: Review Request 67544: RANGER-2132 : Add unit tests for org.apache.ranger.common package

2018-06-14 Thread bhavik patel
/java/org/apache/ranger/common/TestServiceUtil.java PRE-CREATION Diff: https://reviews.apache.org/r/67544/diff/3/ Changes: https://reviews.apache.org/r/67544/diff/2-3/ Testing --- Tested with below two type 1.eclipse->Run as->Junit Test 2.mvn test Thanks, bhavik patel

Re: Review Request 67544: RANGER-2132 : Add unit tests for org.apache.ranger.common package

2018-06-13 Thread bhavik patel
/java/org/apache/ranger/common/TestServiceUtil.java PRE-CREATION Diff: https://reviews.apache.org/r/67544/diff/2/ Changes: https://reviews.apache.org/r/67544/diff/1-2/ Testing --- Tested with below two type 1.eclipse->Run as->Junit Test 2.mvn test Thanks, bhavik patel

Re: Review Request 67544: RANGER-2132 : Add unit tests for org.apache.ranger.common package

2018-06-15 Thread bhavik patel
/java/org/apache/ranger/common/TestServiceUtil.java PRE-CREATION Diff: https://reviews.apache.org/r/67544/diff/4/ Changes: https://reviews.apache.org/r/67544/diff/3-4/ Testing --- Tested with below two type 1.eclipse->Run as->Junit Test 2.mvn test Thanks, bhavik patel

Re: Review Request 63209: RANGER-1644 changed crypto algorithm to a strong one

2017-10-26 Thread bhavik patel
> On Oct. 23, 2017, 4:56 a.m., bhavik patel wrote: > > @Endre Zoltan Kovacs : Have you tested plugins test-connection? If someone > > upgrade from ranger-0.6 to ranger-0.7 or master after then check plugins > > test-connection should not break, can you please confir

Re: Review Request 65567: RANGER-1972 : Ability to label policies, filter/search and show policies by labels

2018-02-11 Thread bhavik patel
is able to filter policies based on policy labels. Thanks, bhavik patel

Re: Review Request 65567: RANGER-1972 : Ability to label policies, filter/search and show policies by labels

2018-02-12 Thread bhavik patel
is able to filter policies based on policy labels. 3. On report page also admin is able to filter policies based on policy labels. Thanks, bhavik patel

Re: Review Request 65567: RANGER-1972 : Ability to label policies, filter/search and show policies by labels

2018-02-14 Thread bhavik patel
--- 1. While creating policy, multiple labels can be assigned also lookup is working. 2. On policy listing page admin is able to filter policies based on policy labels. 3. On report page also admin is able to filter policies based on policy labels. Thanks, bhavik patel

Re: Review Request 65567: RANGER-1972 : Ability to label policies, filter/search and show policies by labels

2018-02-14 Thread bhavik patel
or deleting service - bhavik --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65567/#review197082 --- On Feb. 14, 2018, 12:06 p.m., bhavik patel wrot

Review Request 65567: RANGER-1972 : Ability to label policies, filter/search and show policies by labels

2018-02-08 Thread bhavik patel
. While creating policy, multiple labels can be assigned also lookup is working. 2. On policy listing page admin is able to filter policies based on policy labels. 3. On report page also admin is able to filter policies based on policy labels. Thanks, bhavik patel

Review Request 64869: RANGER-1930 : Add consolidated db schema script for all supported DB flavor

2017-12-29 Thread bhavik patel
related to users/groups and policies/services. Thanks, bhavik patel

Review Request 67643: RANGER-2137 : Service Creation Failure, if user is not present in ranger database

2018-06-20 Thread bhavik patel
with supplied user in the service configuration. Thanks, bhavik patel

Review Request 67642: RANGER-2132 : Add unit tests for org.apache.ranger.common package

2018-06-19 Thread bhavik patel
--- Thanks, bhavik patel

Re: Review Request 67642: RANGER-2132 : Add unit tests for org.apache.ranger.common package

2018-06-19 Thread bhavik patel
always result into fixed set having same order of the elements. It should not be an issues. However we can also compare using set as well. - bhavik --- This is an automatically generated e-mail. To reply, visit: https:/

Re: Review Request 67642: RANGER-2132 : Add unit tests for org.apache.ranger.common package

2018-06-22 Thread bhavik patel
://reviews.apache.org/r/67642/diff/2/ Changes: https://reviews.apache.org/r/67642/diff/1-2/ Testing --- Thanks, bhavik patel

Review Request 67700: RANGER-2141 : Add PatchForKafkaServiceDefUpdate_J10015.java in consolidated DB schema

2018-06-22 Thread bhavik patel
was skipped during Ranger installation and patch were marked executed in x_db_version_h table (manual installation). Thanks, bhavik patel

Review Request 68186: RANGER-2181 : Code Improvement To Follow Best Practices

2018-08-03 Thread bhavik patel
Admin & Ranger KMS rest calls. Thanks, bhavik patel

Re: Review Request 68083: RANGER-2167 - Upgrade to Apache parent pom version 20

2018-07-31 Thread bhavik patel
kms? - bhavik patel On July 27, 2018, 3:28 p.m., Colm O hEigeartaigh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 68133: RANGER-2169: Create unique index on service and name column of x_policy table

2018-07-31 Thread bhavik patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68133/#review206723 --- Ship it! Ship It! - bhavik patel On July 31, 2018, 4:40 p.m

Re: Review Request 68293: RANGER-2114 : Internal Exception: com.mysql.jdbc.MysqlDataTruncation: Data truncation: Data too long for column 'content' at row 1

2018-08-10 Thread bhavik patel
database. - bhavik patel On Aug. 10, 2018, 1:22 p.m., Fatima Khan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 68191: RANGER-2182 : Handle upgrade scenario since atlas-service def is added with new resources for relationship

2018-08-08 Thread bhavik patel
.x to 2.0 new default policy got created successfully with newly added resources and access types. Thanks, bhavik patel

Re: Review Request 68186: RANGER-2181 : Code Improvement To Follow Best Practices

2018-08-06 Thread bhavik patel
, visit: https://reviews.apache.org/r/68186/#review206850 ------- On Aug. 3, 2018, 2:40 p.m., bhavik patel wrote: > > --- > This is an automatically gener

Re: Review Request 68186: RANGER-2181 : Code Improvement To Follow Best Practices

2018-08-06 Thread bhavik patel
/templates/helpers/XAHelpers.js 8ace4d7 Diff: https://reviews.apache.org/r/68186/diff/2/ Changes: https://reviews.apache.org/r/68186/diff/1-2/ Testing --- 1. Tested Ranger Admin & Ranger KMS rest calls. Thanks, bhavik patel

Re: Review Request 68186: RANGER-2181 : Code Improvement To Follow Best Practices

2018-08-07 Thread bhavik patel
/templates/helpers/XAHelpers.js 8ace4d7 Diff: https://reviews.apache.org/r/68186/diff/3/ Changes: https://reviews.apache.org/r/68186/diff/2-3/ Testing --- 1. Tested Ranger Admin & Ranger KMS rest calls. Thanks, bhavik patel

Re: Review Request 68186: RANGER-2181 : Code Improvement To Follow Best Practices

2018-08-07 Thread bhavik patel
el/validation/TestRangerServiceValidator.java > 64ccb7d > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > c116ea2 > security-admin/src/main/webapp/scripts/models/RangerServiceDef.js 9945044 > security-admin/src/main/webapp/styles/xa.css db96ed2 > security-admin/src/main/webapp/templates/helpers/XAHelpers.js 8ace4d7 > > > Diff: https://reviews.apache.org/r/68186/diff/3/ > > > Testing > --- > > 1. Tested Ranger Admin & Ranger KMS rest calls. > > > Thanks, > > bhavik patel > >

Re: Review Request 68293: RANGER-2114 : Internal Exception: com.mysql.jdbc.MysqlDataTruncation: Data truncation: Data too long for column 'content' at row 1

2018-08-13 Thread bhavik patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68293/#review207149 --- Ship it! Ship It! - bhavik patel On Aug. 10, 2018, 1:22 p.m

Re: Review Request 68191: RANGER-2182 : Handle upgrade scenario since atlas-service def is added with new resources for relationship

2018-08-08 Thread bhavik patel
/2/ Changes: https://reviews.apache.org/r/68191/diff/1-2/ Testing --- 1. After upgrade from 1.x to 2.0 new default policy got created successfully with newly added resources and access types. Thanks, bhavik patel

Review Request 68292: RANGER-2187 : External Group search fails on Ranger UI when installed with postgres

2018-08-10 Thread bhavik patel
/ranger/service/TestXGroupService.java 85490dd Diff: https://reviews.apache.org/r/68292/diff/1/ Testing --- 1.) Verified Group search filter for Group Source, syncing with UNIX, LDAP and AD. 2.) Verifeid for oracle, mysql, ms sql, sql anywhere and posgresSQL. Thanks, bhavik patel

Review Request 68629: RANGER-2208 Code improvement to fetch User/Group information and Service Config details

2018-09-05 Thread bhavik patel
& Ranger KMS rest calls. Thanks, bhavik patel

Re: [VOTE] Apache Ranger Release 1.1.0-rc2

2018-07-08 Thread Bhavik Patel
+1 for Apache Ranger 1.1.0 rc2. Regard, Bhavik Patel On Sun, Jul 8, 2018 at 1:55 PM, Madhan Neethiraj wrote: > +1 for Apache Ranger 1.1.0 rc2. > > Thanks, > Madhan > > > > ´╗┐On 7/5/18, 12:56 PM, "Velmurugan Periasamy" wrote: > > Hello Rangers:

Review Request 66473: RANGER-2059 : Write unit tests for export/import functionality

2018-04-05 Thread bhavik patel
with below two type 1.eclipse->Run as->Junit Test 2.mvn test Thanks, bhavik patel

Review Request 66598: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs

2018-04-12 Thread bhavik patel
/hadoop/crypto/key/RangerMasterKey.java 6cfd37e src/main/assembly/kms.xml 68512ef Diff: https://reviews.apache.org/r/66598/diff/1/ Testing --- 1. Verified Ranger Kms is working as expected. Thanks, bhavik patel

Re: Review Request 66598: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs

2018-04-12 Thread bhavik patel
- bhavik --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66598/#review201086 --- On April 13, 2018, 5:14 a.m., bhavik pa

  1   2   3   >