[jira] [Commented] (RANGER-2716) Add catalogs/schemas/tables filter in presto plugin
[ https://issues.apache.org/jira/browse/RANGER-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090542#comment-17090542 ] Jiayi Liu commented on RANGER-2716: --- I have not read all of your patch yet. I thought there was something missing before. I do not know if you have implemented it. If there are still missing, I will propose a new jira > Add catalogs/schemas/tables filter in presto plugin > --- > > Key: RANGER-2716 > URL: https://issues.apache.org/jira/browse/RANGER-2716 > Project: Ranger > Issue Type: Improvement > Components: plugins >Reporter: Jiayi Liu >Priority: Major > Attachments: 0001-RANGER-2716.patch, 0002-RANGER-2716.patch > > > Presto plugin returns the input set of catalogs/schemas/tables directly at > present. However, this causes a problem, that is, when the user uses show > catalogs/schemas/tables, all catalogs/schemas/tables are displayed, even > though the user does not have the permissions to display all > catalogs/schemas/tables. > We need to fix the filterCatalogs/Schemas/Tables functions to filter > catalogs/schemas/tables, so that the user can only see the > catalogs/schemas/tables in which the user has SELECT permission. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RANGER-2716) Add catalogs/schemas/tables filter in presto plugin
[ https://issues.apache.org/jira/browse/RANGER-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090539#comment-17090539 ] Bolke de Bruin commented on RANGER-2716: Awesome. I do wonder what those missing features are as I tried to be pretty comprehensive > Add catalogs/schemas/tables filter in presto plugin > --- > > Key: RANGER-2716 > URL: https://issues.apache.org/jira/browse/RANGER-2716 > Project: Ranger > Issue Type: Improvement > Components: plugins >Reporter: Jiayi Liu >Priority: Major > Attachments: 0001-RANGER-2716.patch, 0002-RANGER-2716.patch > > > Presto plugin returns the input set of catalogs/schemas/tables directly at > present. However, this causes a problem, that is, when the user uses show > catalogs/schemas/tables, all catalogs/schemas/tables are displayed, even > though the user does not have the permissions to display all > catalogs/schemas/tables. > We need to fix the filterCatalogs/Schemas/Tables functions to filter > catalogs/schemas/tables, so that the user can only see the > catalogs/schemas/tables in which the user has SELECT permission. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RANGER-2716) Add catalogs/schemas/tables filter in presto plugin
[ https://issues.apache.org/jira/browse/RANGER-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090537#comment-17090537 ] Jiayi Liu commented on RANGER-2716: --- [~bolke] You're right. There are still some missing features, I can add more on the basis of presto 331. > Add catalogs/schemas/tables filter in presto plugin > --- > > Key: RANGER-2716 > URL: https://issues.apache.org/jira/browse/RANGER-2716 > Project: Ranger > Issue Type: Improvement > Components: plugins >Reporter: Jiayi Liu >Priority: Major > Attachments: 0001-RANGER-2716.patch, 0002-RANGER-2716.patch > > > Presto plugin returns the input set of catalogs/schemas/tables directly at > present. However, this causes a problem, that is, when the user uses show > catalogs/schemas/tables, all catalogs/schemas/tables are displayed, even > though the user does not have the permissions to display all > catalogs/schemas/tables. > We need to fix the filterCatalogs/Schemas/Tables functions to filter > catalogs/schemas/tables, so that the user can only see the > catalogs/schemas/tables in which the user has SELECT permission. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RANGER-2716) Add catalogs/schemas/tables filter in presto plugin
[ https://issues.apache.org/jira/browse/RANGER-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090473#comment-17090473 ] Bolke de Bruin commented on RANGER-2716: I suggest closing this as RANGER-2754 is now merged and addresses this. > Add catalogs/schemas/tables filter in presto plugin > --- > > Key: RANGER-2716 > URL: https://issues.apache.org/jira/browse/RANGER-2716 > Project: Ranger > Issue Type: Improvement > Components: plugins >Reporter: Jiayi Liu >Priority: Major > Attachments: 0001-RANGER-2716.patch, 0002-RANGER-2716.patch > > > Presto plugin returns the input set of catalogs/schemas/tables directly at > present. However, this causes a problem, that is, when the user uses show > catalogs/schemas/tables, all catalogs/schemas/tables are displayed, even > though the user does not have the permissions to display all > catalogs/schemas/tables. > We need to fix the filterCatalogs/Schemas/Tables functions to filter > catalogs/schemas/tables, so that the user can only see the > catalogs/schemas/tables in which the user has SELECT permission. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RANGER-2716) Add catalogs/schemas/tables filter in presto plugin
[ https://issues.apache.org/jira/browse/RANGER-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090200#comment-17090200 ] Jiayi Liu commented on RANGER-2716: --- [~mad...@apache.org] I have fixed the issue in review board. Please review it again. > Add catalogs/schemas/tables filter in presto plugin > --- > > Key: RANGER-2716 > URL: https://issues.apache.org/jira/browse/RANGER-2716 > Project: Ranger > Issue Type: Improvement > Components: plugins >Reporter: Jiayi Liu >Priority: Major > Attachments: 0001-RANGER-2716.patch, 0002-RANGER-2716.patch > > > Presto plugin returns the input set of catalogs/schemas/tables directly at > present. However, this causes a problem, that is, when the user uses show > catalogs/schemas/tables, all catalogs/schemas/tables are displayed, even > though the user does not have the permissions to display all > catalogs/schemas/tables. > We need to fix the filterCatalogs/Schemas/Tables functions to filter > catalogs/schemas/tables, so that the user can only see the > catalogs/schemas/tables in which the user has SELECT permission. -- This message was sent by Atlassian Jira (v8.3.4#803005)