[jira] [Updated] (RANGER-1725) It is incorrect to judge whether you need to create a RangerServiceDef object for a given service

2017-08-08 Thread peng.jianhua (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

peng.jianhua updated RANGER-1725:
-
Attachment: 0001-RANGER-1725-It-is-incorrect-to-judge-whether-you-nee.patch

> It is incorrect to judge whether you need to create a RangerServiceDef object 
> for a given service
> -
>
> Key: RANGER-1725
> URL: https://issues.apache.org/jira/browse/RANGER-1725
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>  Labels: patch
> Attachments: 
> 0001-RANGER-1725-It-is-incorrect-to-judge-whether-you-nee.patch
>
>
> It is incorrect to judge whether you need to create a RangerServiceDef object 
> for a given service.
> The current judgment condition is in the 
> org.apache.ranger.plugin.store.EmbeddedServiceDefsUtil#getOrCreateServiceDef, 
> as follows
> {code:java}
> boolean createServiceDef = (CollectionUtils.isEmpty(supportedServiceDefs) || 
> supportedServiceDefs.contains(serviceDefName));
> {code}
> It means When the supportedServiceDefs is empty, the RangerServiceDef object 
> for the specified service will be created, but I think this judge is 
> incorrect.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (RANGER-1725) It is incorrect to judge whether you need to create a RangerServiceDef object for a given service

2017-08-08 Thread peng.jianhua (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

peng.jianhua updated RANGER-1725:
-
Attachment: (was: 
0001-RANGER-1725-It-is-incorrect-to-judge-whether-you-nee.patch)

> It is incorrect to judge whether you need to create a RangerServiceDef object 
> for a given service
> -
>
> Key: RANGER-1725
> URL: https://issues.apache.org/jira/browse/RANGER-1725
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>  Labels: patch
>
> It is incorrect to judge whether you need to create a RangerServiceDef object 
> for a given service.
> The current judgment condition is in the 
> org.apache.ranger.plugin.store.EmbeddedServiceDefsUtil#getOrCreateServiceDef, 
> as follows
> {code:java}
> boolean createServiceDef = (CollectionUtils.isEmpty(supportedServiceDefs) || 
> supportedServiceDefs.contains(serviceDefName));
> {code}
> It means When the supportedServiceDefs is empty, the RangerServiceDef object 
> for the specified service will be created, but I think this judge is 
> incorrect.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (RANGER-1725) It is incorrect to judge whether you need to create a RangerServiceDef object for a given service

2017-08-07 Thread peng.jianhua (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

peng.jianhua updated RANGER-1725:
-
Description: 
It is incorrect to judge whether you need to create a RangerServiceDef object 
for a given service.
The current judgment condition is in the 
org.apache.ranger.plugin.store.EmbeddedServiceDefsUtil#getOrCreateServiceDef, 
as follows
{code:java}
boolean createServiceDef = (CollectionUtils.isEmpty(supportedServiceDefs) || 
supportedServiceDefs.contains(serviceDefName));
{code}
It means When the supportedServiceDefs is empty, the RangerServiceDef object 
for the specified service will be created, but I think this judge is incorrect.

  was:
It is incorrect to judge whether you need to create a RangerServiceDef object 
for a given service.
The current judgment condition is as follows
{code:java}
boolean createServiceDef = (CollectionUtils.isEmpty(supportedServiceDefs) || 
supportedServiceDefs.contains(serviceDefName));
{code}
It means When the supportedServiceDefs is empty, the RangerServiceDef object 
for the specified service will be created, but I think this judge is incorrect.


> It is incorrect to judge whether you need to create a RangerServiceDef object 
> for a given service
> -
>
> Key: RANGER-1725
> URL: https://issues.apache.org/jira/browse/RANGER-1725
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>  Labels: patch
> Attachments: 
> 0001-RANGER-1725-It-is-incorrect-to-judge-whether-you-nee.patch
>
>
> It is incorrect to judge whether you need to create a RangerServiceDef object 
> for a given service.
> The current judgment condition is in the 
> org.apache.ranger.plugin.store.EmbeddedServiceDefsUtil#getOrCreateServiceDef, 
> as follows
> {code:java}
> boolean createServiceDef = (CollectionUtils.isEmpty(supportedServiceDefs) || 
> supportedServiceDefs.contains(serviceDefName));
> {code}
> It means When the supportedServiceDefs is empty, the RangerServiceDef object 
> for the specified service will be created, but I think this judge is 
> incorrect.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (RANGER-1725) It is incorrect to judge whether you need to create a RangerServiceDef object for a given service

2017-08-07 Thread peng.jianhua (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

peng.jianhua updated RANGER-1725:
-
Attachment: 0001-RANGER-1725-It-is-incorrect-to-judge-whether-you-nee.patch

> It is incorrect to judge whether you need to create a RangerServiceDef object 
> for a given service
> -
>
> Key: RANGER-1725
> URL: https://issues.apache.org/jira/browse/RANGER-1725
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>  Labels: patch
> Attachments: 
> 0001-RANGER-1725-It-is-incorrect-to-judge-whether-you-nee.patch
>
>
> It is incorrect to judge whether you need to create a RangerServiceDef object 
> for a given service.
> The current judgment condition is as follows
> {code:java}
> boolean createServiceDef = (CollectionUtils.isEmpty(supportedServiceDefs) || 
> supportedServiceDefs.contains(serviceDefName));
> {code}
> It means When the supportedServiceDefs is empty, the RangerServiceDef object 
> for the specified service will be created, but I think this judge is 
> incorrect.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (RANGER-1725) It is incorrect to judge whether you need to create a RangerServiceDef object for a given service

2017-08-07 Thread peng.jianhua (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

peng.jianhua updated RANGER-1725:
-
Description: 
It is incorrect to judge whether you need to create a RangerServiceDef object 
for a given service.
The current judgment condition is as follows
{code:java}
boolean createServiceDef = (CollectionUtils.isEmpty(supportedServiceDefs) || 
supportedServiceDefs.contains(serviceDefName));
{code}
It means When the supportedServiceDefs is empty, the RangerServiceDef object 
for the specified service will be created, but I think this judge is incorrect.

  was:
It is incorrect to judge whether you need to create a RangerServiceDef object 
for a given service.
The current judgment condition is as follows
{code:java}
boolean createServiceDef = (CollectionUtils.isEmpty(supportedServiceDefs) || 
supportedServiceDefs.contains(serviceDefName));
{code}
It means When the supportedServiceDefs are empty, the RangerServiceDef object 
for the specified service will be created, but I think this judge is not 
correct.


> It is incorrect to judge whether you need to create a RangerServiceDef object 
> for a given service
> -
>
> Key: RANGER-1725
> URL: https://issues.apache.org/jira/browse/RANGER-1725
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>  Labels: patch
>
> It is incorrect to judge whether you need to create a RangerServiceDef object 
> for a given service.
> The current judgment condition is as follows
> {code:java}
> boolean createServiceDef = (CollectionUtils.isEmpty(supportedServiceDefs) || 
> supportedServiceDefs.contains(serviceDefName));
> {code}
> It means When the supportedServiceDefs is empty, the RangerServiceDef object 
> for the specified service will be created, but I think this judge is 
> incorrect.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)