Re: [PR] RANGER-5005: Use sortpom maven plugin to improve readability of pom files [ranger]
mneethiraj commented on PR #418: URL: https://github.com/apache/ranger/pull/418#issuecomment-2510625212 Merged in ranger-2.6 branch: ``` commit d8d9e207700e89e46eadf14921585c301165e792 Author: Madhan Neethiraj Date: Tue Nov 26 19:16:32 2024 -0800 RANGER-5005: Use sortpom maven plugin to improve readability of pom files (cherry picked from commit a553fa060dbd94634814c3007e6b8d5b30fd) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] RANGER-5005: Use sortpom maven plugin to improve readability of pom files [ranger]
mneethiraj commented on PR #413: URL: https://github.com/apache/ranger/pull/413#issuecomment-2510626425 Merged in master branch: ``` commit a553fa060dbd94634814c3007e6b8d5b30fd Author: Madhan Neethiraj Date: Sun Nov 24 06:59:14 2024 -0800 RANGER-5005: Use sortpom maven plugin to improve readability of pom files ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] RANGER-5005: Use sortpom maven plugin to improve readability of pom files [ranger]
mneethiraj closed pull request #413: RANGER-5005: Use sortpom maven plugin to improve readability of pom files URL: https://github.com/apache/ranger/pull/413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] RANGER-5005: Use sortpom maven plugin to improve readability of pom files [ranger]
mneethiraj closed pull request #418: RANGER-5005: Use sortpom maven plugin to improve readability of pom files URL: https://github.com/apache/ranger/pull/418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] RANGER-5005: Use sortpom maven plugin to improve readability of pom files [ranger]
kumaab commented on code in PR #418: URL: https://github.com/apache/ranger/pull/418#discussion_r1861150557 ## plugin-kylin/pom.xml: ## @@ -15,55 +15,35 @@ See the License for the specific language governing permissions and limitations under the License. --> -http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; -xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> 4.0.0 -ranger-kylin-plugin -Kylin Security Plugin -Kylin Security Plugin -jar - -UTF-8 - org.apache.ranger ranger 2.6.0-SNAPSHOT .. +ranger-kylin-plugin +jar +Kylin Security Plugin +Kylin Security Plugin + +UTF-8 + org.apache.calcite calcite-linq4j 1.16.0 Review Comment: minor: can be kept in a variable, may be subsequent patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] RANGER-5005: Use sortpom maven plugin to improve readability of pom files [ranger]
kumaab commented on code in PR #418:
URL: https://github.com/apache/ranger/pull/418#discussion_r1861156990
##
security-admin/pom.xml:
##
@@ -46,60 +41,171 @@
${asm.all.version}
-com.zaxxer
-HikariCP
-${HikariCP.version}
+ch.qos.logback
+logback-classic
+${logback.version}
+
+
+com.amazonaws
+aws-java-sdk-logs
+${aws-java-sdk.version}
+
+
+com.fasterxml.jackson.core
+jackson-annotations
+${fasterxml.jackson.version}
+
+
+com.fasterxml.jackson.core
+jackson-core
+${fasterxml.jackson.version}
+
+
+com.fasterxml.jackson.core
+jackson-databind
+${fasterxml.jackson.databind.version}
+
+
+com.fasterxml.jackson.jaxrs
+jackson-jaxrs-base
+${fasterxml.jackson.version}
+
+
+com.fasterxml.jackson.jaxrs
+jackson-jaxrs-json-provider
+${fasterxml.jackson.version}
-org.slf4j
-*
+jakarta.activation
+jakarta.activation-api
-org.glassfish.hk2.external
-cglib
-${cglib.version}
+com.google.inject
+guice
+3.0
Review Comment:
minor: can be kept in a variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] RANGER-5005: Use sortpom maven plugin to improve readability of pom files [ranger]
kumaab commented on code in PR #418:
URL: https://github.com/apache/ranger/pull/418#discussion_r1861176506
##
security-admin/pom.xml:
##
@@ -924,17 +921,17 @@
${basedir}/../docs/target/
+
+javax.jws
+javax.jws-api
+1.1
Review Comment:
minor: can be kept in a variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] RANGER-5005: Use sortpom maven plugin to improve readability of pom files [ranger]
kumaab commented on code in PR #418: URL: https://github.com/apache/ranger/pull/418#discussion_r1861176220 ## security-admin/pom.xml: ## @@ -888,10 +885,10 @@ 1.5.3 Review Comment: minor: can be kept in a variable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] RANGER-5005: Use sortpom maven plugin to improve readability of pom files [ranger]
kumaab commented on code in PR #418:
URL: https://github.com/apache/ranger/pull/418#discussion_r1861174106
##
ranger-common-ha/pom.xml:
##
@@ -15,120 +15,119 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
-http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
4.0.0
-ranger-common-ha
-Ranger HA Common Library
-Ranger HA Common Library
-jar
-ranger
org.apache.ranger
+ranger
2.6.0-SNAPSHOT
..
+ranger-common-ha
+jar
+Ranger HA Common Library
+Ranger HA Common Library
-
+
+commons-lang
+commons-lang
+${commons.lang.version}
+
+
+javax.inject
+javax.inject
+1
Review Comment:
minor: can be kept in a variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] RANGER-5005: Use sortpom maven plugin to improve readability of pom files [ranger]
kumaab commented on code in PR #418:
URL: https://github.com/apache/ranger/pull/418#discussion_r1861172955
##
plugin-nestedstructure/pom.xml:
##
@@ -15,93 +15,94 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
-http://maven.apache.org/POM/4.0.0";
- xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+4.0.0
-ranger
org.apache.ranger
+ranger
2.6.0-SNAPSHOT
-..
-4.0.0
+
ranger-nestedstructure-plugin
+jar
NestedStructure Security Plugin
NestedStructure Security Plugin
-jar
+1.11
+1.1.1
+2.9.0
8
8
-3.0.0-M6
+15.4
-
-
-org.apache.ranger
-ranger-plugins-common
-${project.version}
-
-
-commons-codec
-commons-codec
-1.11
-
-
-commons-lang
-commons-lang
-2.6
-
-
-commons-logging
-commons-logging
-1.1.1
-
-
-com.google.code.gson
-gson
-${gson.version}
-compile
-
-
-com.jayway.jsonpath
-json-path
-2.9.0
-
-
-org.openjdk.nashorn
-nashorn-core
-15.4
-
-
-org.testng
-testng
-${testng.version}
-test
-
-
+
+
+com.google.code.gson
+gson
+${gson.version}
+compile
+
+
+com.jayway.jsonpath
+json-path
+${json.path.version}
+
+
+commons-codec
+commons-codec
+${commons.codec.version}
+
+
+commons-lang
+commons-lang
+${commons.lang.version}
+
+
+commons-logging
+commons-logging
+${commons.logging.version}
+
+
+org.apache.ranger
+ranger-plugins-common
+${project.version}
+
+
+org.openjdk.nashorn
+nashorn-core
+${nashhorn.core.version}
+
+
+org.testng
+testng
+${testng.version}
+test
+
+
-
-
-
-org.apache.maven.plugins
-maven-surefire-plugin
-${maven.surefire.plugin.version}
-
-
-org.apache.maven.plugins
-maven-compiler-plugin
-3.3
-true
-
-
false
-${javac.source.version}
-${javac.target.version}
-UTF-8
-1024m
-true
-
-
-
-
+
+
+
+org.apache.maven.plugins
+maven-surefire-plugin
+${maven.surefire.plugin.version}
+
+
+org.apache.maven.plugins
+maven-compiler-plugin
+3.3
Review Comment:
minor: can be kept in a variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] RANGER-5005: Use sortpom maven plugin to improve readability of pom files [ranger]
kumaab commented on code in PR #418:
URL: https://github.com/apache/ranger/pull/418#discussion_r1861169658
##
hive-agent/pom.xml:
##
@@ -200,32 +202,36 @@
javax.el
${javax.el.version}
-
-
-org.junit.jupiter
-junit-jupiter-api
-${junit.jupiter.version}
+org.apache.hadoop
+hadoop-mapreduce-client-core
+${hadoop.version}
test
+
+
+io.netty
+netty
+
+
+log4j
+*
+
+
+org.apache.avro
+avro
+
+
org.apache.tez
tez-dag
0.9.1
Review Comment:
minor: can be kept in a variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] RANGER-5005: Use sortpom maven plugin to improve readability of pom files [ranger]
kumaab commented on code in PR #418:
URL: https://github.com/apache/ranger/pull/418#discussion_r1861169140
##
embeddedwebserver/pom.xml:
##
@@ -99,24 +84,39 @@
${project.version}
-org.apache.ranger
-credentialbuilder
-${project.version}
+org.apache.tomcat
+tomcat-annotations-api
+${tomcat.embed.version}
-org.apache.commons
-commons-lang3
-${commons.lang3.version}
+org.apache.tomcat.embed
+tomcat-embed-core
+${tomcat.embed.version}
-org.apache.commons
-commons-compress
-${commons.compress.version}
+org.apache.tomcat.embed
+tomcat-embed-el
+${tomcat.embed.version}
-org.apache.logging.log4j
-log4j-api
-${log4j2.version}
+org.apache.tomcat.embed
+tomcat-embed-jasper
+${tomcat.embed.version}
+
+
+org.apache.tomcat.embed
+tomcat-embed-websocket
+${tomcat.embed.version}
+
+
+org.eclipse.jdt.core.compiler
+ecj
+P20140317-1600
Review Comment:
minor: can be kept in a variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] RANGER-5005: Use sortpom maven plugin to improve readability of pom files [ranger]
kumaab commented on code in PR #418:
URL: https://github.com/apache/ranger/pull/418#discussion_r1861166908
##
knox-agent/pom.xml:
##
@@ -57,101 +107,66 @@
net.minidev
json-smart
+
+org.apache.knox
+gateway-util-common
+
org.apache.zookeeper
zookeeper
+
+org.eclipse.jetty
+jetty-util
+
+
+org.slf4j
+*
+
-
-javax.servlet
-javax.servlet-api
-${javax.servlet.version}
-
-
-org.glassfish.jersey.core
-jersey-client
-
-
-com.google.code.gson
-gson
-
-
-com.fasterxml.jackson.core
-jackson-core
-${fasterxml.jackson.version}
-
-
-com.fasterxml.jackson.core
-jackson-annotations
-${fasterxml.jackson.version}
-
org.apache.ranger
-ranger-plugins-common
+ranger-plugins-audit
${project.version}
org.apache.ranger
-ranger-plugins-audit
+ranger-plugins-common
${project.version}
+
-commons-collections
-commons-collections
-${commons.collections.version}
+org.eclipse.jetty
+jetty-util
+${knox.jetty.version}
-com.google.protobuf
-protobuf-java
-${protobuf-java.version}
+org.glassfish.jersey.core
+jersey-client
-org.apache.hadoop
-hadoop-hdfs
-${hadoop.version}
-
-
-log4j
-*
-
-
-org.slf4j
-*
-
-
-io.netty
-netty-all
-
-
-io.netty
-netty
-
-
+ch.qos.reload4j
+reload4j
+${reload4j.version}
+test
-
- org.apache.httpcomponents
- httpcore
- ${httpcomponents.httpcore.version}
-
-
-
-org.junit.jupiter
-junit-jupiter-api
-${junit.jupiter.version}
+com.mycila.xmltool
+xmltool
+3.3
Review Comment:
minor: can be kept in a variable.
##
knox-agent/pom.xml:
##
@@ -57,101 +107,66 @@
net.minidev
json-smart
+
+org.apache.knox
+gateway-util-common
+
org.apache.zookeeper
zookeeper
+
+org.eclipse.jetty
+jetty-util
+
+
+org.slf4j
+*
+
-
-javax.servlet
-javax.servlet-api
-${javax.servlet.version}
-
-
-org.glassfish.jersey.core
-jersey-client
-
-
-com.google.code.gson
-gson
-
-
-com.fasterxml.jackson.core
-jackson-core
-${fasterxml.jackson.version}
-
-
-com.fasterxml.jackson.core
-jackson-annotations
-${fasterxml.jackson.version}
-
org.apache.ranger
-ranger-plugins-common
+ranger-plugins-audit
${project.version}
org.apache.ranger
-ranger-plugins-audit
+ranger-plugins-common
${project.version}
+
-commons-collections
-commons-collections
-${commons.collections.version}
+org.eclipse.jetty
+jetty-util
+${knox.jetty.version}
-com.google.protobuf
-protobuf-java
-${protobuf-java.version}
+org.glassfish.jersey.core
+jersey-client
-org.apache.hadoop
-hadoop-hdfs
-${hadoop.version}
-
-
-
Re: [PR] RANGER-5005: Use sortpom maven plugin to improve readability of pom files [ranger]
kumaab commented on code in PR #418:
URL: https://github.com/apache/ranger/pull/418#discussion_r1861164846
##
knox-agent/pom.xml:
##
@@ -17,38 +17,88 @@
-->
http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
4.0.0
-ranger-knox-plugin
-Knox Security Plugin
-Knox Security Plugins
-jar
-
-UTF-8
-9.4.51.v20230217
-
org.apache.ranger
ranger
2.6.0-SNAPSHOT
..
+ranger-knox-plugin
+jar
+Knox Security Plugin
+Knox Security Plugins
+
+9.4.51.v20230217
+UTF-8
+
-org.apache.knox
-gateway-spi
-${knox.gateway.version}
+com.fasterxml.jackson.core
+jackson-annotations
+${fasterxml.jackson.version}
+
+
+com.fasterxml.jackson.core
+jackson-core
+${fasterxml.jackson.version}
+
+
+com.google.code.gson
+gson
+
+
+com.google.protobuf
+protobuf-java
+${protobuf-java.version}
+
+
+commons-collections
+commons-collections
+${commons.collections.version}
+
+
+jakarta.ws.rs
+jakarta.ws.rs-api
+2.1.6
Review Comment:
Jakarta apis will replace javax apis going forward, we can keep this in root
pom.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] RANGER-5005: Use sortpom maven plugin to improve readability of pom files [ranger]
kumaab commented on code in PR #418:
URL: https://github.com/apache/ranger/pull/418#discussion_r1861159625
##
kms/pom.xml:
##
@@ -299,191 +277,176 @@
-com.google.code.findbugs
-jsr305
-${jsr305.version}
+net.minidev
+asm
+${net.minidev.asm.version}
+
-io.netty
-netty-all
-${netty-all.version}
+net.minidev
+json-smart
+${jsonsmart.version}
-org.apache.ranger
-credentialbuilder
-${project.version}
-
-
-com.nimbusds
-nimbus-jose-jwt
-
-
-net.minidev
-json-smart
-
-
+org.apache.commons
+commons-configuration2
+${commons.configuration.version}
-org.apache.httpcomponents
-httpmime
-${httpcomponents.httpmime.version}
+org.apache.commons
+commons-lang3
+${commons.lang3.version}
+
+
+org.apache.commons
+commons-text
+${commons.text.version}
+
+
+org.apache.directory.api
+api-i18n
+1.0.3
Review Comment:
minor: can be kept in a variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] RANGER-5005: Use sortpom maven plugin to improve readability of pom files [ranger]
kumaab commented on code in PR #418:
URL: https://github.com/apache/ranger/pull/418#discussion_r1861159209
##
kms/pom.xml:
##
@@ -282,11 +225,46 @@
-
- com.sun.xml.bind
- jaxb-impl
- ${jaxb-impl.version}
-
+
+com.sun.jersey
+jersey-server
+${jersey-server.version}
+compile
+
+
+com.sun.xml.bind
+jaxb-impl
+${jaxb-impl.version}
+
+
+com.sun.xml.security
+xml-security-impl
+1.0
Review Comment:
minor: can be kept in a variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] RANGER-5005: Use sortpom maven plugin to improve readability of pom files [ranger]
mneethiraj commented on code in PR #413:
URL: https://github.com/apache/ranger/pull/413#discussion_r1858579239
##
plugin-nestedstructure/pom.xml:
##
@@ -15,92 +15,90 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
-http://maven.apache.org/POM/4.0.0";
- xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+4.0.0
-ranger
org.apache.ranger
+ranger
3.0.0-SNAPSHOT
-4.0.0
ranger-nestedstructure-plugin
+jar
NestedStructure Security Plugin
NestedStructure Security Plugin
-jar
8
8
-
-
-org.apache.ranger
-ranger-plugins-common
-${project.version}
-
-
-commons-codec
-commons-codec
-1.11
-
-
-commons-lang
-commons-lang
-2.6
-
-
-commons-logging
-commons-logging
-1.1.1
-
-
-com.google.code.gson
-gson
-${gson.version}
-compile
-
-
-com.jayway.jsonpath
-json-path
-2.9.0
-
-
-org.openjdk.nashorn
-nashorn-core
-15.4
-
-
-org.testng
-testng
-${testng.version}
-test
-
-
+
Review Comment:
For dependencies referenced only in a plugin module, I suggest keeping their
version properties in that plugin module's pom.xml. Converting hardcoded to
properties is a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] RANGER-5005: Use sortpom maven plugin to improve readability of pom files [ranger]
mneethiraj commented on code in PR #413:
URL: https://github.com/apache/ranger/pull/413#discussion_r1858587759
##
ranger-metrics/pom.xml:
##
@@ -15,48 +15,31 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
-http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
-xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
4.0.0
-ranger-metrics
-ranger-metrics
-Ranger Metrics module
-jar
-
-UTF-8
-
org.apache.ranger
ranger
3.0.0-SNAPSHOT
..
+ranger-metrics
+jar
+ranger-metrics
+Ranger Metrics module
+
+
+UTF-8
+
+
org.apache.hadoop
hadoop-common
-${hadoop.version}
-
Review Comment:
Exclusions and version defined in root pom.xml will be applied here. Hence
removed them from here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] RANGER-5005: Use sortpom maven plugin to improve readability of pom files [ranger]
mneethiraj commented on code in PR #413:
URL: https://github.com/apache/ranger/pull/413#discussion_r1858581619
##
ranger-authn/pom.xml:
##
@@ -15,56 +15,36 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
-http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
-xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
4.0.0
-ranger-authn
-ranger-authn
-Ranger Authentication module
-jar
-
-UTF-8
-
+
org.apache.ranger
ranger
3.0.0-SNAPSHOT
..
+ranger-authn
+jar
+ranger-authn
+Ranger Authentication module
+
+
+UTF-8
+
+
-org.apache.hadoop
-hadoop-common
-${hadoop.version}
-
Review Comment:
Exclusions and version defined in root pom.xml (for hadoop-common) will be
applied here too. Hence remove them from child modules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] RANGER-5005: Use sortpom maven plugin to improve readability of pom files [ranger]
mneethiraj commented on code in PR #413:
URL: https://github.com/apache/ranger/pull/413#discussion_r1858579239
##
plugin-nestedstructure/pom.xml:
##
@@ -15,92 +15,90 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
-http://maven.apache.org/POM/4.0.0";
- xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+4.0.0
-ranger
org.apache.ranger
+ranger
3.0.0-SNAPSHOT
-4.0.0
ranger-nestedstructure-plugin
+jar
NestedStructure Security Plugin
NestedStructure Security Plugin
-jar
8
8
-
-
-org.apache.ranger
-ranger-plugins-common
-${project.version}
-
-
-commons-codec
-commons-codec
-1.11
-
-
-commons-lang
-commons-lang
-2.6
-
-
-commons-logging
-commons-logging
-1.1.1
-
-
-com.google.code.gson
-gson
-${gson.version}
-compile
-
-
-com.jayway.jsonpath
-json-path
-2.9.0
-
-
-org.openjdk.nashorn
-nashorn-core
-15.4
-
-
-org.testng
-testng
-${testng.version}
-test
-
-
+
Review Comment:
For dependencies referenced only in a plugin module, I suggest keeping their
version properties in that plugin module's pom.xml. Converting hardcoded to
properties is a good idea. Can this be addressed in a subsequent patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] RANGER-5005: Use sortpom maven plugin to improve readability of pom files [ranger]
mneethiraj commented on code in PR #413: URL: https://github.com/apache/ranger/pull/413#discussion_r1858573408 ## plugin-schema-registry/pom.xml: ## @@ -15,27 +15,25 @@ See the License for the specific language governing permissions and limitations under the License. --> -http://maven.apache.org/POM/4.0.0"; - xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; - xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> 4.0.0 -ranger-schema-registry-plugin -SchemaRegistry Security Plugin -SchemaRegistry Security Plugin -jar org.apache.ranger ranger 3.0.0-SNAPSHOT .. +ranger-schema-registry-plugin +jar +SchemaRegistry Security Plugin +SchemaRegistry Security Plugin 1.11.3 Review Comment: When a dependency is used only within a plugin module, I suggest keeping its version property in plugin module's pom.xml. For rest of Ranger libraries, version properties should be consolidated in root pom.xml. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] RANGER-5005: Use sortpom maven plugin to improve readability of pom files [ranger]
kumaab commented on PR #413: URL: https://github.com/apache/ranger/pull/413#issuecomment-2500037815 Manually reviewed all files except a few (hive-agent/pom.xml, kms/pom.xml, knox/pom.xml, security-admin/pom.xml). Rearrangements look good, there are a few places where submodules use versions which can be all kept in root pom.xml. This is a very useful change going forward for developers to maintain and improve code quality in Ranger. Thank you for this patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] RANGER-5005: Use sortpom maven plugin to improve readability of pom files [ranger]
kumaab commented on code in PR #413:
URL: https://github.com/apache/ranger/pull/413#discussion_r1858060861
##
ugsync/pom.xml:
##
@@ -37,42 +73,47 @@
commons-cli
${commons.cli.version}
+
+commons-codec
+commons-codec
+${commons.codec.version}
+
commons-collections
commons-collections
${commons.collections.version}
+
+commons-io
+commons-io
+${commons.io.version}
+
+
+commons-lang
+commons-lang
+${commons.lang.version}
+
org.apache.commons
commons-configuration2
${commons.configuration.version}
-
+
org.apache.commons
commons-text
-commons-lang
-commons-lang
-${commons.lang.version}
+org.apache.commons
+commons-csv
+1.0
Review Comment:
minor: can be moved to the root pom.xml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] RANGER-5005: Use sortpom maven plugin to improve readability of pom files [ranger]
kumaab commented on code in PR #413: URL: https://github.com/apache/ranger/pull/413#discussion_r1858031122 ## ranger-plugin-classloader/pom.xml: ## @@ -51,4 +50,5 @@ test +http://maven.apache.org Review Comment: Line 53 can be removed ? ## ranger-plugin-classloader/pom.xml: ## @@ -51,4 +50,5 @@ test +http://maven.apache.org Review Comment: Minor: Line 53 can be removed ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] RANGER-5005: Use sortpom maven plugin to improve readability of pom files [ranger]
kumaab commented on code in PR #413:
URL: https://github.com/apache/ranger/pull/413#discussion_r1858029013
##
ranger-metrics/pom.xml:
##
@@ -15,48 +15,31 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
-http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
-xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
4.0.0
-ranger-metrics
-ranger-metrics
-Ranger Metrics module
-jar
-
-UTF-8
-
org.apache.ranger
ranger
3.0.0-SNAPSHOT
..
+ranger-metrics
+jar
+ranger-metrics
+Ranger Metrics module
+
+
+UTF-8
+
+
org.apache.hadoop
hadoop-common
-${hadoop.version}
-
Review Comment:
Exclusions are removed from here as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] RANGER-5005: Use sortpom maven plugin to improve readability of pom files [ranger]
kumaab commented on code in PR #413:
URL: https://github.com/apache/ranger/pull/413#discussion_r1858023053
##
ranger-authn/pom.xml:
##
@@ -15,56 +15,36 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
-http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
-xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
4.0.0
-ranger-authn
-ranger-authn
-Ranger Authentication module
-jar
-
-UTF-8
-
+
org.apache.ranger
ranger
3.0.0-SNAPSHOT
..
+ranger-authn
+jar
+ranger-authn
+Ranger Authentication module
+
+
+UTF-8
+
+
-org.apache.hadoop
-hadoop-common
-${hadoop.version}
-
Review Comment:
It appears that Exclusions for `hadoop-common` were removed but not added
back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] RANGER-5005: Use sortpom maven plugin to improve readability of pom files [ranger]
kumaab commented on code in PR #413: URL: https://github.com/apache/ranger/pull/413#discussion_r1858017814 ## plugin-schema-registry/pom.xml: ## @@ -15,27 +15,25 @@ See the License for the specific language governing permissions and limitations under the License. --> -http://maven.apache.org/POM/4.0.0"; - xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; - xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> 4.0.0 -ranger-schema-registry-plugin -SchemaRegistry Security Plugin -SchemaRegistry Security Plugin -jar org.apache.ranger ranger 3.0.0-SNAPSHOT .. +ranger-schema-registry-plugin +jar +SchemaRegistry Security Plugin +SchemaRegistry Security Plugin 1.11.3 Review Comment: Is it better to keep them in root pom.xml to be consistent? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] RANGER-5005: Use sortpom maven plugin to improve readability of pom files [ranger]
kumaab commented on code in PR #413:
URL: https://github.com/apache/ranger/pull/413#discussion_r1858011691
##
plugin-nestedstructure/pom.xml:
##
@@ -15,92 +15,90 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
-http://maven.apache.org/POM/4.0.0";
- xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+4.0.0
-ranger
org.apache.ranger
+ranger
3.0.0-SNAPSHOT
-4.0.0
ranger-nestedstructure-plugin
+jar
NestedStructure Security Plugin
NestedStructure Security Plugin
-jar
8
8
-
-
-org.apache.ranger
-ranger-plugins-common
-${project.version}
-
-
-commons-codec
-commons-codec
-1.11
-
-
-commons-lang
-commons-lang
-2.6
-
-
-commons-logging
-commons-logging
-1.1.1
-
-
-com.google.code.gson
-gson
-${gson.version}
-compile
-
-
-com.jayway.jsonpath
-json-path
-2.9.0
-
-
-org.openjdk.nashorn
-nashorn-core
-15.4
-
-
-org.testng
-testng
-${testng.version}
-test
-
-
+
Review Comment:
A lot of dependencies here use hard-coded versions, may be we should keep
them in root pom.xml ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
