Re: Review Request 65651: RANGER-1889: List Users belonging to Group in Group tab
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65651/#review198688 --- Ship it! Ship It! - Mehul Parikh On March 6, 2018, 12:31 p.m., Nitin Galave wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65651/ > --- > > (Updated March 6, 2018, 12:31 p.m.) > > > Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and > Velmurugan Periasamy. > > > Bugs: RANGER-1889 > https://issues.apache.org/jira/browse/RANGER-1889 > > > Repository: ranger > > > Description > --- > > Request to add the list of users inside each group page on the Settings -> > Users/Groups page. > > > Diffs > - > > security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java > b713d126a26aa58827f5df4c09478a92a6f602d2 > security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java > 9a9604fefd110d4cc5a25fcc49071d86d1abb61d > security-admin/src/main/webapp/scripts/modules/globalize/message/en.js > 8aaf70507b0964432965053a22e6c35dd17147e0 > security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js > 410a8ada212d711e6391b932305cc924f0062534 > security-admin/src/main/webapp/styles/xa.css > 5ccbbc2204a087011312fac41035a35e79418db7 > security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java > 0b71695e7b3eebe255949e1c5b763890505844aa > security-admin/src/test/java/org/apache/ranger/rest/TestXUserREST.java > 1bf30997ed16be49d8f16e576436f66a74aa511d > > > Diff: https://reviews.apache.org/r/65651/diff/2/ > > > Testing > --- > > 1. Able to see users which are present inside each group.(Added user list > column on group listing page) > 2. User search filter is also working on thoses users. > 3. Also tested with internal and external groups/users. > > > Thanks, > > Nitin Galave > >
Re: Review Request 65651: RANGER-1889: List Users belonging to Group in Group tab
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65651/ --- (Updated March 6, 2018, 12:31 p.m.) Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy. Bugs: RANGER-1889 https://issues.apache.org/jira/browse/RANGER-1889 Repository: ranger Description --- Request to add the list of users inside each group page on the Settings -> Users/Groups page. Diffs (updated) - security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java b713d126a26aa58827f5df4c09478a92a6f602d2 security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 9a9604fefd110d4cc5a25fcc49071d86d1abb61d security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 8aaf70507b0964432965053a22e6c35dd17147e0 security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js 410a8ada212d711e6391b932305cc924f0062534 security-admin/src/main/webapp/styles/xa.css 5ccbbc2204a087011312fac41035a35e79418db7 security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java 0b71695e7b3eebe255949e1c5b763890505844aa security-admin/src/test/java/org/apache/ranger/rest/TestXUserREST.java 1bf30997ed16be49d8f16e576436f66a74aa511d Diff: https://reviews.apache.org/r/65651/diff/2/ Changes: https://reviews.apache.org/r/65651/diff/1-2/ Testing --- 1. Able to see users which are present inside each group.(Added user list column on group listing page) 2. User search filter is also working on thoses users. 3. Also tested with internal and external groups/users. Thanks, Nitin Galave
Re: Review Request 65651: RANGER-1889: List Users belonging to Group in Group tab
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65651/#review197744 --- Ship it! Ship It! - Gautam Borad On Feb. 14, 2018, 11:25 a.m., Nitin Galave wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65651/ > --- > > (Updated Feb. 14, 2018, 11:25 a.m.) > > > Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and > Velmurugan Periasamy. > > > Bugs: RANGER-1889 > https://issues.apache.org/jira/browse/RANGER-1889 > > > Repository: ranger > > > Description > --- > > Request to add the list of users inside each group page on the Settings -> > Users/Groups page. > > > Diffs > - > > security-admin/src/main/webapp/scripts/modules/globalize/message/en.js > b71427c > security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js > 9febd99 > > > Diff: https://reviews.apache.org/r/65651/diff/1/ > > > Testing > --- > > 1. Able to see users which are present inside each group.(Added user list > column on group listing page) > 2. User search filter is also working on thoses users. > 3. Also tested with internal and external groups/users. > > > Thanks, > > Nitin Galave > >