---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69677/#review212238
---
Ship it!
Ship It!
- Velmurugan Periasamy
On Jan. 22, 2019,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69677/#review212231
---
Ship it!
Ship It!
- Zsombor Gegesy
On Jan. 22, 2019, 1:47
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69677/
---
(Updated Jan. 22, 2019, 1:47 p.m.)
Review request for ranger, Abhay Kulkarni,
> On Jan. 8, 2019, 11:48 a.m., Zsombor Gegesy wrote:
> > It's great news, that you could delete thousands of lines of repetitive
> > code, however you could achieve more, if instead of putting everything into
> > one class, and put
> > '''
> > if self.XA_DB_FLAVOR == DB_MYSQL:
> >...
> >
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69677/
---
(Updated Jan. 15, 2019, 12:55 p.m.)
Review request for ranger, Abhay Kulkarni,
> On Jan. 8, 2019, 11:48 a.m., Zsombor Gegesy wrote:
> > It's great news, that you could delete thousands of lines of repetitive
> > code, however you could achieve more, if instead of putting everything into
> > one class, and put
> > '''
> > if self.XA_DB_FLAVOR == DB_MYSQL:
> >...
> >
> On Jan. 8, 2019, 11:48 a.m., Zsombor Gegesy wrote:
> > It's great news, that you could delete thousands of lines of repetitive
> > code, however you could achieve more, if instead of putting everything into
> > one class, and put
> > '''
> > if self.XA_DB_FLAVOR == DB_MYSQL:
> >...
> >
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69677/#review211760
---
It's great news, that you could delete thousands of lines of
