Re: Review Request 71495: RANGER-2570 : Handling the pop up of policy details on Ranger Access audit log row

2019-09-19 Thread Abhay Kulkarni 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71495/#review217869
---




security-admin/src/main/java/org/apache/ranger/service/RangerDataHistService.java
Line 95 (original), 97 (patched)


policy.setServiceType() is corrected with RANGER-2580. With that fix, kines 
95-103 may not be required. Please review.


- Abhay Kulkarni


On Sept. 19, 2019, 1:30 p.m., Fatima Khan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71495/
> ---
> 
> (Updated Sept. 19, 2019, 1:30 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2570
> https://issues.apache.org/jira/browse/RANGER-2570
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Issue on pop up of policy details of ranger access audit log row.
> 
> 
> Diffs
> -
> 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerDataHistService.java
>  ced9ea8 
>   security-admin/src/main/webapp/scripts/models/RangerPolicy.js cd873b3 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js 
> af024e2 
>   
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js
>  31fc7c1 
>   security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 6a1c7c2 
> 
> 
> Diff: https://reviews.apache.org/r/71495/diff/2/
> 
> 
> Testing
> ---
> 
> The policy details get popped up.
> 
> 
> Thanks,
> 
> Fatima Khan
> 
>

Re: Review Request 71495: RANGER-2570 : Handling the pop up of policy details on Ranger Access audit log row

2019-09-19 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71495/#review217855
---


Ship it!




Ship It!

- Velmurugan Periasamy


On Sept. 19, 2019, 1:30 p.m., Fatima Khan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71495/
> ---
> 
> (Updated Sept. 19, 2019, 1:30 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2570
> https://issues.apache.org/jira/browse/RANGER-2570
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Issue on pop up of policy details of ranger access audit log row.
> 
> 
> Diffs
> -
> 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerDataHistService.java
>  ced9ea8 
>   security-admin/src/main/webapp/scripts/models/RangerPolicy.js cd873b3 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js 
> af024e2 
>   
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js
>  31fc7c1 
>   security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 6a1c7c2 
> 
> 
> Diff: https://reviews.apache.org/r/71495/diff/2/
> 
> 
> Testing
> ---
> 
> The policy details get popped up.
> 
> 
> Thanks,
> 
> Fatima Khan
> 
>

Re: Review Request 71495: RANGER-2570 : Handling the pop up of policy details on Ranger Access audit log row

2019-09-19 Thread Fatima Khan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71495/
---

(Updated Sept. 19, 2019, 1:30 p.m.)


Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, 
and Velmurugan Periasamy.


Bugs: RANGER-2570
https://issues.apache.org/jira/browse/RANGER-2570


Repository: ranger


Description
---

Issue on pop up of policy details of ranger access audit log row.


Diffs (updated)
-

  
security-admin/src/main/java/org/apache/ranger/service/RangerDataHistService.java
 ced9ea8 
  security-admin/src/main/webapp/scripts/models/RangerPolicy.js cd873b3 
  security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js 
af024e2 
  
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js
 31fc7c1 
  security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 6a1c7c2 


Diff: https://reviews.apache.org/r/71495/diff/2/

Changes: https://reviews.apache.org/r/71495/diff/1-2/


Testing
---

The policy details get popped up.


Thanks,

Fatima Khan

Re: Review Request 71495: RANGER-2570 : Handling the pop up of policy details on Ranger Access audit log row

2019-09-18 Thread Abhay Kulkarni 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71495/#review217819
---




security-admin/src/main/java/org/apache/ranger/service/RangerDataHistService.java
Lines 98 (patched)


Consider rewriting this as:

if (xXService != null) {
   XXServiceDef xXServiceDef = 
daoMgr.getXXServiceDef().getById(xXService.getType());
   if (xXServiceDef != null) {
  policy.setServiceType(xXServiceDef.getName());
   }
}


- Formatted with spaces around operators and parentheses, correct 
camel-case names for variables.
- Defined xXServiceDef within the smallest scope where it is used.


- Abhay Kulkarni


On Sept. 18, 2019, 1:09 p.m., Fatima Khan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71495/
> ---
> 
> (Updated Sept. 18, 2019, 1:09 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2570
> https://issues.apache.org/jira/browse/RANGER-2570
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Issue on pop up of policy details of ranger access audit log row.
> 
> 
> Diffs
> -
> 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerDataHistService.java
>  ced9ea8 
>   security-admin/src/main/webapp/scripts/models/RangerPolicy.js cd873b3 
> 
> 
> Diff: https://reviews.apache.org/r/71495/diff/1/
> 
> 
> Testing
> ---
> 
> The policy details get popped up.
> 
> 
> Thanks,
> 
> Fatima Khan
> 
>