Re: Review Request 72847: RANGER-2998 : API for Ranger KMS service status

2020-09-20 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72847/#review221906 --- Ship it! Ship It! - Mehul Parikh On Sept. 20, 2020, 1:11

Re: Review Request 72847: RANGER-2998 : API for Ranger KMS service status

2020-09-20 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72847/#review221905 --- Ship it! Ship It! - Madhan Neethiraj On Sept. 20, 2020,

Re: Review Request 72847: RANGER-2998 : API for Ranger KMS service status

2020-09-20 Thread Dhaval Shah
> On Sept. 16, 2020, 6:45 p.m., Madhan Neethiraj wrote: > > kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAuthenticationFilter.java > > Lines 131 (patched) > > > > > > As Ramesh suggested, consider

Re: Review Request 72847: RANGER-2998 : API for Ranger KMS service status

2020-09-20 Thread Dhaval Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72847/ --- (Updated Sept. 20, 2020, 1:11 p.m.) Review request for ranger, Ankita Sinha,

Re: Review Request 72847: RANGER-2998 : API for Ranger KMS service status

2020-09-16 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72847/#review221877 ---

Re: Review Request 72847: RANGER-2998 : API for Ranger KMS service status

2020-09-16 Thread Dhaval Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72847/ --- (Updated Sept. 16, 2020, 6:38 p.m.) Review request for ranger, Ankita Sinha,

Re: Review Request 72847: RANGER-2998 : API for Ranger KMS service status

2020-09-16 Thread Dhaval Shah
> On Sept. 16, 2020, 3:44 p.m., Ramesh Mani wrote: > > kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMDCFilter.java > > Lines 77 (patched) > > > > > > do we need to check only the "/kms/api/status"

Re: Review Request 72847: RANGER-2998 : API for Ranger KMS service status

2020-09-16 Thread Dhaval Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72847/ --- (Updated Sept. 16, 2020, 6:31 p.m.) Review request for ranger, Ankita Sinha,