Re: Review Request 61078: RANGER-1708: Remove tag services from service type and service name filters under Access Audit.

2017-08-02 Thread Mehul Parikh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61078/#review182074
---


Ship it!




Ship It!

- Mehul Parikh


On Aug. 1, 2017, 6:42 a.m., Nitin Galave wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61078/
> ---
> 
> (Updated Aug. 1, 2017, 6:42 a.m.)
> 
> 
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1708
> https://issues.apache.org/jira/browse/RANGER-1708
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Since we donot directly associate audit logs as part of tag service (rather 
> we associate them as part of their respective service with which the tag 
> service is associated, for example hive), it would be appropriate to remove 
> the tag services from the filters.That is from Ranger UI - > Audit Menu -> 
> Admin Tab
> Remove service name and type of tags from search filter.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 40f56dd 
> 
> 
> Diff: https://reviews.apache.org/r/61078/diff/1/
> 
> 
> Testing
> ---
> 
> Verified :
> Audit -> Access Tab -> search filter :
> 1. No tag service name option found under service name drop-down.
> 2. No tag service type option found under service type drop-down.
> 3. Able to search by service name and type for hive, hdfs etc. (except tag 
> service name and type).
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>



Re: Review Request 61078: RANGER-1708: Remove tag services from service type and service name filters under Access Audit.

2017-08-02 Thread Abhay Kulkarni

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61078/#review182021
---


Ship it!




Ship It!

- Abhay Kulkarni


On Aug. 1, 2017, 6:42 a.m., Nitin Galave wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61078/
> ---
> 
> (Updated Aug. 1, 2017, 6:42 a.m.)
> 
> 
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1708
> https://issues.apache.org/jira/browse/RANGER-1708
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Since we donot directly associate audit logs as part of tag service (rather 
> we associate them as part of their respective service with which the tag 
> service is associated, for example hive), it would be appropriate to remove 
> the tag services from the filters.That is from Ranger UI - > Audit Menu -> 
> Admin Tab
> Remove service name and type of tags from search filter.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 40f56dd 
> 
> 
> Diff: https://reviews.apache.org/r/61078/diff/1/
> 
> 
> Testing
> ---
> 
> Verified :
> Audit -> Access Tab -> search filter :
> 1. No tag service name option found under service name drop-down.
> 2. No tag service type option found under service type drop-down.
> 3. Able to search by service name and type for hive, hdfs etc. (except tag 
> service name and type).
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>



Review Request 61078: RANGER-1708: Remove tag services from service type and service name filters under Access Audit.

2017-07-24 Thread Nitin Galave

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61078/
---

Review request for ranger, Gautam Borad, Mehul Parikh, and Velmurugan Periasamy.


Bugs: RANGER-1708
https://issues.apache.org/jira/browse/RANGER-1708


Repository: ranger


Description
---

Since we donot directly associate audit logs as part of tag service (rather we 
associate them as part of their respective service with which the tag service 
is associated, for example hive), it would be appropriate to remove the tag 
services from the filters.That is from Ranger UI - > Audit Menu -> Admin Tab
Remove service name and type of tags from search filter.


Diffs
-

  security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 40f56dd 


Diff: https://reviews.apache.org/r/61078/diff/1/


Testing
---

Verified :
Audit -> Access Tab -> search filter :
1. No tag service name option found under service name drop-down.
2. No tag service type option found under service type drop-down.
3. Able to search by service name and type for hive, hdfs etc. (except tag 
service name and type).


Thanks,

Nitin Galave