Re: Review Request 61452: RANGER-1725: It is incorrect to judge whether you need to create a RangerServiceDef object for a given service

2017-08-09 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61452/#review182481 --- Ship it! Ship It! - Colm O hEigeartaigh On Aug. 9, 2017,

Re: Review Request 61452: RANGER-1725: It is incorrect to judge whether you need to create a RangerServiceDef object for a given service

2017-08-08 Thread pengjianhua
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61452/ --- (Updated 八月 9, 2017, 5:33 a.m.) Review request for ranger, Alok Lal, Ankita

Re: Review Request 61452: RANGER-1725: It is incorrect to judge whether you need to create a RangerServiceDef object for a given service

2017-08-08 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61452/#review182401 --- Looks fine. Could you remove the try/catch statement in

Review Request 61452: RANGER-1725: It is incorrect to judge whether you need to create a RangerServiceDef object for a given service

2017-08-07 Thread pengjianhua
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61452/ --- Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O