Re: Review Request 71444: RANGER-2559 : Update Atlas Authorizer with forwardedAddresses and Remote IP to handle request from proxy.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71444/#review217685 --- Ship it! Ship It! - Mehul Parikh On Sept. 11, 2019, 10:36 a.m., Nixon Rodrigues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71444/ > --- > > (Updated Sept. 11, 2019, 10:36 a.m.) > > > Review request for ranger, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, and > Velmurugan Periasamy. > > > Bugs: RANGER-2559 > https://issues.apache.org/jira/browse/RANGER-2559 > > > Repository: ranger > > > Description > --- > > This patch sets forwardedAddresses and Remote IP to from AtlasAccessRequest > to RangerAccessRequestImpl. > > * This patch depends ATLAS-3387 due compilation as addition attributes are > added in AtlasAccessRequest > > > Diffs > - > > > plugin-atlas/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java > c6008ba8a > pom.xml 13d5a5bc0 > > > Diff: https://reviews.apache.org/r/71444/diff/2/ > > > Testing > --- > > Testing Ranger audits with and without following settings for various Atlas > resource authorization. > > ranger.plugin.atlas.use.x-forwarded-for.ipaddress=true > ranger.plugin.atlas.trusted.proxy.ipaddresses=PROXY_IP > > > Thanks, > > Nixon Rodrigues > >
Re: Review Request 71444: RANGER-2559 : Update Atlas Authorizer with forwardedAddresses and Remote IP to handle request from proxy.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71444/
---
(Updated Sept. 11, 2019, 10:36 a.m.)
Review request for ranger, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, and
Velmurugan Periasamy.
Changes
---
This patch is dependent on ATLAS-3387 which is committed but not yet released,
hence updated {atlas.version} in pom.xml to 3.0.0-SNAPSHOT updated patch for
successful build.
Bugs: RANGER-2559
https://issues.apache.org/jira/browse/RANGER-2559
Repository: ranger
Description
---
This patch sets forwardedAddresses and Remote IP to from AtlasAccessRequest to
RangerAccessRequestImpl.
* This patch depends ATLAS-3387 due compilation as addition attributes are
added in AtlasAccessRequest
Diffs (updated)
-
plugin-atlas/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java
c6008ba8a
pom.xml 13d5a5bc0
Diff: https://reviews.apache.org/r/71444/diff/2/
Changes: https://reviews.apache.org/r/71444/diff/1-2/
Testing
---
Testing Ranger audits with and without following settings for various Atlas
resource authorization.
ranger.plugin.atlas.use.x-forwarded-for.ipaddress=true
ranger.plugin.atlas.trusted.proxy.ipaddresses=PROXY_IP
Thanks,
Nixon Rodrigues
Re: Review Request 71444: RANGER-2559 : Update Atlas Authorizer with forwardedAddresses and Remote IP to handle request from proxy.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71444/#review217611 --- Ship it! Ship It! - Madhan Neethiraj On Sept. 6, 2019, 10:34 a.m., Nixon Rodrigues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71444/ > --- > > (Updated Sept. 6, 2019, 10:34 a.m.) > > > Review request for ranger, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, and > Velmurugan Periasamy. > > > Bugs: RANGER-2559 > https://issues.apache.org/jira/browse/RANGER-2559 > > > Repository: ranger > > > Description > --- > > This patch sets forwardedAddresses and Remote IP to from AtlasAccessRequest > to RangerAccessRequestImpl. > > * This patch depends ATLAS-3387 due compilation as addition attributes are > added in AtlasAccessRequest > > > Diffs > - > > > plugin-atlas/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java > c6008ba8a > > > Diff: https://reviews.apache.org/r/71444/diff/1/ > > > Testing > --- > > Testing Ranger audits with and without following settings for various Atlas > resource authorization. > > ranger.plugin.atlas.use.x-forwarded-for.ipaddress=true > ranger.plugin.atlas.trusted.proxy.ipaddresses=PROXY_IP > > > Thanks, > > Nixon Rodrigues > >
Review Request 71444: RANGER-2559 : Update Atlas Authorizer with forwardedAddresses and Remote IP to handle request from proxy.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71444/ --- Review request for ranger, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, and Velmurugan Periasamy. Bugs: RANGER-2559 https://issues.apache.org/jira/browse/RANGER-2559 Repository: ranger Description --- This patch sets forwardedAddresses and Remote IP to from AtlasAccessRequest to RangerAccessRequestImpl. * This patch depends ATLAS-3387 due compilation as addition attributes are added in AtlasAccessRequest Diffs - plugin-atlas/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java c6008ba8a Diff: https://reviews.apache.org/r/71444/diff/1/ Testing --- Testing Ranger audits with and without following settings for various Atlas resource authorization. ranger.plugin.atlas.use.x-forwarded-for.ipaddress=true ranger.plugin.atlas.trusted.proxy.ipaddresses=PROXY_IP Thanks, Nixon Rodrigues
