Re: Review Request 71465: RANGER-2564:Avoid recursive audit log in Solr Plugin by user solr when plugin is enabled for ranger_audits collection

2019-09-11 Thread Ramesh Mani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71465/
---

(Updated Sept. 11, 2019, 8:59 p.m.)


Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
Madhan Neethiraj, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, 
and Velmurugan Periasamy.


Changes
---

review comments addressed.


Repository: ranger


Description
---

RANGER-2564:Avoid recursive audit log in Solr Plugin by user solr when plugin 
is enabled for ranger_audits collection


Diffs (updated)
-

  
agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerMultiResourceAuditHandler.java
 c8ba6dd 
  
plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuditHandler.java
 PRE-CREATION 
  
plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java
 5fcd45d 


Diff: https://reviews.apache.org/r/71465/diff/4/

Changes: https://reviews.apache.org/r/71465/diff/3-4/


Testing
---

- Testing done enabling the SOLR Plugin in ranger_audits collection.


Thanks,

Ramesh Mani

Re: Review Request 71465: RANGER-2564:Avoid recursive audit log in Solr Plugin by user solr when plugin is enabled for ranger_audits collection

2019-09-11 Thread Abhay Kulkarni 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71465/#review217693
---


Ship it!




Ship It!

- Abhay Kulkarni


On Sept. 11, 2019, 8:14 p.m., Ramesh Mani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71465/
> ---
> 
> (Updated Sept. 11, 2019, 8:14 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
> Madhan Neethiraj, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, 
> and Velmurugan Periasamy.
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> RANGER-2564:Avoid recursive audit log in Solr Plugin by user solr when plugin 
> is enabled for ranger_audits collection
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerMultiResourceAuditHandler.java
>  c8ba6dd 
>   
> plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuditHandler.java
>  PRE-CREATION 
>   
> plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java
>  5fcd45d 
> 
> 
> Diff: https://reviews.apache.org/r/71465/diff/3/
> 
> 
> Testing
> ---
> 
> - Testing done enabling the SOLR Plugin in ranger_audits collection.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

Re: Review Request 71465: RANGER-2564:Avoid recursive audit log in Solr Plugin by user solr when plugin is enabled for ranger_audits collection

2019-09-11 Thread Ramesh Mani 


> On Sept. 11, 2019, 5:12 p.m., Velmurugan Periasamy wrote:
> > plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuditHandler.java
> > Lines 32 (patched)
> > 
> >
> > consider renaming this property?

fixed


- Ramesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71465/#review217690
---


On Sept. 11, 2019, 8:14 p.m., Ramesh Mani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71465/
> ---
> 
> (Updated Sept. 11, 2019, 8:14 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
> Madhan Neethiraj, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, 
> and Velmurugan Periasamy.
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> RANGER-2564:Avoid recursive audit log in Solr Plugin by user solr when plugin 
> is enabled for ranger_audits collection
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerMultiResourceAuditHandler.java
>  c8ba6dd 
>   
> plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuditHandler.java
>  PRE-CREATION 
>   
> plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java
>  5fcd45d 
> 
> 
> Diff: https://reviews.apache.org/r/71465/diff/3/
> 
> 
> Testing
> ---
> 
> - Testing done enabling the SOLR Plugin in ranger_audits collection.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

Re: Review Request 71465: RANGER-2564:Avoid recursive audit log in Solr Plugin by user solr when plugin is enabled for ranger_audits collection

2019-09-11 Thread Ramesh Mani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71465/
---

(Updated Sept. 11, 2019, 8:14 p.m.)


Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
Madhan Neethiraj, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, 
and Velmurugan Periasamy.


Changes
---

addressed review comments


Repository: ranger


Description
---

RANGER-2564:Avoid recursive audit log in Solr Plugin by user solr when plugin 
is enabled for ranger_audits collection


Diffs (updated)
-

  
agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerMultiResourceAuditHandler.java
 c8ba6dd 
  
plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuditHandler.java
 PRE-CREATION 
  
plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java
 5fcd45d 


Diff: https://reviews.apache.org/r/71465/diff/3/

Changes: https://reviews.apache.org/r/71465/diff/2-3/


Testing
---

- Testing done enabling the SOLR Plugin in ranger_audits collection.


Thanks,

Ramesh Mani

Re: Review Request 71465: RANGER-2564:Avoid recursive audit log in Solr Plugin by user solr when plugin is enabled for ranger_audits collection

2019-09-11 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71465/#review217690
---




plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuditHandler.java
Lines 32 (patched)


consider renaming this property?


- Velmurugan Periasamy


On Sept. 11, 2019, 12:26 a.m., Ramesh Mani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71465/
> ---
> 
> (Updated Sept. 11, 2019, 12:26 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
> Madhan Neethiraj, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, 
> and Velmurugan Periasamy.
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> RANGER-2564:Avoid recursive audit log in Solr Plugin by user solr when plugin 
> is enabled for ranger_audits collection
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerMultiResourceAuditHandler.java
>  c8ba6dd 
>   
> plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuditHandler.java
>  PRE-CREATION 
>   
> plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java
>  5fcd45d 
> 
> 
> Diff: https://reviews.apache.org/r/71465/diff/2/
> 
> 
> Testing
> ---
> 
> - Testing done enabling the SOLR Plugin in ranger_audits collection.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

Re: Review Request 71465: RANGER-2564:Avoid recursive audit log in Solr Plugin by user solr when plugin is enabled for ranger_audits collection

2019-09-10 Thread Ramesh Mani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71465/
---

(Updated Sept. 11, 2019, 12:26 a.m.)


Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
Madhan Neethiraj, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, 
and Velmurugan Periasamy.


Changes
---

Addressed review comments


Repository: ranger


Description
---

RANGER-2564:Avoid recursive audit log in Solr Plugin by user solr when plugin 
is enabled for ranger_audits collection


Diffs (updated)
-

  
agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerMultiResourceAuditHandler.java
 c8ba6dd 
  
plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuditHandler.java
 PRE-CREATION 
  
plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java
 5fcd45d 


Diff: https://reviews.apache.org/r/71465/diff/2/

Changes: https://reviews.apache.org/r/71465/diff/1-2/


Testing
---

- Testing done enabling the SOLR Plugin in ranger_audits collection.


Thanks,

Ramesh Mani

Re: Review Request 71465: RANGER-2564:Avoid recursive audit log in Solr Plugin by user solr when plugin is enabled for ranger_audits collection

2019-09-10 Thread Abhay Kulkarni 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71465/#review217683
---




plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuditHandler.java
Lines 60 (patched)


If access is denied, it should be logged, right? Please review.



plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuditHandler.java
Lines 72 (patched)


Is it required to be defined for this class if all it does is to call its 
superclass method?


- Abhay Kulkarni


On Sept. 10, 2019, 11:18 p.m., Ramesh Mani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71465/
> ---
> 
> (Updated Sept. 10, 2019, 11:18 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
> Madhan Neethiraj, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, 
> and Velmurugan Periasamy.
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> RANGER-2564:Avoid recursive audit log in Solr Plugin by user solr when plugin 
> is enabled for ranger_audits collection
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerMultiResourceAuditHandler.java
>  c8ba6dd 
>   
> plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuditHandler.java
>  PRE-CREATION 
>   
> plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java
>  5fcd45d 
> 
> 
> Diff: https://reviews.apache.org/r/71465/diff/1/
> 
> 
> Testing
> ---
> 
> - Testing done enabling the SOLR Plugin in ranger_audits collection.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

Review Request 71465: RANGER-2564:Avoid recursive audit log in Solr Plugin by user solr when plugin is enabled for ranger_audits collection

2019-09-10 Thread Ramesh Mani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71465/
---

Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
Madhan Neethiraj, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, 
and Velmurugan Periasamy.


Repository: ranger


Description
---

RANGER-2564:Avoid recursive audit log in Solr Plugin by user solr when plugin 
is enabled for ranger_audits collection


Diffs
-

  
agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerMultiResourceAuditHandler.java
 c8ba6dd 
  
plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuditHandler.java
 PRE-CREATION 
  
plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java
 5fcd45d 


Diff: https://reviews.apache.org/r/71465/diff/1/


Testing
---

- Testing done enabling the SOLR Plugin in ranger_audits collection.


Thanks,

Ramesh Mani