[GitHub] [incubator-ratis] lokeshj1703 commented on a change in pull request #138: RATIS-989. Avoid change state from closing to exception in LogAppender

2020-06-30 Thread GitBox
lokeshj1703 commented on a change in pull request #138: URL: https://github.com/apache/incubator-ratis/pull/138#discussion_r447545765 ## File path: ratis-server/src/main/java/org/apache/ratis/server/impl/LogAppender.java ## @@ -117,6 +121,16 @@ void stop() { public String

[GitHub] [incubator-ratis] runzhiwang commented on a change in pull request #138: RATIS-989. Avoid change state from closing to exception in LogAppender

2020-06-30 Thread GitBox
runzhiwang commented on a change in pull request #138: URL: https://github.com/apache/incubator-ratis/pull/138#discussion_r447560825 ## File path: ratis-server/src/main/java/org/apache/ratis/server/impl/LogAppender.java ## @@ -117,6 +121,16 @@ void stop() { public String

[GitHub] [incubator-ratis] cyrus-jackson commented on pull request #140: Adds new JMX metric for getting Groups a server is part of

2020-06-30 Thread GitBox
cyrus-jackson commented on pull request #140: URL: https://github.com/apache/incubator-ratis/pull/140#issuecomment-651693429 Failing tests are not related to the patch This is an automated message from the Apache Git Service.

[GitHub] [incubator-ratis] cyrus-jackson commented on pull request #136: RATIS-974. Build fails on Windows machine

2020-06-30 Thread GitBox
cyrus-jackson commented on pull request #136: URL: https://github.com/apache/incubator-ratis/pull/136#issuecomment-651694986 Thank for the review and commit @lokeshj1703 This is an automated message from the Apache Git Servi

[GitHub] [incubator-ratis] runzhiwang commented on pull request #140: Adds new JMX metric for getting Groups a server is part of

2020-06-30 Thread GitBox
runzhiwang commented on pull request #140: URL: https://github.com/apache/incubator-ratis/pull/140#issuecomment-651694904 @cyrus-jackson Hi, You can push an empty commit by `git commit --allow-empty -m "triger ci"` to trigger CI again. The CI passed ratio is about 50%. ---

[GitHub] [incubator-ratis] lokeshj1703 commented on pull request #138: RATIS-989. Avoid change state from CLOSING to EXCEPTION in LogAppender

2020-06-30 Thread GitBox
lokeshj1703 commented on pull request #138: URL: https://github.com/apache/incubator-ratis/pull/138#issuecomment-651714855 @runzhiwang Thanks for the contribution! I have committed the PR to master branch. This is an automat

[GitHub] [incubator-ratis] lokeshj1703 closed pull request #138: RATIS-989. Avoid change state from CLOSING to EXCEPTION in LogAppender

2020-06-30 Thread GitBox
lokeshj1703 closed pull request #138: URL: https://github.com/apache/incubator-ratis/pull/138 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [DISCUSS] Apache Ratis 0.6.0 release

2020-06-30 Thread Lokesh Jain
Thanks everyone for voting! Following jiras are blocking the release. https://issues.apache.org/jira/browse/RATIS-936 https://issues.apache.org/jira/browse/RATIS-991 I will create RC once these a