Re: Gradle Build [PREVIOUSLY] Re: Board feedback - Request discuss attic for River

[Peter Firmstone]

Hi Philip,

The most recent modular build attempt is here:

http://svn.apache.org/viewvc/river/jtsk/modules/

Cheers,

Peter.

On 7/3/2020 2:19 PM, Phillip Rhodes wrote:

Aaah, I may not be using the latest code then. For me, the maven build
is failing right now due to missing dependencies on classes from the
river-policy module, and that module doesn't even have a pom.xml in
it.

Which branch is everybody working on? And is work still going on
through the svn repo at the moment? I haven't had time to catch up on
all the email threads... I saw some reference to switching to Git ( a
move I endorse) but I am not sure if it's time to switch yet.  Any
insight would be much appreciated.


Phil

Re: Gradle Build [PREVIOUSLY] Re: Board feedback - Request discuss attic for River

[Phillip Rhodes]

Aaah, I may not be using the latest code then. For me, the maven build
is failing right now due to missing dependencies on classes from the
river-policy module, and that module doesn't even have a pom.xml in
it.

Which branch is everybody working on? And is work still going on
through the svn repo at the moment? I haven't had time to catch up on
all the email threads... I saw some reference to switching to Git ( a
move I endorse) but I am not sure if it's time to switch yet.  Any
insight would be much appreciated.


Phil

Re: Gradle Build [PREVIOUSLY] Re: Board feedback - Request discuss attic for River

[Peter Firmstone]

Hi Phil,

It's great to have your help. :)

The maven build structure is almost complete, there are some junit tests 
that need to be moved over to their relevant modules from the old ant 
build.  After that there will be some minor implementation dependencies 
between the modules that need to be broken, as well as some issues with 
the pom files themselves.  I believe that the gradle build will utilise 
the same module layout, so any work getting a maven build working will 
not go to waste.


It's not at a stage where it builds yet, there is some work remaining.   
It's probably best to stick with Java 8, as there will be some 
additional problems building later Java versions.


Cheers,

Peter.


On 7/2/2020 12:10 PM, Phillip Rhodes wrote:

A Gradle build would be nice. I'm willing to invest some time trying
to help make it happen if need be. But I am curious.., it looks like
someone started a Maven build a while back.. From what I can see it
seems to maybe be incomplete, or just bit-rotted. But depending on the
details of the state of that work, would there be any reason to prefer
sticking with maven? (FSM help me, I can't believe I just said that in
a public forum).

I'm not the biggest Maven fan in the world, so I only raise this issue
from the "can we use existing work instead of starting from scratch"
perspective.


Phil

Re: Gradle Build [PREVIOUSLY] Re: Board feedback - Request discuss attic for River

[Dan Rollo]

Phil,

If nothing else comes of this, I want to thank you for the phrase "FSM help 
me”. I had to look it up, and had a huge grin reading the wikipedia page I 
found. Wow!

Any way, I think Peter’s work includes much of the conversion to a build using 
maven modules. I am not maven averse, but neither am I gradle negative. My 
enthusiasm for the maven build is based on a hope it would lead to clearer 
delineation of  components (some of which share the same source code, but 
produce separate jars with some of the same class files as needed). I’d be 
happy to lend a hand with any maven issue that pops up, but would not lambast a 
gradle approach.

Dan


> Re: Gradle Build [PREVIOUSLY] Re: Board feedback - Request discuss attic for 
> River
>   12518 by: Phillip Rhodes
> 
> Administrivia:
> 
> -
> To post to the list, e-mail: dev@river.apache.org
> To unsubscribe, e-mail: dev-digest-unsubscr...@river.apache.org
> For additional commands, e-mail: dev-digest-h...@river.apache.org
> 
> --
> 
> 
> From: Phillip Rhodes 
> Subject: Re: Gradle Build [PREVIOUSLY] Re: Board feedback - Request discuss 
> attic for River
> Date: July 1, 2020 at 10:10:29 PM EDT
> To: dev@river.apache.org
> Cc: Michael Sobolewski , dennis.re...@gmail.com
> 
> 
> A Gradle build would be nice. I'm willing to invest some time trying
> to help make it happen if need be. But I am curious.., it looks like
> someone started a Maven build a while back.. From what I can see it
> seems to maybe be incomplete, or just bit-rotted. But depending on the
> details of the state of that work, would there be any reason to prefer
> sticking with maven? (FSM help me, I can't believe I just said that in
> a public forum).
> 
> I'm not the biggest Maven fan in the world, so I only raise this issue
> from the "can we use existing work instead of starting from scratch"
> perspective.
> 
> 
> Phil
> 
> 
> 

Re: Gradle Build [PREVIOUSLY] Re: Board feedback - Request discuss attic for River

[Phillip Rhodes]

A Gradle build would be nice. I'm willing to invest some time trying
to help make it happen if need be. But I am curious.., it looks like
someone started a Maven build a while back.. From what I can see it
seems to maybe be incomplete, or just bit-rotted. But depending on the
details of the state of that work, would there be any reason to prefer
sticking with maven? (FSM help me, I can't believe I just said that in
a public forum).

I'm not the biggest Maven fan in the world, so I only raise this issue
from the "can we use existing work instead of starting from scratch"
perspective.


Phil

Re: Gradle Build [PREVIOUSLY] Re: Board feedback - Request discuss attic for River

[Peter Firmstone]

Excellent, thanks Mike,

Good to have you with us.

Cheers,

Peter.

On 5/28/2020 12:40 AM, Michael Sobolewski wrote:

Hi Peter,

I am still interested. Dennis worked with me on the SORCER/Rio 
integration for a couple years at AFRL/WPAFB. He helped us to 
integrate all projects at the Multidisciplinary Science and Technology 
Center with git/gradle uniform build automation, distributions and 
testing. I do not see another better alternative for River than 
git/gradle.


If Dennis needs my help I am available.

Regards
Mike

On May 27, 2020, at 3:33 AM, Peter Firmstone 
mailto:peter.firmst...@zeus.net.au>> wrote:


Thanks Dan,

Hi Dennis,

I recall Michael from Sorcer Soft (cc'd) also showed interest in a 
Gradle build.


The modular build is here:
https://svn.apache.org/viewvc/river/jtsk/modules/
svn checkout http://svn.apache.org/repos/asf/river/jtsk/modules

Do you still have svn access?   It's a development build, I think 
people would be pleased to see some development action.


The qa test suite is currently an ant build.

Regards,

Peter.


On 5/27/2020 3:40 AM, Dan Rollo wrote:

Regarding a gradle build:
I’m not against a gradle build, but I’m by no means a gradle expert.

For the initial modular build, I think the “opinionated” nature of maven is 
helpful in providing some guard rails, but that could just be a function of me 
having more familiarity with maven.

Dan

Re: Gradle Build [PREVIOUSLY] Re: Board feedback - Request discuss attic for River

[Peter Firmstone]

River's still using SVN.  Feel free to bring that up for discussion or a 
vote if you like, I don't think there will be any resistance to change.



On 5/27/2020 11:01 PM, Dennis Reedy wrote:

Peter,

I’ll try checking that out. One thing, I had thought River switched to 
git? Or is River still using subversion?


Dennis

On May 27, 2020, at 4:33 AM, Peter Firmstone 
 wrote:




Thanks Dan,

Hi Dennis,

I recall Michael from Sorcer Soft (cc'd) also showed interest in a 
Gradle build.


The modular build is here:
https://svn.apache.org/viewvc/river/jtsk/modules/
svn checkout http://svn.apache.org/repos/asf/river/jtsk/modules

Do you still have svn access?   It's a development build, I think 
people would be pleased to see some development action.


The qa test suite is currently an ant build.

Regards,

Peter.


On 5/27/2020 3:40 AM, Dan Rollo wrote:

Regarding a gradle build:
I’m not against a gradle build, but I’m by no means a gradle expert.

For the initial modular build, I think the “opinionated” nature of maven is 
helpful in providing some guard rails, but that could just be a function of me 
having more familiarity with maven.

Dan

Re: Gradle Build [PREVIOUSLY] Re: Board feedback - Request discuss attic for River

[Michael Sobolewski]

Hi Peter,

I am still interested. Dennis worked with me on the SORCER/Rio integration for 
a couple years at AFRL/WPAFB. He helped us to integrate all projects at the 
Multidisciplinary Science and Technology Center with git/gradle uniform build 
automation, distributions and testing. I do not see another better alternative 
for River than git/gradle. 

If Dennis needs my help I am available.

Regards
Mike

> On May 27, 2020, at 3:33 AM, Peter Firmstone  
> wrote:
> 
> Thanks Dan,
> 
> Hi Dennis, 
> 
> I recall Michael from Sorcer Soft (cc'd) also showed interest in a Gradle 
> build. 
> 
> The modular build is here:
> https://svn.apache.org/viewvc/river/jtsk/modules/ 
> 
> svn checkout http://svn.apache.org/repos/asf/river/jtsk/modules
> 
> Do you still have svn access?   It's a development build, I think people 
> would be pleased to see some development action.
> 
> The qa test suite is currently an ant build.
> 
> Regards,
> 
> Peter.
> 
> 
> On 5/27/2020 3:40 AM, Dan Rollo wrote:
>> Regarding a gradle build: 
>> I’m not against a gradle build, but I’m by no means a gradle expert.
>> 
>> For the initial modular build, I think the “opinionated” nature of maven is 
>> helpful in providing some guard rails, but that could just be a function of 
>> me having more familiarity with maven.
>> 
>> Dan
>> 

Re: Gradle Build [PREVIOUSLY] Re: Board feedback - Request discuss attic for River

[Dennis Reedy]

Peter,

Can/should we work off of this repository as well?
https://github.com/apache/river

Dennis

On Wed, May 27, 2020 at 9:01 AM Dennis Reedy  wrote:

> Peter,
>
> I’ll try checking that out. One thing, I had thought River switched to
> git? Or is River still using subversion?
>
> Dennis
>
> On May 27, 2020, at 4:33 AM, Peter Firmstone 
> wrote:
>
> 
>
> Thanks Dan,
>
> Hi Dennis,
>
> I recall Michael from Sorcer Soft (cc'd) also showed interest in a Gradle
> build.
> The modular build is here:
> https://svn.apache.org/viewvc/river/jtsk/modules/
> svn checkout http://svn.apache.org/repos/asf/river/jtsk/modules
>
> Do you still have svn access?   It's a development build, I think people
> would be pleased to see some development action.
>
> The qa test suite is currently an ant build.
> Regards,
>
> Peter.
>
>
> On 5/27/2020 3:40 AM, Dan Rollo wrote:
>
> Regarding a gradle build:
> I’m not against a gradle build, but I’m by no means a gradle expert.
>
> For the initial modular build, I think the “opinionated” nature of maven is 
> helpful in providing some guard rails, but that could just be a function of 
> me having more familiarity with maven.
>
> Dan
>
>
>

Re: Gradle Build [PREVIOUSLY] Re: Board feedback - Request discuss attic for River

[Dennis Reedy]

Peter,

I’ll try checking that out. One thing, I had thought River switched to git? Or 
is River still using subversion?

Dennis

> On May 27, 2020, at 4:33 AM, Peter Firmstone  
> wrote:
> 
> 
> Thanks Dan,
> 
> Hi Dennis, 
> 
> I recall Michael from Sorcer Soft (cc'd) also showed interest in a Gradle 
> build. 
> 
> The modular build is here:
> https://svn.apache.org/viewvc/river/jtsk/modules/
> svn checkout http://svn.apache.org/repos/asf/river/jtsk/modules
> 
> Do you still have svn access?   It's a development build, I think people 
> would be pleased to see some development action.
> 
> The qa test suite is currently an ant build.
> 
> Regards,
> 
> Peter.
> 
> 
>> On 5/27/2020 3:40 AM, Dan Rollo wrote:
>> Regarding a gradle build: 
>> I’m not against a gradle build, but I’m by no means a gradle expert.
>> 
>> For the initial modular build, I think the “opinionated” nature of maven is 
>> helpful in providing some guard rails, but that could just be a function of 
>> me having more familiarity with maven.
>> 
>> Dan
>>