[GitHub] vongosling commented on issue #189: [ROCKETMQ-270] Move flush position forward to first MappedFile whose start offset is non-zero

2017-11-02 Thread GitBox
vongosling commented on issue #189: [ROCKETMQ-270] Move flush position forward to first MappedFile whose start offset is non-zero URL: https://github.com/apache/rocketmq/pull/189#issuecomment-341332092 LGTM This is an

[GitHub] coveralls commented on issue #189: [ROCKETMQ-270] Move flush position forward to first MappedFile whose start offset is non-zero

2017-11-02 Thread GitBox
coveralls commented on issue #189: [ROCKETMQ-270] Move flush position forward to first MappedFile whose start offset is non-zero URL: https://github.com/apache/rocketmq/pull/189#issuecomment-341332822 [![Coverage

[GitHub] zhouxinyu commented on issue #186: [ROCKETMQ-307] Polish the JVM parameters in start scriptes

2017-11-02 Thread GitBox
zhouxinyu commented on issue #186: [ROCKETMQ-307] Polish the JVM parameters in start scriptes URL: https://github.com/apache/rocketmq/pull/186#issuecomment-341335627 Hi, sorry for late. I have last two questions: 1. What's the default value `MetaspaceSize` and

[GitHub] vongosling commented on issue #186: [ROCKETMQ-307] Polish the JVM parameters in start scriptes

2017-11-02 Thread GitBox
vongosling commented on issue #186: [ROCKETMQ-307] Polish the JVM parameters in start scriptes URL: https://github.com/apache/rocketmq/pull/186#issuecomment-341334478 RocektMQ's master branch is not master, could you switch merge branch to develop :-)

[GitHub] johnsonyang commented on issue #186: [ROCKETMQ-307] Polish the JVM parameters in start scriptes

2017-11-02 Thread GitBox
johnsonyang commented on issue #186: [ROCKETMQ-307] Polish the JVM parameters in start scriptes URL: https://github.com/apache/rocketmq/pull/186#issuecomment-341602398 Hi, zhou thanks you feedback quickly! 1. From the jvm arguments view, the `MetaspaceSize` and

[GitHub] zhouxinyu commented on issue #190: add new consumer implement

2017-11-02 Thread GitBox
zhouxinyu commented on issue #190: add new consumer implement URL: https://github.com/apache/rocketmq/pull/190#issuecomment-341608762 Did you mean `CONSUME_FROM_LAST_OFFSET` don't take effect for the broadcast model? BTW, could you please report a JIRA issue before submitting a pull

[GitHub] zhouxinyu commented on issue #186: [ROCKETMQ-307] Polish the JVM parameters in start scriptes

2017-11-02 Thread GitBox
zhouxinyu commented on issue #186: [ROCKETMQ-307] Polish the JVM parameters in start scriptes URL: https://github.com/apache/rocketmq/pull/186#issuecomment-341608562 Thanks, I will merge this PR soon, and please submit PR to `develop` branch next time~ ?

[GitHub] lyy4j commented on issue #190: add new consumer implement

2017-11-02 Thread GitBox
lyy4j commented on issue #190: add new consumer implement URL: https://github.com/apache/rocketmq/pull/190#issuecomment-341610628 @zhouxinyu ,sorry I have modify my commented again . This is an automated message from the

[GitHub] lyy4j commented on issue #190: add new consumer implement

2017-11-02 Thread GitBox
lyy4j commented on issue #190: add new consumer implement URL: https://github.com/apache/rocketmq/pull/190#issuecomment-341611982 I have report JIRA ISSUE(309), would you have check ? @zhouxinyu This is an automated

[GitHub] zhouxinyu closed pull request #186: [ROCKETMQ-307] Polish the JVM parameters in start scriptes

2017-11-02 Thread GitBox
zhouxinyu closed pull request #186: [ROCKETMQ-307] Polish the JVM parameters in start scriptes URL: https://github.com/apache/rocketmq/pull/186 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] zhouxinyu commented on issue #190: [ROCKETMQ-309] Add new consumer implement

2017-11-02 Thread GitBox
zhouxinyu commented on issue #190: [ROCKETMQ-309] Add new consumer implement URL: https://github.com/apache/rocketmq/pull/190#issuecomment-341612261 Thanks, let's discuss in ROCKETMQ-309 first~ This is an automated message

[GitHub] lyy4j opened a new pull request #190: Tag 20171102

2017-11-02 Thread GitBox
lyy4j opened a new pull request #190: Tag 20171102 URL: https://github.com/apache/rocketmq/pull/190 When user use consume client in Broadcast model ,we can pull message only from fist offset. However, we only want to pull message from last offset sometimes, and we can use