[GitHub] vongosling edited a comment on issue #358: [ISSUE #292] Add support of transactional message feature

vongosling edited a comment on issue #358: [ISSUE #292] Add support of transactional message feature URL: https://github.com/apache/rocketmq/pull/358#issuecomment-404109978 LGTM if a rational response to my point out. This is an awesome feature, @lizhanhui @Jaskey @shroman Could we speed

[GitHub] vongosling commented on a change in pull request #358: [ISSUE #292] Add support of transactional message feature

vongosling commented on a change in pull request #358: [ISSUE #292] Add support of transactional message feature URL: https://github.com/apache/rocketmq/pull/358#discussion_r201624161 ## File path: broker/src/main/java/org/apache/rocketmq/broker/client/ProducerManager.java

[GitHub] vongosling commented on a change in pull request #358: [ISSUE #292] Add support of transactional message feature

vongosling commented on a change in pull request #358: [ISSUE #292] Add support of transactional message feature URL: https://github.com/apache/rocketmq/pull/358#discussion_r20162 ## File path: broker/src/main/java/org/apache/rocketmq/broker/client/net/Broker2Client.java

[GitHub] vongosling commented on a change in pull request #358: [ISSUE #292] Add support of transactional message feature

vongosling commented on a change in pull request #358: [ISSUE #292] Add support of transactional message feature URL: https://github.com/apache/rocketmq/pull/358#discussion_r201625741 ## File path:

[GitHub] vongosling commented on a change in pull request #358: [ISSUE #292] Add support of transactional message feature

vongosling commented on a change in pull request #358: [ISSUE #292] Add support of transactional message feature URL: https://github.com/apache/rocketmq/pull/358#discussion_r201625122 ## File path: broker/src/main/java/org/apache/rocketmq/broker/transaction/TransactionRecord.java

[GitHub] vongosling commented on issue #358: [ISSUE #292] Add support of transactional message feature

vongosling commented on issue #358: [ISSUE #292] Add support of transactional message feature URL: https://github.com/apache/rocketmq/pull/358#issuecomment-404363649 @duhengforever Forget to comment, What is the coverage of the new code, over 80%?

[GitHub] coveralls edited a comment on issue #358: [ISSUE #292] Add support of transactional message feature

coveralls edited a comment on issue #358: [ISSUE #292] Add support of transactional message feature URL: https://github.com/apache/rocketmq/pull/358#issuecomment-403372266 [](https://coveralls.io/builds/17945588)