[GitHub] [rocketmq] RongtongJin commented on issue #1887: feat(store): remove extra flush of StoreCheckpoint

RongtongJin commented on issue #1887: feat(store): remove extra flush of StoreCheckpoint URL: https://github.com/apache/rocketmq/pull/1887#issuecomment-604938824 The code is OK, but please create a issue to link this pr and the title of this pr is named as ‘[ISSUE #xxx] Remove extra flush

[GitHub] [rocketmq] RongtongJin commented on issue #1888: feat(broker): check logic move forward for return firstly

RongtongJin commented on issue #1888: feat(broker): check logic move forward for return firstly URL: https://github.com/apache/rocketmq/pull/1888#issuecomment-604939973 Plz create a issue to describe the problem you want to solve and put forward your pr to develop branch.

[GitHub] [rocketmq] RongtongJin closed issue #1886: DefaultMQPushConsumer start invokSync call timeout

RongtongJin closed issue #1886: DefaultMQPushConsumer start invokSync call timeout URL: https://github.com/apache/rocketmq/issues/1886 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [rocketmq] RongtongJin commented on issue #1886: DefaultMQPushConsumer start invokSync call timeout

RongtongJin commented on issue #1886: DefaultMQPushConsumer start invokSync call timeout URL: https://github.com/apache/rocketmq/issues/1886#issuecomment-604940327 I will close the Issue first, but please feel free to reopen it if you have any other issues. Issues are generally used for

[GitHub] [rocketmq] RongtongJin closed issue #1878: There is no unit test of clean IndexFile in DefaultMessageStoreCleanFilesTest.java

RongtongJin closed issue #1878: There is no unit test of clean IndexFile in DefaultMessageStoreCleanFilesTest.java URL: https://github.com/apache/rocketmq/issues/1878 This is an automated message from the Apache Git

[GitHub] [rocketmq] xujianhai666 opened a new pull request #1888: feat(broker): check logic move forward for return firstly

xujianhai666 opened a new pull request #1888: feat(broker): check logic move forward for return firstly URL: https://github.com/apache/rocketmq/pull/1888 This is an automated message from the Apache Git Service. To respond

[GitHub] [rocketmq] xujianhai666 opened a new pull request #1887: feat(store): remove extra flush of StoreCheckpoint

xujianhai666 opened a new pull request #1887: feat(store): remove extra flush of StoreCheckpoint URL: https://github.com/apache/rocketmq/pull/1887 motivation: after review code, I found DefaultMessageStore#shutdown will call storeCheckpoint#flush and storeCheckpoint#shutdown, but

[GitHub] [rocketmq] coveralls commented on issue #1888: feat(broker): check logic move forward for return firstly

coveralls commented on issue #1888: feat(broker): check logic move forward for return firstly URL: https://github.com/apache/rocketmq/pull/1888#issuecomment-604851518 [](https://coveralls.io/builds/29654592) Coverage

[GitHub] [rocketmq] zongtanghu commented on issue #1786: [ISSUE #1689]add interfaces to remove unused statsItems in BrokerStatsManager

zongtanghu commented on issue #1786: [ISSUE #1689]add interfaces to remove unused statsItems in BrokerStatsManager URL: https://github.com/apache/rocketmq/pull/1786#issuecomment-604829924 It looks good, I approve this pr.

[GitHub] [rocketmq] zongtanghu commented on a change in pull request #1824: [ISSUE #1770] Add a query message trace command in mqadmin.

zongtanghu commented on a change in pull request #1824: [ISSUE #1770] Add a query message trace command in mqadmin. URL: https://github.com/apache/rocketmq/pull/1824#discussion_r399054856 ## File path: client/src/main/java/org/apache/rocketmq/client/trace/TraceDataEncoder.java

[GitHub] [rocketmq] zongtanghu commented on issue #1885: fix typo in document (#1866)

zongtanghu commented on issue #1885: fix typo in document (#1866) URL: https://github.com/apache/rocketmq/pull/1885#issuecomment-604835858 Firstly, please put forward your pr to remotes develop branch. This is an automated

[GitHub] [rocketmq] coveralls commented on issue #1887: feat(store): remove extra flush of StoreCheckpoint

coveralls commented on issue #1887: feat(store): remove extra flush of StoreCheckpoint URL: https://github.com/apache/rocketmq/pull/1887#issuecomment-604847327 [](https://coveralls.io/builds/29654435) Coverage

[GitHub] [rocketmq] xujianhai666 opened a new issue #1889: support ringbuffer mode for consumer

xujianhai666 opened a new issue #1889: support ringbuffer mode for consumer URL: https://github.com/apache/rocketmq/issues/1889 **FEATURE REQUEST** 1. Please describe the feature you are requesting. rocketmq consmer has two mode: concurrent and orderly, but sometimes we don`t

[GitHub] [rocketmq] RongtongJin commented on issue #727: Bugfix/update topic perm

RongtongJin commented on issue #727: Bugfix/update topic perm URL: https://github.com/apache/rocketmq/pull/727#issuecomment-604954261 Could you please resolve the conflict？ This is an automated message from the Apache Git

[GitHub] [rocketmq-externals] gripson commented on issue #534: [rocketm-connect-jdbc can't build : maven dependency not added to latest version]

gripson commented on issue #534: [rocketm-connect-jdbc can't build : maven dependency not added to latest version] URL: https://github.com/apache/rocketmq-externals/issues/534#issuecomment-604992221 > I probably need some help. After checking the `rocketmq-replicator` is not in maven

[GitHub] [rocketmq-externals] gripson removed a comment on issue #534: [rocketm-connect-jdbc can't build : maven dependency not added to latest version]

gripson removed a comment on issue #534: [rocketm-connect-jdbc can't build : maven dependency not added to latest version] URL: https://github.com/apache/rocketmq-externals/issues/534#issuecomment-604991535 I also met this problem when I tried to build it. My understanding is we need to

[GitHub] [rocketmq-externals] gripson commented on issue #534: [rocketm-connect-jdbc can't build : maven dependency not added to latest version]

gripson commented on issue #534: [rocketm-connect-jdbc can't build : maven dependency not added to latest version] URL: https://github.com/apache/rocketmq-externals/issues/534#issuecomment-604991535 I also met this problem when I tried to build it. My understanding is we need to add the

Errored: duhenglucky/rocketmq#48 (openmessaging-pubsub - 1cdf49a)

Build Update for duhenglucky/rocketmq - Build: #48 Status: Errored Duration: 2 mins and 2 secs Commit: 1cdf49a (openmessaging-pubsub) Author: duhenglucky Message: feat(OMS) add openmessaging pubsub api support View the changeset:

[GitHub] [rocketmq-externals] gripson edited a comment on issue #534: [rocketm-connect-jdbc can't build : maven dependency not added to latest version]

gripson edited a comment on issue #534: [rocketm-connect-jdbc can't build : maven dependency not added to latest version] URL: https://github.com/apache/rocketmq-externals/issues/534#issuecomment-604992221 > I probably need some help. After checking the `rocketmq-replicator` is not in

[GitHub] [rocketmq] RongtongJin commented on issue #926: [RIP-40] Add test case for LockBatchResponseBody

RongtongJin commented on issue #926: [RIP-40] Add test case for LockBatchResponseBody URL: https://github.com/apache/rocketmq/pull/926#issuecomment-604956138 Besides test, there are other commit records. Could you please handle them?

[GitHub] [rocketmq-externals] imaffe commented on issue #539: [ISSUE #538] Add required field in jdbc connector in code and documentation

imaffe commented on issue #539: [ISSUE #538] Add required field in jdbc connector in code and documentation URL: https://github.com/apache/rocketmq-externals/pull/539#issuecomment-605327419 Because I'm not sure what the sample `source-rocketmq` should look like (probably "127.0.0.1:9876

[GitHub] [rocketmq-externals] imaffe opened a new pull request #539: [ISSUE #538] Add required field in jdbc connector in code and documentation

imaffe opened a new pull request #539: [ISSUE #538] Add required field in jdbc connector in code and documentation URL: https://github.com/apache/rocketmq-externals/pull/539 ## What is the purpose of the change Add 2 required field in jdbc sink connector configuration ##

[GitHub] [rocketmq-externals] imaffe opened a new issue #538: [rocketmq-connect-jdbc: required input not complete]

imaffe opened a new issue #538: [rocketmq-connect-jdbc: required input not complete] URL: https://github.com/apache/rocketmq-externals/issues/538 The issue tracker is **ONLY** used for bug report and feature request. Any question or RocketMQ proposal please use our [mailing

[GitHub] [rocketmq-externals] imaffe opened a new issue #540: [GSoC 2020 rocketmq-connect-runtime enhancement] possible enhancements recorder

imaffe opened a new issue #540: [GSoC 2020 rocketmq-connect-runtime enhancement] possible enhancements recorder URL: https://github.com/apache/rocketmq-externals/issues/540 The issue tracker is **ONLY** used for bug report and feature request. Any question or RocketMQ proposal

[GitHub] [rocketmq-client-go] duffiye opened a new issue #464: [Native]route info not found

duffiye opened a new issue #464: [Native]route info not found URL: https://github.com/apache/rocketmq-client-go/issues/464 "route info not found", the problem only happens sometimes. mostly working well. the topic only one comsumer

[GitHub] [rocketmq-externals] imaffe commented on issue #534: [rocketm-connect-jdbc can't build : maven dependency not added to latest version]

imaffe commented on issue #534: [rocketm-connect-jdbc can't build : maven dependency not added to latest version] URL: https://github.com/apache/rocketmq-externals/issues/534#issuecomment-605088281 > > I probably need some help. After checking the `rocketmq-replicator` is not in maven