[GitHub] Humbedooh commented on issue #180: Release 4.1.0 incubating runserver.sh jvm arguments

2017-10-18 Thread GitBox
Humbedooh commented on issue #180: Release 4.1.0 incubating runserver.sh jvm arguments URL: https://github.com/apache/rocketmq/pull/180#issuecomment-337553243 Looks like it's working now :) This is an automated message from

[GitHub] Humbedooh commented on issue #180: Release 4.1.0 incubating runserver.sh jvm arguments

2017-10-18 Thread GitBox
Humbedooh commented on issue #180: Release 4.1.0 incubating runserver.sh jvm arguments URL: https://github.com/apache/rocketmq/pull/180#issuecomment-337551770 One more test, ignore :) This is an automated message from the

[GitHub] Humbedooh commented on issue #180: Release 4.1.0 incubating runserver.sh jvm arguments

2017-10-18 Thread GitBox
Humbedooh commented on issue #180: Release 4.1.0 incubating runserver.sh jvm arguments URL: https://github.com/apache/rocketmq/pull/180#issuecomment-337551318 testing PR message, ignore me This is an automated message from

[GitHub] Jaskey closed pull request #66: [ROCKETMQ-106] Add flow control on topic level

2017-10-18 Thread GitBox
Jaskey closed pull request #66: [ROCKETMQ-106] Add flow control on topic level URL: https://github.com/apache/rocketmq/pull/66 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] dongeforever commented on issue #180: Release 4.1.0 incubating runserver.sh jvm arguments

2017-10-18 Thread GitBox
dongeforever commented on issue #180: Release 4.1.0 incubating runserver.sh jvm arguments URL: https://github.com/apache/rocketmq/pull/180#issuecomment-337780806 @lirenzuo OK. Thanks for your contribution. To help you integrate into the community, you may want to read the guideline in

[GitHub] dongeforever commented on issue #180: Release 4.1.0 incubating runserver.sh jvm arguments

2017-10-18 Thread GitBox
dongeforever commented on issue #180: Release 4.1.0 incubating runserver.sh jvm arguments URL: https://github.com/apache/rocketmq/pull/180#issuecomment-337781670 I will close this PR. Please feel free to reopen it if you are ready to commit something.

[GitHub] dongeforever closed pull request #180: Release 4.1.0 incubating runserver.sh jvm arguments

2017-10-18 Thread GitBox
dongeforever closed pull request #180: Release 4.1.0 incubating runserver.sh jvm arguments URL: https://github.com/apache/rocketmq/pull/180 This is an automated message from the Apache Git Service. To respond to the

[GitHub] dongeforever commented on issue #169: [ROCKETMQ-292]Delete system.exit in MQAdminStartup

2017-10-18 Thread GitBox
dongeforever commented on issue #169: [ROCKETMQ-292]Delete system.exit in MQAdminStartup URL: https://github.com/apache/rocketmq/pull/169#issuecomment-337581743 LGTM This is an automated message from the Apache Git Service.

[GitHub] lirenzuo opened a new pull request #185: In rocketmq 4.1.0 os.sh

2017-10-24 Thread GitBox
lirenzuo opened a new pull request #185: In rocketmq 4.1.0 os.sh URL: https://github.com/apache/rocketmq/pull/185 when execute 'sh os.sh' is errors: os.sh: line 40: /sys/block//queue/scheduler: ? su: ??admin ??? cat: /sys/block//queue/scheduler: ? os is

[GitHub] zhouxinyu commented on issue #185: In rocketmq 4.1.0 os.sh

2017-10-24 Thread GitBox
zhouxinyu commented on issue #185: In rocketmq 4.1.0 os.sh URL: https://github.com/apache/rocketmq/pull/185#issuecomment-338973821 Hi, please report your issue to [JIRA system](https://issues.apache.org/jira/projects/ROCKETMQ), or user mailing list, thanks.

[GitHub] zhouxinyu closed pull request #185: In rocketmq 4.1.0 os.sh

2017-10-24 Thread GitBox
zhouxinyu closed pull request #185: In rocketmq 4.1.0 os.sh URL: https://github.com/apache/rocketmq/pull/185 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] lizhanhui opened a new pull request #195: [ROCKETMQ-317] Take advantage of Linux native libaio

2017-11-23 Thread GitBox
lizhanhui opened a new pull request #195: [ROCKETMQ-317] Take advantage of Linux native libaio URL: https://github.com/apache/rocketmq/pull/195 ## What is the purpose of the change This PR is to make use of the Linux native libaio interfaces in cases where mmap commit log files are

[GitHub] vongosling commented on issue #192: [ROCKETMQ-312] Use independent thread pool for QueryMessageProcessor

2017-11-23 Thread GitBox
vongosling commented on issue #192: [ROCKETMQ-312] Use independent thread pool for QueryMessageProcessor URL: https://github.com/apache/rocketmq/pull/192#issuecomment-346613798 +1 This is an automated message from the Apache

[GitHub] lizhanhui commented on issue #195: [ROCKETMQ-317] Take advantage of Linux native libaio

2017-11-23 Thread GitBox
lizhanhui commented on issue #195: [ROCKETMQ-317] Take advantage of Linux native libaio URL: https://github.com/apache/rocketmq/pull/195#issuecomment-346627882 @zhouxinyu @dongeforever @vintagewang This is an automated

[GitHub] fuyou001 opened a new pull request #196: [ROCKETMQ-314] msg send back must sync change process queue msg size

2017-11-26 Thread GitBox
fuyou001 opened a new pull request #196: [ROCKETMQ-314] msg send back must sync change process queue msg size URL: https://github.com/apache/rocketmq/pull/196 ## What is the purpose of the change when msg process expired, msg send back must sync change process queue msg size .

[GitHub] coveralls commented on issue #196: [ROCKETMQ-314] msg send back must sync change process queue msg size

2017-11-26 Thread GitBox
coveralls commented on issue #196: [ROCKETMQ-314] msg send back must sync change process queue msg size URL: https://github.com/apache/rocketmq/pull/196#issuecomment-347090738 [![Coverage Status](https://coveralls.io/builds/14374766/badge)](https://coveralls.io/builds/14374766)

[GitHub] dongeforever opened a new pull request #198: [ROCKETMQ-321] Fix deleting files in the middle

2017-11-30 Thread GitBox
dongeforever opened a new pull request #198: [ROCKETMQ-321] Fix deleting files in the middle URL: https://github.com/apache/rocketmq/pull/198 ## What is the purpose of the change Avoid deleting files in the middle. Follow this checklist to help us incorporate your

[GitHub] coveralls commented on issue #197: [ROCKETMQ-320] Message loss when shutdown with dispatch behind

2017-11-30 Thread GitBox
coveralls commented on issue #197: [ROCKETMQ-320] Message loss when shutdown with dispatch behind URL: https://github.com/apache/rocketmq/pull/197#issuecomment-348185096 [![Coverage Status](https://coveralls.io/builds/14437995/badge)](https://coveralls.io/builds/14437995)

[GitHub] coveralls commented on issue #198: [ROCKETMQ-321] Fix deleting files in the middle

2017-11-30 Thread GitBox
coveralls commented on issue #198: [ROCKETMQ-321] Fix deleting files in the middle URL: https://github.com/apache/rocketmq/pull/198#issuecomment-348186986 [![Coverage Status](https://coveralls.io/builds/14438036/badge)](https://coveralls.io/builds/14438036) Coverage increased

[GitHub] coveralls commented on issue #199: [ROCKETMQ-308] Increasing name server component network socket buffer size

2017-11-30 Thread GitBox
coveralls commented on issue #199: [ROCKETMQ-308] Increasing name server component network socket buffer size URL: https://github.com/apache/rocketmq/pull/199#issuecomment-348187792 [![Coverage Status](https://coveralls.io/builds/14438157/badge)](https://coveralls.io/builds/14438157)

[GitHub] dongeforever opened a new pull request #197: [Rocketmq-320]Message loss when shutdown with dispatch behind

2017-11-30 Thread GitBox
dongeforever opened a new pull request #197: [Rocketmq-320]Message loss when shutdown with dispatch behind URL: https://github.com/apache/rocketmq/pull/197 ## What is the purpose of the change Avoid message loss when shutdown with dispatch behind Follow this checklist to

[GitHub] zhouxinyu commented on a change in pull request #198: [ROCKETMQ-321] Fix deleting files in the middle

2017-11-30 Thread GitBox
zhouxinyu commented on a change in pull request #198: [ROCKETMQ-321] Fix deleting files in the middle URL: https://github.com/apache/rocketmq/pull/198#discussion_r154075283 ## File path: store/src/main/java/org/apache/rocketmq/store/MappedFile.java ## @@ -570,6 +570,11 @@

[GitHub] vongosling closed pull request #147: [ROCKETMQ-266] Add a specific Exception message for comparing consumerThreadMax and consumerThreadMin

2017-12-13 Thread GitBox
vongosling closed pull request #147: [ROCKETMQ-266] Add a specific Exception message for comparing consumerThreadMax and consumerThreadMin URL: https://github.com/apache/rocketmq/pull/147 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[GitHub] vongosling closed pull request #198: [ROCKETMQ-321] Fix deleting files in the middle

2017-12-13 Thread GitBox
vongosling closed pull request #198: [ROCKETMQ-321] Fix deleting files in the middle URL: https://github.com/apache/rocketmq/pull/198 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] dongeforever commented on issue #199: [ROCKETMQ-308] Increasing name server component network socket buffer size

2017-12-13 Thread GitBox
dongeforever commented on issue #199: [ROCKETMQ-308] Increasing name server component network socket buffer size URL: https://github.com/apache/rocketmq/pull/199#issuecomment-351340831 LGTM This is an automated message from

[GitHub] coveralls commented on issue #152: [ROCKETMQ-278] Add clusterlist cmd by specified cluster

2017-12-13 Thread GitBox
coveralls commented on issue #152: [ROCKETMQ-278] Add clusterlist cmd by specified cluster URL: https://github.com/apache/rocketmq/pull/152#issuecomment-351350856 [![Coverage Status](https://coveralls.io/builds/14633535/badge)](https://coveralls.io/builds/14633535) Changes

[GitHub] vongosling closed pull request #146: [ROCKETMQ-265] fix consume queue?s data maybe repeat bug

2017-12-13 Thread GitBox
vongosling closed pull request #146: [ROCKETMQ-265] fix consume queue?s data maybe repeat bug URL: https://github.com/apache/rocketmq/pull/146 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] vongosling closed pull request #191: [ROCKETMQ-311] Add pull request fast failure mechanism for broker

2017-12-13 Thread GitBox
vongosling closed pull request #191: [ROCKETMQ-311] Add pull request fast failure mechanism for broker URL: https://github.com/apache/rocketmq/pull/191 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] lindzh commented on a change in pull request #152: [ROCKETMQ-278] Add clusterlist cmd by specified cluster

2017-12-13 Thread GitBox
lindzh commented on a change in pull request #152: [ROCKETMQ-278] Add clusterlist cmd by specified cluster URL: https://github.com/apache/rocketmq/pull/152#discussion_r156605033 ## File path: tools/src/main/java/org/apache/rocketmq/tools/command/topic/TopicListSubCommand.java

[GitHub] vongosling closed pull request #202: [ROCKETMQ-315][ROCKETMQ-327] Enhance TLS feature

2017-12-13 Thread GitBox
vongosling closed pull request #202: [ROCKETMQ-315][ROCKETMQ-327] Enhance TLS feature URL: https://github.com/apache/rocketmq/pull/202 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] vongosling commented on issue #199: [ROCKETMQ-308] Increasing name server component network socket buffer size

2017-12-13 Thread GitBox
vongosling commented on issue #199: [ROCKETMQ-308] Increasing name server component network socket buffer size URL: https://github.com/apache/rocketmq/pull/199#issuecomment-348851247 Do we consider to delete socketSndbufSize configuration from class NettySystemConfig.

[GitHub] vongosling closed pull request #199: [ROCKETMQ-308] Increasing name server component network socket buffer size

2017-12-13 Thread GitBox
vongosling closed pull request #199: [ROCKETMQ-308] Increasing name server component network socket buffer size URL: https://github.com/apache/rocketmq/pull/199 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] vongosling closed pull request #197: [ROCKETMQ-320] Message loss when shutdown with dispatch behind

2017-12-13 Thread GitBox
vongosling closed pull request #197: [ROCKETMQ-320] Message loss when shutdown with dispatch behind URL: https://github.com/apache/rocketmq/pull/197 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] dongeforever commented on a change in pull request #189: [ROCKETMQ-270] Move flush position forward to first MappedFile whose start offset is non-zero

2017-12-13 Thread GitBox
dongeforever commented on a change in pull request #189: [ROCKETMQ-270] Move flush position forward to first MappedFile whose start offset is non-zero URL: https://github.com/apache/rocketmq/pull/189#discussion_r156599664 ## File path:

[GitHub] vongosling closed pull request #189: [ROCKETMQ-270] Move flush position forward to first MappedFile whose start offset is non-zero

2017-12-13 Thread GitBox
vongosling closed pull request #189: [ROCKETMQ-270] Move flush position forward to first MappedFile whose start offset is non-zero URL: https://github.com/apache/rocketmq/pull/189 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed

[GitHub] dongeforever commented on a change in pull request #189: [ROCKETMQ-270] Move flush position forward to first MappedFile whose start offset is non-zero

2017-12-13 Thread GitBox
dongeforever commented on a change in pull request #189: [ROCKETMQ-270] Move flush position forward to first MappedFile whose start offset is non-zero URL: https://github.com/apache/rocketmq/pull/189#discussion_r156599664 ## File path:

[GitHub] vongosling closed pull request #121: [ROCKETMQ-226]Remove the code that is not useful in the loop

2017-12-13 Thread GitBox
vongosling closed pull request #121: [ROCKETMQ-226]Remove the code that is not useful in the loop URL: https://github.com/apache/rocketmq/pull/121 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] zhouxinyu opened a new pull request #207: [ROCKETMQ-335] Reload server certificate, private key and root ca when these are changed

2017-12-17 Thread GitBox
zhouxinyu opened a new pull request #207: [ROCKETMQ-335] Reload server certificate, private key and root ca when these are changed URL: https://github.com/apache/rocketmq/pull/207 ## What is the purpose of the change JIRA: https://issues.apache.org/jira/browse/ROCKETMQ-335

[GitHub] fucongchan opened a new pull request #206: spinlock performance improvement

2017-12-16 Thread GitBox
fucongchan opened a new pull request #206: spinlock performance improvement URL: https://github.com/apache/rocketmq/pull/206 ## What is the purpose of the change spin lock performance improvement ## Brief changelog CLH spinlock ## Verifying this change

[GitHub] coveralls commented on issue #206: [ROCKETMQ-334] spinlock performance improvement

2017-12-16 Thread GitBox
coveralls commented on issue #206: [ROCKETMQ-334] spinlock performance improvement URL: https://github.com/apache/rocketmq/pull/206#issuecomment-352217864 [![Coverage Status](https://coveralls.io/builds/14689776/badge)](https://coveralls.io/builds/14689776) Coverage increased

[GitHub] lizhanhui commented on a change in pull request #207: [ROCKETMQ-335] Reload server certificate, private key and root ca when these are changed

2017-12-18 Thread GitBox
lizhanhui commented on a change in pull request #207: [ROCKETMQ-335] Reload server certificate, private key and root ca when these are changed URL: https://github.com/apache/rocketmq/pull/207#discussion_r157440960 ## File path:

[GitHub] dongeforever commented on a change in pull request #127: [ROCKETMQ-233] Fix pull interval issue

2017-12-13 Thread GitBox
dongeforever commented on a change in pull request #127: [ROCKETMQ-233] Fix pull interval issue URL: https://github.com/apache/rocketmq/pull/127#discussion_r156645862 ## File path: client/src/main/java/org/apache/rocketmq/client/consumer/DefaultMQPushConsumer.java ## @@

[GitHub] zhouxinyu closed pull request #142: [ROCKETMQ-255] Fix offsetStore being null after consumers start()

2017-12-13 Thread GitBox
zhouxinyu closed pull request #142: [ROCKETMQ-255] Fix offsetStore being null after consumers start() URL: https://github.com/apache/rocketmq/pull/142 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] Jason918 commented on issue #178: [ROCKETMQ-290] Fix memory leak in WaitNotifyObject#waitingThreadTable

2017-12-14 Thread GitBox
Jason918 commented on issue #178: [ROCKETMQ-290] Fix memory leak in WaitNotifyObject#waitingThreadTable URL: https://github.com/apache/rocketmq/pull/178#issuecomment-351899059 @zhouxinyu Unit tests added, please check these out.

[GitHub] Jason918 commented on issue #178: [ROCKETMQ-290] Fix memory leak in WaitNotifyObject#waitingThreadTable

2017-12-14 Thread GitBox
Jason918 commented on issue #178: [ROCKETMQ-290] Fix memory leak in WaitNotifyObject#waitingThreadTable URL: https://github.com/apache/rocketmq/pull/178#issuecomment-351899059 @zhouxinyu Unit tests added, please check these out. This bug actually has major impact on the performance

[GitHub] Jason918 commented on issue #178: [ROCKETMQ-290] Fix memory leak in WaitNotifyObject#waitingThreadTable

2017-12-14 Thread GitBox
Jason918 commented on issue #178: [ROCKETMQ-290] Fix memory leak in WaitNotifyObject#waitingThreadTable URL: https://github.com/apache/rocketmq/pull/178#issuecomment-351899059 @zhouxinyu Unit tests added, please check these out. This bug actually has major impact on the performance

[GitHub] Jason918 commented on issue #178: [ROCKETMQ-290] Fix memory leak in WaitNotifyObject#waitingThreadTable

2017-12-14 Thread GitBox
Jason918 commented on issue #178: [ROCKETMQ-290] Fix memory leak in WaitNotifyObject#waitingThreadTable URL: https://github.com/apache/rocketmq/pull/178#issuecomment-351899059 @zhouxinyu Unit tests added, please check these out. This bug actually has major impact on the performance

[GitHub] coveralls commented on issue #204: Release 4.2.0

2017-12-14 Thread GitBox
coveralls commented on issue #204: Release 4.2.0 URL: https://github.com/apache/rocketmq/pull/204#issuecomment-351888517 [![Coverage Status](https://coveralls.io/builds/14667591/badge)](https://coveralls.io/builds/14667591) Coverage increased (+0.07%) to 39.988% when pulling

[GitHub] crossupas closed pull request #204: Release 4.2.0

2017-12-14 Thread GitBox
crossupas closed pull request #204: Release 4.2.0 URL: https://github.com/apache/rocketmq/pull/204 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] fuyou001 opened a new pull request #205: [ROCKETMQ-319] improve broker register performance and reduce memory usage

2017-12-14 Thread GitBox
fuyou001 opened a new pull request #205: [ROCKETMQ-319] improve broker register performance and reduce memory usage URL: https://github.com/apache/rocketmq/pull/205 ## What is the purpose of the change improve broker register performance and reduce memory usage ## Brief changelog

[GitHub] coveralls commented on issue #205: [ROCKETMQ-319] improve broker register performance and reduce memory usage

2017-12-14 Thread GitBox
coveralls commented on issue #205: [ROCKETMQ-319] improve broker register performance and reduce memory usage URL: https://github.com/apache/rocketmq/pull/205#issuecomment-351921666 [![Coverage Status](https://coveralls.io/builds/14669536/badge)](https://coveralls.io/builds/14669536)

[GitHub] lizhanhui commented on issue #203: [ROCKETMQ-331] Make DLQ queue nums configurable

2017-12-15 Thread GitBox
lizhanhui commented on issue #203: [ROCKETMQ-331] Make DLQ queue nums configurable URL: https://github.com/apache/rocketmq/pull/203#issuecomment-352001169 Good catch This is an automated message from the Apache Git Service.

[GitHub] lindzh opened a new pull request #203: [ROCKETMQ-331] Make DLQ queue nums configurable

2017-12-13 Thread GitBox
lindzh opened a new pull request #203: [ROCKETMQ-331] Make DLQ queue nums configurable URL: https://github.com/apache/rocketmq/pull/203 ## What is the purpose of the change As DLQ queue nums is configured to static as ``` protected final static int DLQ_NUMS_PER_GROUP = 1;

[GitHub] coveralls commented on issue #203: [ROCKETMQ-331] Make DLQ queue nums configurable

2017-12-13 Thread GitBox
coveralls commented on issue #203: [ROCKETMQ-331] Make DLQ queue nums configurable URL: https://github.com/apache/rocketmq/pull/203#issuecomment-351620199 [![Coverage Status](https://coveralls.io/builds/14650599/badge)](https://coveralls.io/builds/14650599) Coverage decreased

[GitHub] lindzh commented on a change in pull request #129: [ROCKETMQ-239]fix query message by time and fix get queue offset by time

2017-12-13 Thread GitBox
lindzh commented on a change in pull request #129: [ROCKETMQ-239]fix query message by time and fix get queue offset by time URL: https://github.com/apache/rocketmq/pull/129#discussion_r156864077 ## File path: store/src/main/java/org/apache/rocketmq/store/MessageStore.java

[GitHub] coveralls commented on issue #129: [ROCKETMQ-239]fix query message by time and fix get queue offset by time

2017-12-13 Thread GitBox
coveralls commented on issue #129: [ROCKETMQ-239]fix query message by time and fix get queue offset by time URL: https://github.com/apache/rocketmq/pull/129#issuecomment-351621696 [![Coverage Status](https://coveralls.io/builds/14650673/badge)](https://coveralls.io/builds/14650673)

[GitHub] dongeforever closed pull request #60: [ROCKETMQ-96]Rename some temp variable and field

2017-12-13 Thread GitBox
dongeforever closed pull request #60: [ROCKETMQ-96]Rename some temp variable and field URL: https://github.com/apache/rocketmq/pull/60 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] dongeforever commented on issue #60: [ROCKETMQ-96]Rename some temp variable and field

2017-12-13 Thread GitBox
dongeforever commented on issue #60: [ROCKETMQ-96]Rename some temp variable and field URL: https://github.com/apache/rocketmq/pull/60#issuecomment-351373252 This PR has been merged This is an automated message from the

[GitHub] lindzh commented on issue #129: [ROCKETMQ-239]fix query message by time and fix get queue offset by time

2017-12-14 Thread GitBox
lindzh commented on issue #129: [ROCKETMQ-239]fix query message by time and fix get queue offset by time URL: https://github.com/apache/rocketmq/pull/129#issuecomment-351691984 Please help a review,Accuracy message offset search by store time has been fixed.

[GitHub] lizhanhui commented on issue #207: [ROCKETMQ-335] Reload server certificate, private key and root ca when these are changed

2017-12-19 Thread GitBox
lizhanhui commented on issue #207: [ROCKETMQ-335] Reload server certificate, private key and root ca when these are changed URL: https://github.com/apache/rocketmq/pull/207#issuecomment-352968905 I am OK. +1 to merge it.

[GitHub] vongosling closed pull request #28: [ROCKETMQ-27]Add store commitlog path online

2017-12-20 Thread GitBox
vongosling closed pull request #28: [ROCKETMQ-27]Add store commitlog path online URL: https://github.com/apache/rocketmq/pull/28 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] vongosling commented on issue #106: [ROCKETMQ-202] Using the native transport

2017-12-19 Thread GitBox
vongosling commented on issue #106: [ROCKETMQ-202] Using the native transport URL: https://github.com/apache/rocketmq/pull/106#issuecomment-352991289 Associate with #195 @lizhanhui @shroman I close this pr, we could make a collaborative search for native AIO transport polish :-)

[GitHub] vongosling commented on issue #208: [ROCKETMQ-336] Wrong format System.out.printf used in mqadmin

2017-12-19 Thread GitBox
vongosling commented on issue #208: [ROCKETMQ-336] Wrong format System.out.printf used in mqadmin URL: https://github.com/apache/rocketmq/pull/208#issuecomment-352976776 @shroman I guess it is an old version bug before we donated it to apache :-)

[GitHub] vongosling closed pull request #208: [ROCKETMQ-336] Wrong format System.out.printf used in mqadmin

2017-12-19 Thread GitBox
vongosling closed pull request #208: [ROCKETMQ-336] Wrong format System.out.printf used in mqadmin URL: https://github.com/apache/rocketmq/pull/208 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] vongosling closed pull request #207: [ROCKETMQ-335] Reload server certificate, private key and root ca when these are changed

2017-12-19 Thread GitBox
vongosling closed pull request #207: [ROCKETMQ-335] Reload server certificate, private key and root ca when these are changed URL: https://github.com/apache/rocketmq/pull/207 This is an automated message from the Apache Git

[GitHub] zhouxinyu commented on a change in pull request #202: [ROCKETMQ-315][ROCKETMQ-327] Enhance TLS feature

2017-12-12 Thread GitBox
zhouxinyu commented on a change in pull request #202: [ROCKETMQ-315][ROCKETMQ-327] Enhance TLS feature URL: https://github.com/apache/rocketmq/pull/202#discussion_r156338276 ## File path: remoting/src/main/java/org/apache/rocketmq/remoting/netty/TlsHelper.java ## @@ -0,0

[GitHub] zhouxinyu commented on issue #188: [ROCKETMQ-308] Increasing name server component network socket buffer size

2017-11-16 Thread GitBox
zhouxinyu commented on issue #188: [ROCKETMQ-308] Increasing name server component network socket buffer size URL: https://github.com/apache/rocketmq/pull/188#issuecomment-344915627 I changed the target branch, but it seems your PR is based on the wrong codebase, please help fix it.

[GitHub] zhouxinyu commented on issue #190: [ROCKETMQ-309] Add new consumer implement

2017-11-16 Thread GitBox
zhouxinyu commented on issue #190: [ROCKETMQ-309] Add new consumer implement URL: https://github.com/apache/rocketmq/pull/190#issuecomment-344915266 Yes, It's exactly expected, `CONSUME_FROM_LAST_OFFSET` only take effect at the first subscription action of the consumer, you can reset the

[GitHub] zhouxinyu commented on issue #178: [ROCKETMQ-290] Fix memory leak in WaitNotifyObject#waitingThreadTable

2017-11-16 Thread GitBox
zhouxinyu commented on issue #178: [ROCKETMQ-290] Fix memory leak in WaitNotifyObject#waitingThreadTable URL: https://github.com/apache/rocketmq/pull/178#issuecomment-344916027 Hi @Jason918, we need some unit tests to cover your commit~ ?

[GitHub] zhouxinyu commented on issue #165: [ROCKETMQ-296] fix DefaultMessageStoreTest bug: wait more time for consume queue build

2017-11-13 Thread GitBox
zhouxinyu commented on issue #165: [ROCKETMQ-296] fix DefaultMessageStoreTest bug: wait more time for consume queue build URL: https://github.com/apache/rocketmq/pull/165#issuecomment-344158434 Hi, thanks to your contribution sincerely, Maybe add a notify/wait mechanism to wait util the

[GitHub] lyy4j commented on issue #190: [ROCKETMQ-309] Add new consumer implement

2017-11-14 Thread GitBox
lyy4j commented on issue #190: [ROCKETMQ-309] Add new consumer implement URL: https://github.com/apache/rocketmq/pull/190#issuecomment-344184738 what about the result of this pull request? @zhouxinyu This is an automated

[GitHub] Jaskey commented on issue #95: [ROCKETMQ-184]-It takes too long(3-33 seconds) to switch to read from slave when master crashes

2017-11-13 Thread GitBox
Jaskey commented on issue #95: [ROCKETMQ-184]-It takes too long(3-33 seconds) to switch to read from slave when master crashes URL: https://github.com/apache/rocketmq/pull/95#issuecomment-344140091 This pr is not updated from the source for long, so I updated just now , please review.

[GitHub] Jaskey commented on issue #95: [ROCKETMQ-184]-It takes too long(3-33 seconds) to switch to read from slave when master crashes

2017-11-13 Thread GitBox
Jaskey commented on issue #95: [ROCKETMQ-184]-It takes too long(3-33 seconds) to switch to read from slave when master crashes URL: https://github.com/apache/rocketmq/pull/95#issuecomment-344140091 This pr is not updated from the source for long, so I updated just now , please review.

[GitHub] wenweihu86 commented on issue #165: [ROCKETMQ-296] fix DefaultMessageStoreTest bug: wait more time for consume queue build

2017-11-14 Thread GitBox
wenweihu86 commented on issue #165: [ROCKETMQ-296] fix DefaultMessageStoreTest bug: wait more time for consume queue build URL: https://github.com/apache/rocketmq/pull/165#issuecomment-344194223 @zhouxinyu Yes, it is better to use condition variable, but it is just a unit case, so just

[GitHub] fuyou001 opened a new pull request #193: [ROCKETMQ-314] msg send back must sync change process queue msg size

2017-11-21 Thread GitBox
fuyou001 opened a new pull request #193: [ROCKETMQ-314] msg send back must sync change process queue msg size URL: https://github.com/apache/rocketmq/pull/193 ## What is the purpose of the change when msg process expired, msg send back must sync change process queue msg size .

[GitHub] coveralls commented on issue #193: [ROCKETMQ-314] msg send back must sync change process queue msg size

2017-11-21 Thread GitBox
coveralls commented on issue #193: [ROCKETMQ-314] msg send back must sync change process queue msg size URL: https://github.com/apache/rocketmq/pull/193#issuecomment-345950616 [![Coverage Status](https://coveralls.io/builds/14300610/badge)](https://coveralls.io/builds/14300610)

[GitHub] coveralls commented on issue #178: [ROCKETMQ-290] Fix memory leak in WaitNotifyObject#waitingThreadTable

2017-11-18 Thread GitBox
coveralls commented on issue #178: [ROCKETMQ-290] Fix memory leak in WaitNotifyObject#waitingThreadTable URL: https://github.com/apache/rocketmq/pull/178#issuecomment-345496888 [![Coverage Status](https://coveralls.io/builds/14272196/badge)](https://coveralls.io/builds/14272196)

[GitHub] lizhanhui opened a new pull request #194: [ROCKETMQ-315]Enhance TLS default settings

2017-11-21 Thread GitBox
lizhanhui opened a new pull request #194: [ROCKETMQ-315]Enhance TLS default settings URL: https://github.com/apache/rocketmq/pull/194 Let broker connect nameserver using non-encrypted channel if permissive is adopted ## What is the purpose of the change Purpose of this Pull

[GitHub] coveralls commented on issue #194: [ROCKETMQ-315]Enhance TLS default settings

2017-11-21 Thread GitBox
coveralls commented on issue #194: [ROCKETMQ-315]Enhance TLS default settings URL: https://github.com/apache/rocketmq/pull/194#issuecomment-346021477 [![Coverage Status](https://coveralls.io/builds/14304711/badge)](https://coveralls.io/builds/14304711) Coverage increased

[GitHub] zhouxinyu opened a new pull request #191: [ROCKETMQ-311] Add pull request fast failure mechanism for broker

2017-11-06 Thread GitBox
zhouxinyu opened a new pull request #191: [ROCKETMQ-311] Add pull request fast failure mechanism for broker URL: https://github.com/apache/rocketmq/pull/191 ## What is the purpose of the change Now, the broker will reject send message requests when the waiting time is too long at

[GitHub] fuyou001 opened a new pull request #188: Rocketmq 308

2017-11-01 Thread GitBox
fuyou001 opened a new pull request #188: Rocketmq 308 URL: https://github.com/apache/rocketmq/pull/188 ## What is the purpose of the change increasing name server component network socket buffer, improve broker register speed ## Brief changelog delete `NamesrvStartup ` set

[GitHub] johnsonyang commented on issue #186: [ROCKETMQ-307] Fix two issues

2017-11-01 Thread GitBox
johnsonyang commented on issue #186: [ROCKETMQ-307] Fix two issues URL: https://github.com/apache/rocketmq/pull/186#issuecomment-341319944 Hi, zhou the pr pending still! This is an automated message from the Apache Git

[GitHub] vongosling commented on issue #189: [ROCKETMQ-270] Move flush position forward to first MappedFile whose start offset is non-zero

2017-11-02 Thread GitBox
vongosling commented on issue #189: [ROCKETMQ-270] Move flush position forward to first MappedFile whose start offset is non-zero URL: https://github.com/apache/rocketmq/pull/189#issuecomment-341332092 LGTM This is an

[GitHub] zhouxinyu opened a new pull request #189: [ROCKETMQ-270] Move flush position forward to first MappedFile whose start offset is non-zero

2017-11-02 Thread GitBox
zhouxinyu opened a new pull request #189: [ROCKETMQ-270] Move flush position forward to first MappedFile whose start offset is non-zero URL: https://github.com/apache/rocketmq/pull/189 ## What is the purpose of the change To resolve the issue

[GitHub] coveralls commented on issue #189: [ROCKETMQ-270] Move flush position forward to first MappedFile whose start offset is non-zero

2017-11-02 Thread GitBox
coveralls commented on issue #189: [ROCKETMQ-270] Move flush position forward to first MappedFile whose start offset is non-zero URL: https://github.com/apache/rocketmq/pull/189#issuecomment-341332822 [![Coverage

[GitHub] coveralls commented on issue #188: Rocketmq 308

2017-11-01 Thread GitBox
coveralls commented on issue #188: Rocketmq 308 URL: https://github.com/apache/rocketmq/pull/188#issuecomment-341309722 [![Coverage Status](https://coveralls.io/builds/13999719/badge)](https://coveralls.io/builds/13999719) Coverage increased (+0.1%) to 38.896% when pulling

[GitHub] aCoder2013 closed pull request #187: [ROCKETMQ-306] Improve thread name

2017-11-01 Thread GitBox
aCoder2013 closed pull request #187: [ROCKETMQ-306] Improve thread name URL: https://github.com/apache/rocketmq/pull/187 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] zhouxinyu commented on issue #186: [ROCKETMQ-307] Polish the JVM parameters in start scriptes

2017-11-02 Thread GitBox
zhouxinyu commented on issue #186: [ROCKETMQ-307] Polish the JVM parameters in start scriptes URL: https://github.com/apache/rocketmq/pull/186#issuecomment-341335627 Hi, sorry for late. I have last two questions: 1. What's the default value `MetaspaceSize` and

[GitHub] vongosling commented on issue #186: [ROCKETMQ-307] Polish the JVM parameters in start scriptes

2017-11-02 Thread GitBox
vongosling commented on issue #186: [ROCKETMQ-307] Polish the JVM parameters in start scriptes URL: https://github.com/apache/rocketmq/pull/186#issuecomment-341334478 RocektMQ's master branch is not master, could you switch merge branch to develop :-)

[GitHub] johnsonyang commented on issue #186: [ROCKETMQ-307] Polish the JVM parameters in start scriptes

2017-11-02 Thread GitBox
johnsonyang commented on issue #186: [ROCKETMQ-307] Polish the JVM parameters in start scriptes URL: https://github.com/apache/rocketmq/pull/186#issuecomment-341602398 Hi, zhou thanks you feedback quickly! 1. From the jvm arguments view, the `MetaspaceSize` and

[GitHub] zhouxinyu commented on issue #190: add new consumer implement

2017-11-02 Thread GitBox
zhouxinyu commented on issue #190: add new consumer implement URL: https://github.com/apache/rocketmq/pull/190#issuecomment-341608762 Did you mean `CONSUME_FROM_LAST_OFFSET` don't take effect for the broadcast model? BTW, could you please report a JIRA issue before submitting a pull

[GitHub] zhouxinyu commented on issue #186: [ROCKETMQ-307] Polish the JVM parameters in start scriptes

2017-11-02 Thread GitBox
zhouxinyu commented on issue #186: [ROCKETMQ-307] Polish the JVM parameters in start scriptes URL: https://github.com/apache/rocketmq/pull/186#issuecomment-341608562 Thanks, I will merge this PR soon, and please submit PR to `develop` branch next time~ ?

[GitHub] lyy4j commented on issue #190: add new consumer implement

2017-11-02 Thread GitBox
lyy4j commented on issue #190: add new consumer implement URL: https://github.com/apache/rocketmq/pull/190#issuecomment-341610628 @zhouxinyu ,sorry I have modify my commented again . This is an automated message from the

[GitHub] lyy4j commented on issue #190: add new consumer implement

2017-11-02 Thread GitBox
lyy4j commented on issue #190: add new consumer implement URL: https://github.com/apache/rocketmq/pull/190#issuecomment-341611982 I have report JIRA ISSUE(309), would you have check ? @zhouxinyu This is an automated

[GitHub] zhouxinyu closed pull request #186: [ROCKETMQ-307] Polish the JVM parameters in start scriptes

2017-11-02 Thread GitBox
zhouxinyu closed pull request #186: [ROCKETMQ-307] Polish the JVM parameters in start scriptes URL: https://github.com/apache/rocketmq/pull/186 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] zhouxinyu commented on issue #190: [ROCKETMQ-309] Add new consumer implement

2017-11-02 Thread GitBox
zhouxinyu commented on issue #190: [ROCKETMQ-309] Add new consumer implement URL: https://github.com/apache/rocketmq/pull/190#issuecomment-341612261 Thanks, let's discuss in ROCKETMQ-309 first~ This is an automated message

[GitHub] zhouxinyu opened a new pull request #192: [ROCKETMQ-312] Use independent thread pool for QueryMessageProcessor

2017-11-07 Thread GitBox
zhouxinyu opened a new pull request #192: [ROCKETMQ-312] Use independent thread pool for QueryMessageProcessor URL: https://github.com/apache/rocketmq/pull/192 ## What is the purpose of the change Resolve issue [ROCKETMQ-312](https://issues.apache.org/jira/browse/ROCKETMQ-312). >

[GitHub] coveralls commented on issue #192: [ROCKETMQ-312] Use independent thread pool for QueryMessageProcessor

2017-11-07 Thread GitBox
coveralls commented on issue #192: [ROCKETMQ-312] Use independent thread pool for QueryMessageProcessor URL: https://github.com/apache/rocketmq/pull/192#issuecomment-342724466 [![Coverage Status](https://coveralls.io/builds/14091719/badge)](https://coveralls.io/builds/14091719)

[GitHub] lyy4j opened a new pull request #190: Tag 20171102

2017-11-02 Thread GitBox
lyy4j opened a new pull request #190: Tag 20171102 URL: https://github.com/apache/rocketmq/pull/190 When user use consume client in Broadcast model ,we can pull message only from fist offset. However, we only want to pull message from last offset sometimes, and we can use

[GitHub] zhouxinyu closed pull request #201: [ROCKETMQ-324] Expose an interface for client to specify the async call back executor

2017-12-08 Thread GitBox
zhouxinyu closed pull request #201: [ROCKETMQ-324] Expose an interface for client to specify the async call back executor URL: https://github.com/apache/rocketmq/pull/201 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

  1   2   3   4   5   6   7   8   9   10   >