[GitHub] [rocketmq-spring] vongosling edited a comment on issue #210: [ISSUE #218] Fix spring scopeTarget will repeat consumer instance
vongosling edited a comment on issue #210: [ISSUE #218] Fix spring scopeTarget will repeat consumer instance URL: https://github.com/apache/rocketmq-spring/pull/210#issuecomment-574647774 @snicoll Could you help to review this pr:-) refresh could result in the two instances of the **Container created. But I feel spring has provided a similar elegant method like "SpringBeanUtil" here, we do not want to create an extra class to deal with this problem. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-spring] vongosling edited a comment on issue #210: [ISSUE #218] Fix spring scopeTarget will repeat consumer instance
vongosling edited a comment on issue #210: [ISSUE #218] Fix spring scopeTarget will repeat consumer instance URL: https://github.com/apache/rocketmq-spring/pull/210#issuecomment-574647774 @snicoll Could you help to review this pr:-) refresh could result in the two instances of the **Container created. But I feel spring has provided a similar elegant method like "SpringBeanUtil" here, we do not want to create an extra class. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-spring] vongosling edited a comment on issue #210: [ISSUE #218] Fix spring scopeTarget will repeat consumer instance
vongosling edited a comment on issue #210: [ISSUE #218] Fix spring scopeTarget will repeat consumer instance URL: https://github.com/apache/rocketmq-spring/pull/210#issuecomment-574647774 @snicoll Could you help to review this pr:-) refresh could result in the two instances of the **Container created. But I feel spring has provided a similar elegant method like "SpringBeanUtil" here. which is created by ourselves. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services