fuyou001 commented on a change in pull request #205: [ROCKETMQ-319] Improve
broker register performance and reduce memory usage
URL: https://github.com/apache/rocketmq/pull/205#discussion_r172424249
##
File path:
broker/src/main/java/org/apache/rocketmq/broker/out/BrokerOuterAPI.java
##
@@ -231,6 +259,72 @@ public void unregisterBroker(
throw new MQBrokerException(response.getCode(), response.getRemark());
}
+public List needRegister(
+final String clusterName,
+final String brokerAddr,
+final String brokerName,
+final long brokerId,
+final TopicConfigSerializeWrapper topicConfigWrapper,
+final int timeoutMills) {
+final List changedList = new CopyOnWriteArrayList<>();
+List nameServerAddressList =
this.remotingClient.getNameServerAddressList();
+if (nameServerAddressList != null && nameServerAddressList.size() > 0)
{
+final CountDownLatch countDownLatch = new
CountDownLatch(nameServerAddressList.size());
+for (final String namesrvAddr : nameServerAddressList) {
+brokerOuterExecutor.execute(new Runnable() {
+@Override
+public void run() {
+try {
+QueryDataVersionRequestHeader requestHeader = new
QueryDataVersionRequestHeader();
+requestHeader.setBrokerAddr(brokerAddr);
+requestHeader.setBrokerId(brokerId);
+requestHeader.setBrokerName(brokerName);
+requestHeader.setClusterName(clusterName);
+RemotingCommand request =
RemotingCommand.createRequestCommand(RequestCode.QUERY_DATA_VERSION,
requestHeader);
+
request.setBody(topicConfigWrapper.getDataVersion().encode());
+RemotingCommand response =
remotingClient.invokeSync(namesrvAddr, request, timeoutMills);
+DataVersion nameServerDataVersion = null;
+assert response != null;
+Boolean changed = false;
+switch (response.getCode()) {
+case ResponseCode.SUCCESS: {
+QueryDataVersionResponseHeader
queryDataVersionResponseHeader =
+(QueryDataVersionResponseHeader)
response.decodeCommandCustomHeader(QueryDataVersionResponseHeader.class);
+changed =
queryDataVersionResponseHeader.getChanged();
+byte[] body = response.getBody();
+if (body != null) {
+nameServerDataVersion =
DataVersion.decode(body, DataVersion.class);
+if
(!topicConfigWrapper.getDataVersion().equals(nameServerDataVersion)) {
+changed = true;
+}
+}
+if (changed == null || changed) {
+changedList.add(Boolean.TRUE);
+}
+}
+default:
+break;
+}
+log.warn("query data version from name server {}
OK,changed {}, broker {},name server {}", namesrvAddr, changed,
topicConfigWrapper.getDataVersion(), nameServerDataVersion == null ? "" :
nameServerDataVersion);
Review comment:
done
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
