[GitHub] incubator-rocketmq pull request #5: [ROCKETMQ-8]Standardize build script usi...

GitHub user lollipopjin opened a pull request: https://github.com/apache/incubator-rocketmq/pull/5 [ROCKETMQ-8]Standardize build script using maven wrapper. Step1: Remove original scripts. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-rocketmq issue #5: [ROCKETMQ-8] Standardize build script.

Github user lollipopjin commented on the issue: https://github.com/apache/incubator-rocketmq/pull/5 @vongosling I have finished all steps. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-rocketmq issue #7: [ROCKETMQ-3] Clean up and perfect the unit test...

Github user lollipopjin commented on the issue: https://github.com/apache/incubator-rocketmq/pull/7 OK --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] incubator-rocketmq issue #1: [ROCKETMQ-2] Closing the channel

Github user lollipopjin commented on the issue: https://github.com/apache/incubator-rocketmq/pull/1 Seems ok for me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-rocketmq issue #21: [ROCKETMQ-18]Clean code prompted by IntelliJ

Github user lollipopjin commented on the issue: https://github.com/apache/incubator-rocketmq/pull/21 @lizhanhui ` 1.7 1.7 ` Already --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-rocketmq issue #3: [ROCKETMQ-6] Use logger for exceptions instead ...

Github user lollipopjin commented on the issue: https://github.com/apache/incubator-rocketmq/pull/3 @shroman Could you please squash your commits and fix conflicts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-rocketmq issue #6: [ROCKETMQ-5] Avoid creating directories in Util...

Github user lollipopjin commented on the issue: https://github.com/apache/incubator-rocketmq/pull/6 @shroman Could you please squash your commits and fix conflicts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-rocketmq issue #17: [ROCKETMQ-19] Synchronize LinkedList.add() in ...

Github user lollipopjin commented on the issue: https://github.com/apache/incubator-rocketmq/pull/17 @Zhang-Ke Thanks for your PR, Could you please verify mentioned problem, no matter using unit or other ways. At last, please fix the conflict problem. --- If your project is set up

[GitHub] incubator-rocketmq issue #18: [ROCKETMQ-20] Default 'consumeFromWhere' is in...

Github user lollipopjin commented on the issue: https://github.com/apache/incubator-rocketmq/pull/18 @dongeforever Thanks for you PR, we will add some notes in the example to eliminate confuse. :-) --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-rocketmq issue #22: [ROCKETMQ-25] Possible data race while query m...

Github user lollipopjin commented on the issue: https://github.com/apache/incubator-rocketmq/pull/22 @lizhanhui Could you please verify mentioned problem, no matter using unit or other ways. At last, please fix the conflict problem. --- If your project is set up for it, you can

[GitHub] incubator-rocketmq issue #23: [ROCKETMQ-5] Avoid creating directories in Uti...

Github user lollipopjin commented on the issue: https://github.com/apache/incubator-rocketmq/pull/23 Great. @vongosling @zhouxinyu PLZ review the code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-rocketmq issue #48: [ROCKETMQ-70] Duplicate methods in NettyRemoti...

Github user lollipopjin commented on the issue: https://github.com/apache/incubator-rocketmq/pull/48 Done with the review work --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-rocketmq issue #50: [ROCKETMQ-74] Fix DataVersion equals defect

Github user lollipopjin commented on the issue: https://github.com/apache/incubator-rocketmq/pull/50 Seems ok. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-rocketmq issue #75: [ROCKETMQ-138]Add AuthenticationException clas...

Github user lollipopjin commented on the issue: https://github.com/apache/incubator-rocketmq/pull/75 @Jaskey In my opinion, it' better to just remove the > if (!"com.aliyun.openservices.ons.api.impl.authority.exception.AuthenticationException"

[GitHub] incubator-rocketmq issue #126: [ROCKETMQ-231] fix pull consumer pull result ...

Github user lollipopjin commented on the issue: https://github.com/apache/incubator-rocketmq/pull/126 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-rocketmq issue #141: [ROCKETMQ-254] fix logger appender unit test ...

Github user lollipopjin commented on the issue: https://github.com/apache/incubator-rocketmq/pull/141 Thanks @lindzh. I have merged it, please close this pr :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your