Hi, Bruce:
Our guys have use apache email to subscribe private email list :-)
Our guys apache email list:
vongosl...@apache.org
vintagew...@apache.org
yu...@apache.org
stevensc...@apache.org
lizhan...@apache.org
lolli...@apache.org
lon...@apache.org
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/2
@Jaskey Thanks for your PR, Could you paste some unit test for these
question :-) . please see our contributing checklist,
https://github.com/apache/incubator-rocketmq/blob/master
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/4
@nottyjay Thanks for your PR, Could you paste some unit test for these
question :-) . please see our contributing checklist,
https://github.com/apache/incubator-rocketmq/blob/master
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/5
Sorry, we don't merge this PR.
IMO, there is step 2 you must finish :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/4
Could you abide our PR process(modify your PR subject and mention your jira
address in the description), please follow this PR.
https://github.com/apache/incubator-rocketmq/pull/5
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/3
@shroman Thanks your PR
Could you abide our PR process(modify your PR subject and mention your jira
address in the description), please follow this PR.
https://github.com
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/1
@shroman
Thanks for your PR, Could you paste some unit test for these question :-) .
please see our contributing checklist,
https://github.com/apache/incubator-rocketmq/blob/master
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/2
@Jaskey Thanks your PR
Could you abide our PR process(modify your PR subject and mention your jira
address in the description), please follow this PR. #5
---
If your project
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/1
@shroman Thanks for your PR, Could you paste some unit test for these
question :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/1
That's ok for me. please @lollipopjin @zhouxinyu review it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/5
Thanks for your PR.
I have checked it. It's seems ok for me. please @stevenschew @zhouxinyu
review it.
---
If your project is set up for it, you can reply to this email and
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/1
@lollipopjin your review opinion is ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/7
That's ok. please @lollipopjin @zhouxinyu review it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/1
@shroman I will try to grant right permission for your :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/7#discussion_r93749430
--- Diff:
rocketmq-broker/src/test/java/com/alibaba/rocketmq/broker/topic/TopicConfigManagerTest.java
---
@@ -20,52 +20,43
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/7#discussion_r93749892
--- Diff:
rocketmq-broker/src/test/java/com/alibaba/rocketmq/broker/topic/TopicConfigManagerTest.java
---
@@ -20,52 +20,43
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/15
IMO, we can postpone merge this PR here, thanks @Zhang-Ke
About config module, we would refactor here in the latest release version
:-)
---
If your project is set up for it, you
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/11
@shroman cool, we will add code-style parts in website. Every guys could
comment it and help us to perfect it :-)
---
If your project is set up for it, you can reply to this email and
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/2
Source code seems ok, please @zhouxinyu @lollipopjin review it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/8
please modify you PR subject and fix conflict problems.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103499
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java ---
@@ -497,7 +497,7 @@ private void printMasterAndSlaveDiff
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103857
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/slave/SlaveSynchronize.java ---
@@ -106,12 +106,12 @@ private void syncDelayOffset
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103915
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPullConsumerImpl.java
---
@@ -228,6 +228,7 @@ public void
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103929
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPullConsumerImpl.java
---
@@ -247,6 +248,7 @@ public void
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103845
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/slave/SlaveSynchronize.java ---
@@ -106,12 +106,12 @@ private void syncDelayOffset
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103864
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/slave/SlaveSynchronize.java ---
@@ -134,10 +134,10 @@ private void
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103933
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPullConsumerImpl.java
---
@@ -258,6 +260,7 @@ public void
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103841
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/slave/SlaveSynchronize.java ---
@@ -85,9 +85,9 @@ private void syncConsumerOffset
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103642
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/filtersrv/FilterServerUtil.java
---
@@ -26,9 +26,9 @@ public static void callShell
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103833
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/slave/SlaveSynchronize.java ---
@@ -68,10 +68,10 @@ private void syncTopicConfig
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/20
We must keep cautious about storage polish, although some minor rename.
IMO, Could we optimize here in the 4.1.0 or more later version :-)
---
If your project is set up for it, you
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/19
IMO, we could close this pr without any more works @lollipopjin
thanks @Jaskey
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/21
That's ok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and w
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/20
@shroman
what are your recommendations on how to treat the storage module? Should I
create a JIRA issue if I find a problem, but not work on it?
yeah, if you find
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/8
Subject still is "simplify if grammar "?please bind with JIRA. You can
refer to other PR:-)
---
If your project is set up for it, you can reply to this email and have your
re
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/8
Could you polish again just like other PR. such as title start with JIRA
issues. The following links may be helpful for you.
http://rocketmq.incubator.apache.org/docs/pull
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/26
Thanks @thisisbaozi , we have introduced a new way for async behavior in
the latest version. Could you give us some hint for this usage ?
---
If your project is set up for it, you can
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/23
alright for me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/17
Thanks for your ISSUE review before PR @Zhang-Ke
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94727928
--- Diff: _docs/06-best-practice-pull-request.md ---
@@ -53,7 +70,9 @@ Push your branch to Github:
# How to create a PR (contributors
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94728311
--- Diff: _docs/06-best-practice-pull-request.md ---
@@ -4,23 +4,40 @@ permalink: /docs/pull-request/
modified: 2016-12-24T15:01:43-04
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq-site/pull/3
Alright. please @zhouxinyu @lizhanhui review again:-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94732806
--- Diff: _docs/06-best-practice-pull-request.md ---
@@ -4,23 +4,40 @@ permalink: /docs/pull-request/
modified: 2016-12-24T15:01:43-04
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/8
Yes, do not start a new pull request.Just modify your topic, start a JIRA
and bind them :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/27
alright
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/3
IMO, we should prefer slf4j or String.format effective format way to log in
4.x :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/34
@wu-sheng Could you modify your PR , following our codestyle and PR
guide[1] :-)
[1]http://rocketmq.incubator.apache.org/docs/code-guidelines/
---
If your project is set up
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/41
@tain198127 Could you follow other PR[1] style at first
[1] https://github.com/apache/incubator-rocketmq/pull/5
---
If your project is set up for it, you can reply to this
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/8#discussion_r96157627
--- Diff:
rocketmq-namesrv/src/main/java/com/alibaba/rocketmq/namesrv/routeinfo/RouteInfoManager.java
---
@@ -622,7 +622,7 @@ public void
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/8
alright
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/42
alright
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/37
Thanks @iskl @shroman @WillemJiang , I will work on the rocketmq remoting
module these days.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user vongosling opened a pull request:
https://github.com/apache/incubator-rocketmq-site/pull/6
Update deploy guide
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vongosling/incubator-rocketmq-site patch-1
Alternatively
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/46#discussion_r96842460
--- Diff: test/pom.xml ---
@@ -0,0 +1,52 @@
+
+
+
+http://www.w3.org/2001/XMLSchema-instance";
+ xmlns=
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/46#discussion_r96842801
--- Diff:
test/src/main/java/org/apache/rocketmq/test/factory/MessageFactory.java ---
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/46#discussion_r96842213
--- Diff: test/pom.xml ---
@@ -0,0 +1,52 @@
+
+
+
+http://www.w3.org/2001/XMLSchema-instance";
+ xmlns=
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/46
Nice job ! Integration failsafe with sonar, that's really a tremendous
work. :-) We can merge it now, but it still our polish work in the near future
---
If your project is set u
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/45
All checks have failed, please ensure your testing validity
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/44
Thanks @naughtybear
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/43
alright, thanks @iskl
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/41
please follow us PR guide, modify your topic and ensure all testing validity
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/33
alright
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/26
Thanks @thisisbaozi . RocketMQ 4.1 will publish a new async way to deal
with the same requirement.
---
If your project is set up for it, you can reply to this email and have your
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/28
Cool, could we discuss this new feature in dev email list ? BTW, This
branch has conflicts that must be resolved:-)
---
If your project is set up for it, you can reply to this email
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/45
Could you squash your many commmits
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/38
@wu-sheng Thanks for your clean code actions. Why so many format operation,
what had happend when you use our checkstyle, let me know. BTW, you know, UT is
the best assistant of the
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/39
Usually, we need 3 committers to review PR. We'd better not merge the PR
if the opinion fails to unite
---
If your project is set up for it, you can reply to this email and
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/48
alright
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/50
@lizhanhui since 4.1.0, we will start a new branching model, more
formalized, more flexible. All PRs except those bugfix, we recommended to merge
back to develop branch. This guide
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/52
@shroman since 4.1.0, we will start a new branching model, more
formalized, more flexible. All PRs except those bugfix, we recommended to merge
back to develop branch. This guide will
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/51
@shroman since 4.1.0, we will start a new branching model, more
formalized, more flexible. All PRs except those hotfixs, we recommended to
merge back to develop branch. This guide
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/53
Cool, Thanks @dongeforever providing this feature. We will have a look at
this implementation. please hold your horses :-)
---
If your project is set up for it, you can reply to this
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/50
@djKooks You're amazing~
http://rocketmq.incubator.apache.org/docs/branching-model
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/54
@lizhanhui This problem let me feel a bit awkward when we double-check the
4.0.0 vote checklist. May be, we need to let example module into integration
test
---
If your project is
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/54
Agree
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/55
All checks have failed @lizhanhui
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/58
@yuweitaocn Performance Tuning is a Galileo thing. Apache RocketMQ all gc
paramters have been proved in many company production environment. That is
said. All Parameters are have been
Thanks Bruce,
IMO, Service Desk is a design for customer support. So, we have not apply
this feature. We just want to make some works on use of Agile board.
I have a permission to create a sprint now. I think that's ok for use.
Thanks bruce again :-)
2017-02-15 6:25 GMT+08:00 Bruce Snyder :
> H
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/53
Yep agreed @lizhanhui . I will make some comment as much detail as possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/53
@dongeforever we can continue to polish this PR, IMO. if you have any
problem. please let me know. BTW, can you post your performance test result for
us
---
If your project is set up
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/53#discussion_r101990343
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/processor/SendMessageProcessor.java
---
@@ -442,6 +449,202 @@ private
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/53#discussion_r101965587
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/processor/SendMessageProcessor.java
---
@@ -72,7 +73,13 @@ public RemotingCommand
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/53#discussion_r101995981
--- Diff: store/src/main/java/org/apache/rocketmq/store/ConsumeQueue.java
---
@@ -331,7 +331,7 @@ public long getMinOffsetInQueue
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/53#discussion_r101992848
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
---
@@ -595,8 +596,11 @@ private
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/53#discussion_r101994094
--- Diff:
common/src/main/java/org/apache/rocketmq/common/message/MessageBatch.java ---
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/53#discussion_r101993057
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
---
@@ -737,6 +742,10 @@ public
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/53#discussion_r101989915
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/processor/SendMessageProcessor.java
---
@@ -442,6 +449,202 @@ private
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/53#discussion_r101991874
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java ---
@@ -278,14 +280,14 @@ public void createTopic(final
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/53#discussion_r101995717
--- Diff:
store/src/main/java/org/apache/rocketmq/store/AppendMessageResult.java ---
@@ -119,6 +129,7 @@ public String toString
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/53#discussion_r101981097
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/processor/SendMessageProcessor.java
---
@@ -442,6 +449,202 @@ private
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/53#discussion_r101994977
--- Diff:
common/src/main/java/org/apache/rocketmq/common/protocol/header/SendMessageRequestHeader.java
---
@@ -48,6 +48,8
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/53#discussion_r101980234
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/processor/SendMessageProcessor.java
---
@@ -442,6 +449,202 @@ private
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/70
preliminary fault @stevenschew please double check it :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/69
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/68
@Jaskey Could you continue to polish this PR as we have pointed out :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/65#discussion_r103126453
--- Diff:
tools/src/main/java/org/apache/rocketmq/tools/command/SubCommand.java ---
@@ -21,11 +21,11 @@
import
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/65#discussion_r103126511
--- Diff:
tools/src/main/java/org/apache/rocketmq/tools/command/offset/ResetOffsetByTimeCommand.java
---
@@ -22,25 +22,16 @@
import
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/65
@shroman IMO, we can let the tool module unit-test passed once someone
polish here. thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/62
@lizhanhui Cool. Did you check the commits, letting all passed in at least
2 windows environment ?
---
If your project is set up for it, you can reply to this email and have your
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/62
I am hoping someone may test this PR on Windows 10 which covers majority of
windows users.
Show all checks
Yep agreed.
---
If your project is set up for it, you can
1 - 100 of 270 matches
Mail list logo
