[GitHub] incubator-rocketmq issue #39: [ROCKETMQ-45]Delete hanged consume queue files

Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/39 > We'd better not merge the PR if the opinion fails to unite Agree. But this is a minor change to fix obvious corner case mis-handling. Proposing review points are carefully considere

[GitHub] incubator-rocketmq issue #39: [ROCKETMQ-45]Delete hanged consume queue files

Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/39 Usually, we need 3 committers to review PR. We'd better not merge the PR if the opinion fails to unite --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-rocketmq issue #39: [ROCKETMQ-45]Delete hanged consume queue files

Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/39 [](https://coveralls.io/builds/9784819) Coverage increased (+0.1%) to 25.814% when pulling **57111a02721ac8d70d

[GitHub] incubator-rocketmq issue #39: [ROCKETMQ-45]Delete hanged consume queue files

Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/39 [](https://coveralls.io/builds/9784819) Coverage increased (+0.1%) to 25.814% when pulling **57111a02721ac8d70d

[GitHub] incubator-rocketmq issue #39: [ROCKETMQ-45]Delete hanged consume queue files

Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/39 [](https://coveralls.io/builds/9784819) Coverage increased (+0.1%) to 25.814% when pulling **57111a02721ac8d70d

[GitHub] incubator-rocketmq issue #39: [ROCKETMQ-45]Delete hanged consume queue files

Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/39 [](https://coveralls.io/builds/9784804) Coverage increased (+0.1%) to 25.854% when pulling **b8e53c990e0b467c2a

[GitHub] incubator-rocketmq issue #39: [ROCKETMQ-45]Delete hanged consume queue files

Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/39 [](https://coveralls.io/builds/9784804) Coverage increased (+0.1%) to 25.854% when pulling **b8e53c990e0b467c2a

[GitHub] incubator-rocketmq issue #39: [ROCKETMQ-45]Delete hanged consume queue files

Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/39 [](https://coveralls.io/builds/9784804) Coverage increased (+0.1%) to 25.854% when pulling **b8e53c990e0b467c2a

[GitHub] incubator-rocketmq issue #39: [ROCKETMQ-45]Delete hanged consume queue files

Github user zhouxinyu commented on the issue: https://github.com/apache/incubator-rocketmq/pull/39 @lizhanhui Also please add some unit tests -:).. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-rocketmq issue #39: [ROCKETMQ-45]Delete hanged consume queue files

Github user zhouxinyu commented on the issue: https://github.com/apache/incubator-rocketmq/pull/39 I checked ConsumeQueue#correctMinOffset, and you are right this method won't work as expected in this situation. Please @vintagewang @vongosling help review this PR. --- If you

[GitHub] incubator-rocketmq issue #39: [ROCKETMQ-45]Delete hanged consume queue files

Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/39 > what's the appearance/effect of this BUG? Reported bug description is consume queue files cannot be automatically deleted and took up large portion of disk. > IMO, it'

[GitHub] incubator-rocketmq issue #39: [ROCKETMQ-45]Delete hanged consume queue files

Github user zhouxinyu commented on the issue: https://github.com/apache/incubator-rocketmq/pull/39 Hi, @lizhanhui , what's the appearance/effect of this BUG? Let's start from the next round. IMO, it's ok when ConsumeQueue-MappedFile hold failed, this file will be rele