[GitHub] incubator-rocketmq issue #85: [ROCKETMQ-158]Remove logback dependency for ro...
Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #85: [ROCKETMQ-158]Remove logback dependency for ro...
Github user Jaskey commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 @zhouxinyu @shroman @vongosling what's your advice guys? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #85: [ROCKETMQ-158]Remove logback dependency for ro...
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [](https://coveralls.io/builds/11085065) Coverage increased (+2.8%) to 34.601% when pulling **6647aebcac672c4a40c6855629769083f7b4110c on Jaskey:ROCKETMQ-158** into **ab013861cd488f535d9cc03c21481922ba21ed9d on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #85: [ROCKETMQ-158]Remove logback dependency for ro...
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [](https://coveralls.io/builds/11085065) Coverage increased (+2.8%) to 34.601% when pulling **6647aebcac672c4a40c6855629769083f7b4110c on Jaskey:ROCKETMQ-158** into **ab013861cd488f535d9cc03c21481922ba21ed9d on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #85: [ROCKETMQ-158]Remove logback dependency for ro...
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [](https://coveralls.io/builds/11085065) Coverage increased (+2.8%) to 34.601% when pulling **6647aebcac672c4a40c6855629769083f7b4110c on Jaskey:ROCKETMQ-158** into **ab013861cd488f535d9cc03c21481922ba21ed9d on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #85: [ROCKETMQ-158]Remove logback dependency for ro...
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [](https://coveralls.io/builds/11083601) Coverage increased (+2.8%) to 34.628% when pulling **4449b2b21bc9aa198f88a5cdaeb68cd91b112cda on Jaskey:ROCKETMQ-158** into **ab013861cd488f535d9cc03c21481922ba21ed9d on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #85: [ROCKETMQ-158]Remove logback dependency for ro...
Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #85: [ROCKETMQ-158]Remove logback dependency for ro...
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [](https://coveralls.io/builds/10827873) Coverage increased (+0.008%) to 31.788% when pulling **980c1a3b9b2ea054cdbba34d11fac31532a2ec7e on Jaskey:ROCKETMQ-158** into **ab013861cd488f535d9cc03c21481922ba21ed9d on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #85: [ROCKETMQ-158]Remove logback dependency for ro...
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [](https://coveralls.io/builds/10827873) Coverage increased (+0.008%) to 31.788% when pulling **980c1a3b9b2ea054cdbba34d11fac31532a2ec7e on Jaskey:ROCKETMQ-158** into **ab013861cd488f535d9cc03c21481922ba21ed9d on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #85: [ROCKETMQ-158]Remove logback dependency for ro...
Github user Jaskey commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 @lizhanhui please review the updated pr, log4j_tools.xml has been move to distributions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #85: [ROCKETMQ-158]Remove logback dependency for ro...
Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 The conf folder has been moved to the distribution module, please rebase this PR on top of develop branch. I'll +1 thereafter. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #85: [ROCKETMQ-158]Remove logback dependency for ro...
Github user Jaskey commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 @lizhanhui please review the updated pr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #85: [ROCKETMQ-158]Remove logback dependency for ro...
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [](https://coveralls.io/builds/10821765) Coverage decreased (-0.08%) to 31.791% when pulling **3d3801b09e23fbb8af546df1803a0da34a63727e on Jaskey:ROCKETMQ-158** into **7e37799e822cda30b0607f859fc5574f468a49f3 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #85: [ROCKETMQ-158]Remove logback dependency for ro...
Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 > So do you agree this is indeed an issue that needed to be solved? If yes, I will try doing that. Changing specific dependency to a neutral logging framework is good to have as application developer may integrate tool module to their operation management system. > But actually it is a little different from the clientLogger since clientlogger will use the resources file in the classpath by default while tools admin does not have config file in the classpath. I know this, but it does not look like a blocking issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #85: [ROCKETMQ-158]Remove logback dependency for ro...
Github user Jaskey commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 @lizhanhui So do you agree this is indeed an issue that needed to be solved? If yes, I will try doing that. But actually it is a little different from the clientLogger since clientlogger will use the resources file in the classpath by default while tools admin does not have config file in the classpath. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #85: [ROCKETMQ-158]Remove logback dependency for ro...
Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 The logic here shares much similar logic with ClientLogger class, can we extract the common part into a reusable method? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #85: [ROCKETMQ-158]Remove logback dependency for ro...
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [](https://coveralls.io/builds/10807947) Coverage decreased (-0.04%) to 31.829% when pulling **b7218ae4333be8d553f8c00386c241b5ee049e2a on Jaskey:ROCKETMQ-158** into **7e37799e822cda30b0607f859fc5574f468a49f3 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #85: [ROCKETMQ-158]Remove logback dependency for ro...
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [](https://coveralls.io/builds/10807947) Coverage decreased (-0.04%) to 31.829% when pulling **b7218ae4333be8d553f8c00386c241b5ee049e2a on Jaskey:ROCKETMQ-158** into **7e37799e822cda30b0607f859fc5574f468a49f3 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #85: [ROCKETMQ-158]Remove logback dependency for ro...
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [](https://coveralls.io/builds/10807947) Coverage decreased (-0.04%) to 31.829% when pulling **b7218ae4333be8d553f8c00386c241b5ee049e2a on Jaskey:ROCKETMQ-158** into **7e37799e822cda30b0607f859fc5574f468a49f3 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #85: [ROCKETMQ-158]Remove logback dependency for ro...
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [](https://coveralls.io/builds/10807112) Coverage increased (+0.04%) to 31.662% when pulling **53bb2a63828a44a2b2e3ab34e6a7e598d0c22fba on Jaskey:ROCKETMQ-158** into **203cb30a906a77f41b0e5ba09fc351434862d408 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #85: [ROCKETMQ-158]Remove logback dependency for ro...
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [](https://coveralls.io/builds/10807112) Coverage increased (+0.04%) to 31.662% when pulling **53bb2a63828a44a2b2e3ab34e6a7e598d0c22fba on Jaskey:ROCKETMQ-158** into **203cb30a906a77f41b0e5ba09fc351434862d408 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #85: [ROCKETMQ-158]Remove logback dependency for ro...
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [](https://coveralls.io/builds/10807112) Coverage increased (+0.04%) to 31.662% when pulling **53bb2a63828a44a2b2e3ab34e6a7e598d0c22fba on Jaskey:ROCKETMQ-158** into **203cb30a906a77f41b0e5ba09fc351434862d408 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #85: [ROCKETMQ-158]Remove logback dependency for ro...
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [](https://coveralls.io/builds/10806993) Coverage increased (+0.03%) to 31.644% when pulling **b5876bb5651693c12b4774cebe722f0202155331 on Jaskey:ROCKETMQ-158** into **203cb30a906a77f41b0e5ba09fc351434862d408 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #85: [ROCKETMQ-158]Remove logback dependency for ro...
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [](https://coveralls.io/builds/10806993) Coverage increased (+0.03%) to 31.644% when pulling **b5876bb5651693c12b4774cebe722f0202155331 on Jaskey:ROCKETMQ-158** into **203cb30a906a77f41b0e5ba09fc351434862d408 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
