[GitHub] incubator-rocketmq issue #96: [ROCKETMQ-187]Measure the code coverage for In...

2017-05-09 Thread lizhanhui
Github user lizhanhui commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/96
  
It's good and looks it's already been merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-rocketmq issue #96: [ROCKETMQ-187]Measure the code coverage for In...

2017-05-09 Thread dongeforever
Github user dongeforever commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/96
  
The PR is better not to be merged by the original author.
@lizhanhui @zhouxinyu @shroman please help merge this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-rocketmq issue #96: [ROCKETMQ-187]Measure the code coverage for In...

2017-04-26 Thread vongosling
Github user vongosling commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/96
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-rocketmq issue #96: [ROCKETMQ-187]Measure the code coverage for In...

2017-04-21 Thread coveralls
Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/96
  

[![Coverage 
Status](https://coveralls.io/builds/11179609/badge)](https://coveralls.io/builds/11179609)

Coverage increased (+0.06%) to 34.694% when pulling 
**d7a155a4e8d66f20ff4ca4dca55368b593185e9c on dongeforever:IT_POLISH** into 
**42f78c281cbeb5072b04eaf03b1a8059b8d281a7 on apache:develop**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-rocketmq issue #96: [ROCKETMQ-187]Measure the code coverage for In...

2017-04-21 Thread coveralls
Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/96
  

[![Coverage 
Status](https://coveralls.io/builds/11179609/badge)](https://coveralls.io/builds/11179609)

Coverage increased (+0.06%) to 34.694% when pulling 
**d7a155a4e8d66f20ff4ca4dca55368b593185e9c on dongeforever:IT_POLISH** into 
**42f78c281cbeb5072b04eaf03b1a8059b8d281a7 on apache:develop**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-rocketmq issue #96: [ROCKETMQ-187]Measure the code coverage for In...

2017-04-21 Thread coveralls
Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/96
  

[![Coverage 
Status](https://coveralls.io/builds/11179609/badge)](https://coveralls.io/builds/11179609)

Coverage increased (+0.06%) to 34.694% when pulling 
**d7a155a4e8d66f20ff4ca4dca55368b593185e9c on dongeforever:IT_POLISH** into 
**42f78c281cbeb5072b04eaf03b1a8059b8d281a7 on apache:develop**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-rocketmq issue #96: [ROCKETMQ-187]Measure the code coverage for In...

2017-04-21 Thread dongeforever
Github user dongeforever commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/96
  
@lizhanhui @zhouxinyu @vongosling please have a review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---