[GitHub] incubator-rocketmq pull request #36: [ROCKETMQ-43] Remove NoWhitespaceBefore...

2017-01-19 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-rocketmq/pull/36


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #36: [ROCKETMQ-43] Remove NoWhitespaceBefore...

2017-01-13 Thread wu-sheng 
Github user wu-sheng commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/36#discussion_r95958687
  
--- Diff: 
tools/src/main/java/org/apache/rocketmq/tools/command/MQAdminStartup.java ---
@@ -194,7 +197,7 @@ public static void initCommand() {
 private static void initLogback() throws JoranException {
 String rocketmqHome = 
System.getProperty(MixAll.ROCKETMQ_HOME_PROPERTY, 
System.getenv(MixAll.ROCKETMQ_HOME_ENV));
 
-LoggerContext lc = (LoggerContext) 
LoggerFactory.getILoggerFactory();
+LoggerContext lc = 
(LoggerContext)LoggerFactory.getILoggerFactory();
--- End diff --

As you can see, travis-ci's check is passed. So I assume my code style is 
correct.
I think maybe your `codeStyle` doesn't match your design purpose?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #36: [ROCKETMQ-43] Remove NoWhitespaceBefore...

2017-01-13 Thread wu-sheng 
Github user wu-sheng commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/36#discussion_r95957982
  
--- Diff: 
tools/src/main/java/org/apache/rocketmq/tools/command/MQAdminStartup.java ---
@@ -194,7 +197,7 @@ public static void initCommand() {
 private static void initLogback() throws JoranException {
 String rocketmqHome = 
System.getProperty(MixAll.ROCKETMQ_HOME_PROPERTY, 
System.getenv(MixAll.ROCKETMQ_HOME_ENV));
 
-LoggerContext lc = (LoggerContext) 
LoggerFactory.getILoggerFactory();
+LoggerContext lc = 
(LoggerContext)LoggerFactory.getILoggerFactory();
--- End diff --

This file 
https://github.com/apache/incubator-rocketmq/blob/master/style/rmq_codeStyle.xml
 is used. 
In your website doc, just mention about import, but no style-file name.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #36: [ROCKETMQ-43] Remove NoWhitespaceBefore...

2017-01-13 Thread wu-sheng 
Github user wu-sheng commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/36#discussion_r95957237
  
--- Diff: 
tools/src/main/java/org/apache/rocketmq/tools/command/MQAdminStartup.java ---
@@ -194,7 +197,7 @@ public static void initCommand() {
 private static void initLogback() throws JoranException {
 String rocketmqHome = 
System.getProperty(MixAll.ROCKETMQ_HOME_PROPERTY, 
System.getenv(MixAll.ROCKETMQ_HOME_ENV));
 
-LoggerContext lc = (LoggerContext) 
LoggerFactory.getILoggerFactory();
+LoggerContext lc = 
(LoggerContext)LoggerFactory.getILoggerFactory();
--- End diff --

Already do that. Seem not work correctly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #36: [ROCKETMQ-43] Remove NoWhitespaceBefore...

2017-01-13 Thread zhouxinyu 
Github user zhouxinyu commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/36#discussion_r95956604
  
--- Diff: 
tools/src/main/java/org/apache/rocketmq/tools/command/MQAdminStartup.java ---
@@ -194,7 +197,7 @@ public static void initCommand() {
 private static void initLogback() throws JoranException {
 String rocketmqHome = 
System.getProperty(MixAll.ROCKETMQ_HOME_PROPERTY, 
System.getenv(MixAll.ROCKETMQ_HOME_ENV));
 
-LoggerContext lc = (LoggerContext) 
LoggerFactory.getILoggerFactory();
+LoggerContext lc = 
(LoggerContext)LoggerFactory.getILoggerFactory();
--- End diff --

Also please follow the RocketMQ 
[code-style](http://rocketmq.incubator.apache.org/docs/code-guidelines/)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #36: [ROCKETMQ-43] Remove NoWhitespaceBefore...

2017-01-11 Thread wu-sheng 
GitHub user wu-sheng opened a pull request:

https://github.com/apache/incubator-rocketmq/pull/36

[ROCKETMQ-43] Remove NoWhitespaceBefore module in “rmq_checkstyle.xml”

There are both NoWhitespaceBefore and WhitespaceAfter modules in 
checkstyle.xml, like this:



ref https://issues.apache.org/jira/browse/ROCKETMQ-43

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wu-sheng/incubator-rocketmq fix/ROCKETMQ-43

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-rocketmq/pull/36.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #36


commit 30bbee67d030c3d0910be773beb3eb1578ac4644
Author: wusheng 
Date:   2017-01-11T08:04:06Z

ROCKETMQ-43: remove NoWhitespaceBefore module in “rmq_checkstyle.xml”




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---