Re: [royale-compiler] branch develop updated: MemberAccessEmitter: fixed issue where fully-qualified names were emitted as dynamic access with -js-dynamic-access-unknown-members=true

2019-09-09 Thread Alex Harui
I could be wrong, but I think for Eclipse and maybe some other IDEs, some files are necessary to get a project up and running and others are generated by use of the IDE. For example, I don't think I've seen a .factorypath class before, but the .project (and maybe the .classpath) files are

Re: [royale-compiler] branch develop updated: MemberAccessEmitter: fixed issue where fully-qualified names were emitted as dynamic access with -js-dynamic-access-unknown-members=true

2019-09-09 Thread Carlos Rovira
Hi, I notice all that files too from Eclips, can we remove all that files and add all config files to .gitignore. In doing that you ensure that your config files are the ones you use and you don't get any other one from our repo. I think we removed all other IDE files (VScode), specially the ones

Re: [royale-compiler] branch develop updated: MemberAccessEmitter: fixed issue where fully-qualified names were emitted as dynamic access with -js-dynamic-access-unknown-members=true

2019-09-09 Thread Josh Tynjala
Maybe. It's worth mentioning that VSCode's Java support is based on Eclipse, so it uses the same project file formats as Eclipse. We have .classpath and .project files committed in the repo, presumably to make it easy to import the compiler projects into Eclipse. However, they're constantly in a

Re: [royale-compiler] branch develop updated: MemberAccessEmitter: fixed issue where fully-qualified names were emitted as dynamic access with -js-dynamic-access-unknown-members=true

2019-09-09 Thread Alex Harui
Should it be added to .gitignore so it doesn't get committed? On 9/9/19, 6:58 AM, "Josh Tynjala" wrote: I removed this file. Should be gone on both develop and release/0.9.6. - Josh On Mon, Sep 9, 2019 at 6:39 AM Josh Tynjala wrote: > It's a project

Re: [royale-compiler] branch develop updated: MemberAccessEmitter: fixed issue where fully-qualified names were emitted as dynamic access with -js-dynamic-access-unknown-members=true

2019-09-09 Thread Josh Tynjala
I removed this file. Should be gone on both develop and release/0.9.6. - Josh On Mon, Sep 9, 2019 at 6:39 AM Josh Tynjala wrote: > It's a project file created by VSCode. I didn't realize that I > accidentally added it. It can be removed from the repo. > > - Josh > > On Saturday, September 7,

Re: [royale-compiler] branch develop updated: MemberAccessEmitter: fixed issue where fully-qualified names were emitted as dynamic access with -js-dynamic-access-unknown-members=true

2019-09-09 Thread Josh Tynjala
It's a project file created by VSCode. I didn't realize that I accidentally added it. It can be removed from the repo. - Josh On Saturday, September 7, 2019, Alex Harui wrote: > Josh, > > What is the .factorypath file? It is in the release package. Should it even be in the repo? > > -Alex > >

Re: [royale-compiler] branch develop updated: MemberAccessEmitter: fixed issue where fully-qualified names were emitted as dynamic access with -js-dynamic-access-unknown-members=true

2019-09-07 Thread Alex Harui
Josh, What is the .factorypath file? It is in the release package. Should it even be in the repo? -Alex On 8/12/19, 11:12 AM, "joshtynj...@apache.org" wrote: This is an automated email from the ASF dual-hosted git repository. joshtynjala pushed a commit to branch develop