Re: Build failed in Jenkins: royale-typedefs #139

2018-02-13 Thread Gabe Harbs
;>>> wrote:
>>>>>>> 
>>>>>>> Patch files are auto-generated by the Ant script, verified by a build,
>>>>>>> then committed to the src/main/patch/js.patch so that the Maven build
>>>>>>> can
>>>>>>> use it.  If we choose to try to manually maintain the patch files, we
>>>>>>> should comment out the auto-generation in the Ant build, otherwise as
>>>>>>> soon
>>>>>>> as someone uses it, it will blow away manual changes.  And if you had
>>>>>>> auto-generated the patch file, it probably wouldn't have had
>>>>>>> formatting
>>>>>>> issues.
>>>>>>> 
>>>>>>> HTH,
>>>>>>> -Alex
>>>>>>> 
>>>>>>> On 2/12/18, 8:26 AM, "Yishay Weiss" >>>>>> <mailto:yishayj...@hotmail.com>
>>>>>>> <mailto:yishayj...@hotmail.com <mailto:yishayj...@hotmail.com> 
>>>>>>> <mailto:yishayj...@hotmail.com <mailto:yishayj...@hotmail.com>>>>
>>>>>>> wrote:
>>>>>>> 
>>>>>>>> Add, see my later mail.
>>>>>>>> 
>>>>>>>> From: Gabe Harbs<mailto:harbs.li...@gmail.com 
>>>>>>>> <mailto:harbs.li...@gmail.com>
>>>>>>>> <mailto:harbs.li...@gmail.com <mailto:harbs.li...@gmail.com>>>
>>>>>>>> Sent: Monday, February 12, 2018 6:23 PM
>>>>>>>> To: dev@royale.apache.org <mailto:dev@royale.apache.org>
>>>>>>>> <mailto:dev@royale.apache.org 
>>>>>>>> <mailto:dev@royale.apache.org>><mailto:dev@royale.apache.org 
>>>>>>>> <mailto:dev@royale.apache.org>
>>>>>>>> <mailto:dev@royale.apache.org <mailto:dev@royale.apache.org>>>
>>>>>>>> Subject: Re: Build failed in Jenkins: royale-typedefs #139
>>>>>>>> 
>>>>>>>> What was it? Did you add a space, or remove a space?
>>>>>>>>> On Feb 12, 2018, at 6:11 PM, Yishay Weiss >>>>>>>> <mailto:yishayj...@hotmail.com>
>>>>>>>>> <mailto:yishayj...@hotmail.com <mailto:yishayj...@hotmail.com>>>
>>>>>>>>> wrote:
>>>>>>>>> 
>>>>>>>>> I fixed it for my machine. Hopefully Jenkins will be happy too.
>>>>>>>>> 
>>>>>>>>> From: Gabe Harbs<mailto:harbs.li...@gmail.com 
>>>>>>>>> <mailto:harbs.li...@gmail.com>
>>>>>>>>> <mailto:harbs.li...@gmail.com <mailto:harbs.li...@gmail.com>>>
>>>>>>>>> Sent: Monday, February 12, 2018 5:18 PM
>>>>>>>>> To: dev@royale.apache.org <mailto:dev@royale.apache.org>
>>>>>>>>> <mailto:dev@royale.apache.org 
>>>>>>>>> <mailto:dev@royale.apache.org>><mailto:dev@royale.apache.org 
>>>>>>>>> <mailto:dev@royale.apache.org>
>>>>>>>>> <mailto:dev@royale.apache.org <mailto:dev@royale.apache.org>>>
>>>>>>>>> Subject: Re: Build failed in Jenkins: royale-typedefs #139
>>>>>>>>> 
>>>>>>>>> Does anyone understand the patch file syntax enough to guess what’s
>>>>>>>>> wrong?
>>>>>>>>> 
>>>>>>>>>> On Feb 12, 2018, at 5:15 PM, Yishay Weiss >>>>>>>>> <mailto:yishayj...@hotmail.com>
>>>>>>>>>> <mailto:yishayj...@hotmail.com <mailto:yishayj...@hotmail.com>>>
>>>>>>>>>> wrote:
>>>>>>>>>> 
>>>>>>>>>> I  have the same result with ant on my machine. It’s probably a
>>>>>>>>>> windows/mac thing.
>>>>>>>>>> 
>>>>>>>>>> From: Piotr Zarzycki<mailto:piotrzarzyck...@gmail.com 
>>>>>>>>>> <mailto:piotrzarzyck...@gmail.com>
>>>>>>>>>> <mailto:piotrzarzyck...@gmail.com 
>>>>>>>>>> <mailto:piotrzarzyck...@gmail.com>>>
>>>>&

Re: Build failed in Jenkins: royale-typedefs #139

2018-02-13 Thread Gabe Harbs
I created royale-extras and cloned closure-compiler there.[1]

I believe closure-compiler has all the typedefs we are currently using. The 
version of svg.js that’s hosted there[2] seems to be vastly improved over the 
version we’re currently downloading.[3] It looks to me that all the patching we 
are doing on sag.js is not necessary with the newer version.

es3.js and es6.js have patches as well I’m unclear on whether those changes 
need to be applied. I think yes.

Harbs

[1]https://github.com/royale-extras/closure-compiler/ 
<https://github.com/royale-extras/closure-compiler/>
[2]https://github.com/royale-extras/closure-compiler/blob/master/contrib/externs/svg.js
 
<https://github.com/royale-extras/closure-compiler/blob/master/contrib/externs/svg.js>
[3]https://storage.googleapis.com/google-code-archive-downloads/v2/code.google.com/closureidl/svg.js
 
<https://storage.googleapis.com/google-code-archive-downloads/v2/code.google.com/closureidl/svg.js>

> On Feb 13, 2018, at 8:26 AM, Gabe Harbs  wrote:
> 
> We could make a non-Apache organization for Royale-related stuff which is not 
> strictly part of our repos. Kind of like what I did for flex-extras[1]
> 
> [1]https://github.com/flex-extras <https://github.com/flex-extras>
> 
>> On Feb 13, 2018, at 8:06 AM, Alex Harui > <mailto:aha...@adobe.com.INVALID>> wrote:
>> 
>> Where would the fork live?
>> 
>> You might also have to verify that all of the things we patch are
>> available on GH or Git.
>> 
>> Seems like a good possibility,
>> -Alex
>> 
>> On 2/12/18, 1:46 PM, "Gabe Harbs" > <mailto:harbs.li...@gmail.com>> wrote:
>> 
>>> We could fork the Google externs on Github and update those. If we pull
>>> from the forked repo, we would be able to quickly make changes that we
>>> need and make PRs back to Google. That would also make it easy to pull in
>>> changes that are made to Google’s repo.
>>> 
>>> Harbs
>>> 
>>>> On Feb 12, 2018, at 10:00 PM, Alex Harui >>> <mailto:aha...@adobe.com.INVALID>>
>>>> wrote:
>>>> 
>>>> For js.patch, see the js/build.xml in royale-typedefs and the make_patch
>>>> target.
>>>> 
>>>> Lately, I've been thinking about finding some other way of dealing with
>>>> this.  We used patches so we didn't have to host 3rd-party files in our
>>>> source tree.  I think we may now have 3rd-party files elsewhere in our
>>>> source tree so we could just put patched versions in our source tree and
>>>> update LICENSE and headers appropriately.  There is an issue with
>>>> staying
>>>> synced up with the master 3rd-party file.  And, we could make
>>>> pull-requests on the 3rd-party file in some cases.
>>>> 
>>>> Thoughts?
>>>> -Alex 
>>>> 
>>>> On 2/12/18, 11:23 AM, "Gabe Harbs" >>> <mailto:harbs.li...@gmail.com>
>>>> <mailto:harbs.li...@gmail.com <mailto:harbs.li...@gmail.com>>> wrote:
>>>> 
>>>>> Where is that and how do I add to the patches?
>>>>> 
>>>>>> On Feb 12, 2018, at 7:31 PM, Alex Harui >>>>> <mailto:aha...@adobe.com.INVALID>>
>>>>>> wrote:
>>>>>> 
>>>>>> Patch files are auto-generated by the Ant script, verified by a build,
>>>>>> then committed to the src/main/patch/js.patch so that the Maven build
>>>>>> can
>>>>>> use it.  If we choose to try to manually maintain the patch files, we
>>>>>> should comment out the auto-generation in the Ant build, otherwise as
>>>>>> soon
>>>>>> as someone uses it, it will blow away manual changes.  And if you had
>>>>>> auto-generated the patch file, it probably wouldn't have had
>>>>>> formatting
>>>>>> issues.
>>>>>> 
>>>>>> HTH,
>>>>>> -Alex
>>>>>> 
>>>>>> On 2/12/18, 8:26 AM, "Yishay Weiss" >>>>> <mailto:yishayj...@hotmail.com>
>>>>>> <mailto:yishayj...@hotmail.com <mailto:yishayj...@hotmail.com> 
>>>>>> <mailto:yishayj...@hotmail.com <mailto:yishayj...@hotmail.com>>>>
>>>>>> wrote:
>>>>>> 
>>>>>>> Add, see my later mail.
>>>>>>> 
>>>>>>> From: Gabe Harbs<mailto:harbs.li...@gmail.com 
>

Re: Build failed in Jenkins: royale-typedefs #139

2018-02-12 Thread Alex Harui
Where would the fork live?

You might also have to verify that all of the things we patch are
available on GH or Git.

Seems like a good possibility,
-Alex

On 2/12/18, 1:46 PM, "Gabe Harbs"  wrote:

>We could fork the Google externs on Github and update those. If we pull
>from the forked repo, we would be able to quickly make changes that we
>need and make PRs back to Google. That would also make it easy to pull in
>changes that are made to Google’s repo.
>
>Harbs
>
>> On Feb 12, 2018, at 10:00 PM, Alex Harui 
>>wrote:
>> 
>> For js.patch, see the js/build.xml in royale-typedefs and the make_patch
>> target.
>> 
>> Lately, I've been thinking about finding some other way of dealing with
>> this.  We used patches so we didn't have to host 3rd-party files in our
>> source tree.  I think we may now have 3rd-party files elsewhere in our
>> source tree so we could just put patched versions in our source tree and
>> update LICENSE and headers appropriately.  There is an issue with
>>staying
>> synced up with the master 3rd-party file.  And, we could make
>> pull-requests on the 3rd-party file in some cases.
>> 
>> Thoughts?
>> -Alex 
>> 
>> On 2/12/18, 11:23 AM, "Gabe Harbs" ><mailto:harbs.li...@gmail.com>> wrote:
>> 
>>> Where is that and how do I add to the patches?
>>> 
>>>> On Feb 12, 2018, at 7:31 PM, Alex Harui 
>>>> wrote:
>>>> 
>>>> Patch files are auto-generated by the Ant script, verified by a build,
>>>> then committed to the src/main/patch/js.patch so that the Maven build
>>>> can
>>>> use it.  If we choose to try to manually maintain the patch files, we
>>>> should comment out the auto-generation in the Ant build, otherwise as
>>>> soon
>>>> as someone uses it, it will blow away manual changes.  And if you had
>>>> auto-generated the patch file, it probably wouldn't have had
>>>>formatting
>>>> issues.
>>>> 
>>>> HTH,
>>>> -Alex
>>>> 
>>>> On 2/12/18, 8:26 AM, "Yishay Weiss" >>> <mailto:yishayj...@hotmail.com <mailto:yishayj...@hotmail.com>>>
>>>>wrote:
>>>> 
>>>>> Add, see my later mail.
>>>>> 
>>>>> From: Gabe Harbs<mailto:harbs.li...@gmail.com
>>>>><mailto:harbs.li...@gmail.com>>
>>>>> Sent: Monday, February 12, 2018 6:23 PM
>>>>> To: dev@royale.apache.org
>>>>><mailto:dev@royale.apache.org><mailto:dev@royale.apache.org
>>>>><mailto:dev@royale.apache.org>>
>>>>> Subject: Re: Build failed in Jenkins: royale-typedefs #139
>>>>> 
>>>>> What was it? Did you add a space, or remove a space?
>>>>>> On Feb 12, 2018, at 6:11 PM, Yishay Weiss >>>>><mailto:yishayj...@hotmail.com>>
>>>>>> wrote:
>>>>>> 
>>>>>> I fixed it for my machine. Hopefully Jenkins will be happy too.
>>>>>> 
>>>>>> From: Gabe Harbs<mailto:harbs.li...@gmail.com
>>>>>><mailto:harbs.li...@gmail.com>>
>>>>>> Sent: Monday, February 12, 2018 5:18 PM
>>>>>> To: dev@royale.apache.org
>>>>>><mailto:dev@royale.apache.org><mailto:dev@royale.apache.org
>>>>>><mailto:dev@royale.apache.org>>
>>>>>> Subject: Re: Build failed in Jenkins: royale-typedefs #139
>>>>>> 
>>>>>> Does anyone understand the patch file syntax enough to guess what’s
>>>>>> wrong?
>>>>>> 
>>>>>>> On Feb 12, 2018, at 5:15 PM, Yishay Weiss >>>>>><mailto:yishayj...@hotmail.com>>
>>>>>>> wrote:
>>>>>>> 
>>>>>>> I  have the same result with ant on my machine. It’s probably a
>>>>>>> windows/mac thing.
>>>>>>> 
>>>>>>> From: Piotr Zarzycki<mailto:piotrzarzyck...@gmail.com
>>>>>>><mailto:piotrzarzyck...@gmail.com>>
>>>>>>> Sent: Monday, February 12, 2018 3:13 PM
>>>>>>> To: dev@royale.apache.org
>>>>>>><mailto:dev@royale.apache.org><mailto:dev@royale.apache.org
>>>>>>><mailto:dev@royale.apache.org>>
>>>>>>> Subject: Re: Build

Re: Build failed in Jenkins: royale-typedefs #139

2018-02-12 Thread Gabe Harbs
We could fork the Google externs on Github and update those. If we pull from 
the forked repo, we would be able to quickly make changes that we need and make 
PRs back to Google. That would also make it easy to pull in changes that are 
made to Google’s repo.

Harbs

> On Feb 12, 2018, at 10:00 PM, Alex Harui  wrote:
> 
> For js.patch, see the js/build.xml in royale-typedefs and the make_patch
> target.
> 
> Lately, I've been thinking about finding some other way of dealing with
> this.  We used patches so we didn't have to host 3rd-party files in our
> source tree.  I think we may now have 3rd-party files elsewhere in our
> source tree so we could just put patched versions in our source tree and
> update LICENSE and headers appropriately.  There is an issue with staying
> synced up with the master 3rd-party file.  And, we could make
> pull-requests on the 3rd-party file in some cases.
> 
> Thoughts?
> -Alex 
> 
> On 2/12/18, 11:23 AM, "Gabe Harbs"  <mailto:harbs.li...@gmail.com>> wrote:
> 
>> Where is that and how do I add to the patches?
>> 
>>> On Feb 12, 2018, at 7:31 PM, Alex Harui 
>>> wrote:
>>> 
>>> Patch files are auto-generated by the Ant script, verified by a build,
>>> then committed to the src/main/patch/js.patch so that the Maven build
>>> can
>>> use it.  If we choose to try to manually maintain the patch files, we
>>> should comment out the auto-generation in the Ant build, otherwise as
>>> soon
>>> as someone uses it, it will blow away manual changes.  And if you had
>>> auto-generated the patch file, it probably wouldn't have had formatting
>>> issues.
>>> 
>>> HTH,
>>> -Alex
>>> 
>>> On 2/12/18, 8:26 AM, "Yishay Weiss" >> <mailto:yishayj...@hotmail.com <mailto:yishayj...@hotmail.com>>> wrote:
>>> 
>>>> Add, see my later mail.
>>>> 
>>>> From: Gabe Harbs<mailto:harbs.li...@gmail.com 
>>>> <mailto:harbs.li...@gmail.com>>
>>>> Sent: Monday, February 12, 2018 6:23 PM
>>>> To: dev@royale.apache.org 
>>>> <mailto:dev@royale.apache.org><mailto:dev@royale.apache.org 
>>>> <mailto:dev@royale.apache.org>>
>>>> Subject: Re: Build failed in Jenkins: royale-typedefs #139
>>>> 
>>>> What was it? Did you add a space, or remove a space?
>>>>> On Feb 12, 2018, at 6:11 PM, Yishay Weiss >>>> <mailto:yishayj...@hotmail.com>>
>>>>> wrote:
>>>>> 
>>>>> I fixed it for my machine. Hopefully Jenkins will be happy too.
>>>>> 
>>>>> From: Gabe Harbs<mailto:harbs.li...@gmail.com 
>>>>> <mailto:harbs.li...@gmail.com>>
>>>>> Sent: Monday, February 12, 2018 5:18 PM
>>>>> To: dev@royale.apache.org 
>>>>> <mailto:dev@royale.apache.org><mailto:dev@royale.apache.org 
>>>>> <mailto:dev@royale.apache.org>>
>>>>> Subject: Re: Build failed in Jenkins: royale-typedefs #139
>>>>> 
>>>>> Does anyone understand the patch file syntax enough to guess what’s
>>>>> wrong?
>>>>> 
>>>>>> On Feb 12, 2018, at 5:15 PM, Yishay Weiss >>>>> <mailto:yishayj...@hotmail.com>>
>>>>>> wrote:
>>>>>> 
>>>>>> I  have the same result with ant on my machine. It’s probably a
>>>>>> windows/mac thing.
>>>>>> 
>>>>>> From: Piotr Zarzycki<mailto:piotrzarzyck...@gmail.com 
>>>>>> <mailto:piotrzarzyck...@gmail.com>>
>>>>>> Sent: Monday, February 12, 2018 3:13 PM
>>>>>> To: dev@royale.apache.org 
>>>>>> <mailto:dev@royale.apache.org><mailto:dev@royale.apache.org 
>>>>>> <mailto:dev@royale.apache.org>>
>>>>>> Subject: Re: Build failed in Jenkins: royale-typedefs #139
>>>>>> 
>>>>>> Locally I have same result. I tried couple of things but nothing
>>>>>> help.
>>>>>> I
>>>>>> see that it is being applied by following command:
>>>>>> 
>>>>>> [DEBUG] Executing command line: [C:\Program Files\Git\cmd\git.exe,
>>>>>> apply,
>>>>>> --ignore-whitespace, --whitespace=nowarn,
>>>>>> D:\Work\royale-sources\royale-typedefs\js/src/main/patch/js.patch]
>>>>&

Re: Build failed in Jenkins: royale-typedefs #139

2018-02-12 Thread Alex Harui
For js.patch, see the js/build.xml in royale-typedefs and the make_patch
target.

Lately, I've been thinking about finding some other way of dealing with
this.  We used patches so we didn't have to host 3rd-party files in our
source tree.  I think we may now have 3rd-party files elsewhere in our
source tree so we could just put patched versions in our source tree and
update LICENSE and headers appropriately.  There is an issue with staying
synced up with the master 3rd-party file.  And, we could make
pull-requests on the 3rd-party file in some cases.

Thoughts?
-Alex 

On 2/12/18, 11:23 AM, "Gabe Harbs"  wrote:

>Where is that and how do I add to the patches?
>
>> On Feb 12, 2018, at 7:31 PM, Alex Harui 
>>wrote:
>> 
>> Patch files are auto-generated by the Ant script, verified by a build,
>> then committed to the src/main/patch/js.patch so that the Maven build
>>can
>> use it.  If we choose to try to manually maintain the patch files, we
>> should comment out the auto-generation in the Ant build, otherwise as
>>soon
>> as someone uses it, it will blow away manual changes.  And if you had
>> auto-generated the patch file, it probably wouldn't have had formatting
>> issues.
>> 
>> HTH,
>> -Alex
>> 
>> On 2/12/18, 8:26 AM, "Yishay Weiss" ><mailto:yishayj...@hotmail.com>> wrote:
>> 
>>> Add, see my later mail.
>>> 
>>> From: Gabe Harbs<mailto:harbs.li...@gmail.com>
>>> Sent: Monday, February 12, 2018 6:23 PM
>>> To: dev@royale.apache.org<mailto:dev@royale.apache.org>
>>> Subject: Re: Build failed in Jenkins: royale-typedefs #139
>>> 
>>> What was it? Did you add a space, or remove a space?
>>>> On Feb 12, 2018, at 6:11 PM, Yishay Weiss 
>>>> wrote:
>>>> 
>>>> I fixed it for my machine. Hopefully Jenkins will be happy too.
>>>> 
>>>> From: Gabe Harbs<mailto:harbs.li...@gmail.com>
>>>> Sent: Monday, February 12, 2018 5:18 PM
>>>> To: dev@royale.apache.org<mailto:dev@royale.apache.org>
>>>> Subject: Re: Build failed in Jenkins: royale-typedefs #139
>>>> 
>>>> Does anyone understand the patch file syntax enough to guess what’s
>>>> wrong?
>>>> 
>>>>> On Feb 12, 2018, at 5:15 PM, Yishay Weiss 
>>>>> wrote:
>>>>> 
>>>>> I  have the same result with ant on my machine. It’s probably a
>>>>> windows/mac thing.
>>>>> 
>>>>> From: Piotr Zarzycki<mailto:piotrzarzyck...@gmail.com>
>>>>> Sent: Monday, February 12, 2018 3:13 PM
>>>>> To: dev@royale.apache.org<mailto:dev@royale.apache.org>
>>>>> Subject: Re: Build failed in Jenkins: royale-typedefs #139
>>>>> 
>>>>> Locally I have same result. I tried couple of things but nothing
>>>>>help.
>>>>> I
>>>>> see that it is being applied by following command:
>>>>> 
>>>>> [DEBUG] Executing command line: [C:\Program Files\Git\cmd\git.exe,
>>>>> apply,
>>>>> --ignore-whitespace, --whitespace=nowarn,
>>>>> D:\Work\royale-sources\royale-typedefs\js/src/main/patch/js.patch]
>>>>> error: corrupt patch at line 64
>>>>> 
>>>>> Thanks, Piotr
>>>>> 
>>>>> 
>>>>> 2018-02-12 13:47 GMT+01:00 Gabe Harbs :
>>>>> 
>>>>>> Thanks.
>>>>>> 
>>>>>>> On Feb 12, 2018, at 2:43 PM, Piotr Zarzycki
>>>>>>> 
>>>>>> wrote:
>>>>>>> 
>>>>>>> Let me build typedefs locally by Maven will see.
>>>>>>> 
>>>>>>> 2018-02-12 13:36 GMT+01:00 Gabe Harbs :
>>>>>>> 
>>>>>>>> I have no idea why this failed. The patch applied on my machine
>>>>>>>>and
>>>>>>>> line
>>>>>>>> 64 is an empty line.
>>>>>>>> 
>>>>>>>> Maybe it’s a Windows line ending problem?
>>>>>>>> 
>>>>>>>> Thoughts?
>>>>>>>> Harbs
>>>>>>>> 
>>>>>>>>> On Feb 12, 2018, at 2:12 PM, apacheroyal...@gmail.com wrote:
>>>>>>>>> 
>>>>>>>>> See 
>>>>>>>>> 
>>>>>>>>><htt

Re: Build failed in Jenkins: royale-typedefs #139

2018-02-12 Thread Gabe Harbs
Where is that and how do I add to the patches?

> On Feb 12, 2018, at 7:31 PM, Alex Harui  wrote:
> 
> Patch files are auto-generated by the Ant script, verified by a build,
> then committed to the src/main/patch/js.patch so that the Maven build can
> use it.  If we choose to try to manually maintain the patch files, we
> should comment out the auto-generation in the Ant build, otherwise as soon
> as someone uses it, it will blow away manual changes.  And if you had
> auto-generated the patch file, it probably wouldn't have had formatting
> issues.
> 
> HTH,
> -Alex
> 
> On 2/12/18, 8:26 AM, "Yishay Weiss"  <mailto:yishayj...@hotmail.com>> wrote:
> 
>> Add, see my later mail.
>> 
>> From: Gabe Harbs<mailto:harbs.li...@gmail.com>
>> Sent: Monday, February 12, 2018 6:23 PM
>> To: dev@royale.apache.org<mailto:dev@royale.apache.org>
>> Subject: Re: Build failed in Jenkins: royale-typedefs #139
>> 
>> What was it? Did you add a space, or remove a space?
>>> On Feb 12, 2018, at 6:11 PM, Yishay Weiss 
>>> wrote:
>>> 
>>> I fixed it for my machine. Hopefully Jenkins will be happy too.
>>> 
>>> From: Gabe Harbs<mailto:harbs.li...@gmail.com>
>>> Sent: Monday, February 12, 2018 5:18 PM
>>> To: dev@royale.apache.org<mailto:dev@royale.apache.org>
>>> Subject: Re: Build failed in Jenkins: royale-typedefs #139
>>> 
>>> Does anyone understand the patch file syntax enough to guess what’s
>>> wrong?
>>> 
>>>> On Feb 12, 2018, at 5:15 PM, Yishay Weiss 
>>>> wrote:
>>>> 
>>>> I  have the same result with ant on my machine. It’s probably a
>>>> windows/mac thing.
>>>> 
>>>> From: Piotr Zarzycki<mailto:piotrzarzyck...@gmail.com>
>>>> Sent: Monday, February 12, 2018 3:13 PM
>>>> To: dev@royale.apache.org<mailto:dev@royale.apache.org>
>>>> Subject: Re: Build failed in Jenkins: royale-typedefs #139
>>>> 
>>>> Locally I have same result. I tried couple of things but nothing help.
>>>> I
>>>> see that it is being applied by following command:
>>>> 
>>>> [DEBUG] Executing command line: [C:\Program Files\Git\cmd\git.exe,
>>>> apply,
>>>> --ignore-whitespace, --whitespace=nowarn,
>>>> D:\Work\royale-sources\royale-typedefs\js/src/main/patch/js.patch]
>>>> error: corrupt patch at line 64
>>>> 
>>>> Thanks, Piotr
>>>> 
>>>> 
>>>> 2018-02-12 13:47 GMT+01:00 Gabe Harbs :
>>>> 
>>>>> Thanks.
>>>>> 
>>>>>> On Feb 12, 2018, at 2:43 PM, Piotr Zarzycki
>>>>>> 
>>>>> wrote:
>>>>>> 
>>>>>> Let me build typedefs locally by Maven will see.
>>>>>> 
>>>>>> 2018-02-12 13:36 GMT+01:00 Gabe Harbs :
>>>>>> 
>>>>>>> I have no idea why this failed. The patch applied on my machine and
>>>>>>> line
>>>>>>> 64 is an empty line.
>>>>>>> 
>>>>>>> Maybe it’s a Windows line ending problem?
>>>>>>> 
>>>>>>> Thoughts?
>>>>>>> Harbs
>>>>>>> 
>>>>>>>> On Feb 12, 2018, at 2:12 PM, apacheroyal...@gmail.com wrote:
>>>>>>>> 
>>>>>>>> See 
>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapa 
>>>>>>>> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapa>
>>>>>>>> cheroyaleci.westus2.cloudapp.azure.com 
>>>>>>>> <http://cheroyaleci.westus2.cloudapp.azure.com/>&data=02%7C01%7Caharui%40adobe
>>>>>>>> .com%7Ca91f37b4a59c41d2dead08d5723574f0%7Cfa7b1b5a7b34438794aed2c178
>>>>>>>> decee1%7C0%7C0%7C636540496276826984&sdata=LL61UmzMw2XOCgf3qyF5QdqkfK
>>>>>>>> iJJpsRUGawhg2Ub8s%3D&reserved=0:
>>>>>>> 8080/job/royale-typedefs/139/display/redirect>
>>>>>>>> 
>>>>>>>> --
>>>>>>>> Started by upstream project "royale-compiler" build number 89
>>>>>>>> originally caused by:
>>>>>>>> Started by timer
>>>>>>>> Building in workspace <http

Re: Build failed in Jenkins: royale-typedefs #139

2018-02-12 Thread Alex Harui
Patch files are auto-generated by the Ant script, verified by a build,
then committed to the src/main/patch/js.patch so that the Maven build can
use it.  If we choose to try to manually maintain the patch files, we
should comment out the auto-generation in the Ant build, otherwise as soon
as someone uses it, it will blow away manual changes.  And if you had
auto-generated the patch file, it probably wouldn't have had formatting
issues.

HTH,
-Alex

On 2/12/18, 8:26 AM, "Yishay Weiss"  wrote:

>Add, see my later mail.
>
>From: Gabe Harbs<mailto:harbs.li...@gmail.com>
>Sent: Monday, February 12, 2018 6:23 PM
>To: dev@royale.apache.org<mailto:dev@royale.apache.org>
>Subject: Re: Build failed in Jenkins: royale-typedefs #139
>
>What was it? Did you add a space, or remove a space?
>> On Feb 12, 2018, at 6:11 PM, Yishay Weiss 
>>wrote:
>>
>> I fixed it for my machine. Hopefully Jenkins will be happy too.
>>
>> From: Gabe Harbs<mailto:harbs.li...@gmail.com>
>> Sent: Monday, February 12, 2018 5:18 PM
>> To: dev@royale.apache.org<mailto:dev@royale.apache.org>
>> Subject: Re: Build failed in Jenkins: royale-typedefs #139
>>
>> Does anyone understand the patch file syntax enough to guess what’s
>>wrong?
>>
>>> On Feb 12, 2018, at 5:15 PM, Yishay Weiss 
>>>wrote:
>>>
>>> I  have the same result with ant on my machine. It’s probably a
>>>windows/mac thing.
>>>
>>> From: Piotr Zarzycki<mailto:piotrzarzyck...@gmail.com>
>>> Sent: Monday, February 12, 2018 3:13 PM
>>> To: dev@royale.apache.org<mailto:dev@royale.apache.org>
>>> Subject: Re: Build failed in Jenkins: royale-typedefs #139
>>>
>>> Locally I have same result. I tried couple of things but nothing help.
>>>I
>>> see that it is being applied by following command:
>>>
>>> [DEBUG] Executing command line: [C:\Program Files\Git\cmd\git.exe,
>>>apply,
>>> --ignore-whitespace, --whitespace=nowarn,
>>> D:\Work\royale-sources\royale-typedefs\js/src/main/patch/js.patch]
>>> error: corrupt patch at line 64
>>>
>>> Thanks, Piotr
>>>
>>>
>>> 2018-02-12 13:47 GMT+01:00 Gabe Harbs :
>>>
>>>> Thanks.
>>>>
>>>>> On Feb 12, 2018, at 2:43 PM, Piotr Zarzycki
>>>>>
>>>> wrote:
>>>>>
>>>>> Let me build typedefs locally by Maven will see.
>>>>>
>>>>> 2018-02-12 13:36 GMT+01:00 Gabe Harbs :
>>>>>
>>>>>> I have no idea why this failed. The patch applied on my machine and
>>>>>>line
>>>>>> 64 is an empty line.
>>>>>>
>>>>>> Maybe it’s a Windows line ending problem?
>>>>>>
>>>>>> Thoughts?
>>>>>> Harbs
>>>>>>
>>>>>>> On Feb 12, 2018, at 2:12 PM, apacheroyal...@gmail.com wrote:
>>>>>>>
>>>>>>> See 
>>>>>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapa
>>>>>>>cheroyaleci.westus2.cloudapp.azure.com&data=02%7C01%7Caharui%40adobe
>>>>>>>.com%7Ca91f37b4a59c41d2dead08d5723574f0%7Cfa7b1b5a7b34438794aed2c178
>>>>>>>decee1%7C0%7C0%7C636540496276826984&sdata=LL61UmzMw2XOCgf3qyF5QdqkfK
>>>>>>>iJJpsRUGawhg2Ub8s%3D&reserved=0:
>>>>>> 8080/job/royale-typedefs/139/display/redirect>
>>>>>>>
>>>>>>> --
>>>>>>> Started by upstream project "royale-compiler" build number 89
>>>>>>> originally caused by:
>>>>>>> Started by timer
>>>>>>> Building in workspace <http://apacheroyaleci.
>>>> westus2.cloudapp.azure.com:
>>>>>> 8080/job/royale-typedefs/ws/>
>>>>>>>> git.exe rev-parse --is-inside-work-tree # timeout=10
>>>>>>> Fetching changes from the remote Git repository
>>>>>>>> git.exe config remote.origin.url
>>>>>>>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi
>>>>>>>>thub.com%2Fapache%2F&data=02%7C01%7Caharui%40adobe.com%7Ca91f37b4a5
>>>>>>>>9c41d2dead08d5723574f0%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7
>>>>>>>>C636540496276826984&sdata=FXlM%2FFyn1mwiw%2BLJ94iCQbRKHmSodySX4xRIW
>>>

RE: Build failed in Jenkins: royale-typedefs #139

2018-02-12 Thread Yishay Weiss
Add, see my later mail.

From: Gabe Harbs<mailto:harbs.li...@gmail.com>
Sent: Monday, February 12, 2018 6:23 PM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: Re: Build failed in Jenkins: royale-typedefs #139

What was it? Did you add a space, or remove a space?
> On Feb 12, 2018, at 6:11 PM, Yishay Weiss  wrote:
>
> I fixed it for my machine. Hopefully Jenkins will be happy too.
>
> From: Gabe Harbs<mailto:harbs.li...@gmail.com>
> Sent: Monday, February 12, 2018 5:18 PM
> To: dev@royale.apache.org<mailto:dev@royale.apache.org>
> Subject: Re: Build failed in Jenkins: royale-typedefs #139
>
> Does anyone understand the patch file syntax enough to guess what’s wrong?
>
>> On Feb 12, 2018, at 5:15 PM, Yishay Weiss  wrote:
>>
>> I  have the same result with ant on my machine. It’s probably a windows/mac 
>> thing.
>>
>> From: Piotr Zarzycki<mailto:piotrzarzyck...@gmail.com>
>> Sent: Monday, February 12, 2018 3:13 PM
>> To: dev@royale.apache.org<mailto:dev@royale.apache.org>
>> Subject: Re: Build failed in Jenkins: royale-typedefs #139
>>
>> Locally I have same result. I tried couple of things but nothing help. I
>> see that it is being applied by following command:
>>
>> [DEBUG] Executing command line: [C:\Program Files\Git\cmd\git.exe, apply,
>> --ignore-whitespace, --whitespace=nowarn,
>> D:\Work\royale-sources\royale-typedefs\js/src/main/patch/js.patch]
>> error: corrupt patch at line 64
>>
>> Thanks, Piotr
>>
>>
>> 2018-02-12 13:47 GMT+01:00 Gabe Harbs :
>>
>>> Thanks.
>>>
>>>> On Feb 12, 2018, at 2:43 PM, Piotr Zarzycki 
>>> wrote:
>>>>
>>>> Let me build typedefs locally by Maven will see.
>>>>
>>>> 2018-02-12 13:36 GMT+01:00 Gabe Harbs :
>>>>
>>>>> I have no idea why this failed. The patch applied on my machine and line
>>>>> 64 is an empty line.
>>>>>
>>>>> Maybe it’s a Windows line ending problem?
>>>>>
>>>>> Thoughts?
>>>>> Harbs
>>>>>
>>>>>> On Feb 12, 2018, at 2:12 PM, apacheroyal...@gmail.com wrote:
>>>>>>
>>>>>> See <http://apacheroyaleci.westus2.cloudapp.azure.com:
>>>>> 8080/job/royale-typedefs/139/display/redirect>
>>>>>>
>>>>>> --
>>>>>> Started by upstream project "royale-compiler" build number 89
>>>>>> originally caused by:
>>>>>> Started by timer
>>>>>> Building in workspace <http://apacheroyaleci.
>>> westus2.cloudapp.azure.com:
>>>>> 8080/job/royale-typedefs/ws/>
>>>>>>> git.exe rev-parse --is-inside-work-tree # timeout=10
>>>>>> Fetching changes from the remote Git repository
>>>>>>> git.exe config remote.origin.url https://github.com/apache/
>>>>> royale-typedefs.git # timeout=10
>>>>>> Fetching upstream changes from https://github.com/apache/
>>>>> royale-typedefs.git
>>>>>>> git.exe --version # timeout=10
>>>>>>> git.exe fetch --tags --progress https://github.com/apache/
>>>>> royale-typedefs.git +refs/heads/*:refs/remotes/origin/*
>>>>>>> git.exe rev-parse "refs/remotes/origin/develop^{commit}" # timeout=10
>>>>>>> git.exe rev-parse "refs/remotes/origin/origin/develop^{commit}" #
>>>>> timeout=10
>>>>>> Checking out Revision b50b80fa675d06c5b8e9145b1b3f2e54784f25a8
>>>>> (refs/remotes/origin/develop)
>>>>>>> git.exe config core.sparsecheckout # timeout=10
>>>>>>> git.exe checkout -f b50b80fa675d06c5b8e9145b1b3f2e54784f25a8
>>>>>> Commit message: "Added overflowX and overflowY"
>>>>>>> git.exe rev-list --no-walk b50b80fa675d06c5b8e9145b1b3f2e54784f25a8 #
>>>>> timeout=10
>>>>>> [royale-typedefs] $ cmd.exe /C "C:\apache\apache-ant-1.9.9\bin\ant.bat
>>>>> main && exit %%ERRORLEVEL%%"
>>>>>> Buildfile: <http://apacheroyaleci.westus2.cloudapp.azure.com:
>>>>> 8080/job/royale-typedefs/ws/build.xml>
>>>>>>
>>>>>> main:
>>>>>>
>>>>>> download:
>>>>>>  [echo] <http://apacheroyaleci.westus2.cloudapp.azure.com:
>>>>> 8080/job

Re: Build failed in Jenkins: royale-typedefs #139

2018-02-12 Thread Gabe Harbs
What was it? Did you add a space, or remove a space?
> On Feb 12, 2018, at 6:11 PM, Yishay Weiss  wrote:
> 
> I fixed it for my machine. Hopefully Jenkins will be happy too.
> 
> From: Gabe Harbs<mailto:harbs.li...@gmail.com>
> Sent: Monday, February 12, 2018 5:18 PM
> To: dev@royale.apache.org<mailto:dev@royale.apache.org>
> Subject: Re: Build failed in Jenkins: royale-typedefs #139
> 
> Does anyone understand the patch file syntax enough to guess what’s wrong?
> 
>> On Feb 12, 2018, at 5:15 PM, Yishay Weiss  wrote:
>> 
>> I  have the same result with ant on my machine. It’s probably a windows/mac 
>> thing.
>> 
>> From: Piotr Zarzycki<mailto:piotrzarzyck...@gmail.com>
>> Sent: Monday, February 12, 2018 3:13 PM
>> To: dev@royale.apache.org<mailto:dev@royale.apache.org>
>> Subject: Re: Build failed in Jenkins: royale-typedefs #139
>> 
>> Locally I have same result. I tried couple of things but nothing help. I
>> see that it is being applied by following command:
>> 
>> [DEBUG] Executing command line: [C:\Program Files\Git\cmd\git.exe, apply,
>> --ignore-whitespace, --whitespace=nowarn,
>> D:\Work\royale-sources\royale-typedefs\js/src/main/patch/js.patch]
>> error: corrupt patch at line 64
>> 
>> Thanks, Piotr
>> 
>> 
>> 2018-02-12 13:47 GMT+01:00 Gabe Harbs :
>> 
>>> Thanks.
>>> 
>>>> On Feb 12, 2018, at 2:43 PM, Piotr Zarzycki 
>>> wrote:
>>>> 
>>>> Let me build typedefs locally by Maven will see.
>>>> 
>>>> 2018-02-12 13:36 GMT+01:00 Gabe Harbs :
>>>> 
>>>>> I have no idea why this failed. The patch applied on my machine and line
>>>>> 64 is an empty line.
>>>>> 
>>>>> Maybe it’s a Windows line ending problem?
>>>>> 
>>>>> Thoughts?
>>>>> Harbs
>>>>> 
>>>>>> On Feb 12, 2018, at 2:12 PM, apacheroyal...@gmail.com wrote:
>>>>>> 
>>>>>> See <http://apacheroyaleci.westus2.cloudapp.azure.com:
>>>>> 8080/job/royale-typedefs/139/display/redirect>
>>>>>> 
>>>>>> --
>>>>>> Started by upstream project "royale-compiler" build number 89
>>>>>> originally caused by:
>>>>>> Started by timer
>>>>>> Building in workspace <http://apacheroyaleci.
>>> westus2.cloudapp.azure.com:
>>>>> 8080/job/royale-typedefs/ws/>
>>>>>>> git.exe rev-parse --is-inside-work-tree # timeout=10
>>>>>> Fetching changes from the remote Git repository
>>>>>>> git.exe config remote.origin.url https://github.com/apache/
>>>>> royale-typedefs.git # timeout=10
>>>>>> Fetching upstream changes from https://github.com/apache/
>>>>> royale-typedefs.git
>>>>>>> git.exe --version # timeout=10
>>>>>>> git.exe fetch --tags --progress https://github.com/apache/
>>>>> royale-typedefs.git +refs/heads/*:refs/remotes/origin/*
>>>>>>> git.exe rev-parse "refs/remotes/origin/develop^{commit}" # timeout=10
>>>>>>> git.exe rev-parse "refs/remotes/origin/origin/develop^{commit}" #
>>>>> timeout=10
>>>>>> Checking out Revision b50b80fa675d06c5b8e9145b1b3f2e54784f25a8
>>>>> (refs/remotes/origin/develop)
>>>>>>> git.exe config core.sparsecheckout # timeout=10
>>>>>>> git.exe checkout -f b50b80fa675d06c5b8e9145b1b3f2e54784f25a8
>>>>>> Commit message: "Added overflowX and overflowY"
>>>>>>> git.exe rev-list --no-walk b50b80fa675d06c5b8e9145b1b3f2e54784f25a8 #
>>>>> timeout=10
>>>>>> [royale-typedefs] $ cmd.exe /C "C:\apache\apache-ant-1.9.9\bin\ant.bat
>>>>> main && exit %%ERRORLEVEL%%"
>>>>>> Buildfile: <http://apacheroyaleci.westus2.cloudapp.azure.com:
>>>>> 8080/job/royale-typedefs/ws/build.xml>
>>>>>> 
>>>>>> main:
>>>>>> 
>>>>>> download:
>>>>>>  [echo] <http://apacheroyaleci.westus2.cloudapp.azure.com:
>>>>> 8080/job/royale-typedefs/ws/js/..>
>>>>>> [unjar] Expanding: C:\Program Files (x86)\Jenkins\workspace\
>>>>> royale-compiler\compiler-jx\lib\google\closure-compiler\compiler.jar

Re: Build failed in Jenkins: royale-typedefs #139

2018-02-12 Thread Piotr Zarzycki
Yishay,

I did try it the same and it didn't work to me. Your commit helps. Weird.
:)

Thanks, Piotr

2018-02-12 17:11 GMT+01:00 Yishay Weiss :

> I fixed it for my machine. Hopefully Jenkins will be happy too.
>
> From: Gabe Harbs<mailto:harbs.li...@gmail.com>
> Sent: Monday, February 12, 2018 5:18 PM
> To: dev@royale.apache.org<mailto:dev@royale.apache.org>
> Subject: Re: Build failed in Jenkins: royale-typedefs #139
>
> Does anyone understand the patch file syntax enough to guess what’s wrong?
>
> > On Feb 12, 2018, at 5:15 PM, Yishay Weiss 
> wrote:
> >
> > I  have the same result with ant on my machine. It’s probably a
> windows/mac thing.
> >
> > From: Piotr Zarzycki<mailto:piotrzarzyck...@gmail.com>
> > Sent: Monday, February 12, 2018 3:13 PM
> > To: dev@royale.apache.org<mailto:dev@royale.apache.org>
> > Subject: Re: Build failed in Jenkins: royale-typedefs #139
> >
> > Locally I have same result. I tried couple of things but nothing help. I
> > see that it is being applied by following command:
> >
> > [DEBUG] Executing command line: [C:\Program Files\Git\cmd\git.exe, apply,
> > --ignore-whitespace, --whitespace=nowarn,
> > D:\Work\royale-sources\royale-typedefs\js/src/main/patch/js.patch]
> > error: corrupt patch at line 64
> >
> > Thanks, Piotr
> >
> >
> > 2018-02-12 13:47 GMT+01:00 Gabe Harbs :
> >
> >> Thanks.
> >>
> >>> On Feb 12, 2018, at 2:43 PM, Piotr Zarzycki  >
> >> wrote:
> >>>
> >>> Let me build typedefs locally by Maven will see.
> >>>
> >>> 2018-02-12 13:36 GMT+01:00 Gabe Harbs :
> >>>
> >>>> I have no idea why this failed. The patch applied on my machine and
> line
> >>>> 64 is an empty line.
> >>>>
> >>>> Maybe it’s a Windows line ending problem?
> >>>>
> >>>> Thoughts?
> >>>> Harbs
> >>>>
> >>>>> On Feb 12, 2018, at 2:12 PM, apacheroyal...@gmail.com wrote:
> >>>>>
> >>>>> See <http://apacheroyaleci.westus2.cloudapp.azure.com:
> >>>> 8080/job/royale-typedefs/139/display/redirect>
> >>>>>
> >>>>> --
> >>>>> Started by upstream project "royale-compiler" build number 89
> >>>>> originally caused by:
> >>>>> Started by timer
> >>>>> Building in workspace <http://apacheroyaleci.
> >> westus2.cloudapp.azure.com:
> >>>> 8080/job/royale-typedefs/ws/>
> >>>>>> git.exe rev-parse --is-inside-work-tree # timeout=10
> >>>>> Fetching changes from the remote Git repository
> >>>>>> git.exe config remote.origin.url https://github.com/apache/
> >>>> royale-typedefs.git # timeout=10
> >>>>> Fetching upstream changes from https://github.com/apache/
> >>>> royale-typedefs.git
> >>>>>> git.exe --version # timeout=10
> >>>>>> git.exe fetch --tags --progress https://github.com/apache/
> >>>> royale-typedefs.git +refs/heads/*:refs/remotes/origin/*
> >>>>>> git.exe rev-parse "refs/remotes/origin/develop^{commit}" #
> timeout=10
> >>>>>> git.exe rev-parse "refs/remotes/origin/origin/develop^{commit}" #
> >>>> timeout=10
> >>>>> Checking out Revision b50b80fa675d06c5b8e9145b1b3f2e54784f25a8
> >>>> (refs/remotes/origin/develop)
> >>>>>> git.exe config core.sparsecheckout # timeout=10
> >>>>>> git.exe checkout -f b50b80fa675d06c5b8e9145b1b3f2e54784f25a8
> >>>>> Commit message: "Added overflowX and overflowY"
> >>>>>> git.exe rev-list --no-walk b50b80fa675d06c5b8e9145b1b3f2e54784f25a8
> #
> >>>> timeout=10
> >>>>> [royale-typedefs] $ cmd.exe /C "C:\apache\apache-ant-1.9.9\
> bin\ant.bat
> >>>> main && exit %%ERRORLEVEL%%"
> >>>>> Buildfile: <http://apacheroyaleci.westus2.cloudapp.azure.com:
> >>>> 8080/job/royale-typedefs/ws/build.xml>
> >>>>>
> >>>>> main:
> >>>>>
> >>>>> download:
> >>>>>   [echo] <http://apacheroyaleci.westus2.cloudapp.azure.com:
> >>>> 8080/job/royale-typedefs/ws/js/..>
> >>>>>  [unjar] Expanding: C:\Program Files (x86)\Jen

RE: Build failed in Jenkins: royale-typedefs #139

2018-02-12 Thread Yishay Weiss
I fixed it for my machine. Hopefully Jenkins will be happy too.

From: Gabe Harbs<mailto:harbs.li...@gmail.com>
Sent: Monday, February 12, 2018 5:18 PM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: Re: Build failed in Jenkins: royale-typedefs #139

Does anyone understand the patch file syntax enough to guess what’s wrong?

> On Feb 12, 2018, at 5:15 PM, Yishay Weiss  wrote:
>
> I  have the same result with ant on my machine. It’s probably a windows/mac 
> thing.
>
> From: Piotr Zarzycki<mailto:piotrzarzyck...@gmail.com>
> Sent: Monday, February 12, 2018 3:13 PM
> To: dev@royale.apache.org<mailto:dev@royale.apache.org>
> Subject: Re: Build failed in Jenkins: royale-typedefs #139
>
> Locally I have same result. I tried couple of things but nothing help. I
> see that it is being applied by following command:
>
> [DEBUG] Executing command line: [C:\Program Files\Git\cmd\git.exe, apply,
> --ignore-whitespace, --whitespace=nowarn,
> D:\Work\royale-sources\royale-typedefs\js/src/main/patch/js.patch]
> error: corrupt patch at line 64
>
> Thanks, Piotr
>
>
> 2018-02-12 13:47 GMT+01:00 Gabe Harbs :
>
>> Thanks.
>>
>>> On Feb 12, 2018, at 2:43 PM, Piotr Zarzycki 
>> wrote:
>>>
>>> Let me build typedefs locally by Maven will see.
>>>
>>> 2018-02-12 13:36 GMT+01:00 Gabe Harbs :
>>>
>>>> I have no idea why this failed. The patch applied on my machine and line
>>>> 64 is an empty line.
>>>>
>>>> Maybe it’s a Windows line ending problem?
>>>>
>>>> Thoughts?
>>>> Harbs
>>>>
>>>>> On Feb 12, 2018, at 2:12 PM, apacheroyal...@gmail.com wrote:
>>>>>
>>>>> See <http://apacheroyaleci.westus2.cloudapp.azure.com:
>>>> 8080/job/royale-typedefs/139/display/redirect>
>>>>>
>>>>> --
>>>>> Started by upstream project "royale-compiler" build number 89
>>>>> originally caused by:
>>>>> Started by timer
>>>>> Building in workspace <http://apacheroyaleci.
>> westus2.cloudapp.azure.com:
>>>> 8080/job/royale-typedefs/ws/>
>>>>>> git.exe rev-parse --is-inside-work-tree # timeout=10
>>>>> Fetching changes from the remote Git repository
>>>>>> git.exe config remote.origin.url https://github.com/apache/
>>>> royale-typedefs.git # timeout=10
>>>>> Fetching upstream changes from https://github.com/apache/
>>>> royale-typedefs.git
>>>>>> git.exe --version # timeout=10
>>>>>> git.exe fetch --tags --progress https://github.com/apache/
>>>> royale-typedefs.git +refs/heads/*:refs/remotes/origin/*
>>>>>> git.exe rev-parse "refs/remotes/origin/develop^{commit}" # timeout=10
>>>>>> git.exe rev-parse "refs/remotes/origin/origin/develop^{commit}" #
>>>> timeout=10
>>>>> Checking out Revision b50b80fa675d06c5b8e9145b1b3f2e54784f25a8
>>>> (refs/remotes/origin/develop)
>>>>>> git.exe config core.sparsecheckout # timeout=10
>>>>>> git.exe checkout -f b50b80fa675d06c5b8e9145b1b3f2e54784f25a8
>>>>> Commit message: "Added overflowX and overflowY"
>>>>>> git.exe rev-list --no-walk b50b80fa675d06c5b8e9145b1b3f2e54784f25a8 #
>>>> timeout=10
>>>>> [royale-typedefs] $ cmd.exe /C "C:\apache\apache-ant-1.9.9\bin\ant.bat
>>>> main && exit %%ERRORLEVEL%%"
>>>>> Buildfile: <http://apacheroyaleci.westus2.cloudapp.azure.com:
>>>> 8080/job/royale-typedefs/ws/build.xml>
>>>>>
>>>>> main:
>>>>>
>>>>> download:
>>>>>   [echo] <http://apacheroyaleci.westus2.cloudapp.azure.com:
>>>> 8080/job/royale-typedefs/ws/js/..>
>>>>>  [unjar] Expanding: C:\Program Files (x86)\Jenkins\workspace\
>>>> royale-compiler\compiler-jx\lib\google\closure-compiler\compiler.jar
>> into
>>>> <http://apacheroyaleci.westus2.cloudapp.azure.com:
>>>> 8080/job/royale-typedefs/ws/js/target/temp/externs>
>>>>>  [unzip] Expanding: <http://apacheroyaleci.westus2.cloudapp.azure.com
>> :
>>>> 8080/job/royale-typedefs/ws/js/target/temp/externs/externs.zip> into <
>>>> http://apacheroyaleci.westus2.cloudapp.azure.com:
>>>> 8080/job/royale-typedefs/ws/js/target/downloads>
>>>>>

Re: Build failed in Jenkins: royale-typedefs #139

2018-02-12 Thread Gabe Harbs
Does anyone understand the patch file syntax enough to guess what’s wrong?

> On Feb 12, 2018, at 5:15 PM, Yishay Weiss  wrote:
> 
> I  have the same result with ant on my machine. It’s probably a windows/mac 
> thing.
> 
> From: Piotr Zarzycki<mailto:piotrzarzyck...@gmail.com>
> Sent: Monday, February 12, 2018 3:13 PM
> To: dev@royale.apache.org<mailto:dev@royale.apache.org>
> Subject: Re: Build failed in Jenkins: royale-typedefs #139
> 
> Locally I have same result. I tried couple of things but nothing help. I
> see that it is being applied by following command:
> 
> [DEBUG] Executing command line: [C:\Program Files\Git\cmd\git.exe, apply,
> --ignore-whitespace, --whitespace=nowarn,
> D:\Work\royale-sources\royale-typedefs\js/src/main/patch/js.patch]
> error: corrupt patch at line 64
> 
> Thanks, Piotr
> 
> 
> 2018-02-12 13:47 GMT+01:00 Gabe Harbs :
> 
>> Thanks.
>> 
>>> On Feb 12, 2018, at 2:43 PM, Piotr Zarzycki 
>> wrote:
>>> 
>>> Let me build typedefs locally by Maven will see.
>>> 
>>> 2018-02-12 13:36 GMT+01:00 Gabe Harbs :
>>> 
>>>> I have no idea why this failed. The patch applied on my machine and line
>>>> 64 is an empty line.
>>>> 
>>>> Maybe it’s a Windows line ending problem?
>>>> 
>>>> Thoughts?
>>>> Harbs
>>>> 
>>>>> On Feb 12, 2018, at 2:12 PM, apacheroyal...@gmail.com wrote:
>>>>> 
>>>>> See <http://apacheroyaleci.westus2.cloudapp.azure.com:
>>>> 8080/job/royale-typedefs/139/display/redirect>
>>>>> 
>>>>> --
>>>>> Started by upstream project "royale-compiler" build number 89
>>>>> originally caused by:
>>>>> Started by timer
>>>>> Building in workspace <http://apacheroyaleci.
>> westus2.cloudapp.azure.com:
>>>> 8080/job/royale-typedefs/ws/>
>>>>>> git.exe rev-parse --is-inside-work-tree # timeout=10
>>>>> Fetching changes from the remote Git repository
>>>>>> git.exe config remote.origin.url https://github.com/apache/
>>>> royale-typedefs.git # timeout=10
>>>>> Fetching upstream changes from https://github.com/apache/
>>>> royale-typedefs.git
>>>>>> git.exe --version # timeout=10
>>>>>> git.exe fetch --tags --progress https://github.com/apache/
>>>> royale-typedefs.git +refs/heads/*:refs/remotes/origin/*
>>>>>> git.exe rev-parse "refs/remotes/origin/develop^{commit}" # timeout=10
>>>>>> git.exe rev-parse "refs/remotes/origin/origin/develop^{commit}" #
>>>> timeout=10
>>>>> Checking out Revision b50b80fa675d06c5b8e9145b1b3f2e54784f25a8
>>>> (refs/remotes/origin/develop)
>>>>>> git.exe config core.sparsecheckout # timeout=10
>>>>>> git.exe checkout -f b50b80fa675d06c5b8e9145b1b3f2e54784f25a8
>>>>> Commit message: "Added overflowX and overflowY"
>>>>>> git.exe rev-list --no-walk b50b80fa675d06c5b8e9145b1b3f2e54784f25a8 #
>>>> timeout=10
>>>>> [royale-typedefs] $ cmd.exe /C "C:\apache\apache-ant-1.9.9\bin\ant.bat
>>>> main && exit %%ERRORLEVEL%%"
>>>>> Buildfile: <http://apacheroyaleci.westus2.cloudapp.azure.com:
>>>> 8080/job/royale-typedefs/ws/build.xml>
>>>>> 
>>>>> main:
>>>>> 
>>>>> download:
>>>>>   [echo] <http://apacheroyaleci.westus2.cloudapp.azure.com:
>>>> 8080/job/royale-typedefs/ws/js/..>
>>>>>  [unjar] Expanding: C:\Program Files (x86)\Jenkins\workspace\
>>>> royale-compiler\compiler-jx\lib\google\closure-compiler\compiler.jar
>> into
>>>> <http://apacheroyaleci.westus2.cloudapp.azure.com:
>>>> 8080/job/royale-typedefs/ws/js/target/temp/externs>
>>>>>  [unzip] Expanding: <http://apacheroyaleci.westus2.cloudapp.azure.com
>> :
>>>> 8080/job/royale-typedefs/ws/js/target/temp/externs/externs.zip> into <
>>>> http://apacheroyaleci.westus2.cloudapp.azure.com:
>>>> 8080/job/royale-typedefs/ws/js/target/downloads>
>>>>>[get] Getting: https://storage.googleapis.com/google-code-archive-
>>>> downloads/v2/code.google.com/closureidl/svg.js
>>>>>[get] To: <http://apacheroyaleci.westus2.cloudapp.azure.com:
>>>> 8080/job/royale-typedefs/ws/js/target/downloads/svg.js>
>>>>> 
>>>>> double-check-file:
>>>>>   [echo] ${env.ROYALE_DOWNLOAD_CACHE}
>>>>>   [echo] Need file: ${still_no_file}
>>>>> 
>>>>> get-from-cache-if-needed:
>>>>> 
>>>>> fail-if-not-found:
>>>>> 
>>>>> preprocess:
>>>>>   [exec] error: corrupt patch at line 64
>>>>> 
>>>>> BUILD FAILED
>>>>> <http://apacheroyaleci.westus2.cloudapp.azure.com:
>>>> 8080/job/royale-typedefs/ws/build.xml>:52: The following error occurred
>>>> while executing this line:
>>>>> <http://apacheroyaleci.westus2.cloudapp.azure.com:
>>>> 8080/job/royale-typedefs/ws/js/build.xml>:149: exec returned: 128
>>>>> 
>>>>> Total time: 2 seconds
>>>>> Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8
>>>>> Build step 'Invoke Ant' marked build as failure
>>>> 
>>>> 
>>> 
>>> 
>>> --
>>> 
>>> Piotr Zarzycki
>>> 
>>> Patreon: *https://www.patreon.com/piotrzarzycki
>>> <https://www.patreon.com/piotrzarzycki>*
>> 
>> 
> 
> 
> --
> 
> Piotr Zarzycki
> 
> Patreon: *https://www.patreon.com/piotrzarzycki
> <https://www.patreon.com/piotrzarzycki>*
> 



RE: Build failed in Jenkins: royale-typedefs #139

2018-02-12 Thread Yishay Weiss
I  have the same result with ant on my machine. It’s probably a windows/mac 
thing.

From: Piotr Zarzycki<mailto:piotrzarzyck...@gmail.com>
Sent: Monday, February 12, 2018 3:13 PM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: Re: Build failed in Jenkins: royale-typedefs #139

Locally I have same result. I tried couple of things but nothing help. I
see that it is being applied by following command:

[DEBUG] Executing command line: [C:\Program Files\Git\cmd\git.exe, apply,
--ignore-whitespace, --whitespace=nowarn,
D:\Work\royale-sources\royale-typedefs\js/src/main/patch/js.patch]
error: corrupt patch at line 64

Thanks, Piotr


2018-02-12 13:47 GMT+01:00 Gabe Harbs :

> Thanks.
>
> > On Feb 12, 2018, at 2:43 PM, Piotr Zarzycki 
> wrote:
> >
> > Let me build typedefs locally by Maven will see.
> >
> > 2018-02-12 13:36 GMT+01:00 Gabe Harbs :
> >
> >> I have no idea why this failed. The patch applied on my machine and line
> >> 64 is an empty line.
> >>
> >> Maybe it’s a Windows line ending problem?
> >>
> >> Thoughts?
> >> Harbs
> >>
> >>> On Feb 12, 2018, at 2:12 PM, apacheroyal...@gmail.com wrote:
> >>>
> >>> See <http://apacheroyaleci.westus2.cloudapp.azure.com:
> >> 8080/job/royale-typedefs/139/display/redirect>
> >>>
> >>> --
> >>> Started by upstream project "royale-compiler" build number 89
> >>> originally caused by:
> >>> Started by timer
> >>> Building in workspace <http://apacheroyaleci.
> westus2.cloudapp.azure.com:
> >> 8080/job/royale-typedefs/ws/>
> >>>> git.exe rev-parse --is-inside-work-tree # timeout=10
> >>> Fetching changes from the remote Git repository
> >>>> git.exe config remote.origin.url https://github.com/apache/
> >> royale-typedefs.git # timeout=10
> >>> Fetching upstream changes from https://github.com/apache/
> >> royale-typedefs.git
> >>>> git.exe --version # timeout=10
> >>>> git.exe fetch --tags --progress https://github.com/apache/
> >> royale-typedefs.git +refs/heads/*:refs/remotes/origin/*
> >>>> git.exe rev-parse "refs/remotes/origin/develop^{commit}" # timeout=10
> >>>> git.exe rev-parse "refs/remotes/origin/origin/develop^{commit}" #
> >> timeout=10
> >>> Checking out Revision b50b80fa675d06c5b8e9145b1b3f2e54784f25a8
> >> (refs/remotes/origin/develop)
> >>>> git.exe config core.sparsecheckout # timeout=10
> >>>> git.exe checkout -f b50b80fa675d06c5b8e9145b1b3f2e54784f25a8
> >>> Commit message: "Added overflowX and overflowY"
> >>>> git.exe rev-list --no-walk b50b80fa675d06c5b8e9145b1b3f2e54784f25a8 #
> >> timeout=10
> >>> [royale-typedefs] $ cmd.exe /C "C:\apache\apache-ant-1.9.9\bin\ant.bat
> >> main && exit %%ERRORLEVEL%%"
> >>> Buildfile: <http://apacheroyaleci.westus2.cloudapp.azure.com:
> >> 8080/job/royale-typedefs/ws/build.xml>
> >>>
> >>> main:
> >>>
> >>> download:
> >>>[echo] <http://apacheroyaleci.westus2.cloudapp.azure.com:
> >> 8080/job/royale-typedefs/ws/js/..>
> >>>   [unjar] Expanding: C:\Program Files (x86)\Jenkins\workspace\
> >> royale-compiler\compiler-jx\lib\google\closure-compiler\compiler.jar
> into
> >> <http://apacheroyaleci.westus2.cloudapp.azure.com:
> >> 8080/job/royale-typedefs/ws/js/target/temp/externs>
> >>>   [unzip] Expanding: <http://apacheroyaleci.westus2.cloudapp.azure.com
> :
> >> 8080/job/royale-typedefs/ws/js/target/temp/externs/externs.zip> into <
> >> http://apacheroyaleci.westus2.cloudapp.azure.com:
> >> 8080/job/royale-typedefs/ws/js/target/downloads>
> >>> [get] Getting: https://storage.googleapis.com/google-code-archive-
> >> downloads/v2/code.google.com/closureidl/svg.js
> >>> [get] To: <http://apacheroyaleci.westus2.cloudapp.azure.com:
> >> 8080/job/royale-typedefs/ws/js/target/downloads/svg.js>
> >>>
> >>> double-check-file:
> >>>[echo] ${env.ROYALE_DOWNLOAD_CACHE}
> >>>[echo] Need file: ${still_no_file}
> >>>
> >>> get-from-cache-if-needed:
> >>>
> >>> fail-if-not-found:
> >>>
> >>> preprocess:
> >>>[exec] error: corrupt patch at line 64
> >>>
> >>> BUILD FAILED
> >>> <http://apacheroyaleci.westus2.cloudapp.azure.com:
> >> 8080/job/royale-typedefs/ws/build.xml>:52: The following error occurred
> >> while executing this line:
> >>> <http://apacheroyaleci.westus2.cloudapp.azure.com:
> >> 8080/job/royale-typedefs/ws/js/build.xml>:149: exec returned: 128
> >>>
> >>> Total time: 2 seconds
> >>> Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8
> >>> Build step 'Invoke Ant' marked build as failure
> >>
> >>
> >
> >
> > --
> >
> > Piotr Zarzycki
> >
> > Patreon: *https://www.patreon.com/piotrzarzycki
> > <https://www.patreon.com/piotrzarzycki>*
>
>


--

Piotr Zarzycki

Patreon: *https://www.patreon.com/piotrzarzycki
<https://www.patreon.com/piotrzarzycki>*



Re: Build failed in Jenkins: royale-typedefs #139

2018-02-12 Thread Piotr Zarzycki
Locally I have same result. I tried couple of things but nothing help. I
see that it is being applied by following command:

[DEBUG] Executing command line: [C:\Program Files\Git\cmd\git.exe, apply,
--ignore-whitespace, --whitespace=nowarn,
D:\Work\royale-sources\royale-typedefs\js/src/main/patch/js.patch]
error: corrupt patch at line 64

Thanks, Piotr


2018-02-12 13:47 GMT+01:00 Gabe Harbs :

> Thanks.
>
> > On Feb 12, 2018, at 2:43 PM, Piotr Zarzycki 
> wrote:
> >
> > Let me build typedefs locally by Maven will see.
> >
> > 2018-02-12 13:36 GMT+01:00 Gabe Harbs :
> >
> >> I have no idea why this failed. The patch applied on my machine and line
> >> 64 is an empty line.
> >>
> >> Maybe it’s a Windows line ending problem?
> >>
> >> Thoughts?
> >> Harbs
> >>
> >>> On Feb 12, 2018, at 2:12 PM, apacheroyal...@gmail.com wrote:
> >>>
> >>> See  >> 8080/job/royale-typedefs/139/display/redirect>
> >>>
> >>> --
> >>> Started by upstream project "royale-compiler" build number 89
> >>> originally caused by:
> >>> Started by timer
> >>> Building in workspace  westus2.cloudapp.azure.com:
> >> 8080/job/royale-typedefs/ws/>
>  git.exe rev-parse --is-inside-work-tree # timeout=10
> >>> Fetching changes from the remote Git repository
>  git.exe config remote.origin.url https://github.com/apache/
> >> royale-typedefs.git # timeout=10
> >>> Fetching upstream changes from https://github.com/apache/
> >> royale-typedefs.git
>  git.exe --version # timeout=10
>  git.exe fetch --tags --progress https://github.com/apache/
> >> royale-typedefs.git +refs/heads/*:refs/remotes/origin/*
>  git.exe rev-parse "refs/remotes/origin/develop^{commit}" # timeout=10
>  git.exe rev-parse "refs/remotes/origin/origin/develop^{commit}" #
> >> timeout=10
> >>> Checking out Revision b50b80fa675d06c5b8e9145b1b3f2e54784f25a8
> >> (refs/remotes/origin/develop)
>  git.exe config core.sparsecheckout # timeout=10
>  git.exe checkout -f b50b80fa675d06c5b8e9145b1b3f2e54784f25a8
> >>> Commit message: "Added overflowX and overflowY"
>  git.exe rev-list --no-walk b50b80fa675d06c5b8e9145b1b3f2e54784f25a8 #
> >> timeout=10
> >>> [royale-typedefs] $ cmd.exe /C "C:\apache\apache-ant-1.9.9\bin\ant.bat
> >> main && exit %%ERRORLEVEL%%"
> >>> Buildfile:  >> 8080/job/royale-typedefs/ws/build.xml>
> >>>
> >>> main:
> >>>
> >>> download:
> >>>[echo]  >> 8080/job/royale-typedefs/ws/js/..>
> >>>   [unjar] Expanding: C:\Program Files (x86)\Jenkins\workspace\
> >> royale-compiler\compiler-jx\lib\google\closure-compiler\compiler.jar
> into
> >>  >> 8080/job/royale-typedefs/ws/js/target/temp/externs>
> >>>   [unzip] Expanding:  :
> >> 8080/job/royale-typedefs/ws/js/target/temp/externs/externs.zip> into <
> >> http://apacheroyaleci.westus2.cloudapp.azure.com:
> >> 8080/job/royale-typedefs/ws/js/target/downloads>
> >>> [get] Getting: https://storage.googleapis.com/google-code-archive-
> >> downloads/v2/code.google.com/closureidl/svg.js
> >>> [get] To:  >> 8080/job/royale-typedefs/ws/js/target/downloads/svg.js>
> >>>
> >>> double-check-file:
> >>>[echo] ${env.ROYALE_DOWNLOAD_CACHE}
> >>>[echo] Need file: ${still_no_file}
> >>>
> >>> get-from-cache-if-needed:
> >>>
> >>> fail-if-not-found:
> >>>
> >>> preprocess:
> >>>[exec] error: corrupt patch at line 64
> >>>
> >>> BUILD FAILED
> >>>  >> 8080/job/royale-typedefs/ws/build.xml>:52: The following error occurred
> >> while executing this line:
> >>>  >> 8080/job/royale-typedefs/ws/js/build.xml>:149: exec returned: 128
> >>>
> >>> Total time: 2 seconds
> >>> Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8
> >>> Build step 'Invoke Ant' marked build as failure
> >>
> >>
> >
> >
> > --
> >
> > Piotr Zarzycki
> >
> > Patreon: *https://www.patreon.com/piotrzarzycki
> > *
>
>


-- 

Piotr Zarzycki

Patreon: *https://www.patreon.com/piotrzarzycki
*


Re: Build failed in Jenkins: royale-typedefs #139

2018-02-12 Thread Gabe Harbs
Thanks.

> On Feb 12, 2018, at 2:43 PM, Piotr Zarzycki  wrote:
> 
> Let me build typedefs locally by Maven will see.
> 
> 2018-02-12 13:36 GMT+01:00 Gabe Harbs :
> 
>> I have no idea why this failed. The patch applied on my machine and line
>> 64 is an empty line.
>> 
>> Maybe it’s a Windows line ending problem?
>> 
>> Thoughts?
>> Harbs
>> 
>>> On Feb 12, 2018, at 2:12 PM, apacheroyal...@gmail.com wrote:
>>> 
>>> See > 8080/job/royale-typedefs/139/display/redirect>
>>> 
>>> --
>>> Started by upstream project "royale-compiler" build number 89
>>> originally caused by:
>>> Started by timer
>>> Building in workspace > 8080/job/royale-typedefs/ws/>
 git.exe rev-parse --is-inside-work-tree # timeout=10
>>> Fetching changes from the remote Git repository
 git.exe config remote.origin.url https://github.com/apache/
>> royale-typedefs.git # timeout=10
>>> Fetching upstream changes from https://github.com/apache/
>> royale-typedefs.git
 git.exe --version # timeout=10
 git.exe fetch --tags --progress https://github.com/apache/
>> royale-typedefs.git +refs/heads/*:refs/remotes/origin/*
 git.exe rev-parse "refs/remotes/origin/develop^{commit}" # timeout=10
 git.exe rev-parse "refs/remotes/origin/origin/develop^{commit}" #
>> timeout=10
>>> Checking out Revision b50b80fa675d06c5b8e9145b1b3f2e54784f25a8
>> (refs/remotes/origin/develop)
 git.exe config core.sparsecheckout # timeout=10
 git.exe checkout -f b50b80fa675d06c5b8e9145b1b3f2e54784f25a8
>>> Commit message: "Added overflowX and overflowY"
 git.exe rev-list --no-walk b50b80fa675d06c5b8e9145b1b3f2e54784f25a8 #
>> timeout=10
>>> [royale-typedefs] $ cmd.exe /C "C:\apache\apache-ant-1.9.9\bin\ant.bat
>> main && exit %%ERRORLEVEL%%"
>>> Buildfile: > 8080/job/royale-typedefs/ws/build.xml>
>>> 
>>> main:
>>> 
>>> download:
>>>[echo] > 8080/job/royale-typedefs/ws/js/..>
>>>   [unjar] Expanding: C:\Program Files (x86)\Jenkins\workspace\
>> royale-compiler\compiler-jx\lib\google\closure-compiler\compiler.jar into
>> > 8080/job/royale-typedefs/ws/js/target/temp/externs>
>>>   [unzip] Expanding: > 8080/job/royale-typedefs/ws/js/target/temp/externs/externs.zip> into <
>> http://apacheroyaleci.westus2.cloudapp.azure.com:
>> 8080/job/royale-typedefs/ws/js/target/downloads>
>>> [get] Getting: https://storage.googleapis.com/google-code-archive-
>> downloads/v2/code.google.com/closureidl/svg.js
>>> [get] To: > 8080/job/royale-typedefs/ws/js/target/downloads/svg.js>
>>> 
>>> double-check-file:
>>>[echo] ${env.ROYALE_DOWNLOAD_CACHE}
>>>[echo] Need file: ${still_no_file}
>>> 
>>> get-from-cache-if-needed:
>>> 
>>> fail-if-not-found:
>>> 
>>> preprocess:
>>>[exec] error: corrupt patch at line 64
>>> 
>>> BUILD FAILED
>>> > 8080/job/royale-typedefs/ws/build.xml>:52: The following error occurred
>> while executing this line:
>>> > 8080/job/royale-typedefs/ws/js/build.xml>:149: exec returned: 128
>>> 
>>> Total time: 2 seconds
>>> Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8
>>> Build step 'Invoke Ant' marked build as failure
>> 
>> 
> 
> 
> -- 
> 
> Piotr Zarzycki
> 
> Patreon: *https://www.patreon.com/piotrzarzycki
> *



Re: Build failed in Jenkins: royale-typedefs #139

2018-02-12 Thread Piotr Zarzycki
Let me build typedefs locally by Maven will see.

2018-02-12 13:36 GMT+01:00 Gabe Harbs :

> I have no idea why this failed. The patch applied on my machine and line
> 64 is an empty line.
>
> Maybe it’s a Windows line ending problem?
>
> Thoughts?
> Harbs
>
> > On Feb 12, 2018, at 2:12 PM, apacheroyal...@gmail.com wrote:
> >
> > See  8080/job/royale-typedefs/139/display/redirect>
> >
> > --
> > Started by upstream project "royale-compiler" build number 89
> > originally caused by:
> > Started by timer
> > Building in workspace  8080/job/royale-typedefs/ws/>
> >> git.exe rev-parse --is-inside-work-tree # timeout=10
> > Fetching changes from the remote Git repository
> >> git.exe config remote.origin.url https://github.com/apache/
> royale-typedefs.git # timeout=10
> > Fetching upstream changes from https://github.com/apache/
> royale-typedefs.git
> >> git.exe --version # timeout=10
> >> git.exe fetch --tags --progress https://github.com/apache/
> royale-typedefs.git +refs/heads/*:refs/remotes/origin/*
> >> git.exe rev-parse "refs/remotes/origin/develop^{commit}" # timeout=10
> >> git.exe rev-parse "refs/remotes/origin/origin/develop^{commit}" #
> timeout=10
> > Checking out Revision b50b80fa675d06c5b8e9145b1b3f2e54784f25a8
> (refs/remotes/origin/develop)
> >> git.exe config core.sparsecheckout # timeout=10
> >> git.exe checkout -f b50b80fa675d06c5b8e9145b1b3f2e54784f25a8
> > Commit message: "Added overflowX and overflowY"
> >> git.exe rev-list --no-walk b50b80fa675d06c5b8e9145b1b3f2e54784f25a8 #
> timeout=10
> > [royale-typedefs] $ cmd.exe /C "C:\apache\apache-ant-1.9.9\bin\ant.bat
> main && exit %%ERRORLEVEL%%"
> > Buildfile:  8080/job/royale-typedefs/ws/build.xml>
> >
> > main:
> >
> > download:
> > [echo]  8080/job/royale-typedefs/ws/js/..>
> >[unjar] Expanding: C:\Program Files (x86)\Jenkins\workspace\
> royale-compiler\compiler-jx\lib\google\closure-compiler\compiler.jar into
>  8080/job/royale-typedefs/ws/js/target/temp/externs>
> >[unzip] Expanding:  8080/job/royale-typedefs/ws/js/target/temp/externs/externs.zip> into <
> http://apacheroyaleci.westus2.cloudapp.azure.com:
> 8080/job/royale-typedefs/ws/js/target/downloads>
> >  [get] Getting: https://storage.googleapis.com/google-code-archive-
> downloads/v2/code.google.com/closureidl/svg.js
> >  [get] To:  8080/job/royale-typedefs/ws/js/target/downloads/svg.js>
> >
> > double-check-file:
> > [echo] ${env.ROYALE_DOWNLOAD_CACHE}
> > [echo] Need file: ${still_no_file}
> >
> > get-from-cache-if-needed:
> >
> > fail-if-not-found:
> >
> > preprocess:
> > [exec] error: corrupt patch at line 64
> >
> > BUILD FAILED
> >  8080/job/royale-typedefs/ws/build.xml>:52: The following error occurred
> while executing this line:
> >  8080/job/royale-typedefs/ws/js/build.xml>:149: exec returned: 128
> >
> > Total time: 2 seconds
> > Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8
> > Build step 'Invoke Ant' marked build as failure
>
>


-- 

Piotr Zarzycki

Patreon: *https://www.patreon.com/piotrzarzycki
*


Re: Build failed in Jenkins: royale-typedefs #139

2018-02-12 Thread Gabe Harbs
I have no idea why this failed. The patch applied on my machine and line 64 is 
an empty line.

Maybe it’s a Windows line ending problem?

Thoughts?
Harbs

> On Feb 12, 2018, at 2:12 PM, apacheroyal...@gmail.com wrote:
> 
> See 
> 
> 
> --
> Started by upstream project "royale-compiler" build number 89
> originally caused by:
> Started by timer
> Building in workspace 
> 
>> git.exe rev-parse --is-inside-work-tree # timeout=10
> Fetching changes from the remote Git repository
>> git.exe config remote.origin.url 
>> https://github.com/apache/royale-typedefs.git # timeout=10
> Fetching upstream changes from https://github.com/apache/royale-typedefs.git
>> git.exe --version # timeout=10
>> git.exe fetch --tags --progress 
>> https://github.com/apache/royale-typedefs.git 
>> +refs/heads/*:refs/remotes/origin/*
>> git.exe rev-parse "refs/remotes/origin/develop^{commit}" # timeout=10
>> git.exe rev-parse "refs/remotes/origin/origin/develop^{commit}" # timeout=10
> Checking out Revision b50b80fa675d06c5b8e9145b1b3f2e54784f25a8 
> (refs/remotes/origin/develop)
>> git.exe config core.sparsecheckout # timeout=10
>> git.exe checkout -f b50b80fa675d06c5b8e9145b1b3f2e54784f25a8
> Commit message: "Added overflowX and overflowY"
>> git.exe rev-list --no-walk b50b80fa675d06c5b8e9145b1b3f2e54784f25a8 # 
>> timeout=10
> [royale-typedefs] $ cmd.exe /C "C:\apache\apache-ant-1.9.9\bin\ant.bat main 
> && exit %%ERRORLEVEL%%"
> Buildfile: 
> 
> 
> main:
> 
> download:
> [echo] 
> 
>[unjar] Expanding: C:\Program Files 
> (x86)\Jenkins\workspace\royale-compiler\compiler-jx\lib\google\closure-compiler\compiler.jar
>  into 
> 
>[unzip] Expanding: 
> 
>  into 
> 
>  [get] Getting: 
> https://storage.googleapis.com/google-code-archive-downloads/v2/code.google.com/closureidl/svg.js
>  [get] To: 
> 
> 
> double-check-file:
> [echo] ${env.ROYALE_DOWNLOAD_CACHE}
> [echo] Need file: ${still_no_file}
> 
> get-from-cache-if-needed:
> 
> fail-if-not-found:
> 
> preprocess:
> [exec] error: corrupt patch at line 64
> 
> BUILD FAILED
> :52:
>  The following error occurred while executing this line:
> :149:
>  exec returned: 128
> 
> Total time: 2 seconds
> Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8
> Build step 'Invoke Ant' marked build as failure