Re: What you think about this fix - SearchFilter bead

2020-10-20 Thread Hugo Ferreira
Hi Carlos, You welcome. I saw your comments on github and also reply on that. Carlos Rovira escreveu no dia terça, 20/10/2020 à(s) 09:19: > Hi Hugo, > > much appreciate the effort. Many thanks! :) > > El mar., 20 oct. 2020 a las 2:21, Hugo Ferreira () > escribió: > > > Hi Carlos, > > > > Now

Re: What you think about this fix - SearchFilter bead

2020-10-20 Thread Carlos Rovira
Hi Hugo, much appreciate the effort. Many thanks! :) El mar., 20 oct. 2020 a las 2:21, Hugo Ferreira () escribió: > Hi Carlos, > > Now everything as it should be :) > > 1. Checked Jenkins to be sure to not apply the fix during another issue; > 2. Fork refreshed; > 3. Apply the fix; > 4.

Re: What you think about this fix - SearchFilter bead

2020-10-19 Thread Hugo Ferreira
Hi Carlos, Now everything as it should be :) 1. Checked Jenkins to be sure to not apply the fix during another issue; 2. Fork refreshed; 3. Apply the fix; 4. Compiled with ANT; 5. Test with TDJ (before the test, clean the browser console, test the fix and check for an error). 6. Commit; 7. Pull

Re: What you think about this fix - SearchFilter bead

2020-10-19 Thread Hugo Ferreira
Hi Carlos, No problem. I will do that. Carlos Rovira escreveu no dia segunda, 19/10/2020 à(s) 11:32: > Hi Hugo, > > sorry, but this way of sharing code is not the best for us to interact. > If I copy and override on my file, I get lots of errors and also its > unformatted, so to review it I

Re: What you think about this fix - SearchFilter bead

2020-10-19 Thread Carlos Rovira
Hi Hugo, sorry, but this way of sharing code is not the best for us to interact. If I copy and override on my file, I get lots of errors and also its unformatted, so to review it I should invest a lot of time formatting it and see where the email is adding bad characters. You can use

Re: What you think about this fix - SearchFilter bead

2020-10-18 Thread hferreira
Hi Carlos, I was able to replicate the issue on TDJ apply the fix and saw the issue goes away. BUT I had to clean everything and rebuild everything (I even put a console log to be sure that I was testing updated version). I thought that was normal. Thank you for point me out about the remove

Re: What you think about this fix - SearchFilter bead

2020-10-18 Thread Hugo Ferreira
Hi Carlos, I was able to replicate the issue on TDJ apply the fix and saw the issue goes away. BUT I had to clean everything and rebuild everything (I even put a console log to be sure that I was testing updated version). I thought that was normal. Thank you for point me out about the remove

Re: What you think about this fix - SearchFilter bead

2020-10-18 Thread Hugo Ferreira
Hi Carlos, I was able to replicate the issue on TDJ apply the fix and saw the issue goes away. BUT I had to clean everything and rebuild everything (I even put a console log to be sure that I was testing updated version). I thought that was normal. Thank you for point me out about the remove

Re: What you think about this fix - SearchFilter bead

2020-10-18 Thread Carlos Rovira
Hi Hugo, when I tried that code I had to add the imports too. Anyway I tried again, and I'm getting the same fail in the TDJ SearchFilter example Are you getting the same? Also I think you'll need to remove the listener when the popup closes, since the list is recreated again and a new listener

Re: What you think about this fix - SearchFilter bead

2020-10-18 Thread Hugo Ferreira
Hi Carlos, I was able to compile the Royale SDK with ant. Built the TDJ and replicate the exactly issue that you mention before. Applied a fix that keeps my original fix without the issue that you mention but this time directly from the compiled Royale SDK + TDJ. So, the new code is 2 new

Re: What you think about this fix - SearchFilter bead

2020-10-15 Thread Carlos Rovira
Ok Hugo, many thanks :) El jue., 15 oct. 2020 a las 1:50, Hugo Ferreira () escribió: > Hi Carlos, > > OK, let me try :) > > Carlos Rovira escreveu no dia quarta, 14/10/2020 > à(s) 08:29: > > > Hi Hugo, > > > > I'm trying that snippet in jewel with TDJ and as I start to interact with > > the

Re: What you think about this fix - SearchFilter bead

2020-10-14 Thread Hugo Ferreira
Hi Carlos, OK, let me try :) Carlos Rovira escreveu no dia quarta, 14/10/2020 à(s) 08:29: > Hi Hugo, > > I'm trying that snippet in jewel with TDJ and as I start to interact with > the CMB I get this: > > SearchFilter.as:123 Uncaught TypeError: Cannot read property > 'addEventListener' of null

Re: What you think about this fix - SearchFilter bead

2020-10-14 Thread Carlos Rovira
Hi Hugo, I'm trying that snippet in jewel with TDJ and as I start to interact with the CMB I get this: SearchFilter.as:123 Uncaught TypeError: Cannot read property 'addEventListener' of null at org.apache.royale.jewel.beads.controls.combobox.SearchFilter.set__list (SearchFilter.as:123)