Hi Piotr,
don't worry that was some of things I worried so much when working on MDL,
and for that reason I made most of the changes I did at that moment. In
Jewel I'll be doing the same ;)
2018-03-12 19:34 GMT+01:00 Piotr Zarzycki :
> Subclass, change it and remember
Subclass, change it and remember to test as I pointed with some custom
className setted in the example. See what happen.
Looking forward to the results.
Thanks,
Piotr
2018-03-12 19:30 GMT+01:00 Carlos Rovira :
> Hi Piotr,
> subclass will be most to test the use of
Hi Piotr,
subclass will be most to test the use of element.classList, a part from the
reverse order. I think element.classList will remove the need of much code
in jewel components about how to setup classes in those components
2018-03-12 19:27 GMT+01:00 Piotr Zarzycki
Hi Carlos,
These layout classes have worked fine for dozens of example. They are
small, simple and stupid.
I don't understand why, if you want vertical layout, you want to set a
child's display to "inline-block". That would not layout vertically
unless you are counting in line-wrapping. To
Hi Alex,
no, I want the normal effect of a vertical layout, since finaly is get in
both ways.
The problem for me is :
1) people that wants to change it must subclass layout to modify, instead
of override css rule
2) there's an excess of html code since in each component inside the layout
the
On 3/12/18, 10:11 AM, "carlos.rov...@gmail.com on behalf of Carlos Rovira"
wrote:
>>
>> I still don't get why, if your Button is a subcomponent, some framework
>> code was setting display style on it unless you were using a layout
If I would want an Vertical layout which do not affect as much your
children - I would create set of layouts beads which applies FlexBox rules
or Grid rules to the children. The things is that I would do this the same
way - by inline styles instead of css classes.
Why ? Look into my previous
HI Alex
2018-03-12 17:02 GMT+01:00 Alex Harui :
> Hi Carlos,
>
> As I said in my last post, you are welcome to write different layout
> classes. We don't all have to agree on "one right answer". There often
> isn't one right answer. Code up what you want to see and
Hi Carlos,
As I said in my last post, you are welcome to write different layout
classes. We don't all have to agree on "one right answer". There often
isn't one right answer. Code up what you want to see and document why you
like it. Our users will then be able to choose. We will probably
Hi,
I must say that I was wrong in some part of my argumentation. I though the
problem was in UIBase setting up things like display:block, but after
looking at layout code since Harbs pointed me try to duplicate it by my
side I saw is the vertical layout what was setting the inline styles. For
2018-03-12 11:29 GMT+01:00 Harbs :
>
> Can you explain why you care about inline CSS? I’m not getting it.
>
>
As I get the basis of jewel and jewel theme working right, I want to start
creating blog examples with the code and I know, people out there that
wants to see if we
Hi Piotr,
this issue is affecting all the code since is in basic.
You can check my branch and see it yourself, If you see the html code
you'll see all buttons with hardcoded style properties. What is not good at
all.
2018-03-12 10:20 GMT+01:00 Piotr Zarzycki :
>
HI Alex,
2018-03-12 8:17 GMT+01:00 Alex Harui :
> IMO some styles (padding, margin, font*) determine the "boxes", other
> styles (position, display) place the boxes.
I think almost the same
> The layouts will likely set
> position and display directly on the outer
Carlos,
Does your code with mentioned issue is in jewel branch ?
2018-03-12 10:15 GMT+01:00 Carlos Rovira :
> Hi Harbs,
>
> the frameworks I'm watching are MDL, Semantic and Bootstrap (all top
> frameworks) to see what they do in different cases and guide me to find
Hi Harbs,
the frameworks I'm watching are MDL, Semantic and Bootstrap (all top
frameworks) to see what they do in different cases and guide me to find the
best way to implement the HTML Jewel should output in royale in Royale. All
of this frameworks are only HTML/JS/CSS (not builds from other
IMO some styles (padding, margin, font*) determine the "boxes", other
styles (position, display) place the boxes. The layouts will likely set
position and display directly on the outer box of a component. The
defaults.css in Basic should not have any styles that determine the boxes.
Those
If you are trying to override the values, you probably need different beads.
There’s no other well known framework which builds HTML from code. At best they
stick pseudo-code inside HTML. That’s a huge difference between Royale and
anything else.
> On Mar 12, 2018, at 12:17 AM, Carlos Rovira
Hi Harbs,
but you are losing one important point here: When I try to override the
value with CSS I can't since style is always take before my css.
So my styles in my theme are not valid due to the styles in the framework.
And more over, did you see only one example out there in any well-known ui
Display:block is almost always the right choice. It’s set in the Layout bead.
I don’t agree on “clean” HTML. The only reason to use css classes is to enable
restyling (i.e. skinning) of an ap with different CSS sets. Otherwise, inline
CSS is probably more efficient than css files.
> On Mar 11,
19 matches
Mail list logo