Re: HTTP interface integration and unfinished project (s2rest_netty) removal.

2018-11-22 Thread DO YUNG YOON
Thanks, daewon. I will follow this on JIRA.

On Thu, Nov 22, 2018 at 3:33 PM daewon  wrote:

> I created an issue  for
> this discussion.
> I think we will make the decisions in JIRA and start working on them.
>
>
> 2018년 11월 22일 (목) 오후 2:00, DO YUNG YOON 님이 작성:
>
> > Thanks for getting involved in the discussion Woonsan.
> >
> > @deawon, can you please create the Jira issue for this?
> >
> > By the way, I merged S2GRAPH-246(integration of documents into S2Graph
> > project) into master yesterday, so I think we are ready to work on this.
> > What if we move the APIs one by one and document them together?
> >
> > Since we have to go through the full list of APIs, I think it is a good
> > time to document them also.
> >
> >
> >
> >
> >
> > On Thu, Nov 22, 2018 at 6:10 AM Woonsan Ko  wrote:
> >
> > > Now I see why it was broken. ;-)
> > > I recently re-subscribed the lists and started reading past messages to
> > > understand the context.
> > > I'm very looking forward to seeing the progress!
> > >
> > > Cheers,
> > >
> > > Woonsan
> > >
> > > On 2018/11/07 07:51:20, daewon  wrote:
> > > > I've looked at the features that are available to remove the Play!
> > > > Framework.
> > > >
> > > > I have written my comments for each function groups.
> > > >
> > > > - The Admin and Create APIs have yet to integrate many functions into
> > the
> > > > Play! controller code, so code separation must be preceded in order
> to
> > > move
> > > > functionality.
> > > > - The API with the `withWait` postfix of the Edge/Vertex creation API
> > is
> > > an
> > > > API that tells the client whether the request is applied correctly.
> > > >This is a duplicate API that exists for backward compatibility.
> > > > - Management routes are suggested to unify API routes with prefixes
> > such
> > > as
> > > > `/admin/?` or `/managment/?`.
> > > > - Server health_check or Counter related features are not available
> > > > anymore, so I suggest you exclude them.
> > > >
> > > > ## Edge creation
> > > >   ### List of APIs to leave
> > > > POST/graphs/edges/insert
> > > >
> > > > POST/graphs/edges/insertBulk
> > > > POST/graphs/edges/delete
> > > >
> > > > POST/graphs/edges/deleteAll
> > > >
> > > > POST/graphs/edges/deleteAllWithOutWait
> > > >
> > > > POST/graphs/edges/update
> > > >
> > > > POST/graphs/edges/increment
> > > > POST/graphs/edges/incrementCount
> > > > POST/graphs/edges/bulk
> > > >
> > > >   ### List of APIs that should be removed
> > > > POST/graphs/edges/deleteWithWait
> > > >
> > > > POST/graphs/edges/updateWithWait
> > > >
> > > > POST/graphs/edges/incrementWithWait
> > > >
> > > > POST/graphs/edges/bulkWithWait
> > > >
> > > > POST/graphs/edges/insertWithWait
> > > >
> > > >
> > > > ## Edge query
> > > >
> > > >   ### List of APIs to leave
> > > > POST/graphs/getEdges
> > > >
> > > > POST/graphs/checkEdges
> > > >
> > > >
> > > >   ### List of APIs that should be removed
> > > > POST/graphs/getEdgesGrouped
> > > >
> > > > POST/graphs/getEdgesGroupedExcluded
> > > >
> > > > POST/graphs/getEdgesGroupedExcludedFormatted
> > > >
> > > > GET /graphs/getEdge/:srcId/:tgtId/:labelName/:direction
> > > >
> > > > POST/graphs/getEdgesExcluded
> > > >
> > > > POST/graphs/getEdgesExcluded/grouped
> > > >
> > > > POST/graphs/getEdges/grouped
> > > >
> > > >
> > > >
> > > > ## Vertex related
> > > >   ### List of APIs to leave
> > > > POST/graphs/getVertices
> > > > POST/graphs/vertices/insert
> > > > POST/graphs/vertices/delete
> > > > POST/graphs/vertices/deleteAll
> > > >
> > > >   ### List of APIs that should be removed
> > > > POST/graphs/vertices/insert/:serviceName/:columnName
> > > > POST/graphs/vertices/delete/:serviceName/:columnName
> > > >
> > > > POST/graphs/vertices/deleteAll/:serviceName/:columnName
> > > >
> > > > POST/graphs/vertices/insertWithWait
> > > >
> > > > POST/graphs/vertices/deleteWithWait
> > > >
> > > >
> > > > ## Vertex related
> > > >   ### List of APIs to leave
> > > > POST/graphs/createService
> > > >
> > > > GET /graphs/getService/:serviceName
> > > >
> > > > GET /graphs/getLabels/:serviceName
> > > >
> > > > POST/graphs/createLabel
> > > >
> > > > POST/graphs/addIndex
> > > >
> > > > GET /graphs/getLabel/:labelName
> > > >
> > > > PUT /graphs/deleteLabelReally/:labelName
> > > >
> > > > POST/graphs/addProp/:labelName
> > > >
> > > > POST/graphs/createServiceColumn
> > > >
> > > > PUT /graphs/deleteServiceColumn/:serviceName/:columnName
> > > >
> > 

Re: HTTP interface integration and unfinished project (s2rest_netty) removal.

2018-11-21 Thread daewon
I created an issue  for
this discussion.
I think we will make the decisions in JIRA and start working on them.


2018년 11월 22일 (목) 오후 2:00, DO YUNG YOON 님이 작성:

> Thanks for getting involved in the discussion Woonsan.
>
> @deawon, can you please create the Jira issue for this?
>
> By the way, I merged S2GRAPH-246(integration of documents into S2Graph
> project) into master yesterday, so I think we are ready to work on this.
> What if we move the APIs one by one and document them together?
>
> Since we have to go through the full list of APIs, I think it is a good
> time to document them also.
>
>
>
>
>
> On Thu, Nov 22, 2018 at 6:10 AM Woonsan Ko  wrote:
>
> > Now I see why it was broken. ;-)
> > I recently re-subscribed the lists and started reading past messages to
> > understand the context.
> > I'm very looking forward to seeing the progress!
> >
> > Cheers,
> >
> > Woonsan
> >
> > On 2018/11/07 07:51:20, daewon  wrote:
> > > I've looked at the features that are available to remove the Play!
> > > Framework.
> > >
> > > I have written my comments for each function groups.
> > >
> > > - The Admin and Create APIs have yet to integrate many functions into
> the
> > > Play! controller code, so code separation must be preceded in order to
> > move
> > > functionality.
> > > - The API with the `withWait` postfix of the Edge/Vertex creation API
> is
> > an
> > > API that tells the client whether the request is applied correctly.
> > >This is a duplicate API that exists for backward compatibility.
> > > - Management routes are suggested to unify API routes with prefixes
> such
> > as
> > > `/admin/?` or `/managment/?`.
> > > - Server health_check or Counter related features are not available
> > > anymore, so I suggest you exclude them.
> > >
> > > ## Edge creation
> > >   ### List of APIs to leave
> > > POST/graphs/edges/insert
> > >
> > > POST/graphs/edges/insertBulk
> > > POST/graphs/edges/delete
> > >
> > > POST/graphs/edges/deleteAll
> > >
> > > POST/graphs/edges/deleteAllWithOutWait
> > >
> > > POST/graphs/edges/update
> > >
> > > POST/graphs/edges/increment
> > > POST/graphs/edges/incrementCount
> > > POST/graphs/edges/bulk
> > >
> > >   ### List of APIs that should be removed
> > > POST/graphs/edges/deleteWithWait
> > >
> > > POST/graphs/edges/updateWithWait
> > >
> > > POST/graphs/edges/incrementWithWait
> > >
> > > POST/graphs/edges/bulkWithWait
> > >
> > > POST/graphs/edges/insertWithWait
> > >
> > >
> > > ## Edge query
> > >
> > >   ### List of APIs to leave
> > > POST/graphs/getEdges
> > >
> > > POST/graphs/checkEdges
> > >
> > >
> > >   ### List of APIs that should be removed
> > > POST/graphs/getEdgesGrouped
> > >
> > > POST/graphs/getEdgesGroupedExcluded
> > >
> > > POST/graphs/getEdgesGroupedExcludedFormatted
> > >
> > > GET /graphs/getEdge/:srcId/:tgtId/:labelName/:direction
> > >
> > > POST/graphs/getEdgesExcluded
> > >
> > > POST/graphs/getEdgesExcluded/grouped
> > >
> > > POST/graphs/getEdges/grouped
> > >
> > >
> > >
> > > ## Vertex related
> > >   ### List of APIs to leave
> > > POST/graphs/getVertices
> > > POST/graphs/vertices/insert
> > > POST/graphs/vertices/delete
> > > POST/graphs/vertices/deleteAll
> > >
> > >   ### List of APIs that should be removed
> > > POST/graphs/vertices/insert/:serviceName/:columnName
> > > POST/graphs/vertices/delete/:serviceName/:columnName
> > >
> > > POST/graphs/vertices/deleteAll/:serviceName/:columnName
> > >
> > > POST/graphs/vertices/insertWithWait
> > >
> > > POST/graphs/vertices/deleteWithWait
> > >
> > >
> > > ## Vertex related
> > >   ### List of APIs to leave
> > > POST/graphs/createService
> > >
> > > GET /graphs/getService/:serviceName
> > >
> > > GET /graphs/getLabels/:serviceName
> > >
> > > POST/graphs/createLabel
> > >
> > > POST/graphs/addIndex
> > >
> > > GET /graphs/getLabel/:labelName
> > >
> > > PUT /graphs/deleteLabelReally/:labelName
> > >
> > > POST/graphs/addProp/:labelName
> > >
> > > POST/graphs/createServiceColumn
> > >
> > > PUT /graphs/deleteServiceColumn/:serviceName/:columnName
> > >
> > > POST/graphs/addServiceColumnProp/:serviceName/:columnName
> > >
> > > POST/graphs/addServiceColumnProps/:serviceName/:columnName
> > >
> > > GET /graphs/getServiceColumn/:serviceName/:columnName
> > >
> > > POST/graphs/createHTable
> > >
> > > GET /admin/labels/:serviceName
> > >
> > > POST

Re: HTTP interface integration and unfinished project (s2rest_netty) removal.

2018-11-21 Thread DO YUNG YOON
Thanks for getting involved in the discussion Woonsan.

@deawon, can you please create the Jira issue for this?

By the way, I merged S2GRAPH-246(integration of documents into S2Graph
project) into master yesterday, so I think we are ready to work on this.
What if we move the APIs one by one and document them together?

Since we have to go through the full list of APIs, I think it is a good
time to document them also.





On Thu, Nov 22, 2018 at 6:10 AM Woonsan Ko  wrote:

> Now I see why it was broken. ;-)
> I recently re-subscribed the lists and started reading past messages to
> understand the context.
> I'm very looking forward to seeing the progress!
>
> Cheers,
>
> Woonsan
>
> On 2018/11/07 07:51:20, daewon  wrote:
> > I've looked at the features that are available to remove the Play!
> > Framework.
> >
> > I have written my comments for each function groups.
> >
> > - The Admin and Create APIs have yet to integrate many functions into the
> > Play! controller code, so code separation must be preceded in order to
> move
> > functionality.
> > - The API with the `withWait` postfix of the Edge/Vertex creation API is
> an
> > API that tells the client whether the request is applied correctly.
> >This is a duplicate API that exists for backward compatibility.
> > - Management routes are suggested to unify API routes with prefixes such
> as
> > `/admin/?` or `/managment/?`.
> > - Server health_check or Counter related features are not available
> > anymore, so I suggest you exclude them.
> >
> > ## Edge creation
> >   ### List of APIs to leave
> > POST/graphs/edges/insert
> >
> > POST/graphs/edges/insertBulk
> > POST/graphs/edges/delete
> >
> > POST/graphs/edges/deleteAll
> >
> > POST/graphs/edges/deleteAllWithOutWait
> >
> > POST/graphs/edges/update
> >
> > POST/graphs/edges/increment
> > POST/graphs/edges/incrementCount
> > POST/graphs/edges/bulk
> >
> >   ### List of APIs that should be removed
> > POST/graphs/edges/deleteWithWait
> >
> > POST/graphs/edges/updateWithWait
> >
> > POST/graphs/edges/incrementWithWait
> >
> > POST/graphs/edges/bulkWithWait
> >
> > POST/graphs/edges/insertWithWait
> >
> >
> > ## Edge query
> >
> >   ### List of APIs to leave
> > POST/graphs/getEdges
> >
> > POST/graphs/checkEdges
> >
> >
> >   ### List of APIs that should be removed
> > POST/graphs/getEdgesGrouped
> >
> > POST/graphs/getEdgesGroupedExcluded
> >
> > POST/graphs/getEdgesGroupedExcludedFormatted
> >
> > GET /graphs/getEdge/:srcId/:tgtId/:labelName/:direction
> >
> > POST/graphs/getEdgesExcluded
> >
> > POST/graphs/getEdgesExcluded/grouped
> >
> > POST/graphs/getEdges/grouped
> >
> >
> >
> > ## Vertex related
> >   ### List of APIs to leave
> > POST/graphs/getVertices
> > POST/graphs/vertices/insert
> > POST/graphs/vertices/delete
> > POST/graphs/vertices/deleteAll
> >
> >   ### List of APIs that should be removed
> > POST/graphs/vertices/insert/:serviceName/:columnName
> > POST/graphs/vertices/delete/:serviceName/:columnName
> >
> > POST/graphs/vertices/deleteAll/:serviceName/:columnName
> >
> > POST/graphs/vertices/insertWithWait
> >
> > POST/graphs/vertices/deleteWithWait
> >
> >
> > ## Vertex related
> >   ### List of APIs to leave
> > POST/graphs/createService
> >
> > GET /graphs/getService/:serviceName
> >
> > GET /graphs/getLabels/:serviceName
> >
> > POST/graphs/createLabel
> >
> > POST/graphs/addIndex
> >
> > GET /graphs/getLabel/:labelName
> >
> > PUT /graphs/deleteLabelReally/:labelName
> >
> > POST/graphs/addProp/:labelName
> >
> > POST/graphs/createServiceColumn
> >
> > PUT /graphs/deleteServiceColumn/:serviceName/:columnName
> >
> > POST/graphs/addServiceColumnProp/:serviceName/:columnName
> >
> > POST/graphs/addServiceColumnProps/:serviceName/:columnName
> >
> > GET /graphs/getServiceColumn/:serviceName/:columnName
> >
> > POST/graphs/createHTable
> >
> > GET /admin/labels/:serviceName
> >
> > POST/graphs/copyLabel/:oldLabelName/:newLabelName
> >
> > POST/graphs/renameLabel/:oldLabelName/:newLabelName
> >
> > POST/graphs/swapLabels/:leftLabelName/:rightLabelName
> >
> > POST/graphs/updateHTable/:labelName/:newHTableName
> >
> > PUT /graphs/loadCache
> >
> >
> > ## Experiment related
> >   ### List of API to leave
> > POST/graphs/experiment/:accessToken/:experimentName/:uuid
> >
> > POST/graphs/experiments
> >
> >
> > ## publish (deprecated)
> >   ### List 

Re: HTTP interface integration and unfinished project (s2rest_netty) removal.

2018-11-21 Thread Woonsan Ko
Now I see why it was broken. ;-)
I recently re-subscribed the lists and started reading past messages to 
understand the context.
I'm very looking forward to seeing the progress!

Cheers,

Woonsan

On 2018/11/07 07:51:20, daewon  wrote: 
> I've looked at the features that are available to remove the Play!
> Framework.
> 
> I have written my comments for each function groups.
> 
> - The Admin and Create APIs have yet to integrate many functions into the
> Play! controller code, so code separation must be preceded in order to move
> functionality.
> - The API with the `withWait` postfix of the Edge/Vertex creation API is an
> API that tells the client whether the request is applied correctly.
>This is a duplicate API that exists for backward compatibility.
> - Management routes are suggested to unify API routes with prefixes such as
> `/admin/?` or `/managment/?`.
> - Server health_check or Counter related features are not available
> anymore, so I suggest you exclude them.
> 
> ## Edge creation
>   ### List of APIs to leave
> POST/graphs/edges/insert
> 
> POST/graphs/edges/insertBulk
> POST/graphs/edges/delete
> 
> POST/graphs/edges/deleteAll
> 
> POST/graphs/edges/deleteAllWithOutWait
> 
> POST/graphs/edges/update
> 
> POST/graphs/edges/increment
> POST/graphs/edges/incrementCount
> POST/graphs/edges/bulk
> 
>   ### List of APIs that should be removed
> POST/graphs/edges/deleteWithWait
> 
> POST/graphs/edges/updateWithWait
> 
> POST/graphs/edges/incrementWithWait
> 
> POST/graphs/edges/bulkWithWait
> 
> POST/graphs/edges/insertWithWait
> 
> 
> ## Edge query
> 
>   ### List of APIs to leave
> POST/graphs/getEdges
> 
> POST/graphs/checkEdges
> 
> 
>   ### List of APIs that should be removed
> POST/graphs/getEdgesGrouped
> 
> POST/graphs/getEdgesGroupedExcluded
> 
> POST/graphs/getEdgesGroupedExcludedFormatted
> 
> GET /graphs/getEdge/:srcId/:tgtId/:labelName/:direction
> 
> POST/graphs/getEdgesExcluded
> 
> POST/graphs/getEdgesExcluded/grouped
> 
> POST/graphs/getEdges/grouped
> 
> 
> 
> ## Vertex related
>   ### List of APIs to leave
> POST/graphs/getVertices
> POST/graphs/vertices/insert
> POST/graphs/vertices/delete
> POST/graphs/vertices/deleteAll
> 
>   ### List of APIs that should be removed
> POST/graphs/vertices/insert/:serviceName/:columnName
> POST/graphs/vertices/delete/:serviceName/:columnName
> 
> POST/graphs/vertices/deleteAll/:serviceName/:columnName
> 
> POST/graphs/vertices/insertWithWait
> 
> POST/graphs/vertices/deleteWithWait
> 
> 
> ## Vertex related
>   ### List of APIs to leave
> POST/graphs/createService
> 
> GET /graphs/getService/:serviceName
> 
> GET /graphs/getLabels/:serviceName
> 
> POST/graphs/createLabel
> 
> POST/graphs/addIndex
> 
> GET /graphs/getLabel/:labelName
> 
> PUT /graphs/deleteLabelReally/:labelName
> 
> POST/graphs/addProp/:labelName
> 
> POST/graphs/createServiceColumn
> 
> PUT /graphs/deleteServiceColumn/:serviceName/:columnName
> 
> POST/graphs/addServiceColumnProp/:serviceName/:columnName
> 
> POST/graphs/addServiceColumnProps/:serviceName/:columnName
> 
> GET /graphs/getServiceColumn/:serviceName/:columnName
> 
> POST/graphs/createHTable
> 
> GET /admin/labels/:serviceName
> 
> POST/graphs/copyLabel/:oldLabelName/:newLabelName
> 
> POST/graphs/renameLabel/:oldLabelName/:newLabelName
> 
> POST/graphs/swapLabels/:leftLabelName/:rightLabelName
> 
> POST/graphs/updateHTable/:labelName/:newHTableName
> 
> PUT /graphs/loadCache
> 
> 
> ## Experiment related
>   ### List of API to leave
> POST/graphs/experiment/:accessToken/:experimentName/:uuid
> 
> POST/graphs/experiments
> 
> 
> ## publish (deprecated)
>   ### List of APIs that should be removed
> POST/publish/:topic
> 
> POST/publishOnly/:topic
> 
> 
>  Health Check(deprecated)
>   ### List of APIs that should be removed
> GET /health_check.html
> 
> PUT /health_check/:isHealthy
> 
> 
> ## Counter related (deprecated)
>   ### List of APIs that should be removed
> POST/counter/v1/:service/:action
> GET /counter/v1/:service/:action
> PUT /counter/v1/:service/:action
> PUT /counter/v1/:service/:action/prepare
> DELETE  /counter/v1/:service/:action
> GET /counter/v1/:service/:action/ranking
> DELETE  /counter/v1/:service/:action/ranking
> GET 

Re: HTTP interface integration and unfinished project (s2rest_netty) removal.

2018-11-07 Thread DO YUNG YOON
+1 on deprecate unnecessary routes.
About 'WithWait' postfix, I think we should make routes with `WithWait`
postfix as the default and deprecate others, so for example, only
leave `/graphs/edges/insert`
and replace use `/graphs/edges/insertWithWait` implementation in there.

Anyway, the list looks pretty long. Why don't we split list to groups, and
let any volunteers like me to work on this.

On Wed, Nov 7, 2018 at 4:51 PM daewon  wrote:

> I've looked at the features that are available to remove the Play!
> Framework.
>
> I have written my comments for each function groups.
>
> - The Admin and Create APIs have yet to integrate many functions into the
> Play! controller code, so code separation must be preceded in order to move
> functionality.
> - The API with the `withWait` postfix of the Edge/Vertex creation API is an
> API that tells the client whether the request is applied correctly.
>This is a duplicate API that exists for backward compatibility.
> - Management routes are suggested to unify API routes with prefixes such as
> `/admin/?` or `/managment/?`.
> - Server health_check or Counter related features are not available
> anymore, so I suggest you exclude them.
>
> ## Edge creation
>   ### List of APIs to leave
> POST/graphs/edges/insert
>
> POST/graphs/edges/insertBulk
> POST/graphs/edges/delete
>
> POST/graphs/edges/deleteAll
>
> POST/graphs/edges/deleteAllWithOutWait
>
> POST/graphs/edges/update
>
> POST/graphs/edges/increment
> POST/graphs/edges/incrementCount
> POST/graphs/edges/bulk
>
>   ### List of APIs that should be removed
> POST/graphs/edges/deleteWithWait
>
> POST/graphs/edges/updateWithWait
>
> POST/graphs/edges/incrementWithWait
>
> POST/graphs/edges/bulkWithWait
>
> POST/graphs/edges/insertWithWait
>
>
> ## Edge query
>
>   ### List of APIs to leave
> POST/graphs/getEdges
>
> POST/graphs/checkEdges
>
>
>   ### List of APIs that should be removed
> POST/graphs/getEdgesGrouped
>
> POST/graphs/getEdgesGroupedExcluded
>
> POST/graphs/getEdgesGroupedExcludedFormatted
>
> GET /graphs/getEdge/:srcId/:tgtId/:labelName/:direction
>
> POST/graphs/getEdgesExcluded
>
> POST/graphs/getEdgesExcluded/grouped
>
> POST/graphs/getEdges/grouped
>
>
>
> ## Vertex related
>   ### List of APIs to leave
> POST/graphs/getVertices
> POST/graphs/vertices/insert
> POST/graphs/vertices/delete
> POST/graphs/vertices/deleteAll
>
>   ### List of APIs that should be removed
> POST/graphs/vertices/insert/:serviceName/:columnName
> POST/graphs/vertices/delete/:serviceName/:columnName
>
> POST/graphs/vertices/deleteAll/:serviceName/:columnName
>
> POST/graphs/vertices/insertWithWait
>
> POST/graphs/vertices/deleteWithWait
>
>
> ## Vertex related
>   ### List of APIs to leave
> POST/graphs/createService
>
> GET /graphs/getService/:serviceName
>
> GET /graphs/getLabels/:serviceName
>
> POST/graphs/createLabel
>
> POST/graphs/addIndex
>
> GET /graphs/getLabel/:labelName
>
> PUT /graphs/deleteLabelReally/:labelName
>
> POST/graphs/addProp/:labelName
>
> POST/graphs/createServiceColumn
>
> PUT /graphs/deleteServiceColumn/:serviceName/:columnName
>
> POST/graphs/addServiceColumnProp/:serviceName/:columnName
>
> POST/graphs/addServiceColumnProps/:serviceName/:columnName
>
> GET /graphs/getServiceColumn/:serviceName/:columnName
>
> POST/graphs/createHTable
>
> GET /admin/labels/:serviceName
>
> POST/graphs/copyLabel/:oldLabelName/:newLabelName
>
> POST/graphs/renameLabel/:oldLabelName/:newLabelName
>
> POST/graphs/swapLabels/:leftLabelName/:rightLabelName
>
> POST/graphs/updateHTable/:labelName/:newHTableName
>
> PUT /graphs/loadCache
>
>
> ## Experiment related
>   ### List of API to leave
> POST/graphs/experiment/:accessToken/:experimentName/:uuid
>
> POST/graphs/experiments
>
>
> ## publish (deprecated)
>   ### List of APIs that should be removed
> POST/publish/:topic
>
> POST/publishOnly/:topic
>
>
>  Health Check(deprecated)
>   ### List of APIs that should be removed
> GET /health_check.html
>
> PUT /health_check/:isHealthy
>
>
> ## Counter related (deprecated)
>   ### List of APIs that should be removed
> POST/counter/v1/:service/:action
> GET /counter/v1/:service/:action
> PUT /counter/v1/:service/:action
> PUT /counter/v1/:service/:action/prepare
> DELETE  /counter/v1/:service/:action
>  

Re: HTTP interface integration and unfinished project (s2rest_netty) removal.

2018-11-06 Thread daewon
I've looked at the features that are available to remove the Play!
Framework.

I have written my comments for each function groups.

- The Admin and Create APIs have yet to integrate many functions into the
Play! controller code, so code separation must be preceded in order to move
functionality.
- The API with the `withWait` postfix of the Edge/Vertex creation API is an
API that tells the client whether the request is applied correctly.
   This is a duplicate API that exists for backward compatibility.
- Management routes are suggested to unify API routes with prefixes such as
`/admin/?` or `/managment/?`.
- Server health_check or Counter related features are not available
anymore, so I suggest you exclude them.

## Edge creation
  ### List of APIs to leave
POST/graphs/edges/insert

POST/graphs/edges/insertBulk
POST/graphs/edges/delete

POST/graphs/edges/deleteAll

POST/graphs/edges/deleteAllWithOutWait

POST/graphs/edges/update

POST/graphs/edges/increment
POST/graphs/edges/incrementCount
POST/graphs/edges/bulk

  ### List of APIs that should be removed
POST/graphs/edges/deleteWithWait

POST/graphs/edges/updateWithWait

POST/graphs/edges/incrementWithWait

POST/graphs/edges/bulkWithWait

POST/graphs/edges/insertWithWait


## Edge query

  ### List of APIs to leave
POST/graphs/getEdges

POST/graphs/checkEdges


  ### List of APIs that should be removed
POST/graphs/getEdgesGrouped

POST/graphs/getEdgesGroupedExcluded

POST/graphs/getEdgesGroupedExcludedFormatted

GET /graphs/getEdge/:srcId/:tgtId/:labelName/:direction

POST/graphs/getEdgesExcluded

POST/graphs/getEdgesExcluded/grouped

POST/graphs/getEdges/grouped



## Vertex related
  ### List of APIs to leave
POST/graphs/getVertices
POST/graphs/vertices/insert
POST/graphs/vertices/delete
POST/graphs/vertices/deleteAll

  ### List of APIs that should be removed
POST/graphs/vertices/insert/:serviceName/:columnName
POST/graphs/vertices/delete/:serviceName/:columnName

POST/graphs/vertices/deleteAll/:serviceName/:columnName

POST/graphs/vertices/insertWithWait

POST/graphs/vertices/deleteWithWait


## Vertex related
  ### List of APIs to leave
POST/graphs/createService

GET /graphs/getService/:serviceName

GET /graphs/getLabels/:serviceName

POST/graphs/createLabel

POST/graphs/addIndex

GET /graphs/getLabel/:labelName

PUT /graphs/deleteLabelReally/:labelName

POST/graphs/addProp/:labelName

POST/graphs/createServiceColumn

PUT /graphs/deleteServiceColumn/:serviceName/:columnName

POST/graphs/addServiceColumnProp/:serviceName/:columnName

POST/graphs/addServiceColumnProps/:serviceName/:columnName

GET /graphs/getServiceColumn/:serviceName/:columnName

POST/graphs/createHTable

GET /admin/labels/:serviceName

POST/graphs/copyLabel/:oldLabelName/:newLabelName

POST/graphs/renameLabel/:oldLabelName/:newLabelName

POST/graphs/swapLabels/:leftLabelName/:rightLabelName

POST/graphs/updateHTable/:labelName/:newHTableName

PUT /graphs/loadCache


## Experiment related
  ### List of API to leave
POST/graphs/experiment/:accessToken/:experimentName/:uuid

POST/graphs/experiments


## publish (deprecated)
  ### List of APIs that should be removed
POST/publish/:topic

POST/publishOnly/:topic


 Health Check(deprecated)
  ### List of APIs that should be removed
GET /health_check.html

PUT /health_check/:isHealthy


## Counter related (deprecated)
  ### List of APIs that should be removed
POST/counter/v1/:service/:action
GET /counter/v1/:service/:action
PUT /counter/v1/:service/:action
PUT /counter/v1/:service/:action/prepare
DELETE  /counter/v1/:service/:action
GET /counter/v1/:service/:action/ranking
DELETE  /counter/v1/:service/:action/ranking
GET /counter/v1/:service/:action/:item
PUT /counter/v1/:service/:action/:item
POST/counter/v1/mget

I look forward to feedback.


Re: HTTP interface integration and unfinished project (s2rest_netty) removal.

2018-11-06 Thread daewon
Thank you for your feedback.
I want to integrate the HTTP interface with minimal code changes. To do
this, i will take a little look at the list of tasks needed and create an
issue through JIRA.



2018년 11월 6일 (화) 오후 6:25, DO YUNG YOON 님이 작성:

> Hi deawon.
>
> Thanks for bringing this issue up.
>
> I agree with your suggestions since I got pretty frustrated when I was
> working on S2GRAPH-243(I modify one line of code and had to re-package
> project since dev mode on s2rest_play is not working because of classpath
> issue).
>
> I am more than happy to work on this since the current dev environment has
> been broken.
>
>
>
> On Mon, Nov 5, 2018 at 6:15 PM daewon  wrote:
>
> > S2Graph's main web interface is based on Play! Framework.
> >
> > Key features provided include:
> >   - admin api
> >   - read/write api (include graph traverse)
> >
> > and known issues:
> >   1. The `s2rest_netty` project is experimental and supports only `graph
> > traverse` API.
> >   2. `s2rest_play` based on Play! Framework.
> > Play! Framework is full stack framework, so it has a lot of
> > dependencies that s2graph does not need.
> > There is also a conflict with byte buddy for patching asynchbase.
> >   3. `GraphQL` is still in the experimental phase and does not yet
> provide
> > all the functionality.
> >
> > I suggest removing `s2rest_play` and `s2rest_netty` to solve the above
> > problem.
> >
> > Akka HTTP is a stable phase, and the GraphQL web interface is built on
> Akka
> > HTTP.
> > It would be nice if a full-featured Web Interface would be provided by
> > connecting an existing Web Interface to an implemented GraphQL server.
> >
> > Thank you for your feedback.
> >
> > reference: https://richardimaoka.github.io/blog/hello-world-http-bench/
> >
>


Re: HTTP interface integration and unfinished project (s2rest_netty) removal.

2018-11-06 Thread DO YUNG YOON
Hi deawon.

Thanks for bringing this issue up.

I agree with your suggestions since I got pretty frustrated when I was
working on S2GRAPH-243(I modify one line of code and had to re-package
project since dev mode on s2rest_play is not working because of classpath
issue).

I am more than happy to work on this since the current dev environment has
been broken.



On Mon, Nov 5, 2018 at 6:15 PM daewon  wrote:

> S2Graph's main web interface is based on Play! Framework.
>
> Key features provided include:
>   - admin api
>   - read/write api (include graph traverse)
>
> and known issues:
>   1. The `s2rest_netty` project is experimental and supports only `graph
> traverse` API.
>   2. `s2rest_play` based on Play! Framework.
> Play! Framework is full stack framework, so it has a lot of
> dependencies that s2graph does not need.
> There is also a conflict with byte buddy for patching asynchbase.
>   3. `GraphQL` is still in the experimental phase and does not yet provide
> all the functionality.
>
> I suggest removing `s2rest_play` and `s2rest_netty` to solve the above
> problem.
>
> Akka HTTP is a stable phase, and the GraphQL web interface is built on Akka
> HTTP.
> It would be nice if a full-featured Web Interface would be provided by
> connecting an existing Web Interface to an implemented GraphQL server.
>
> Thank you for your feedback.
>
> reference: https://richardimaoka.github.io/blog/hello-world-http-bench/
>


HTTP interface integration and unfinished project (s2rest_netty) removal.

2018-11-05 Thread daewon
S2Graph's main web interface is based on Play! Framework.

Key features provided include:
  - admin api
  - read/write api (include graph traverse)

and known issues:
  1. The `s2rest_netty` project is experimental and supports only `graph
traverse` API.
  2. `s2rest_play` based on Play! Framework.
Play! Framework is full stack framework, so it has a lot of
dependencies that s2graph does not need.
There is also a conflict with byte buddy for patching asynchbase.
  3. `GraphQL` is still in the experimental phase and does not yet provide
all the functionality.

I suggest removing `s2rest_play` and `s2rest_netty` to solve the above
problem.

Akka HTTP is a stable phase, and the GraphQL web interface is built on Akka
HTTP.
It would be nice if a full-featured Web Interface would be provided by
connecting an existing Web Interface to an implemented GraphQL server.

Thank you for your feedback.

reference: https://richardimaoka.github.io/blog/hello-world-http-bench/