Re: HTTP interface integration and unfinished project (s2rest_netty) removal.

2018-11-22 Thread DO YUNG YOON
Thanks, daewon. I will follow this on JIRA. On Thu, Nov 22, 2018 at 3:33 PM daewon wrote: > I created an issue for > this discussion. > I think we will make the decisions in JIRA and start working on them. > > > 2018년 11월 22일 (목) 오후 2:00, DO

Re: HTTP interface integration and unfinished project (s2rest_netty) removal.

2018-11-21 Thread daewon
I created an issue for this discussion. I think we will make the decisions in JIRA and start working on them. 2018년 11월 22일 (목) 오후 2:00, DO YUNG YOON 님이 작성: > Thanks for getting involved in the discussion Woonsan. > > @deawon, can you please

Re: HTTP interface integration and unfinished project (s2rest_netty) removal.

2018-11-21 Thread DO YUNG YOON
Thanks for getting involved in the discussion Woonsan. @deawon, can you please create the Jira issue for this? By the way, I merged S2GRAPH-246(integration of documents into S2Graph project) into master yesterday, so I think we are ready to work on this. What if we move the APIs one by one and

Re: HTTP interface integration and unfinished project (s2rest_netty) removal.

2018-11-21 Thread Woonsan Ko
Now I see why it was broken. ;-) I recently re-subscribed the lists and started reading past messages to understand the context. I'm very looking forward to seeing the progress! Cheers, Woonsan On 2018/11/07 07:51:20, daewon wrote: > I've looked at the features that are available to remove

Re: HTTP interface integration and unfinished project (s2rest_netty) removal.

2018-11-07 Thread DO YUNG YOON
+1 on deprecate unnecessary routes. About 'WithWait' postfix, I think we should make routes with `WithWait` postfix as the default and deprecate others, so for example, only leave `/graphs/edges/insert` and replace use `/graphs/edges/insertWithWait` implementation in there. Anyway, the list looks

Re: HTTP interface integration and unfinished project (s2rest_netty) removal.

2018-11-06 Thread daewon
I've looked at the features that are available to remove the Play! Framework. I have written my comments for each function groups. - The Admin and Create APIs have yet to integrate many functions into the Play! controller code, so code separation must be preceded in order to move functionality.

Re: HTTP interface integration and unfinished project (s2rest_netty) removal.

2018-11-06 Thread daewon
Thank you for your feedback. I want to integrate the HTTP interface with minimal code changes. To do this, i will take a little look at the list of tasks needed and create an issue through JIRA. 2018년 11월 6일 (화) 오후 6:25, DO YUNG YOON 님이 작성: > Hi deawon. > > Thanks for bringing this issue up. >

Re: HTTP interface integration and unfinished project (s2rest_netty) removal.

2018-11-06 Thread DO YUNG YOON
Hi deawon. Thanks for bringing this issue up. I agree with your suggestions since I got pretty frustrated when I was working on S2GRAPH-243(I modify one line of code and had to re-package project since dev mode on s2rest_play is not working because of classpath issue). I am more than happy to