[jira] [Commented] (S2GRAPH-196) Apply Query Parameter to Label Fetch in S2GraphQL

2018-04-11 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/S2GRAPH-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433548#comment-16433548
 ] 

ASF GitHub Bot commented on S2GRAPH-196:


Github user asfgit closed the pull request at:

https://github.com/apache/incubator-s2graph/pull/155


> Apply Query Parameter to Label Fetch in S2GraphQL
> -
>
> Key: S2GRAPH-196
> URL: https://issues.apache.org/jira/browse/S2GRAPH-196
> Project: S2Graph
>  Issue Type: Improvement
>  Components: s2graphql
>Reporter: Daewon Jeong
>Assignee: Daewon Jeong
>Priority: Major
>
> h1. Apply Query Param that existed in existing Rest API
> Rather than applying all of the existing params, apply what is required.
> h2. List
> * offset
> * limit
> * cacheTTLInMillis
> * indexName



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (S2GRAPH-196) Apply Query Parameter to Label Fetch in S2GraphQL

2018-04-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/S2GRAPH-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427943#comment-16427943
 ] 

ASF GitHub Bot commented on S2GRAPH-196:


GitHub user daewon opened a pull request:

https://github.com/apache/incubator-s2graph/pull/155

[S2GRAPH-196] Apply Query Parameter to Label Fetch in S2GraphQL

I added a Query parameter to the label level.

offset: Start position of the document(edge) to be fetched 
limit: Total number of documents(edge) to fetch from offset
index: Name of the Index as defined in the Label. Determine the ordering of 
the documents to be fetched
filter: It is used to filter the document(edge) to be returned through the 
properties of the document(edge)

example) 
```graphql
query {
  movielens {
Movie(id: 1) {
  title  
  Tagged(offset: 0, limit: 10, index: _PK, filter: "tag = friendship") 
{
tag
User {  
  id  
}
  }
}
  }
}
```

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/daewon/incubator-s2graph S2GRAPH-196

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-s2graph/pull/155.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #155


commit d6c72ab838970724751cf8ea53cf90f1a587bc4a
Author: daewon 
Date:   2018-04-06T04:17:32Z

add queryParam




> Apply Query Parameter to Label Fetch in S2GraphQL
> -
>
> Key: S2GRAPH-196
> URL: https://issues.apache.org/jira/browse/S2GRAPH-196
> Project: S2Graph
>  Issue Type: Improvement
>  Components: s2graphql
>Reporter: Daewon Jeong
>Assignee: Daewon Jeong
>Priority: Major
>
> h1. Apply Query Param that existed in existing Rest API
> Rather than applying all of the existing params, apply what is required.
> h2. List
> * offset
> * limit
> * cacheTTLInMillis
> * indexName



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)