[jira] [Commented] (S2GRAPH-248) HTTP interface integration.

2018-11-29 Thread Daewon Jeong (JIRA)
[ https://issues.apache.org/jira/browse/S2GRAPH-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704375#comment-16704375 ] Daewon Jeong commented on S2GRAPH-248: -- [~steamshon]  Thank you for your suggestion. I think that

[jira] [Commented] (S2GRAPH-248) HTTP interface integration.

2018-11-29 Thread DOYUNG YOON (JIRA)
[ https://issues.apache.org/jira/browse/S2GRAPH-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704141#comment-16704141 ] DOYUNG YOON commented on S2GRAPH-248: - [~daewon] Thanks for reviewing and mering it! I think we

[jira] [Commented] (S2GRAPH-248) HTTP interface integration.

2018-11-28 Thread DOYUNG YOON (JIRA)
[ https://issues.apache.org/jira/browse/S2GRAPH-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702614#comment-16702614 ] DOYUNG YOON commented on S2GRAPH-248: - [~daewon] Hi daewon. I copied missing APIs from s2rest_play

Re: [jira] [Commented] (S2GRAPH-248) HTTP interface integration.

2018-11-26 Thread daewon
@DOYUNG Thank you for your feedback. I think the graphql project does not need to have an http layer. Therefore, in the s2graphql project, i want to remove the http layer by leaving only graphql's unique functions such as schema creation and query parsing. I will also be able to set the

Re: [jira] [Commented] (S2GRAPH-248) HTTP interface integration.

2018-11-26 Thread DO YUNG YOON
No problem deawon, I will work on S2GRAPH-249 based on your commit. Just quick questions, I guess you mention 4 high-level functionalities. 1. write 2. read 3. admin 4. graphql It seems like you intend to migrate s2graphql also into this new subproject s2http, so just quick question, are we

Re: [jira] [Commented] (S2GRAPH-248) HTTP interface integration.

2018-11-26 Thread daewon
[S2GRAPH-248] I made the first commit for the issue. Link: https://github.com/daewon/incubator-s2graph/tree/S2GRAPH-248/s2http I chose `akka http` because it was stable and lightweight with the` framework` for `http layer`. The initial implementation focused on minimizing external dependencies

[jira] [Commented] (S2GRAPH-248) HTTP interface integration.

2018-11-22 Thread Daewon Jeong (JIRA)
[ https://issues.apache.org/jira/browse/S2GRAPH-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696384#comment-16696384 ] Daewon Jeong commented on S2GRAPH-248: -- [~steamshon] Thank you for your feedback. I will quickly

[jira] [Commented] (S2GRAPH-248) HTTP interface integration.

2018-11-22 Thread DOYUNG YOON (JIRA)
[ https://issues.apache.org/jira/browse/S2GRAPH-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696304#comment-16696304 ] DOYUNG YOON commented on S2GRAPH-248: - [~daewon] Many thanks for opening up this issue. In summary,