Review Request 52030: Fix SAMZA-1018

2016-09-19 Thread Tommy Becker
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52030/ --- Review request for samza. Bugs: SAMZA-1018

Re: Review Request 47835: SAMZA-914: Initial draft for Java programming APIs on operators supporting DAGs

2016-09-19 Thread Yi Pan (Data Infrastructure)
> On Sept. 14, 2016, 7:03 p.m., Chris Pettitt wrote: > > samza-operator/src/main/java/org/apache/samza/operators/api/Windows.java, > > line 48 > > > > > > Does the concrete class need to be exposed? Interfaces are

Re: Review Request 47835: SAMZA-914: Initial draft for Java programming APIs on operators supporting DAGs

2016-09-19 Thread Yi Pan (Data Infrastructure)
> On Sept. 14, 2016, 7:03 p.m., Chris Pettitt wrote: > > samza-operator/src/main/java/org/apache/samza/operators/api/internal/Window.java, > > line 39 > > > > > > IIUC given this interface Window is basically an

Re: Review Request 52030: Fix SAMZA-1018

2016-09-19 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52030/#review149475 --- Ship it! Ship It! - Jake Maes On Sept. 19, 2016, 12:26

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

2016-09-19 Thread Xinyu Liu
> On Sept. 16, 2016, 8:58 p.m., Yi Pan (Data Infrastructure) wrote: > > docs/learn/tutorials/versioned/samza-async-user-guide.md, line 71 > > > > > > The explanation of "processAsync() will always be invoked in a

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

2016-09-19 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/ --- (Updated Sept. 19, 2016, 5:23 p.m.) Review request for samza, Chris Pettitt,

Re: Review Request 40313: SAMZA-785

2016-09-19 Thread VENKATA KRISHNA NANNAPANENI
> On Nov. 16, 2015, 7:34 p.m., Boris Shkolnik wrote: > > > > VENKATA KRISHNA NANNAPANENI wrote: > Is there anything I need to do like commit or create pull request? I > wasn't aware of the process from here. > > Navina Ramesh wrote: > Sorry for the delay, Venkata Krishna Nannapaneni.

Re: Review Request 47835: SAMZA-914: Initial draft for Java programming APIs on operators supporting DAGs

2016-09-19 Thread Yi Pan (Data Infrastructure)
> On Sept. 19, 2016, 9:24 p.m., Jagadish Venkatraman wrote: > > samza-operator/src/main/java/org/apache/samza/operators/api/internal/Operators.java, > > line 236 > > > > > > nit: > > Small typo here - Maybe,

Re: Review Request 51126: SAMZA 998: Documentation updates for refactored Job Coordinator

2016-09-19 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51126/#review149579 --- Ship it! Ship It! - Yi Pan (Data Infrastructure) On Sept.