Re: Review Request 39806: SAMZA-798 : Performance and stability issue after combining checkpoint and coordinator stream

> On Oct. 30, 2015, 6:06 p.m., Xinyu Liu wrote: > > samza-core/src/main/scala/org/apache/samza/checkpoint/CheckpointTool.scala, > > line 132 > > <https://reviews.apache.org/r/39806/diff/1/?file=1112956#file1112956line132> > > > > I think sc

Re: Review Request 39806: SAMZA-798 : Performance and stability issue after combining checkpoint and coordinator stream

123) <https://reviews.apache.org/r/39806/#comment162817> I think scala prefers to use the companion object as the factory to create new instance (code before change). Is there any reason for this change? - Xinyu Liu On Oct. 30, 2015, 7:09 a.m., N

Review Request 41071: SAMZA-843: fix heap usage increase caused by container timer change

ing --- Thanks, Xinyu Liu

Re: [VOTE] Samza 0.10.0 Release Candidate 2

+1 on my side. I also ran the gradle build and unit tests without failure. Thanks, Xinyu On Wed, Dec 9, 2015 at 9:54 AM, Tao Feng wrote: > +1 from my side(non-binding). I download the package and successfully run > all the unit tests without failure. > > On Tue, Dec 8,

Review Request 41912: SAMZA-850: Yarn Job Validation Tool

/41912/diff/ Testing --- Unit tests added to cover all the new methods/classes. Thanks, Xinyu Liu

Review Request 48213: SAMZA-960: Make system producer thread safe

/TestKafkaSystemProducer.scala 8e32bba6ced090f0fc8d4e5176fe0788df36981d Diff: https://reviews.apache.org/r/48213/diff/ Testing --- Unit tests and local testing. Thanks, Xinyu Liu

Re: Review Request 48213: SAMZA-960: Make system producer thread safe

04c9113fd6c3dd56c49ff46c8c1c0ff12f68e5e2 samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemProducer.scala 8e32bba6ced090f0fc8d4e5176fe0788df36981d Diff: https://reviews.apache.org/r/48213/diff/ Testing --- Unit tests and local testing. Thanks, Xinyu Liu

Re: Review Request 48213: SAMZA-960: Make system producer thread safe

/org/apache/samza/system/kafka/TestKafkaSystemProducer.scala 8e32bba6ced090f0fc8d4e5176fe0788df36981d Diff: https://reviews.apache.org/r/48213/diff/ Testing --- Unit tests and local testing. Thanks, Xinyu Liu

Re: Review Request 48213: SAMZA-960: Make system producer thread safe

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48213/#review136654 --- On June 8, 2016, 11:53 p.m., Xinyu Liu wrote: > > ---

Re: Review Request 48182: SAMZA-958: Make store/cache thread safe

To reply, visit: https://reviews.apache.org/r/48182/#review136335 ------- On June 9, 2016, 12:33 a.m., Xinyu Liu wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 48182: SAMZA-958: Make store/cache thread safe

tests and local deployment. Thanks, Xinyu Liu

Re: Review Request 48243: SAMZA-961: Async tasks and multithreading model

samza-core/src/test/scala/org/apache/samza/system/TestSystemConsumers.scala 09da62e0f9a10f7c3683345a309c6278ff01fb4b Diff: https://reviews.apache.org/r/48243/diff/ Testing --- unit tests and local testing. Thanks, Xinyu Liu

Review Request 48243: SAMZA-961: Async tasks and multithreading model

/scala/org/apache/samza/system/TestSystemConsumers.scala 09da62e0f9a10f7c3683345a309c6278ff01fb4b Diff: https://reviews.apache.org/r/48243/diff/ Testing --- unit tests and local testing. Thanks, Xinyu Liu

Re: Review Request 48243: SAMZA-961: Async tasks and multithreading model

generated e-mail. To reply, visit: https://reviews.apache.org/r/48243/#review137543 ------- On June 15, 2016, 11:41 p.m., Xinyu Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews

Re: Review Request 48243: SAMZA-961: Async tasks and multithreading model

t; > Chris Pettitt wrote: > I had the same comment on the last pass. I don't understand how this is > supposed to work. Might be worth discussing this in person with Xinyu and > then either fixing the code or the doc as appropriate. Thanks both of you to catch this. I messed up the code during the task state refactoring. Now the logic should be fixed. - Xinyu

Re: Review Request 48243: SAMZA-961: Async tasks and multithreading model

/TestSystemConsumers.scala 09da62e0f9a10f7c3683345a309c6278ff01fb4b Diff: https://reviews.apache.org/r/48243/diff/ Testing --- unit tests and local testing. Thanks, Xinyu Liu

Re: Review Request 43053: allow warning instead of fail in case of invalid num of partitions in the checkpoint partition

-kafka/src/main/scala/org/apache/samza/util/KafkaUtil.scala (line 162) <https://reviews.apache.org/r/43053/#comment178367> nitpick: the var name of "msg1" seems not very well chosen. Shall we do warn(msg + "...") instead? - Xinyu Liu On Feb. 1, 2016, 6:25

Re: Review Request 43350: SAMZA-867 Fix job restart/shutdown in the event of a node outage.

ception.java (line 27) <https://reviews.apache.org/r/43350/#comment181838> is serialVersionUID needed here? If so please use the autogenerated one. - Xinyu Liu On Feb. 23, 2016, 9:43 p.m., Jake Maes wrote: > > --- &g

Re: Understand Samza default metrics

essage. But this average also includes time taken to process null > messages. So I don't trust the accuracy of that metric. > > Each metric emitted by Samza contains a header which includes job name, > job > id, container name and metric timestamp. You can use it to calculate > messag

Re: Understand Samza default metrics

Hi, David, I didn't find a wiki page that contains the descriptions of all Samza metrics. You can find the basic metrics by googling the following classes: SamzaContainerMetrics, TaskInstanceMetrics, SystemConsumersMetrics and SystemProducersMetrics. For your example, you can use the

Re: [DISCUSS] Re-thinking the Samza Job Coordinator

This is awesome! Samza will be able to run standalone or on different kinds of clusters, which can serve a wide range of applications. Glad to see this is happening. Thanks, Xinyu On Tue, Mar 1, 2016 at 8:48 AM, Jagadish Venkatraman wrote: > Hi all, > > Currently, the

Re: Review Request 50318: SAMZA-979: Remove KafkaCheckpointMigration

/50318/diff/ Testing --- Tested by locally deployed jobs. Passed gradle tests. Thanks, Xinyu Liu

Review Request 50451: SAMZA-981: Set consistent Kafka clientId for a job instance

--- gradle build & tests Thanks, Xinyu Liu

Re: Review Request 50451: SAMZA-981: Set consistent Kafka clientId for a job instance

-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemConsumer.scala ece0359d1a31e65113f4832dd3baddb788cecef4 Diff: https://reviews.apache.org/r/50451/diff/ Testing --- gradle build & tests Thanks, Xinyu Liu

Re: Review Request 50318: SAMZA-979: Remove KafkaCheckpointMigration

To reply, visit: https://reviews.apache.org/r/50318/#review143446 ------- On July 25, 2016, 9:29 p.m., Xinyu Liu wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 50451: SAMZA-981: Set consistent Kafka clientId for a job instance

/TestKafkaConfig.scala c4a83f60cf049e6fd65f940b69674895d07ab871 samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemConsumer.scala ece0359d1a31e65113f4832dd3baddb788cecef4 Diff: https://reviews.apache.org/r/50451/diff/ Testing --- gradle build & tests Thanks, Xinyu Liu

Re: Review Request 50451: SAMZA-981: Set consistent Kafka clientId for a job instance

-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemConsumer.scala ece0359d1a31e65113f4832dd3baddb788cecef4 Diff: https://reviews.apache.org/r/50451/diff/ Testing --- gradle build & tests Thanks, Xinyu Liu

Review Request 50056: Multithreading changes

96eb5faf5c2a6f8b4271a5ed16e709015d78bab0 samza-test/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala fd4e7624afced0df104d4a90539149197b93808b Diff: https://reviews.apache.org/r/50056/diff/ Testing --- Tested in yarn. Thanks, Xinyu Liu

Review Request 50527: SAMZA-970: fix integration tests

/samza_job_yarn_deployer.py 38635ca5899c43fb61d6b4042e8543f0508fd41b Diff: https://reviews.apache.org/r/50527/diff/ Testing --- run integration tests and now they work fine. Thanks, Xinyu Liu

Review Request 50318: SAMZA-979: Fix for KafkaCheckpointMigration not registering source correctly

5d2641ab1e54d49f7b983bc526762cfb50f2911b Diff: https://reviews.apache.org/r/50318/diff/ Testing --- Tested by locally deployed jobs. Passed gradle tests. Thanks, Xinyu Liu

Re: Review Request 50583: SAMZA-954 Improve logging for Samza

s better to have: Logging.info((message, startupLog:boolean=false) => Any) That way we can use info log for both startup and non startup logging, and potentially adding it for debug and error in the future too. - Xinyu Liu On July 28, 2016, 8:41 p.

Review Request 50588: SAMZA-982: Add null check for offset update in OffsetManager

75ba8af7cdda6b297abaa3dbb99c98b406e31f88 Diff: https://reviews.apache.org/r/50588/diff/ Testing --- tested by unit tests and verifed also in hello-samza jobs. Thanks, Xinyu Liu

Review Request 50590: Update jackson version in hello-samza to match samza

://reviews.apache.org/r/50590/diff/ Testing --- Tested by running hello-world and check the output. Thanks, Xinyu Liu

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

overly simplified. I added more details. Please take a look. - Xinyu ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/#review142985 --- On July 27, 2016, 11:05 p.m., Xinyu Liu wrote: >

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

789> Please take a look at this again. - Xinyu Liu On July 27, 2016, 11:05 p.m., Xinyu Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: [DISCUSS] [VOTE] Apache Samza 0.10.1 RC0

+1 (non-binding). Thanks, Xinyu On Mon, Aug 1, 2016 at 11:41 AM, Jagadish Venkatraman < jagadish1...@gmail.com> wrote: > Thanks for driving this release.+1 approve (non-binding) > > Thanks, > Jagadish > > On Mon, Aug 1, 2016 at 11:39 AM, Navina Ramesh > > wrote:

Re: Review Request 50682: SAMZA-993 Fix logging bug for some scala versions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50682/#review144417 --- Ship it! +1. thanks for the quick fix! - Xinyu Liu On Aug

Re: Review Request 48213: SAMZA-960: Make system producer thread safe

/samza/system/kafka/TestKafkaSystemProducer.scala 8e32bba6ced090f0fc8d4e5176fe0788df36981d Diff: https://reviews.apache.org/r/48213/diff/ Testing --- Unit tests and local testing. Thanks, Xinyu Liu

Re: Review Request 50143: Support the notion of 'end-of-stream' in Samza when consuming from finite sources

read safe since we might have multiple threads for a task. - Xinyu Liu On July 18, 2016, 4:29 p.m., Jagadish Venkatraman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 50056: SAMZA-863: Multithreading changes

--- Tested in yarn. Thanks, Xinyu Liu

Re: Review Request 50056: SAMZA-863: Multithreading changes

/ Testing --- Tested in yarn. Thanks, Xinyu Liu

Re: Review Request 50056: Multithreading changes

/TestKeyValueStores.scala fd4e7624afced0df104d4a90539149197b93808b Diff: https://reviews.apache.org/r/50056/diff/ Testing --- Tested in yarn. Thanks, Xinyu Liu

Review Request 50174: SAMZA-977: User doc for samza multithreading

116238312df7071747cbbc14bc9c46f558755195 docs/learn/documentation/versioned/jobs/configuration-table.html 54c52981c3055b398ee60af50eeaf2592ed0e64f Diff: https://reviews.apache.org/r/50174/diff/ Testing --- Test the web pages locally. Thanks, Xinyu Liu

Re: Review Request 50056: SAMZA-863: Multithreading changes

--- Tested in yarn. Thanks, Xinyu Liu

Re: Review Request 50082: SAMZA-973: Disk Quotas: clamp max delay, better measure processing time

/samza/container/RunLoop.scala (line 79) <https://reviews.apache.org/r/50082/#comment208023> Shall we move this line in the process() function? - Xinyu Liu On July 15, 2016, 7:59 p.m., Chris Pettitt

Re: Review Request 49877: SAMZA-972: Holistic memory monitoring for SamzaContainer

/samza/container/host/ProcfsBasedStatisticsMonitor.java (line 177) <https://reviews.apache.org/r/49877/#comment207134> Do you think we should catch all the throwable here to prevent the thread being killed? - Xinyu Liu On July 11, 2016, 6:57 a.m., Jagadish Venkatraman

Re: Review Request 48243: SAMZA-961: Async tasks and multithreading model

/ Testing --- unit tests and local testing. Thanks, Xinyu Liu

Re: Review Request 50670: SAMZA-991: Continue to report SamzaAppMasterMetrics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50670/#review144393 --- Ship it! +1 - Xinyu Liu On Aug. 1, 2016, 10:21 p.m

Re: Review Request 50670: SAMZA-991: Continue to report SamzaAppMasterMetrics

ations. Could you please take a look? Thanks. - Xinyu Liu On Aug. 1, 2016, 9:07 p.m., Jagadish Venkatraman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 50527: SAMZA-970: fix integration tests

/diff/ Testing --- run integration tests and now they work fine. Thanks, Xinyu Liu

Re: [VOTE] Apache Samza 0.12.0 RC2

Ran build, checkAll and integration tests. All passed. +1 non-binding. Thanks, Xinyu On Wed, Feb 8, 2017 at 4:18 PM, Boris S wrote: > Cloned the release and ran build, test and checkAll.sh > All passed. > Verified MD5 and the signature. > Got warning - "this key is not

Re: Review Request 56911: SAMZA-1099: Documentation updates for Samza 0.12 release (for 0.12.0 branch)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56911/#review166393 --- Ship it! Ship It! - Xinyu Liu On Feb. 22, 2017, 4:27 p.m

Re: Review Request 56928: SAMZA-1099: Changes to hello-samza (latest branch) for the 0.12.0 release

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56928/#review166399 --- Ship it! Ship It! - Xinyu Liu On Feb. 22, 2017, 3:45 p.m

Re: Review Request 56909: SAMZA-1099: Changes to hello-samza (master branch) for the 0.12.0 release

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56909/#review166398 --- Ship it! Ship It! - Xinyu Liu On Feb. 22, 2017, 3:55 p.m

Re: Review Request 56913: SAMZA-1099: Documentation updates for Samza 0.12 release (for master branch)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56913/#review166396 --- Ship it! Ship It! - Xinyu Liu On Feb. 22, 2017, 7:29 p.m

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

syncRunLoop.java (line 605) <https://reviews.apache.org/r/51346/#comment213289> if(endOfStream) ... samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala (line 355) <https://reviews.apache.org/r/51346/#comment213294> No need for this logic since AsyncRunLoop won't

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

.thread.pool.size, task.callback.timeout.ms and > > task.max.concurrency This config is pretty awkward (so is the name). It's just for fallback to old runloop if there is any issue with the new AsyncRunLoop. So I don't expect users to set it normally. Once the AsyncRun

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

/ Testing --- Test the web pages locally. Thanks, Xinyu Liu

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

ed since no invoke anymore, right? - Xinyu Liu On Aug. 29, 2016, 11:47 p.m., Jagadish Venkatraman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 51252: SAMZA-1004: Fix some logging and javadoc issues for AsyncStreamTask

/main/scala/org/apache/samza/container/SamzaContainer.scala f786fc08c8f7eced4f4084dc8326b28b6422 Diff: https://reviews.apache.org/r/51252/diff/ Testing --- gradlew clean build. Thanks, Xinyu Liu

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

/ Testing --- Test the web pages locally. Thanks, Xinyu Liu

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

AsyncStreamTask by default? > > Esp. on jobs that don't need any async processing. > > Why is the default value false? > > > > If users upgrade to the new version and automatically start using > > multithreaded execution, will they

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

1 once AsyncRunLoop is fully stablized. - Xinyu Liu On Aug. 30, 2016, 12:49 a.m., Xinyu Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: [DISCUSS] End of Stream Feature in Samza

It's very exciting that Samza is adding support of bounded input streams. Nice write-up of different scenarios and options. Look forward to having this feature work with the upcoming HDFS consumer! Thanks, Xinyu On Tue, Aug 30, 2016 at 12:09 PM, Jagadish Venkatraman < jagadish1...@gmail.com>

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

1) <https://reviews.apache.org/r/51346/#comment215659> seems this is only needed for unit test. Please move the code to scala test. - Xinyu Liu On Sept. 6, 2016, 4:02 p.m., Jagadish Venkatraman wrote: > > --- > This is an

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

/SystemConsumers.scala (line 207) <https://reviews.apache.org/r/51346/#comment215701> nit: no ";" at the end for scala - Xinyu Liu On Sept. 6, 2016, 4:02 p.m., Jagadish Venkatraman wrote: > > --- > This is an autom

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

--- Test the web pages locally. Thanks, Xinyu Liu

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

! Thanks! - Xinyu --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/#review148041 --- On Sept. 13, 2016

Re: Review Request 51819: SAMZA-1015 Add support for streams, Lambdas and other JDK 8 like features in checkstyle

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51819/#review148585 --- Ship it! Ship It! - Xinyu Liu On Sept. 12, 2016, 7:28 p.m

Re: Review Request 52140: added docs for split deployment

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52140/#review150500 --- Ship it! Ship It! - Xinyu Liu On Sept. 27, 2016, 12:58 a.m

Review Request 52401: SAMZA-995: Remove configs deprecated in 0.10.* release and update configs

/KafkaCheckpointManager.scala ea10cae82f2900c185c8c814f48dc02bbcb45621 samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TeskKafkaCheckpointLogKey.scala c360b6c74ff924311f350df2e49424351a5c8d07 Diff: https://reviews.apache.org/r/52401/diff/ Testing --- ./gradlew build Thanks, Xinyu Liu

Re: Review Request 52401: SAMZA-995: Remove configs deprecated in 0.10.* release and update configs

) --- Thanks, Xinyu Liu

Review Request 52400: SAMZA-995: Remove configs deprecated in 0.10.* release and update configs

/learn/tutorials/versioned/remote-debugging-samza.md ad1d04d835f10aeb6996d2ecbee1d0ae65eb98e9 Diff: https://reviews.apache.org/r/52400/diff/ Testing --- Thanks, Xinyu Liu

Re: Review Request 52401: SAMZA-995: Remove configs deprecated in 0.10.* release and update configs

--- ./gradlew build Thanks, Xinyu Liu

Review Request 52403: SAMZA-1028: Moving logline before closing kafka producer and making exception thrown AtomicReference

/apache/samza/system/kafka/KafkaSystemProducer.scala 5ff6d3caf54ed148aa40c7c752c587e556a4f34a Diff: https://reviews.apache.org/r/52403/diff/ Testing --- Tested in jobs deployed in Yarn cluster. Thanks, Xinyu Liu

Re: Review Request 52403: SAMZA-1028: Moving logline before closing kafka producer and making exception thrown AtomicReference

nyu --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52403/#review150948 ------- On Sept. 29, 2016, 9:23 p.m., Xinyu Liu wrote: > > ---

Re: Review Request 52403: SAMZA-1028: Moving logline before closing kafka producer and making exception thrown AtomicReference

e.org/r/52403/#review150907 --- On Sept. 29, 2016, 9 p.m., Xinyu Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Review Request 52402: SAMZA-1020: Remove some deprecated interfaces from 0.10 version

ea10cae82f2900c185c8c814f48dc02bbcb45621 samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TeskKafkaCheckpointLogKey.scala c360b6c74ff924311f350df2e49424351a5c8d07 Diff: https://reviews.apache.org/r/52402/diff/ Testing --- ./gradlew build Thanks, Xinyu Liu

Re: RecordTooLargeException recovery

Hi, David, For your questions: 1) In this case Samza recovered but the changelog message was lost. In 0.10.1 KafkaSystemProducer has a race condition: there is small chance the later send success might override the previous failure. The bug is fixed in the upcoming 0.11.0 release (SAMZA-1019).

[VOTE] Apache Samza 0.11.0 RC1

Hey all, This is a call for a vote on a release of Apache Samza 0.11.0. Thanks to everyone who has contributed to this release. We are very glad to see some new contributors in this release. Note: this release candidate fixed the version issue in integration test previously found in 0.11.0 RC0.

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

tion right? Actually it's different: processAsync() will always be invoked from a single thread (for all tasks). The reason being asynchronous calls will not require threads blocking on the calls. The callback can be invoked from multiple threads. Samza controls when to invoke processAsync()/window()/commit() for each task. - Xinyu -

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

54c52981c3055b398ee60af50eeaf2592ed0e64f docs/learn/tutorials/versioned/index.md b4d687a63638aca4f876af88556de9973acfd718 docs/learn/tutorials/versioned/samza-async-user-guide.md PRE-CREATION Diff: https://reviews.apache.org/r/50174/diff/ Testing --- Test the web pages locally. Thanks, Xinyu Liu

Re: Review Request 52140: added docs for split deployment

ease, can we use 0.11.0 acrose all examples here? docs/learn/documentation/versioned/operations/split-deployment.md (line 113) <https://reviews.apache.org/r/52140/#comment217715> I think we need to mention the framework libraries needed to be placed to each node in the cluster. -

Re: Review Request 52133: reopen a Kafka system producer if send called again

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52133/#review149925 --- Ship it! Ship It! - Xinyu Liu On Sept. 21, 2016, 8:36 p.m

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

docs/learn/tutorials/versioned/index.md ca2b08fb02a83f72f804c4059f258253c046a1b6 docs/learn/tutorials/versioned/samza-async-user-guide.md PRE-CREATION Diff: https://reviews.apache.org/r/50174/diff/ Testing --- Test the web pages locally. Thanks, Xinyu Liu

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

sit: https://reviews.apache.org/r/50174/#review148824 --- On Sept. 16, 2016, 5:33 p.m., Xinyu Liu wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50174/#review148826 ----------- On Sept. 16, 2016, 5:33 p.m., Xinyu Liu wrote: > > --- > This

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

54c52981c3055b398ee60af50eeaf2592ed0e64f docs/learn/tutorials/versioned/index.md b4d687a63638aca4f876af88556de9973acfd718 docs/learn/tutorials/versioned/samza-async-user-guide.md PRE-CREATION Diff: https://reviews.apache.org/r/50174/diff/ Testing --- Test the web pages locally. Thanks, Xinyu Liu

Re: Review Request 50174: SAMZA-977: User doc for samza multithreading

b4d687a63638aca4f876af88556de9973acfd718 docs/learn/tutorials/versioned/samza-async-user-guide.md PRE-CREATION Diff: https://reviews.apache.org/r/50174/diff/ Testing --- Test the web pages locally. Thanks, Xinyu Liu

Review Request 51962: SAMZA-1021 Remove the redundent poll waiting inside AsyncRunLoop blockIfBusy

a510bb0c5914c772438930d27f100b4d360c1296 Diff: https://reviews.apache.org/r/51962/diff/ Testing --- Tested by yarn job. Thanks, Xinyu Liu

Re: Review Request 51962: SAMZA-1021 Remove the redundent poll waiting inside AsyncRunLoop blockIfBusy

are high at the same time. Diffs - samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java a510bb0c5914c772438930d27f100b4d360c1296 Diff: https://reviews.apache.org/r/51962/diff/ Testing --- Tested by yarn job. Thanks, Xinyu Liu

Re: Review Request 51962: SAMZA-1021 Remove the redundent poll waiting inside AsyncRunLoop blockIfBusy

and block_ns are high at the same time. Diffs - samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java a510bb0c5914c772438930d27f100b4d360c1296 Diff: https://reviews.apache.org/r/51962/diff/ Testing --- Tested by yarn job. Thanks, Xinyu Liu

Re: Review Request 51962: SAMZA-1021 Remove the redundent poll waiting inside AsyncRunLoop blockIfBusy

/java/org/apache/samza/task/AsyncRunLoop.java a510bb0c5914c772438930d27f100b4d360c1296 Diff: https://reviews.apache.org/r/51962/diff/ Testing --- Tested by yarn job. Thanks, Xinyu Liu

[DISCUSS] Samza 0.11.0 release

Hi, All, There have been quite a lot of new features added to master since 0.10 release to warrant a new major release. At LinkedIn, we've done functional and performance testing against master in the past weeks, and deployed jobs with the latest build in production. We will continue to test for

Re: Review Request 52436: SAMZA-1016: Fix support for joint compilation of scala and java sources

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52436/#review151060 --- Ship it! Good catch! Thanks for fixing this! - Xinyu Liu

[DISCUSS] [VOTE] Apache Samza 0.11.0 RC0

vote: [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) +1 from my side for the release. Cheers! Xinyu Liu

Re: [DISCUSS] [VOTE] Apache Samza 0.11.0 RC0

Subject correction: [VOTE] Apache Samza 0.11.0 RC0. Thanks, Xinyu On Fri, Sep 30, 2016 at 12:00 PM, xinyu liu <xinyuliu...@gmail.com> wrote: > Hey all, > > This is a call for a vote on a release of Apache Samza 0.11.0. Thanks to > everyone who has contributed to this release

Re: Review Request 52403: SAMZA-1028: Moving logline before closing kafka producer and making exception thrown AtomicReference

; Wondering why we rethrow a previously saved exception instead of > > no-oping the flush? Is the user expected to handle this? If so, should > > document why & how. > > Prateek Maheshwari wrote: > Nvm this, I think the intention is to throw in the next operation after a > send error callback. I added the comments. Please take a look agai

Re: Review Request 52403: SAMZA-1028: Moving logline before closing kafka producer and making exception thrown AtomicReference

in jobs deployed in Yarn cluster. Thanks, Xinyu Liu

Re: Review Request 53282: SAMZA-1043: Samza performance improvements

e should ever be creating a default new SerdeManager > > just for this class. Same for SystemConsumerMetrics (and other places where > > this pattern is used for objects). Constants are fine. > > Xinyu Liu wrote: > I think these are created as default for the testin

  1   2   3   >