[GitHub] samza pull request #567: JIRA 1735 Adding ListGaugeMBean, to enable MBean va...

2018-06-27 Thread rmatharu
GitHub user rmatharu opened a pull request: https://github.com/apache/samza/pull/567 JIRA 1735 Adding ListGaugeMBean, to enable MBean validation Adding ListGaugeMBean, to enable MBean validation. Tested with LocalContainerRunner and YARN job. JIRA SAMZA-1733/ SAMZA-1735

[GitHub] samza pull request #590: Fixing problem with Serde of StackTraceElement, was...

2018-07-27 Thread rmatharu
GitHub user rmatharu opened a pull request: https://github.com/apache/samza/pull/590 Fixing problem with Serde of StackTraceElement, was causing test failure Root cause of the failing test (after constructor param addition) is that java's StackTraceElement does not serialize

[GitHub] samza pull request #591: Adding filter mechanism to MetricsSnapshotReporter

2018-07-30 Thread rmatharu
GitHub user rmatharu opened a pull request: https://github.com/apache/samza/pull/591 Adding filter mechanism to MetricsSnapshotReporter This regex based filter mechanism allow for blacklisting of metrics being reporter by the Snapshot Reporter, by specifying the blacklist in config

[GitHub] samza pull request #596: SAMZA-1733: Defaulting to non-null serde, in case n...

2018-08-01 Thread rmatharu
GitHub user rmatharu opened a pull request: https://github.com/apache/samza/pull/596 SAMZA-1733: Defaulting to non-null serde, in case none is specified Currently, if no system or stream serde is specified the SnapshotReporter simply crashes because a MetricsSnapshot cannot

[GitHub] samza pull request #605: Enabling auto-discovery of regex input topics

2018-08-10 Thread rmatharu
GitHub user rmatharu opened a pull request: https://github.com/apache/samza/pull/605 Enabling auto-discovery of regex input topics Incomplete. Work in progress You can merge this pull request into a Git repository by running: $ git pull https://github.com/rmatharu/samza

[GitHub] samza pull request #602: Create diagnostic topic and ACLs if diagnostics ena...

2018-08-06 Thread rmatharu
GitHub user rmatharu opened a pull request: https://github.com/apache/samza/pull/602 Create diagnostic topic and ACLs if diagnostics enabled * Current SnapshotReporter semantics are to specify stream as . * We create topic in JobRunner because AM can also emit metrics

[GitHub] samza pull request #609: SAMZA-1733: Bugfix: Moving to use string for type i...

2018-08-15 Thread rmatharu
GitHub user rmatharu opened a pull request: https://github.com/apache/samza/pull/609 SAMZA-1733: Bugfix: Moving to use string for type info, to avoid ClassNotFound on deserial Exception type was serialized as a Class. However in case of Exceptions defined in non-samza-related

[GitHub] samza pull request #599: Fix for transient error failure -- concurrent evict...

2018-08-06 Thread rmatharu
GitHub user rmatharu opened a pull request: https://github.com/apache/samza/pull/599 Fix for transient error failure -- concurrent evictions causing incorrectness You can merge this pull request into a Git repository by running: $ git pull https://github.com/rmatharu/samza

[GitHub] samza pull request #610: SAMZA-1733 : Adding comments, adding emptyness chec...

2018-08-17 Thread rmatharu
GitHub user rmatharu opened a pull request: https://github.com/apache/samza/pull/610 SAMZA-1733 : Adding comments, adding emptyness check to MetricsSnapshotReporter message * Added comments for MetricsConfig * Added simple emptyness check for MetricsSnapshotReporter You can

[GitHub] samza pull request #572: Adding containerID to metric header

2018-07-20 Thread rmatharu
GitHub user rmatharu opened a pull request: https://github.com/apache/samza/pull/572 Adding containerID to metric header Adding containerID to MetricsHeader (published by MetricsSnapshotReporter). It is populated using the value set for the env variable

[GitHub] samza pull request #731: Removing regex-input static-input exclusivity check

2018-10-15 Thread rmatharu
GitHub user rmatharu opened a pull request: https://github.com/apache/samza/pull/731 Removing regex-input static-input exclusivity check This PR converts a hard-check that fails in case of regex-defined input if there is an overlap between regex-input and task-input

[GitHub] samza pull request #756: Changes to Standalone integration tests

2018-10-22 Thread rmatharu
GitHub user rmatharu opened a pull request: https://github.com/apache/samza/pull/756 Changes to Standalone integration tests * Removing task.inputs since its not required in the new Samza 1.0 API * Fixing input-output sys bug * Fixing jobModel zk path bug -- camel case

[GitHub] samza pull request #752: Adding fix to integration test

2018-10-22 Thread rmatharu
GitHub user rmatharu opened a pull request: https://github.com/apache/samza/pull/752 Adding fix to integration test ClientHelper changed the log-print, which the integration test relies on. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] samza pull request #776: Adding release notes for Samza 1.0

2018-10-26 Thread rmatharu
GitHub user rmatharu opened a pull request: https://github.com/apache/samza/pull/776 Adding release notes for Samza 1.0 https://user-images.githubusercontent.com/40646191/47598767-00e19a00-d956-11e8-8865-38467bcdd11f.png;> ![Uploading Screen Shot 2018-10-26 at 7.26.06 PM.p

[GitHub] samza pull request #758: Minor instruction changes

2018-10-23 Thread rmatharu
GitHub user rmatharu opened a pull request: https://github.com/apache/samza/pull/758 Minor instruction changes You can merge this pull request into a Git repository by running: $ git pull https://github.com/rmatharu/samza doc Alternatively you can review and apply

[GitHub] samza pull request #796: Enabling auto-discovery of regex input topics

2018-11-05 Thread rmatharu
GitHub user rmatharu opened a pull request: https://github.com/apache/samza/pull/796 Enabling auto-discovery of regex input topics This PR makes the following changes * Enriches StreamPartitionCountMonitor to periodically monitor input-regexes to match to actual inputs

[GitHub] samza pull request #605: Enabling auto-discovery of regex input topics

2018-11-05 Thread rmatharu
Github user rmatharu closed the pull request at: https://github.com/apache/samza/pull/605 ---

[GitHub] samza pull request #659: Revised monitoring doc

2018-09-25 Thread rmatharu
GitHub user rmatharu opened a pull request: https://github.com/apache/samza/pull/659 Revised monitoring doc You can merge this pull request into a Git repository by running: $ git pull https://github.com/rmatharu/samza monitoringdoc Alternatively you can review and apply

[GitHub] samza pull request #882: DiagnosticsAppender for log4j2

2019-01-15 Thread rmatharu
GitHub user rmatharu opened a pull request: https://github.com/apache/samza/pull/882 DiagnosticsAppender for log4j2 This PR adds a DiagnosticsAppender for log4j2. There exists one already for log4j in samza-log4j. However the Appender, LogEvent, and Configuration APIs

[GitHub] samza pull request #889: Test basic standby allocator

2019-01-22 Thread rmatharu
GitHub user rmatharu opened a pull request: https://github.com/apache/samza/pull/889 Test basic standby allocator Please DO NOT review yet. This PR is missing unit-tests and testing. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] samza pull request #864: SAMZA-2018 : State restore improvements using Rocks...

2018-12-17 Thread rmatharu
GitHub user rmatharu opened a pull request: https://github.com/apache/samza/pull/864 SAMZA-2018 : State restore improvements using RocksDB writebatch API This PR enables the RocksDbKeyValueStore to use the writeBatch API. You can merge this pull request into a Git repository

[GitHub] samza pull request #851: Flaky test fix

2018-12-10 Thread rmatharu
GitHub user rmatharu opened a pull request: https://github.com/apache/samza/pull/851 Flaky test fix MockStorageEngine has a static list of incomingMessageEnvelopes, which was a non thread-safe ArrayList. However in case of parallel restore (recent change), this needs

[GitHub] samza pull request #838: Moving store test to TestContainerStorageManager fr...

2018-12-03 Thread rmatharu
GitHub user rmatharu opened a pull request: https://github.com/apache/samza/pull/838 Moving store test to TestContainerStorageManager from TestSamzaContainer There was a test in TestSamzaContainer that needs to be moved to TestContainerStorageManager because the restore logic

[GitHub] samza pull request #843: Moving restorePath into ContainerStorageManager

2018-12-04 Thread rmatharu
GitHub user rmatharu opened a pull request: https://github.com/apache/samza/pull/843 Moving restorePath into ContainerStorageManager You can merge this pull request into a Git repository by running: $ git pull https://github.com/rmatharu/samza refactoringCSM Alternatively

[GitHub] samza pull request #823: State restore improvements

2018-11-27 Thread rmatharu
GitHub user rmatharu opened a pull request: https://github.com/apache/samza/pull/823 State restore improvements This PR makes the following changes: * Consumer consolidation to ensure 1 storeConsumer per system, earlier it was 1 consumer per SSP per store

[GitHub] samza pull request #872: StandbyTaskGenerator interface and a BuddyContainer...

2019-01-08 Thread rmatharu
GitHub user rmatharu opened a pull request: https://github.com/apache/samza/pull/872 StandbyTaskGenerator interface and a BuddyContainerBased implementation This PR adds * StandbyTaskGenerator that is used to populate StandbyTasks once the SSP and TaskName groupers have

[GitHub] samza pull request #876: Basic Standby container implementation

2019-01-12 Thread rmatharu
GitHub user rmatharu opened a pull request: https://github.com/apache/samza/pull/876 Basic Standby container implementation Please DO Not review yet. This is to be rebased on top of PR 871 and 872. This PR brings a basic standby container implementation

[GitHub] samza pull request #890: Bugfix : Passing localityManager to JobModel when c...

2019-01-23 Thread rmatharu
GitHub user rmatharu opened a pull request: https://github.com/apache/samza/pull/890 Bugfix : Passing localityManager to JobModel when created from JobModelManager Samza Standalone required JobModel refactoring, due to which jobModelRef (and localityManager) is set explicitly

[GitHub] samza pull request #892: Samza-2018: Using Rocksdb bulk load only for clean-...

2019-01-23 Thread rmatharu
GitHub user rmatharu opened a pull request: https://github.com/apache/samza/pull/892 Samza-2018: Using Rocksdb bulk load only for clean-slate restores Rocksdb has a problem that its bulk-load option cannot be used on existing stores seamlessly. See https://github.com/facebook

[GitHub] samza pull request #897: SEP-19 : Refactoring to remove localityManager from...

2019-01-25 Thread rmatharu
GitHub user rmatharu opened a pull request: https://github.com/apache/samza/pull/897 SEP-19 : Refactoring to remove localityManager from JobModel This PR removes localityManager from JobModel. There was some localityMapping creation location in JobModel that was based