[GitHub] shanthoosh commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor

2019-02-19 Thread GitBox
shanthoosh commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#discussion_r258307442 ## File path: samza-core/src/main/java/org/apache/samza/execution/JobPlanner.java ## @@ -155,4 +158,33

[GitHub] shanthoosh commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor

2019-02-19 Thread GitBox
shanthoosh commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#discussion_r258306761 ## File path:

[GitHub] shanthoosh commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor

2019-02-19 Thread GitBox
shanthoosh commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#discussion_r258308009 ## File path: samza-core/src/test/java/org/apache/samza/runtime/TestLocalApplicationRunner.java ## @@

[GitHub] shanthoosh commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor

2019-02-19 Thread GitBox
shanthoosh commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#discussion_r258307896 ## File path: samza-test/src/main/java/org/apache/samza/test/framework/TestRunner.java ## @@ -104,7

[GitHub] shanthoosh commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor

2019-02-19 Thread GitBox
shanthoosh commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#discussion_r258141427 ## File path: samza-core/src/main/java/org/apache/samza/execution/JobPlanner.java ## @@ -155,4 +158,33