[jira] [Commented] (SDAP-36) Fix failing org.apache.sdap.mudrod.ontology.process.TestLocalOntology
[ https://issues.apache.org/jira/browse/SDAP-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495911#comment-16495911 ] ASF GitHub Bot commented on SDAP-36: jjacob7734 closed pull request #11: SDAP-36 MUDROD Storage unit test suite URL: https://github.com/apache/incubator-sdap-mudrod/pull/11 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.gitignore b/.gitignore index 3009cbf..9944c94 100644 --- a/.gitignore +++ b/.gitignore @@ -15,3 +15,4 @@ core/.externalToolBuilders/Maven_Ant_Builder.launch core/maven-eclipse.xml service/.classpath web/.classpath +.metadata/ \ No newline at end of file diff --git a/core/src/test/java/org/apache/sdap/mudrod/driver/ESDriverTest.java b/core/src/test/java/org/apache/sdap/mudrod/driver/ESDriverTest.java new file mode 100644 index 000..5c29b61 --- /dev/null +++ b/core/src/test/java/org/apache/sdap/mudrod/driver/ESDriverTest.java @@ -0,0 +1,359 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); you + * may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.sdap.mudrod.driver; + +import org.apache.commons.io.IOUtils; +import org.apache.sdap.mudrod.main.MudrodConstants; +import org.apache.sdap.mudrod.main.MudrodEngine; +import org.apache.sdap.mudrod.driver.EmbeddedElasticsearchServer; +import org.elasticsearch.client.Client; +import org.codehaus.jettison.json.JSONException; +import org.codehaus.jettison.json.JSONObject; +import org.elasticsearch.index.query.MatchAllQueryBuilder; +import org.elasticsearch.index.query.QueryBuilders; +import org.elasticsearch.action.bulk.BulkProcessor; +import org.elasticsearch.action.update.UpdateRequest; +import org.junit.Test; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import java.io.IOException; +import java.io.InputStream; +import java.util.ArrayList; +import java.util.List; +import java.util.HashMap; +import java.util.Map; +import java.util.Properties; +import java.util.concurrent.ExecutionException; + +public class ESDriverTest { + + private static final Logger LOG = LoggerFactory.getLogger(ESDriver.class); + protected static final String ES_SETTINGS = "elastic_settings.json"; + protected static final String ES_MAPPINGS = "elastic_mappings.json"; + + @Test + public void testESDriver() { +ESDriver es = new ESDriver(); + } + + @Test + public void testESDriverProperties() { +EmbeddedElasticsearchServer tempes = new EmbeddedElasticsearchServer(); +Client client = tempes.getClient(); +assert client != null; + } + + @Test + public void testCreateBulkProcessor() { +MudrodEngine mudrodEngine = new MudrodEngine(); +ESDriver es = new ESDriver(mudrodEngine.loadConfig()); +es.createBulkProcessor(); + +BulkProcessor processor = es.getBulkProcessor(); +assert processor != null; + } + + @Test + public void testDestroyBulkProcessor() { +MudrodEngine mudrodEngine = new MudrodEngine(); +ESDriver es = new ESDriver(mudrodEngine.loadConfig()); +es.createBulkProcessor(); +es.destroyBulkProcessor(); + +BulkProcessor processor = es.getBulkProcessor(); +assert processor == null; + } + + @Test + public void testPutMapping() { +MudrodEngine mudrodEngine = new MudrodEngine(); +ESDriver es = new ESDriver(mudrodEngine.loadConfig()); + +InputStream settingsStream = getClass().getClassLoader().getResourceAsStream(ES_SETTINGS); +InputStream mappingsStream = getClass().getClassLoader().getResourceAsStream(ES_MAPPINGS); + +JSONObject settingsJSON = null; +JSONObject mappingJSON = null; + +Properties props = mudrodEngine.loadConfig(); +try { + settingsJSON = new JSONObject(IOUtils.toString(settingsStream)); +} catch (JSONException | IOException e1) { + LOG.error("Error reading Elasticsearch settings!", e1); +} + +try { + mappingJSON = new JSONObject(IOUtils.toString(mappingsStream)); +} catch (JSONException | IOException e1) { + LOG.error("Error reading Elasticsearch mappings!", e1); +} + +try { + if (settingsJSON != null && mappingJSON != null) { +es.putMapping(props.getProperty(MudrodConstants.ES_INDEX_NAME), settingsJSON.toString(), mappingJSON.toString()); + } +} catch (IOException e) { +
[jira] [Commented] (SDAP-36) Fix failing org.apache.sdap.mudrod.ontology.process.TestLocalOntology
[ https://issues.apache.org/jira/browse/SDAP-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456628#comment-16456628 ] ASF GitHub Bot commented on SDAP-36: lewismc commented on issue #11: SDAP-36 MUDROD Storage unit test suite URL: https://github.com/apache/incubator-sdap-mudrod/pull/11#issuecomment-385009566 Hi @Yongyao couple of questions here 1. I posted a direct link to an example of creating an [embedded ES server](http://cupofjava.de/blog/2012/11/27/embedded-elasticsearch-server-for-tests/)... this is what you need to create. This will then be used when unit tests are executed... makes sense? 1. Is there any reason that @clarkgogogo is submitting code for a PR via your repository? That would seem to me to be missing the point of us bringing him on board for the summer. What happens when you are gone and no-one is able to manage PR's which come into your repository? It would be appreciated if you could point @clarkgogogo to the [CONTRIBUTING GUIDELINES](https://github.com/apache/incubator-sdap-mudrod/blob/master/CONTRIBUTING.md) such that he can understand and practice the development workflow himself. 1. you state "...but he got stuck because the client he got through this approach is null."... this is because he did not create the embedded ES server as I stated and requested above 1. you state "...I am actually a little confused with the embedded server approach. Why do you need it?" The answer is simple... it is so we can actually test the data persistence functionality within MUDROD. Unless we have a running instance of ES, we are unable to interact with any data... does this make sense? 1. You stated "...The sample code you provided seems to create a ES client, which is the same as the one we created through ESdriver." No this is not correct, if you look at the following code, it clearly creates a ```Node``` object which is the ES data node. ``` public EmbeddedElasticsearchServer(String dataDirectory) { this.dataDirectory = dataDirectory; ImmutableSettings.Builder elasticsearchSettings = ImmutableSettings.settingsBuilder() .put("http.enabled", "false") .put("path.data", dataDirectory); node = nodeBuilder() .local(true) .settings(elasticsearchSettings.build()) .node(); } ``` Once we've created the ```Node``` with ```@setUpClass``` then we can begin executing Unit tests against that Node. 1. Final thing for now, for the ESDriverTest you guys have actually not tested anything at all. You are confusing use of the [Java assert](https://docs.oracle.com/javase/7/docs/technotes/guides/language/assert.html) with [JUnit's assert](https://junit.org/junit4/javadoc/latest/org/junit/Assert.html) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix failing org.apache.sdap.mudrod.ontology.process.TestLocalOntology > - > > Key: SDAP-36 > URL: https://issues.apache.org/jira/browse/SDAP-36 > Project: Apache Science Data Analytics Platform > Issue Type: Task > Components: mudrod >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Major > Fix For: 0.1 > > > The remote file at > https://raw.githubusercontent.com/ESIPFed/sweet/master/2.4/sweetAll.owl no > longer exists as we changed a bunch of things in SWEET including the > availability of any OWL serializations. > The equivalent file (in Turtle serialization) is located at > https://raw.githubusercontent.com/ESIPFed/sweet/master/src/sweetAll.ttl -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SDAP-36) Fix failing org.apache.sdap.mudrod.ontology.process.TestLocalOntology
[ https://issues.apache.org/jira/browse/SDAP-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454484#comment-16454484 ] ASF GitHub Bot commented on SDAP-36: Yongyao commented on issue #11: SDAP-36 MUDROD Storage unit test suite URL: https://github.com/apache/incubator-sdap-mudrod/pull/11#issuecomment-384704662 @lewismc Kejin has added the embedded ES server as you suggested, but he got stuck because the client (https://github.com/Yongyao/incubator-sdap-mudrod/blob/SDAP-36/core/src/test/java/org/apache/sdap/mudrod/driver/ESDriverTest.java#L53) he got through this approach is null. I am actually a little confused with the embedded server approach. Why do you need it? The sample code you provided seems to create a ES client, which is the same as the one we created through ESdriver. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix failing org.apache.sdap.mudrod.ontology.process.TestLocalOntology > - > > Key: SDAP-36 > URL: https://issues.apache.org/jira/browse/SDAP-36 > Project: Apache Science Data Analytics Platform > Issue Type: Task > Components: mudrod >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Major > Fix For: 0.1 > > > The remote file at > https://raw.githubusercontent.com/ESIPFed/sweet/master/2.4/sweetAll.owl no > longer exists as we changed a bunch of things in SWEET including the > availability of any OWL serializations. > The equivalent file (in Turtle serialization) is located at > https://raw.githubusercontent.com/ESIPFed/sweet/master/src/sweetAll.ttl -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SDAP-36) Fix failing org.apache.sdap.mudrod.ontology.process.TestLocalOntology
[ https://issues.apache.org/jira/browse/SDAP-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432963#comment-16432963 ] ASF GitHub Bot commented on SDAP-36: lewismc commented on a change in pull request #11: SDAP-36 MUDROD Storage unit test suite URL: https://github.com/apache/incubator-sdap-mudrod/pull/11#discussion_r180562835 ## File path: core/src/test/java/org/apache/sdap/mudrod/driver/ESDriverTest.java ## @@ -0,0 +1,357 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); you + * may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.sdap.mudrod.driver; + +import org.apache.commons.io.IOUtils; +import org.apache.sdap.mudrod.main.MudrodConstants; +import org.apache.sdap.mudrod.main.MudrodEngine; +import org.elasticsearch.client.Client; +import org.codehaus.jettison.json.JSONException; +import org.codehaus.jettison.json.JSONObject; +import org.elasticsearch.index.query.MatchAllQueryBuilder; +import org.elasticsearch.index.query.QueryBuilders; +import org.elasticsearch.action.bulk.BulkProcessor; +import org.elasticsearch.action.update.UpdateRequest; +import org.junit.Test; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.IOException; +import java.io.InputStream; +import java.util.ArrayList; +import java.util.List; +import java.util.HashMap; +import java.util.Map; +import java.util.Properties; +import java.util.concurrent.ExecutionException; + +public class ESDriverTest { + + private static final Logger LOG = LoggerFactory.getLogger(ESDriver.class); + protected static final String ES_SETTINGS = "elastic_settings.json"; + protected static final String ES_MAPPINGS = "elastic_mappings.json"; + + @Test + public void testESDriver() { +ESDriver es = new ESDriver(); + } + + @Test + public void testESDriverProperties() { +MudrodEngine mudrodEngine = new MudrodEngine(); +ESDriver es = new ESDriver(mudrodEngine.loadConfig()); + +Client client = es.getClient(); +assert client != null; + } + + @Test + public void testCreateBulkProcessor() { +MudrodEngine mudrodEngine = new MudrodEngine(); +ESDriver es = new ESDriver(mudrodEngine.loadConfig()); +es.createBulkProcessor(); + +BulkProcessor processor = es.getBulkProcessor(); +assert processor != null; + } + + @Test + public void testDestroyBulkProcessor() { +MudrodEngine mudrodEngine = new MudrodEngine(); +ESDriver es = new ESDriver(mudrodEngine.loadConfig()); +es.createBulkProcessor(); +es.destroyBulkProcessor(); + +BulkProcessor processor = es.getBulkProcessor(); +assert processor == null; + } + + @Test + public void testPutMapping() { +MudrodEngine mudrodEngine = new MudrodEngine(); +ESDriver es = new ESDriver(mudrodEngine.loadConfig()); + +InputStream settingsStream = getClass().getClassLoader().getResourceAsStream(ES_SETTINGS); +InputStream mappingsStream = getClass().getClassLoader().getResourceAsStream(ES_MAPPINGS); + +JSONObject settingsJSON = null; +JSONObject mappingJSON = null; + +Properties props = mudrodEngine.loadConfig(); +try { + settingsJSON = new JSONObject(IOUtils.toString(settingsStream)); +} catch (JSONException | IOException e1) { + LOG.error("Error reading Elasticsearch settings!", e1); +} + +try { + mappingJSON = new JSONObject(IOUtils.toString(mappingsStream)); +} catch (JSONException | IOException e1) { + LOG.error("Error reading Elasticsearch mappings!", e1); +} + +try { + if (settingsJSON != null && mappingJSON != null) { +es.putMapping(props.getProperty(MudrodConstants.ES_INDEX_NAME), settingsJSON.toString(), mappingJSON.toString()); + } +} catch (IOException e) { + LOG.error("Error entering Elasticsearch Mappings!", e); +} + } + + @Test + public void testCustomAnalyzingStringString() { +MudrodEngine mudrodEngine = new MudrodEngine(); +ESDriver es = new ESDriver(mudrodEngine.loadConfig()); +String str = "temp"; + +try { + String res = es.customAnalyzing("mudrod", str); + assert res != ""; + assert res != null; +} catch (InterruptedException | ExecutionException e) { + LOG.error("Error!", e); +} + } + + @Test + public void testCustomAnalyzingStringStringString() { +MudrodEngine mudrodEngine = new MudrodEngine(); +ESDriver es = new ESDriver(mudrodEngine.loadConfig()); +String str = "temp"; + +
[jira] [Commented] (SDAP-36) Fix failing org.apache.sdap.mudrod.ontology.process.TestLocalOntology
[ https://issues.apache.org/jira/browse/SDAP-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432959#comment-16432959 ] ASF GitHub Bot commented on SDAP-36: lewismc commented on a change in pull request #11: SDAP-36 MUDROD Storage unit test suite URL: https://github.com/apache/incubator-sdap-mudrod/pull/11#discussion_r180562906 ## File path: core/src/test/java/org/apache/sdap/mudrod/driver/ESDriverTest.java ## @@ -0,0 +1,357 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); you + * may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.sdap.mudrod.driver; + +import org.apache.commons.io.IOUtils; +import org.apache.sdap.mudrod.main.MudrodConstants; +import org.apache.sdap.mudrod.main.MudrodEngine; +import org.elasticsearch.client.Client; +import org.codehaus.jettison.json.JSONException; +import org.codehaus.jettison.json.JSONObject; +import org.elasticsearch.index.query.MatchAllQueryBuilder; +import org.elasticsearch.index.query.QueryBuilders; +import org.elasticsearch.action.bulk.BulkProcessor; +import org.elasticsearch.action.update.UpdateRequest; +import org.junit.Test; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.IOException; +import java.io.InputStream; +import java.util.ArrayList; +import java.util.List; +import java.util.HashMap; +import java.util.Map; +import java.util.Properties; +import java.util.concurrent.ExecutionException; + +public class ESDriverTest { + + private static final Logger LOG = LoggerFactory.getLogger(ESDriver.class); + protected static final String ES_SETTINGS = "elastic_settings.json"; + protected static final String ES_MAPPINGS = "elastic_mappings.json"; + + @Test + public void testESDriver() { +ESDriver es = new ESDriver(); + } + + @Test + public void testESDriverProperties() { +MudrodEngine mudrodEngine = new MudrodEngine(); +ESDriver es = new ESDriver(mudrodEngine.loadConfig()); + +Client client = es.getClient(); +assert client != null; + } + + @Test + public void testCreateBulkProcessor() { +MudrodEngine mudrodEngine = new MudrodEngine(); +ESDriver es = new ESDriver(mudrodEngine.loadConfig()); +es.createBulkProcessor(); + +BulkProcessor processor = es.getBulkProcessor(); +assert processor != null; + } + + @Test + public void testDestroyBulkProcessor() { +MudrodEngine mudrodEngine = new MudrodEngine(); +ESDriver es = new ESDriver(mudrodEngine.loadConfig()); +es.createBulkProcessor(); +es.destroyBulkProcessor(); + +BulkProcessor processor = es.getBulkProcessor(); +assert processor == null; + } + + @Test + public void testPutMapping() { +MudrodEngine mudrodEngine = new MudrodEngine(); +ESDriver es = new ESDriver(mudrodEngine.loadConfig()); + +InputStream settingsStream = getClass().getClassLoader().getResourceAsStream(ES_SETTINGS); +InputStream mappingsStream = getClass().getClassLoader().getResourceAsStream(ES_MAPPINGS); + +JSONObject settingsJSON = null; +JSONObject mappingJSON = null; + +Properties props = mudrodEngine.loadConfig(); +try { + settingsJSON = new JSONObject(IOUtils.toString(settingsStream)); +} catch (JSONException | IOException e1) { + LOG.error("Error reading Elasticsearch settings!", e1); +} + +try { + mappingJSON = new JSONObject(IOUtils.toString(mappingsStream)); +} catch (JSONException | IOException e1) { + LOG.error("Error reading Elasticsearch mappings!", e1); +} + +try { + if (settingsJSON != null && mappingJSON != null) { +es.putMapping(props.getProperty(MudrodConstants.ES_INDEX_NAME), settingsJSON.toString(), mappingJSON.toString()); + } +} catch (IOException e) { + LOG.error("Error entering Elasticsearch Mappings!", e); +} + } + + @Test + public void testCustomAnalyzingStringString() { +MudrodEngine mudrodEngine = new MudrodEngine(); +ESDriver es = new ESDriver(mudrodEngine.loadConfig()); +String str = "temp"; + +try { + String res = es.customAnalyzing("mudrod", str); + assert res != ""; + assert res != null; +} catch (InterruptedException | ExecutionException e) { + LOG.error("Error!", e); +} + } + + @Test + public void testCustomAnalyzingStringStringString() { +MudrodEngine mudrodEngine = new MudrodEngine(); +ESDriver es = new ESDriver(mudrodEngine.loadConfig()); +String str = "temp"; + +
[jira] [Commented] (SDAP-36) Fix failing org.apache.sdap.mudrod.ontology.process.TestLocalOntology
[ https://issues.apache.org/jira/browse/SDAP-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432932#comment-16432932 ] ASF GitHub Bot commented on SDAP-36: lewismc commented on a change in pull request #11: SDAP-36 MUDROD Storage unit test suite URL: https://github.com/apache/incubator-sdap-mudrod/pull/11#discussion_r180560126 ## File path: core/src/test/java/org/apache/sdap/mudrod/driver/ESDriverTest.java ## @@ -28,367 +42,331 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; -public class ESDriverTest { +import junit.framework.Assert; Review comment: This is the old JUnit import. Please use org.junit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix failing org.apache.sdap.mudrod.ontology.process.TestLocalOntology > - > > Key: SDAP-36 > URL: https://issues.apache.org/jira/browse/SDAP-36 > Project: Apache Science Data Analytics Platform > Issue Type: Task > Components: mudrod >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Major > > The remote file at > https://raw.githubusercontent.com/ESIPFed/sweet/master/2.4/sweetAll.owl no > longer exists as we changed a bunch of things in SWEET including the > availability of any OWL serializations. > The equivalent file (in Turtle serialization) is located at > https://raw.githubusercontent.com/ESIPFed/sweet/master/src/sweetAll.ttl -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SDAP-36) Fix failing org.apache.sdap.mudrod.ontology.process.TestLocalOntology
[ https://issues.apache.org/jira/browse/SDAP-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427878#comment-16427878 ] ASF GitHub Bot commented on SDAP-36: lewismc commented on a change in pull request #11: SDAP-36 MUDROD Storage unit test suite URL: https://github.com/apache/incubator-sdap-mudrod/pull/11#discussion_r179651247 ## File path: core/src/test/java/org/apache/sdap/mudrod/driver/ESDriverTest.java ## @@ -0,0 +1,394 @@ +package org.apache.sdap.mudrod.driver; + +import static org.junit.Assert.*; Review comment: Never use wildcard imports always make explicit imports This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix failing org.apache.sdap.mudrod.ontology.process.TestLocalOntology > - > > Key: SDAP-36 > URL: https://issues.apache.org/jira/browse/SDAP-36 > Project: Apache Science Data Analytics Platform > Issue Type: Task > Components: mudrod >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Major > > The remote file at > https://raw.githubusercontent.com/ESIPFed/sweet/master/2.4/sweetAll.owl no > longer exists as we changed a bunch of things in SWEET including the > availability of any OWL serializations. > The equivalent file (in Turtle serialization) is located at > https://raw.githubusercontent.com/ESIPFed/sweet/master/src/sweetAll.ttl -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SDAP-36) Fix failing org.apache.sdap.mudrod.ontology.process.TestLocalOntology
[ https://issues.apache.org/jira/browse/SDAP-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426114#comment-16426114 ] ASF GitHub Bot commented on SDAP-36: lewismc opened a new pull request #10: SDAP-36 Fix failing org.apache.sdap.mudrod.ontology.process.TestLocalOntology URL: https://github.com/apache/incubator-sdap-mudrod/pull/10 This PR will eventually address https://issues.apache.org/jira/browse/SDAP-36 Right now it is not finished... further work is required to override some internal Jena ontology loading. I will come back to it after the storage re-architecture is complete. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix failing org.apache.sdap.mudrod.ontology.process.TestLocalOntology > - > > Key: SDAP-36 > URL: https://issues.apache.org/jira/browse/SDAP-36 > Project: Apache Science Data Analytics Platform > Issue Type: Task > Components: mudrod >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Major > > The remote file at > https://raw.githubusercontent.com/ESIPFed/sweet/master/2.4/sweetAll.owl no > longer exists as we changed a bunch of things in SWEET including the > availability of any OWL serializations. > The equivalent file (in Turtle serialization) is located at > https://raw.githubusercontent.com/ESIPFed/sweet/master/src/sweetAll.ttl -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SDAP-36) Fix failing org.apache.sdap.mudrod.ontology.process.TestLocalOntology
[ https://issues.apache.org/jira/browse/SDAP-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426115#comment-16426115 ] ASF GitHub Bot commented on SDAP-36: asfgit commented on issue #10: SDAP-36 Fix failing org.apache.sdap.mudrod.ontology.process.TestLocalOntology URL: https://github.com/apache/incubator-sdap-mudrod/pull/10#issuecomment-378730772 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix failing org.apache.sdap.mudrod.ontology.process.TestLocalOntology > - > > Key: SDAP-36 > URL: https://issues.apache.org/jira/browse/SDAP-36 > Project: Apache Science Data Analytics Platform > Issue Type: Task > Components: mudrod >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Major > > The remote file at > https://raw.githubusercontent.com/ESIPFed/sweet/master/2.4/sweetAll.owl no > longer exists as we changed a bunch of things in SWEET including the > availability of any OWL serializations. > The equivalent file (in Turtle serialization) is located at > https://raw.githubusercontent.com/ESIPFed/sweet/master/src/sweetAll.ttl -- This message was sent by Atlassian JIRA (v7.6.3#76005)