Re: Review Request 67846: SENTRY-2283 Multiple versions of metrics on the classpath causes Sentry to not startup

2018-07-06 Thread Steve Moist via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67846/ --- (Updated July 6, 2018, 7:06 p.m.) Review request for sentry. Repository:

Re: Review Request 67803: SENTRY-2247: Add e2e tests to verify owner privileges

2018-07-06 Thread Na Li via Review Board
> On July 6, 2018, 2:23 p.m., kalyan kumar kalvagadda wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 2786-2797 (patched) > > >

Review Request 67846: SENTRY-2283 Multiple versions of metrics on the classpath causes Sentry to not startup

2018-07-06 Thread Steve Moist via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67846/ --- Review request for sentry. Repository: sentry Description --- Excluding

Re: Review Request 67846: SENTRY-2283 Multiple versions of metrics on the classpath causes Sentry to not startup

2018-07-06 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67846/#review205809 --- sentry-binding/sentry-binding-hive/pom.xml Lines 63-68 (patched)

Re: Review Request 67803: SENTRY-2247: Add e2e tests to verify owner privileges

2018-07-06 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67803/#review205805 --- Ship it! Ship It! - Arjun Mishra On July 5, 2018, 9:14

Re: Review Request 67803: SENTRY-2247: Add e2e tests to verify owner privileges

2018-07-06 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67803/#review205797 ---

Re: Review Request 67803: SENTRY-2247: Add e2e tests to verify owner privileges

2018-07-06 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67803/#review205801 --- Ship it! Fix it and ship it. - kalyan kumar kalvagadda On

Re: Review Request 67846: SENTRY-2283 Multiple versions of metrics on the classpath causes Sentry to not startup

2018-07-06 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67846/#review205821 --- Fix it, then Ship it! Fix it.