Re: Review Request 67879: SENTRY-2309: Add relevant full snapshot timeline messages to std.out

2018-07-13 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67879/#review206044 ---

Re: Review Request 67899: SENTRY-2299: NPE In Sentry HDFS Sync Plugin

2018-07-13 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67899/#review206050 --- >From your comment, "Sentry client at NameNode does not create

Re: Review Request 67899: SENTRY-2299: NPE In Sentry HDFS Sync Plugin

2018-07-13 Thread Na Li via Review Board
> On July 13, 2018, 1:16 p.m., kalyan kumar kalvagadda wrote: > > From your comment, "Sentry client at NameNode does not create entry for > > external table. When user rename an external table with different path, > > null exception happens" > > > > Does does that mean sentry ACL's don't work

Re: Review Request 67899: SENTRY-2299: NPE In Sentry HDFS Sync Plugin

2018-07-13 Thread kalyan kumar kalvagadda via Review Board
> On July 13, 2018, 1:16 p.m., kalyan kumar kalvagadda wrote: > > From your comment, "Sentry client at NameNode does not create entry for > > external table. When user rename an external table with different path, > > null exception happens" > > > > Does does that mean sentry ACL's don't work

Re: Review Request 67899: SENTRY-2299: NPE In Sentry HDFS Sync Plugin

2018-07-13 Thread kalyan kumar kalvagadda via Review Board
> On July 13, 2018, 1:16 p.m., kalyan kumar kalvagadda wrote: > > From your comment, "Sentry client at NameNode does not create entry for > > external table. When user rename an external table with different path, > > null exception happens" > > > > Does does that mean sentry ACL's don't work

Re: Review Request 67899: SENTRY-2299: NPE In Sentry HDFS Sync Plugin

2018-07-13 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67899/#review206055 ---

Re: Review Request 67899: SENTRY-2299: NPE In Sentry HDFS Sync Plugin

2018-07-13 Thread Na Li via Review Board
> On July 13, 2018, 1:16 p.m., kalyan kumar kalvagadda wrote: > > From your comment, "Sentry client at NameNode does not create entry for > > external table. When user rename an external table with different path, > > null exception happens" > > > > Does does that mean sentry ACL's don't work

Re: Review Request 67899: SENTRY-2299: NPE In Sentry HDFS Sync Plugin

2018-07-13 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67899/ --- (Updated July 13, 2018, 3:45 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 67879: SENTRY-2309: Add relevant full snapshot timeline messages to std.out

2018-07-13 Thread Arjun Mishra via Review Board
> On July 13, 2018, 12:37 p.m., kalyan kumar kalvagadda wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java > > Lines 99-100 (original), 100-103 (patched) > > > > > >

Re: Review Request 67899: SENTRY-2299: NPE In Sentry HDFS Sync Plugin

2018-07-13 Thread Na Li via Review Board
> On July 13, 2018, 3:35 p.m., kalyan kumar kalvagadda wrote: > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java > > Lines 881-885 (patched) > > > > > > Better way to avoid this

Review Request 67912: SENTRY-2310: Sentry is not be able to fetch full update subsequently, when there is HMS restart in the snapshot process.

2018-07-13 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67912/ --- Review request for sentry, Alexander Kolbasov, Arjun Mishra, Na Li, and Sergio

Re: Review Request 67879: SENTRY-2309: Add relevant full snapshot timeline messages to std.out

2018-07-13 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67879/ --- (Updated July 13, 2018, 5:03 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 67912: SENTRY-2310: Sentry is not be able to fetch full update subsequently, when there is HMS restart in the snapshot process.

2018-07-13 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67912/#review206062 --- Fix it, then Ship it! The patch looks good. I'd like to see a

Re: Review Request 67888: SENTRY-2308: Create privilege on table has no use case

2018-07-13 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67888/ --- (Updated July 13, 2018, 6:45 p.m.) Review request for sentry and Arjun Mishra.

Re: Review Request 67888: SENTRY-2308: Create privilege on table has no use case

2018-07-13 Thread Sergio Pena via Review Board
> On July 12, 2018, 2:53 p.m., Arjun Mishra wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java > > Line 550 (original), 558 (patched) > >

Re: Review Request 67888: SENTRY-2308: Create privilege on table has no use case

2018-07-13 Thread Sergio Pena via Review Board
> On July 12, 2018, 2:49 p.m., Arjun Mishra wrote: > > Sergio, I think this method "checkAllowedGrantPrivileges()" can be > > incorporated in method "analyzePrivilegeListDef()" where we are currently > > checking for similar imperssible grants like only select on column and so > > on. I need

Re: Review Request 67912: SENTRY-2310: Sentry is not be able to fetch full update subsequently, when there is HMS restart in the snapshot process.

2018-07-13 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67912/#review206075 ---