Re: Review Request 69987: SENTRY-2497: show grant role results should handle case where URI doesn't have a defined scheme

2019-02-22 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69987/#review213085 --- Ship it! Ship It! - Na Li On Feb. 21, 2019, 8:17 p.m.,

Review Request 70043: SENTRY-2502: Sentry NN plug-in stops fetching updates from sentry server

2019-02-22 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70043/ --- Review request for sentry, Arjun Mishra, Haley Reeve, and Na Li. Bugs:

Re: Review Request 70043: SENTRY-2502: Sentry NN plug-in stops fetching updates from sentry server

2019-02-22 Thread Haley Reeve via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70043/#review213091 --- Ship it! Ship It! - Haley Reeve On Feb. 22, 2019, 6:40

Re: Review Request 70043: SENTRY-2502: Sentry NN plug-in stops fetching updates from sentry server

2019-02-22 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70043/#review213094 ---

Re: Review Request 70043: SENTRY-2502: Sentry NN plug-in stops fetching updates from sentry server

2019-02-22 Thread kalyan kumar kalvagadda via Review Board
> On Feb. 22, 2019, 6:48 p.m., Haley Reeve wrote: > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java > > Line 689 (original), 694 (patched) > > > > > > Why the change from sets to

Re: Review Request 70043: SENTRY-2502: Sentry NN plug-in stops fetching updates from sentry server

2019-02-22 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70043/#review213095 ---

Re: Review Request 70043: SENTRY-2502: Sentry NN plug-in stops fetching updates from sentry server

2019-02-22 Thread Haley Reeve via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70043/#review213088 ---

Re: Review Request 70043: SENTRY-2502: Sentry NN plug-in stops fetching updates from sentry server

2019-02-22 Thread kalyan kumar kalvagadda via Review Board
> On Feb. 22, 2019, 8:58 p.m., Na Li wrote: > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java > > Lines 507 (patched) > > > > > > should this be removed if it has no authz obj? >

Re: Review Request 70043: SENTRY-2502: Sentry NN plug-in stops fetching updates from sentry server

2019-02-22 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70043/#review213102 --- Ship it! Ship It! - Na Li On Feb. 22, 2019, 6:40 p.m.,

Re: Review Request 70043: SENTRY-2502: Sentry NN plug-in stops fetching updates from sentry server

2019-02-22 Thread kalyan kumar kalvagadda via Review Board
> On Feb. 22, 2019, 8:46 p.m., Na Li wrote: > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java > > Line 689 (original), 694 (patched) > > > > > > Kalyan, do you mean "If we use the

Re: Review Request 70043: SENTRY-2502: Sentry NN plug-in stops fetching updates from sentry server

2019-02-22 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70043/ --- (Updated Feb. 23, 2019, 5:28 a.m.) Review request for sentry, Arjun Mishra,